This enables conversion of OpenMP Target op with region from FIR Dialect to LLVM IR Dialect.
Depends on D147247
Paths
| Differential D147439
[MLIR][OpenMP] Add conversion support from FIR to LLVM Dialect for OMP Target ClosedPublic Authored by TIFitis on Apr 3 2023, 5:30 AM.
Details Summary This enables conversion of OpenMP Target op with region from FIR Dialect to LLVM IR Dialect. Depends on D147247
Diff Detail
Event TimelineHerald added subscribers: jplehr, sstefan1, stephenneuendorffer and 2 others. · View Herald Transcript This revision now requires changes to proceed.Apr 4 2023, 1:13 PM Comment Actions
The test was failing because of the missing dependency on target map clause support. On rerun it is passing. Sorry, you are right about the conversion. I've updated the target op along with the target data ops to use the existing region conversion patters. This revision is now accepted and ready to land.Apr 11 2023, 6:17 AM Closed by commit rGdc26a3d9cddd: [MLIR][OpenMP] Add conversion support from FIR to LLVM Dialect for OMP Target (authored by TIFitis). · Explain WhyApr 11 2023, 8:37 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 510460 flang/test/Fir/convert-to-llvm-openmp-and-fir.fir
mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp
mlir/test/Conversion/OpenMPToLLVM/convert-to-llvmir.mlir
|
Looking back at this, not sure why we needed this pattern. Doesn't RegionLessOpConversion cover this case?