This is an archive of the discontinued LLVM Phabricator instance.

[Docs][typo] Done the required fix for the #61690
ClosedPublic

Authored by aabhinavg on Mar 25 2023, 11:03 PM.

Details

Summary

[Docs][typo] Done the required fix for the #61690
[Docs][llvm-opt-report] Done the required fix for the #61657

This patch will fix both the issue #61690 #61657

Diff Detail

Event Timeline

aabhinavg created this revision.Mar 25 2023, 11:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2023, 11:03 PM
aabhinavg requested review of this revision.Mar 25 2023, 11:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2023, 11:03 PM
aabhinavg edited the summary of this revision. (Show Details)Mar 25 2023, 11:07 PM
aabhinavg added a reviewer: balazske.
aabhinavg removed rG LLVM Github Monorepo as the repository for this revision.

[docs][llvm-opt-reduce] Added description which might be useful.

aabhinavg edited the summary of this revision. (Show Details)Mar 25 2023, 11:31 PM
aabhinavg edited the summary of this revision. (Show Details)Mar 25 2023, 11:33 PM
aabhinavg added a reviewer: serge-sans-paille.
aabhinavg edited the summary of this revision. (Show Details)
aabhinavg added a reviewer: nikic.
aabhinavg edited the summary of this revision. (Show Details)

Done some minor changes

llvm/docs/CommandGuide/llvm-opt-report.rst
18

This line is mostly redundant with line 14. And line 19 would be great right after line 14.

aabhinavg updated this revision to Diff 509961.Mar 31 2023, 3:27 AM

Done fix as per suggestion

aabhinavg marked an inline comment as done.Mar 31 2023, 3:28 AM
llvm/docs/CommandGuide/llvm-opt-report.rst
20

maybe move that after the two examples, as it's just an extra explanation on the behavior.

aabhinavg updated this revision to Diff 510048.Mar 31 2023, 8:23 AM

Added as a note

aabhinavg marked an inline comment as done.Mar 31 2023, 8:25 AM

Added it as a note before the options

aabhinavg updated this revision to Diff 510150.Mar 31 2023, 4:49 PM

Added note as per documentation

jdoerfert added inline comments.Mar 31 2023, 5:53 PM
llvm/docs/GettingStarted.rst
2

We might want to keep some of the newlines.

llvm/docs/CommandGuide/llvm-opt-report.rst
67

I think .. note:: requires an indented block.

aabhinavg updated this revision to Diff 511363.Apr 6 2023, 4:13 AM

Done the minor fixes

aabhinavg marked an inline comment as done.Apr 6 2023, 4:14 AM

Done it.

serge-sans-paille accepted this revision.Apr 6 2023, 5:35 AM

Thanks for your patience, and, of course, for the fix o/

This revision is now accepted and ready to land.Apr 6 2023, 5:35 AM
This revision was landed with ongoing or failed builds.Apr 6 2023, 9:52 AM
This revision was automatically updated to reflect the committed changes.