Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs

[yeswalrus]

Summary

Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs

ASTStmtWriter::VisitConceptSpecializationExpr specifically expects getTemplateArgsAsWritten() to return true, which it wasn't when parsed by ASTContext.cpp in certain edge cases.

[yeswalrus]

Solves issue: https://github.com/llvm/llvm-project/issues/61486

[yeswalrus]

@erichkeane What are the next steps to make this land? Looks like the build servers have been stuck waiting for an agent for over 24h

[erichkeane]

While I'd definitely like to see the pre-commit bots finish before committing this, Aaron tells me there seems to be a series of problems (we had an outage earlier this week, we might be seeing more from it!). Feel free to commit without waiting, post-commit works, so they can catch anything that went wrong.

Do you need someone to commit this for you? If so, let us know, and respond with "Your Name <EmailToCommitUnder>".

[yeswalrus]

-I can handle it. -
Edit: I cannot handle it, I don't have commit access. If you could commit to both main and the 16.x lines with the attribution to Walter Gray <[e-mail]> that would be much appreciated. Thanks!

[erichkeane]

In D146678#4220360, @yeswalrus wrote:

-I can handle it. -
Edit: I cannot handle it, I don't have commit access. If you could commit to both main and the 16.x lines with the attribution to Walter Gray <[e-mail]> that would be much appreciated. Thanks!

You already have commit rights? Ok then. In order to get this merged into the 16 release, you need to create a github issue to cherry-pick it, and add it to the https://github.com/llvm/llvm-project/milestone/21 milestone.

[shafik]

clang/lib/AST/ASTContext.cpp

845

nit follow clang-tidy bugprone-argument-comment convention

[yeswalrus]

Fix Nit

[yeswalrus]

In D146678#4220408, @erichkeane wrote:

In D146678#4220360, @yeswalrus wrote:

-I can handle it. -
Edit: I cannot handle it, I don't have commit access. If you could commit to both main and the 16.x lines with the attribution to Walter Gray <[e-mail]> that would be much appreciated. Thanks!

You already have commit rights? Ok then. In order to get this merged into the 16 release, you need to create a github issue to cherry-pick it, and add it to the https://github.com/llvm/llvm-project/milestone/21 milestone.

I think there was a mixup. While I initially thought I could handle it, I do not in fact have commit rights.

[erichkeane]

In D146678#4229052, @yeswalrus wrote:

In D146678#4220408, @erichkeane wrote:

In D146678#4220360, @yeswalrus wrote:

-I can handle it. -
Edit: I cannot handle it, I don't have commit access. If you could commit to both main and the 16.x lines with the attribution to Walter Gray <[e-mail]> that would be much appreciated. Thanks!

You already have commit rights? Ok then. In order to get this merged into the 16 release, you need to create a github issue to cherry-pick it, and add it to the https://github.com/llvm/llvm-project/milestone/21 milestone.

I think there was a mixup. While I initially thought I could handle it, I do not in fact have commit rights.

Ok, not a problem! I need you to provide your requested 'author' string in the form of: "Your Name <[e-mail]>"

[yeswalrus]

"Walter Gray<[e-mail]>"
Thank you, and sorry about the back and forth.