Page MenuHomePhabricator

yeswalrus (Walter Gray)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 22 2023, 5:33 PM (11 w, 2 d)

Recent Activity

Mar 29 2023

yeswalrus added a comment to D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs.

"Walter Gray<yeswalrus@gmail.com>"
Thank you, and sorry about the back and forth.

Mar 29 2023, 9:21 AM · Restricted Project, Restricted Project

Mar 28 2023

yeswalrus added a comment to D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs.

-I can handle it. -
Edit: I cannot handle it, I don't have commit access. If you could commit to both main and the 16.x lines with the attribution to Walter Gray <yeswalrus@gmail.com> that would be much appreciated. Thanks!

You already have commit rights? Ok then. In order to get this merged into the 16 release, you need to create a github issue to cherry-pick it, and add it to the https://github.com/llvm/llvm-project/milestone/21 milestone.

Mar 28 2023, 4:57 PM · Restricted Project, Restricted Project
yeswalrus updated the diff for D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs.

Fix Nit

Mar 28 2023, 4:57 PM · Restricted Project, Restricted Project

Mar 24 2023

yeswalrus added a comment to D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs.

-I can handle it. -
Edit: I cannot handle it, I don't have commit access. If you could commit to both main and the 16.x lines with the attribution to Walter Gray <yeswalrus@gmail.com> that would be much appreciated. Thanks!

Mar 24 2023, 11:41 AM · Restricted Project, Restricted Project
yeswalrus added a comment to D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs.

@erichkeane What are the next steps to make this land? Looks like the build servers have been stuck waiting for an agent for over 24h

Mar 24 2023, 9:32 AM · Restricted Project, Restricted Project

Mar 22 2023

yeswalrus updated the summary of D146680: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field.
Mar 22 2023, 6:07 PM · Restricted Project, Restricted Project
yeswalrus added a comment to D146680: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field.

Hoping this can make it into clang-16.0.1, since the crash this causes makes clangd unusable in codebases using concepts in template arguments in this manner.

Mar 22 2023, 6:06 PM · Restricted Project, Restricted Project
yeswalrus updated the summary of D146680: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field.
Mar 22 2023, 6:04 PM · Restricted Project, Restricted Project
yeswalrus added a comment to D146680: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field.

Resolves https://github.com/llvm/llvm-project/issues/61486, Similar to https://reviews.llvm.org/D146678 but targeting the llvm-16 series.

Mar 22 2023, 6:04 PM · Restricted Project, Restricted Project
yeswalrus retitled D146680: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field from Add test for AST Writer crash to Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field.
Mar 22 2023, 6:03 PM · Restricted Project, Restricted Project
yeswalrus requested review of D146680: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field.
Mar 22 2023, 5:58 PM · Restricted Project, Restricted Project
yeswalrus retitled D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs from Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs to Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field.
Mar 22 2023, 5:53 PM · Restricted Project, Restricted Project
yeswalrus added a comment to D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs.

Solves issue: https://github.com/llvm/llvm-project/issues/61486

Mar 22 2023, 5:50 PM · Restricted Project, Restricted Project
yeswalrus requested review of D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs.
Mar 22 2023, 5:49 PM · Restricted Project, Restricted Project