This is an archive of the discontinued LLVM Phabricator instance.

Flang cmake patch to handle LLVM_ENABLE_EH conflict (issue #59353)

Authored by pmccormick on Mar 15 2023, 3:43 PM.



A quick fix to address issue #59353.

High-level summary: don't allow Flang to build/configure when LLVM_ENABLE_EH is set.

As mentioned in the issue, this is aligned with the flang style guidelines (no exceptions). We have a couple of recent use cases (e..g, the spack managed install of llvm) that are actually producing versions of Flang w/ the link time failures mentioned in this issue.

Diff Detail

Event Timeline

pmccormick created this revision.Mar 15 2023, 3:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2023, 3:43 PM
pmccormick requested review of this revision.Mar 15 2023, 3:43 PM
klausler accepted this revision.Mar 15 2023, 3:44 PM

LGTM and thanks!

This revision is now accepted and ready to land.Mar 15 2023, 3:44 PM

Rebased to capture latest state.

This revision was landed with ongoing or failed builds.Apr 26 2023, 1:08 PM
This revision was automatically updated to reflect the committed changes.