Reuse StructuralHash and allow it to be used in non-expensive checks builds.
Move PreservedAnalysisChecker further down StandardInstrumentations so other Instrumentations (e.g. printing) have a chance to run before PreservedAnalysisChecker crashes.
Differential D146003
[StandardInstrumentations] Verify function doesn't change if analyses are preserved aeubanks on Mon, Mar 13, 5:11 PM. Authored by
Details Reuse StructuralHash and allow it to be used in non-expensive checks builds. Move PreservedAnalysisChecker further down StandardInstrumentations so other Instrumentations (e.g. printing) have a chance to run before PreservedAnalysisChecker crashes.
Diff Detail
Event TimelineComment Actions Looks good in general, but it would be better to have this patch split into several smaller patches: renaming NFC, InstructionCounter intro, one for each particular pass fix.
Comment Actions Please split out the fixes to individual passes.
Comment Actions nontrivial-unswitch-markloopasdeleted.ll failure looks legit.
|