Page MenuHomePhabricator

yrouban (Yevgeny Rouban)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 4 2017, 1:39 AM (281 w, 6 d)

Recent Activity

Thu, Nov 10

yrouban added inline comments to D137632: [LoopPredication] Widen checks if condition operands constant ranges are known.
Thu, Nov 10, 9:58 PM · Restricted Project, Restricted Project

Oct 3 2022

yrouban committed rGe35182108809: Fix compilation of CodeLayout.cpp for MacOS (authored by yrouban).
Fix compilation of CodeLayout.cpp for MacOS
Oct 3 2022, 7:52 AM · Restricted Project, Restricted Project
yrouban closed D135072: Fix llvm build on MacOS.
Oct 3 2022, 7:52 AM · Restricted Project, Restricted Project

Sep 23 2022

yrouban added a comment to D134388: [Analysis] Make members of InlineCost const (NFC).

It is very inconvenient to have non-static const fields.
In our downstream source we have a field of InlineCost that is changing. With this patch we cannot change the value of the field. The same problem is with locals of InlineCost type.
Consider reverting this patch, please.

Sep 23 2022, 3:49 AM · Restricted Project, Restricted Project

Sep 1 2022

yrouban added inline comments to D132571: [RLEV] Pick a correct insert point when incoming instruction is itself a phi node.
Sep 1 2022, 9:02 AM · Restricted Project, Restricted Project
yrouban added inline comments to D132571: [RLEV] Pick a correct insert point when incoming instruction is itself a phi node.
Sep 1 2022, 5:29 AM · Restricted Project, Restricted Project

Mar 10 2022

yrouban committed rGc5f34d169244: [CommandLine] Keep option default value unset if no cl::init() is used (authored by yrouban).
[CommandLine] Keep option default value unset if no cl::init() is used
Mar 10 2022, 11:25 PM · Restricted Project
yrouban closed D114645: [CommandLine] Keep option default value unset if no cl::init() is used.
Mar 10 2022, 11:25 PM · Restricted Project, Restricted Project

Mar 9 2022

yrouban committed rGfcd9fa416d0d: [Support] Try 2: Reset option to its default if its Default field is undefined (authored by yrouban).
[Support] Try 2: Reset option to its default if its Default field is undefined
Mar 9 2022, 5:28 PM · Restricted Project
Herald added a project to D115433: [CommandLine] Reset option to its default if its Default field is undefined: Restricted Project.
Mar 9 2022, 5:27 PM · Restricted Project, Restricted Project

Mar 8 2022

yrouban closed D120713: [clangd] Make dexp command line options sticky.

Closed by commit https://reviews.llvm.org/rGc8a35727fe7c.

Mar 8 2022, 10:11 PM · Restricted Project, Restricted Project, Restricted Project
yrouban committed rGc8a35727fe7c: [clangd] Make dexp command line options sticky (authored by yrouban).
[clangd] Make dexp command line options sticky
Mar 8 2022, 10:01 PM · Restricted Project, Restricted Project
yrouban committed rG81f8df0c83c6: [clangd] Make dexp command line options sticky (authored by yrouban).
[clangd] Make dexp command line options sticky
Mar 8 2022, 10:01 PM · Restricted Project, Restricted Project

Mar 1 2022

yrouban added reviewers for D120713: [clangd] Make dexp command line options sticky: kbobyrev, sammccall.
Mar 1 2022, 11:49 PM · Restricted Project, Restricted Project, Restricted Project
yrouban updated subscribers of D120713: [clangd] Make dexp command line options sticky.

I'm not a competent reviewer for clangd

! In D120713#3353532, @jhenderson wrote:

I don't know anything about clangd either. Not sure why I was added as a reviewer :)

I took your names from https://reviews.llvm.org/D105959 which affected Dexp.cpp and was related to cl::opt.
Ok, I will shoot in the dark once more :)

Mar 1 2022, 11:46 PM · Restricted Project, Restricted Project, Restricted Project
yrouban requested review of D120713: [clangd] Make dexp command line options sticky.
Mar 1 2022, 4:00 AM · Restricted Project, Restricted Project, Restricted Project

Feb 27 2022

yrouban added a reverting change for rG7fb39fb6d666: [Support] Reset option to its default if its Default field is undefined: rGbeb92af01b0b: Revert "[Support] Reset option to its default if its Default field is undefined".
Feb 27 2022, 6:48 AM
yrouban committed rGbeb92af01b0b: Revert "[Support] Reset option to its default if its Default field is undefined" (authored by yrouban).
Revert "[Support] Reset option to its default if its Default field is undefined"
Feb 27 2022, 6:48 AM
yrouban added a reverting change for D115433: [CommandLine] Reset option to its default if its Default field is undefined: rGbeb92af01b0b: Revert "[Support] Reset option to its default if its Default field is undefined".
Feb 27 2022, 6:48 AM · Restricted Project, Restricted Project
yrouban committed rG7fb39fb6d666: [Support] Reset option to its default if its Default field is undefined (authored by yrouban).
[Support] Reset option to its default if its Default field is undefined
Feb 27 2022, 5:58 AM
yrouban closed D115433: [CommandLine] Reset option to its default if its Default field is undefined.
Feb 27 2022, 5:58 AM · Restricted Project, Restricted Project
yrouban added a comment to D115433: [CommandLine] Reset option to its default if its Default field is undefined.

... To make code review smoother, I'd recommend making the motivation stronger in the commit message.

ok. Thank you Chris.

Feb 27 2022, 4:35 AM · Restricted Project, Restricted Project

Feb 25 2022

yrouban added a comment to D114645: [CommandLine] Keep option default value unset if no cl::init() is used.

LGTM, thank you for improving this!

Thank you very much. Consider reviewing the related
D115433 [CommandLine] Reset option to its default if its Default field is undefined

Feb 25 2022, 1:16 AM · Restricted Project, Restricted Project

Feb 23 2022

yrouban added a comment to D115433: [CommandLine] Reset option to its default if its Default field is undefined.

ping, please review.

Feb 23 2022, 9:26 PM · Restricted Project, Restricted Project
yrouban added a comment to D114645: [CommandLine] Keep option default value unset if no cl::init() is used.

ping, please review.

Feb 23 2022, 9:26 PM · Restricted Project, Restricted Project
yrouban abandoned D91329: [NewPM] Re-enable PreserveCFGChecker.

Closed by commit b5c63e30ca1af7e36ba5069eb0121d1eb4b06ebb.

Feb 23 2022, 9:24 PM · Restricted Project

Jan 25 2022

yrouban added a comment to D81499: [Debugger] Use FileSystem instead of calling llvm::sys::fs::openFileForWrite directly..

Sorry, I have a typo in diff number. My commit relates to https://reviews.llvm.org/D81449.

Jan 25 2022, 10:48 PM · Restricted Project
yrouban added a comment to D81449: [JumpThreading] Handle zero !prof branch_weights.

Sounds good, thanks!

added with commit 707836ed4ed https://reviews.llvm.org/rG707836ed4edb21e7133007f0200c3fd3a04d3409

Jan 25 2022, 10:47 PM · Restricted Project
yrouban committed rG4fb8e0b8621a: [JumpThreading] Add a test for handling zero !prof branch_weights (authored by yrouban).
[JumpThreading] Add a test for handling zero !prof branch_weights
Jan 25 2022, 10:43 PM

Jan 24 2022

yrouban added a comment to D81449: [JumpThreading] Handle zero !prof branch_weights.

Curious why the test case threading_prof3.ll didn't make it into the commit?

Good catch! The test looks to be lost. I will push it tomorrow if you do not mind.

Jan 24 2022, 11:38 PM · Restricted Project

Jan 10 2022

yrouban added a comment to D115433: [CommandLine] Reset option to its default if its Default field is undefined.

... With this patch, options _without_ cl::init should get reset to the default-constructed value of the option type, and options with cl::init get initialized to the default value.

+1. I have fixed the summary to make it clearer.

Jan 10 2022, 7:08 PM · Restricted Project, Restricted Project
yrouban updated the summary of D115433: [CommandLine] Reset option to its default if its Default field is undefined.
Jan 10 2022, 7:06 PM · Restricted Project, Restricted Project

Dec 12 2021

yrouban added a comment to D114645: [CommandLine] Keep option default value unset if no cl::init() is used.

ping, please review.

Dec 12 2021, 5:58 PM · Restricted Project, Restricted Project
yrouban added a comment to D115433: [CommandLine] Reset option to its default if its Default field is undefined.

ping, please review.

Dec 12 2021, 5:58 PM · Restricted Project, Restricted Project

Dec 9 2021

yrouban updated the diff for D114645: [CommandLine] Keep option default value unset if no cl::init() is used.

Extracted a separate change D115433.

Dec 9 2021, 1:25 AM · Restricted Project, Restricted Project
yrouban updated the diff for D115433: [CommandLine] Reset option to its default if its Default field is undefined.

added context lines

Dec 9 2021, 1:24 AM · Restricted Project, Restricted Project
yrouban added inline comments to D114645: [CommandLine] Keep option default value unset if no cl::init() is used.
Dec 9 2021, 1:21 AM · Restricted Project, Restricted Project
yrouban requested review of D115433: [CommandLine] Reset option to its default if its Default field is undefined.
Dec 9 2021, 1:17 AM · Restricted Project, Restricted Project

Dec 7 2021

yrouban added inline comments to D114645: [CommandLine] Keep option default value unset if no cl::init() is used.
Dec 7 2021, 10:07 PM · Restricted Project, Restricted Project
yrouban added inline comments to D114645: [CommandLine] Keep option default value unset if no cl::init() is used.
Dec 7 2021, 7:25 AM · Restricted Project, Restricted Project
yrouban updated the summary of D114645: [CommandLine] Keep option default value unset if no cl::init() is used.
Dec 7 2021, 7:24 AM · Restricted Project, Restricted Project

Dec 5 2021

yrouban added a comment to D114645: [CommandLine] Keep option default value unset if no cl::init() is used.

Any thought? ping

Dec 5 2021, 8:25 PM · Restricted Project, Restricted Project

Nov 26 2021

yrouban requested review of D114645: [CommandLine] Keep option default value unset if no cl::init() is used.
Nov 26 2021, 8:12 AM · Restricted Project, Restricted Project

Nov 18 2021

yrouban accepted D114009: [BPI] Look-up tables for non-loop branches. NFC..
Nov 18 2021, 5:56 PM · Restricted Project

Nov 16 2021

yrouban added a comment to D114009: [BPI] Look-up tables for non-loop branches. NFC..

instead of storing a bool value (swap the probability or not) it would be better to store final array of branch probabilities to set so it would not need to define probabilities every time and optionally swap them.

Nov 16 2021, 5:43 PM · Restricted Project
yrouban added inline comments to D114009: [BPI] Look-up tables for non-loop branches. NFC..
Nov 16 2021, 5:12 PM · Restricted Project
yrouban added a reviewer for D114009: [BPI] Look-up tables for non-loop branches. NFC.: ebrevnov.
Nov 16 2021, 5:07 PM · Restricted Project

Nov 7 2021

yrouban added a reviewer for D113344: [BPI] Push exit block rather than exiting ones in getSccExitBlocks: ebrevnov.
Nov 7 2021, 1:53 AM · Restricted Project

Oct 13 2021

yrouban added inline comments to D111581: Remove checks for old gcc versions for LLVM_ATTRIBUTE_*.
Oct 13 2021, 10:47 PM · Restricted Project, Restricted Project

Oct 7 2021

yrouban added inline comments to D111023: [ConstantFold] Refactor load folding.
Oct 7 2021, 3:15 AM · Restricted Project
yrouban updated subscribers of D111023: [ConstantFold] Refactor load folding.
Oct 7 2021, 3:13 AM · Restricted Project

Jul 22 2021

yrouban abandoned D103887: [StackMaps] Force section serialization for functions with no records.

Thank you, Philip. The .stack_sizes section seems to be exactly what we need.

One minor issue I had to solve downstream: the .stack_sizes section does not have the ELF::SHF_ALLOC flag as the llvm_stackmaps does. So I had to set this flag in MCObjectFileInfo.cpp.

Jul 22 2021, 10:04 PM · Restricted Project

Jul 12 2021

yrouban committed rG88024a724c3b: [RS4GC] Use one DVCache for both inlineGetBaseAndOffset() and insertParsePoints… (authored by yrouban).
[RS4GC] Use one DVCache for both inlineGetBaseAndOffset() and insertParsePoints…
Jul 12 2021, 4:14 AM
yrouban closed D103240: [RS4GC] Use one DVCache for both inlineGetBaseAndOffset() and insertParsePoints().
Jul 12 2021, 4:13 AM · Restricted Project
yrouban committed rGa95c336b5e3b: [RS4GC] Add a test to demonstrate duplication of base generation. NFC (authored by yrouban).
[RS4GC] Add a test to demonstrate duplication of base generation. NFC
Jul 12 2021, 4:13 AM
yrouban closed D103238: [RS4GC] Add a test to demonstrate duplication of base generation. NFC.
Jul 12 2021, 4:13 AM · Restricted Project

Jun 18 2021

yrouban planned changes to D103887: [StackMaps] Force section serialization for functions with no records.

I don't really have an objection to this, but have you looked at the -stack-size-section support? I think you might be able to get the same information that way. If that doesn't work for some reason, just let me know and we can move forward with the review of this.

Thank you, Philip. The .stack_sizes section seems to be exactly what we need.

Jun 18 2021, 3:54 AM · Restricted Project

Jun 9 2021

yrouban updated the diff for D103887: [StackMaps] Force section serialization for functions with no records.

fixed nits reported by build bots

Jun 9 2021, 8:50 PM · Restricted Project

Jun 8 2021

yrouban requested review of D103887: [StackMaps] Force section serialization for functions with no records.
Jun 8 2021, 4:15 AM · Restricted Project

May 27 2021

yrouban requested review of D103240: [RS4GC] Use one DVCache for both inlineGetBaseAndOffset() and insertParsePoints().
May 27 2021, 4:03 AM · Restricted Project
yrouban requested review of D103238: [RS4GC] Add a test to demonstrate duplication of base generation. NFC.
May 27 2021, 3:58 AM · Restricted Project

May 26 2021

yrouban committed rG4d26f41f76c4: [RS4GC] Introduce intrinsics to get base ptr and offset (authored by yrouban).
[RS4GC] Introduce intrinsics to get base ptr and offset
May 26 2021, 7:16 PM
yrouban closed D100445: [RS4GC] Introduce intrinsics to get base ptr and offset.
May 26 2021, 7:15 PM · Restricted Project
yrouban updated the summary of D100445: [RS4GC] Introduce intrinsics to get base ptr and offset.
May 26 2021, 7:00 PM · Restricted Project
yrouban updated the diff for D100445: [RS4GC] Introduce intrinsics to get base ptr and offset.

Philip, thank you for comments. I believe I addressed them all.

May 26 2021, 3:43 AM · Restricted Project

May 24 2021

yrouban planned changes to D100445: [RS4GC] Introduce intrinsics to get base ptr and offset.
May 24 2021, 7:53 PM · Restricted Project
yrouban added a comment to D100445: [RS4GC] Introduce intrinsics to get base ptr and offset.

I'm still working on the next version.

May 24 2021, 2:12 AM · Restricted Project

May 21 2021

yrouban closed D102631: Allow incomplete template types in unique_function arguments.

I have just committed the patch as
https://reviews.llvm.org/rGe3eaff10b29d8bb85a0d09e6bb72fbdb7cc9c3ea
Sorry I forget to add the 'Differential Revision:' line to the comment.

May 21 2021, 12:15 AM · Restricted Project
yrouban committed rGe3eaff10b29d: Allow incomplete template types in unique_function arguments (authored by yrouban).
Allow incomplete template types in unique_function arguments
May 21 2021, 12:10 AM

May 19 2021

yrouban added a comment to D102631: Allow incomplete template types in unique_function arguments.

I'm ok with the patch and will land it. Lets wait for @DaniilSuchkov's resolution.

May 19 2021, 10:53 PM · Restricted Project

May 18 2021

yrouban accepted D102631: Allow incomplete template types in unique_function arguments.

lgtm

May 18 2021, 7:21 PM · Restricted Project

Apr 13 2021

yrouban requested review of D100445: [RS4GC] Introduce intrinsics to get base ptr and offset.
Apr 13 2021, 10:10 PM · Restricted Project

Apr 8 2021

yrouban updated the diff for D100009: [WIP][Statepoint Lowering] Allow other than N byte sized types in deopt bundle.

Added 3 test cases with live-in deopt values that crash.
Removed one unrelated comment .
Fixed couple of places with hardcoded 64 const.
Marked the patch as work-in-progress.

Apr 8 2021, 8:39 AM · Restricted Project
yrouban planned changes to D100009: [WIP][Statepoint Lowering] Allow other than N byte sized types in deopt bundle.
Apr 8 2021, 4:36 AM · Restricted Project

Apr 7 2021

yrouban committed rG3e738afae4b5: [Statepoint Lowering] Allow other than N byte sized types in deopt bundle (authored by yrouban).
[Statepoint Lowering] Allow other than N byte sized types in deopt bundle
Apr 7 2021, 3:49 AM
yrouban closed D100006: [Statepoint Lowering] Allow other than N byte sized types in deopt bundle.
Apr 7 2021, 3:49 AM · Restricted Project

Apr 6 2021

yrouban added a comment to D100006: [Statepoint Lowering] Allow other than N byte sized types in deopt bundle.

LGTM, looks straight forward.

Though, can you share a bit of motivation? I'm curious where this is useful.

I found this constraint accidentally while preparing a test for D100009 where I wanted to check that an arbitrary sized types are ok for spill slot size promotion.

Apr 6 2021, 9:32 PM · Restricted Project
yrouban requested review of D100009: [WIP][Statepoint Lowering] Allow other than N byte sized types in deopt bundle.
Apr 6 2021, 8:09 PM · Restricted Project
yrouban requested review of D100006: [Statepoint Lowering] Allow other than N byte sized types in deopt bundle.
Apr 6 2021, 7:40 PM · Restricted Project
yrouban committed rGb5c63e30ca1a: [NewPM] Set verify-cfg-preserved=1 by default for debug builds (authored by yrouban).
[NewPM] Set verify-cfg-preserved=1 by default for debug builds
Apr 6 2021, 6:36 PM

Apr 5 2021

yrouban committed rG98742e42fc50: [NewPM] Fix unused lambda capture build error (authored by yrouban).
[NewPM] Fix unused lambda capture build error
Apr 5 2021, 11:17 PM
yrouban committed rG39e3e3aa51d6: [NewPM] Redesign of PreserveCFG Checker (authored by yrouban).
[NewPM] Redesign of PreserveCFG Checker
Apr 5 2021, 10:37 PM
yrouban closed D91327: [NewPM] Redesign of PreserveCFG Checker.
Apr 5 2021, 10:36 PM · Restricted Project, Restricted Project
yrouban committed rG872c57c90ac6: [NewPM] Change tests to run them without PreserveCFGChecker. NFC (authored by yrouban).
[NewPM] Change tests to run them without PreserveCFGChecker. NFC
Apr 5 2021, 9:34 PM
yrouban closed D99878: Fix tests to run them without PreserveCFGChecker. NFC.
Apr 5 2021, 9:33 PM · Restricted Project
yrouban updated the diff for D91327: [NewPM] Redesign of PreserveCFG Checker.

Addressed comments.
Some tests were moved a separate patch (D99878).

Apr 5 2021, 2:02 AM · Restricted Project, Restricted Project
yrouban requested review of D99878: Fix tests to run them without PreserveCFGChecker. NFC.
Apr 5 2021, 2:00 AM · Restricted Project

Apr 1 2021

yrouban committed rG1ed53d44d8e9: [LoopFlatten] Do not report CFG analyses as up-to-date (authored by yrouban).
[LoopFlatten] Do not report CFG analyses as up-to-date
Apr 1 2021, 1:53 AM
yrouban closed D99700: [LoopFlatten] Do not report CFG analyses as up-to-date.
Apr 1 2021, 1:53 AM · Restricted Project

Mar 31 2021

yrouban requested review of D99700: [LoopFlatten] Do not report CFG analyses as up-to-date.
Mar 31 2021, 9:22 PM · Restricted Project
yrouban added a comment to D91327: [NewPM] Redesign of PreserveCFG Checker.

@skatkov, @fedor.sergeev, could you please review. During the long time this features is on the reconstruction we introduced a new bug in the LoopFlatten pass. See the comment https://reviews.llvm.org/D90940#inline-938253.

Mar 31 2021, 8:50 PM · Restricted Project, Restricted Project
yrouban added inline comments to D90940: [LoopFlatten] Make it a FunctionPass.
Mar 31 2021, 8:49 PM · Restricted Project
yrouban added inline comments to D91327: [NewPM] Redesign of PreserveCFG Checker.
Mar 31 2021, 7:08 PM · Restricted Project, Restricted Project

Mar 29 2021

yrouban updated the diff for D91327: [NewPM] Redesign of PreserveCFG Checker.

fixed the nits

Mar 29 2021, 8:55 PM · Restricted Project, Restricted Project
yrouban added a comment to D91327: [NewPM] Redesign of PreserveCFG Checker.

Just two nits from me. I think it looks fine, but I'm not familiar with the new pass manager and don't feel confident enough to approve it.

Jakub, thank you for comments. I expect @skatkov or @fedor.sergeev to look from NewPM point of view.

Mar 29 2021, 8:52 PM · Restricted Project, Restricted Project
yrouban updated the diff for D91327: [NewPM] Redesign of PreserveCFG Checker.

just rebased. please review

Mar 29 2021, 5:20 AM · Restricted Project, Restricted Project

Mar 25 2021

yrouban committed rGf7ef26ef0b29: [SLP] Fix crash in reduction for integer min/max (authored by yrouban).
[SLP] Fix crash in reduction for integer min/max
Mar 25 2021, 8:03 AM
yrouban closed D99328: [SLP] Fix crash in reduction for integer min/max.
Mar 25 2021, 8:03 AM · Restricted Project
yrouban updated the diff for D99328: [SLP] Fix crash in reduction for integer min/max.

fixed the test

Mar 25 2021, 5:10 AM · Restricted Project
yrouban added inline comments to D99328: [SLP] Fix crash in reduction for integer min/max.
Mar 25 2021, 5:09 AM · Restricted Project