Page MenuHomePhabricator

yrouban (Yevgeny Rouban)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 4 2017, 1:39 AM (118 w, 5 d)

Recent Activity

Sep 11 2019

yrouban committed rGbdfe84ad110f: Make SwitchInstProfUpdateWrapper strict permanently (authored by yrouban).
Make SwitchInstProfUpdateWrapper strict permanently
Sep 11 2019, 8:41 PM
yrouban committed rL371707: Make SwitchInstProfUpdateWrapper strict permanently.
Make SwitchInstProfUpdateWrapper strict permanently
Sep 11 2019, 8:40 PM
yrouban closed D67435: Make SwitchInstProfUpdateWrapper strict permanently.
Sep 11 2019, 8:40 PM · Restricted Project
yrouban created D67435: Make SwitchInstProfUpdateWrapper strict permanently.
Sep 11 2019, 3:44 AM · Restricted Project

Aug 12 2019

yrouban committed rG8b996dc16ee4: Verifier: check prof branch_weights (authored by yrouban).
Verifier: check prof branch_weights
Aug 12 2019, 9:04 PM
yrouban committed rL368647: Verifier: check prof branch_weights.
Verifier: check prof branch_weights
Aug 12 2019, 9:04 PM
yrouban closed D61179: Verifier: check prof branch_weights.
Aug 12 2019, 9:04 PM · Restricted Project

Aug 7 2019

yrouban committed rGcb87f3734b0a: Force check prof branch_weights consistency in SwitchInstProfUpdateWrapper (authored by yrouban).
Force check prof branch_weights consistency in SwitchInstProfUpdateWrapper
Aug 7 2019, 12:19 AM
yrouban committed rL368129: Force check prof branch_weights consistency in SwitchInstProfUpdateWrapper.
Force check prof branch_weights consistency in SwitchInstProfUpdateWrapper
Aug 7 2019, 12:19 AM
yrouban closed D64061: Force check prof branch_weights consistency in SwitchInstProfUpdateWrapper.
Aug 7 2019, 12:19 AM · Restricted Project

Jul 9 2019

yrouban added a comment to D64061: Force check prof branch_weights consistency in SwitchInstProfUpdateWrapper.

please flip the flag to false by default and check in the rest first.

done. D64233 is landed.

Jul 9 2019, 8:52 PM · Restricted Project
yrouban closed D64233: Prepare for making SwitchInstProfUpdateWrapper strict.

Closed by commit rL365439: Prepare for making SwitchInstProfUpdateWrapper strict (authored by yrouban).
yrouban committed rG592f44a7e75b: Prepare for making SwitchInstProfUpdateWrapper strict (authored by yrouban).
llvm-svn: 365439

Jul 9 2019, 8:52 PM · Restricted Project

Jul 8 2019

yrouban committed rG592f44a7e75b: Prepare for making SwitchInstProfUpdateWrapper strict (authored by yrouban).
Prepare for making SwitchInstProfUpdateWrapper strict
Jul 8 2019, 10:08 PM
yrouban committed rL365439: Prepare for making SwitchInstProfUpdateWrapper strict.
Prepare for making SwitchInstProfUpdateWrapper strict
Jul 8 2019, 10:07 PM

Jul 4 2019

yrouban retitled D64233: Prepare for making SwitchInstProfUpdateWrapper strict from Prepare for making SwitchInstProfUpdateWrapper strict. to Prepare for making SwitchInstProfUpdateWrapper strict.
Jul 4 2019, 9:16 PM · Restricted Project
yrouban updated the diff for D64061: Force check prof branch_weights consistency in SwitchInstProfUpdateWrapper.

extracted the preparation patch to the separate patch D64233.

Jul 4 2019, 9:14 PM · Restricted Project
yrouban added a child revision for D64233: Prepare for making SwitchInstProfUpdateWrapper strict: D64061: Force check prof branch_weights consistency in SwitchInstProfUpdateWrapper.
Jul 4 2019, 9:14 PM · Restricted Project
yrouban added a parent revision for D64061: Force check prof branch_weights consistency in SwitchInstProfUpdateWrapper: D64233: Prepare for making SwitchInstProfUpdateWrapper strict.
Jul 4 2019, 9:14 PM · Restricted Project
yrouban created D64233: Prepare for making SwitchInstProfUpdateWrapper strict.
Jul 4 2019, 9:10 PM · Restricted Project

Jul 3 2019

yrouban updated the diff for D64061: Force check prof branch_weights consistency in SwitchInstProfUpdateWrapper.

Changed assert(false) to llvm_unreachable() for release builds to fail on inconsistencies. Though it seems to be too strict as the code can tolerate such inconsistencies.

Jul 3 2019, 9:21 PM · Restricted Project

Jul 2 2019

yrouban added a comment to D64061: Force check prof branch_weights consistency in SwitchInstProfUpdateWrapper.

What types of testing has been done ? I assume the code base now is relatively clean so it is safe to turn this on by default?

Frankly speaking I'm not 100% sure that the code is safe. There could be projects that might hit the assertion. E.g I have to fix one pass internally at Azul. I tested LLVM monorepo make check-all and our Azul Zing test suits. So, I believe that the only way to find issues is to land this check D64061 and the verifyer D61179 one by one with some reasonable interval (one week?).

Jul 2 2019, 9:50 PM · Restricted Project
yrouban created D64061: Force check prof branch_weights consistency in SwitchInstProfUpdateWrapper.
Jul 2 2019, 12:04 AM · Restricted Project

Jul 1 2019

yrouban committed rGd4097b4a93a2: [SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for… (authored by yrouban).
[SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for…
Jul 1 2019, 1:45 AM
yrouban committed rL364734: [SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for….
[SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for…
Jul 1 2019, 1:44 AM
yrouban closed D60606: [SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for SwitchInst.
Jul 1 2019, 1:44 AM · Restricted Project

Jun 26 2019

yrouban updated the diff for D60606: [SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for SwitchInst.

Addressed most comments. The main changes are the following:

  • added more cases to trivial-unswitch-profmd.ll
  • brushed up basictest-profmd.ll
  • added NewSI default case weight if the default successor was not an exit
Jun 26 2019, 1:10 AM · Restricted Project
yrouban added inline comments to D60606: [SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for SwitchInst.
Jun 26 2019, 1:02 AM · Restricted Project

Jun 24 2019

yrouban added a comment to D63706: [InlineCost] Fix bug 42084: remember negative result when computing full inline cost.

Please, see my comment to PR42084: https://bugs.llvm.org/show_bug.cgi?id=42084#c3.
A core of the problem is in two difference Cost-vs-Threshold checks used in analyzeBlock (Cost >= Threshold) and analyzeCall (Cost < max(1, Threshold)).
I believe a proper fix for this bug would be to use a unified Cost-vs-Threshold check everywhere.

I agree that those two checks seem to be inconsistent with each other, but I insist on my fix. It makes the method analyzeBlock() return same result (negative or positive) regardless of the flag ComputeFullInlineCost.
The root cause is that the analyzeBlock() returns different results (negative or positive) for different ComputeFullInlineCost. And the checks you mentioned if fixed could just hide this difference.

Jun 24 2019, 11:09 PM · Restricted Project
yrouban set the repository for D63706: [InlineCost] Fix bug 42084: remember negative result when computing full inline cost to rG LLVM Github Monorepo.
Jun 24 2019, 2:54 AM · Restricted Project
yrouban created D63706: [InlineCost] Fix bug 42084: remember negative result when computing full inline cost.
Jun 24 2019, 2:54 AM · Restricted Project

Jun 21 2019

yrouban added a comment to D63058: [InlineCost] Fix bug 42084: return the first negative result.

One issue bothers me: results of the InlineCost analyzer will depend on the flag ComputeFullInlineCost. Negative or positive decision will persist but the message and highest computed cost will be changing.

We already have the cost difference depending on this flag.
It seems to be rather obvious consequence of "full inline cost" notion and the difference should not be confusing...

I still believe that we should separate a bug fix from introducing a new feature. As I read the comments this patch looks to be complex to be just a bugfix but not full enough to introduce a new and complete feature.
I could provide a one line fix with a test if I believe it is a complete fix for the bug. In other words I'm a bit stuck. Any suggestions are welcome.

Jun 21 2019, 1:41 AM · Restricted Project

Jun 20 2019

yrouban committed rGd5e1ce3f44b0: [LICM & MSSA] Fixed test to run only with assertions enabled as it uses -debug… (authored by yrouban).
[LICM & MSSA] Fixed test to run only with assertions enabled as it uses -debug…
Jun 20 2019, 9:49 PM
yrouban added inline comments to D63582: [LICM & MSSA] Limit unsafe sinking and hoisting..
Jun 20 2019, 9:47 PM · Restricted Project
yrouban committed rL364005: [LICM & MSSA] Fixed test to run only with assertions enabled as it uses -debug….
[LICM & MSSA] Fixed test to run only with assertions enabled as it uses -debug…
Jun 20 2019, 9:46 PM

Jun 18 2019

yrouban updated the diff for D60606: [SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for SwitchInst.

Rebased to the latest HEAD. Please review. Its sibling patches have been landed.

Jun 18 2019, 10:47 PM · Restricted Project

Jun 17 2019

yrouban committed rG69daf4a72daf: [SimplifyCFG] NFC, prof branch_weighs handling is simplified (authored by yrouban).
[SimplifyCFG] NFC, prof branch_weighs handling is simplified
Jun 17 2019, 11:50 PM
yrouban committed rL363652: [SimplifyCFG] NFC, prof branch_weighs handling is simplified.
[SimplifyCFG] NFC, prof branch_weighs handling is simplified
Jun 17 2019, 11:50 PM
yrouban closed D62123: [NFC] SimplifyCFG prof branch_weighs handling is simplified.
Jun 17 2019, 11:50 PM · Restricted Project

Jun 16 2019

yrouban committed rGee62c40eae93: [SimplifyCFG] Fix prof branch_weights MD while removing unreachable switch cases (authored by yrouban).
[SimplifyCFG] Fix prof branch_weights MD while removing unreachable switch cases
Jun 16 2019, 10:53 PM
yrouban committed rL363527: [SimplifyCFG] Fix prof branch_weights MD while removing unreachable switch cases.
[SimplifyCFG] Fix prof branch_weights MD while removing unreachable switch cases
Jun 16 2019, 10:53 PM
yrouban closed D62186: [SimplifyCFG] Fix prof branch_weights MD while removing unreachable switch cases.
Jun 16 2019, 10:53 PM · Restricted Project

Jun 14 2019

yrouban added inline comments to D62123: [NFC] SimplifyCFG prof branch_weighs handling is simplified.
Jun 14 2019, 5:14 AM · Restricted Project
yrouban updated the diff for D63058: [InlineCost] Fix bug 42084: return the first negative result.
  • extracted a separate function GetFirstNegative()
  • changed the test to check that the bug is fixed
Jun 14 2019, 4:48 AM · Restricted Project
yrouban added a comment to D63058: [InlineCost] Fix bug 42084: return the first negative result.

I think this is somewhat the wrong approach.
I think we need to widen the interface a bit to return two pieces of information instead of one:

  1. The highest cost computed
  2. Any inline-blocking construct encountered And we should phrase #2 as a bitmask so that we can return multiple things in it. One of them can be that we exceeded the threshold, another can be any terminal condition we additionally reached like recursion. I think this will also make the code more clear as we won't be throwing away any information at any step.

In general I agree with this approach. But the bigger change it needs the stronger intention I have to fix the bug with a minimal change and to develop the feature as another separate patch. One issue bothers me: results of the InlineCost analyzer will depend on the flag ComputeFullInlineCost. Negative or positive decision will persist but the message and highest computed cost will be changing.

Jun 14 2019, 12:43 AM · Restricted Project

Jun 11 2019

yrouban planned changes to D63058: [InlineCost] Fix bug 42084: return the first negative result.
Jun 11 2019, 3:20 AM · Restricted Project

Jun 9 2019

yrouban added a comment to D63058: [InlineCost] Fix bug 42084: return the first negative result.

2 questions, since i've read through the diff:

  1. will this pick the smallest cost, or the first negative cost?
  2. is this missing some abstraction? maybe InlineResult Result should be some wrapper that should be assigned-to, that will internally only accept the new value if it's better than what it currently has,
  1. Not the smallest cost, but the first negative result with its message.
  2. I think such an abstraction would not be much shorter: Result = InlineResult::FirstNegative(Result, expression)
Jun 9 2019, 8:45 PM · Restricted Project
yrouban added a comment to D63058: [InlineCost] Fix bug 42084: return the first negative result.

tests?

Makes sense. I will try.

Jun 9 2019, 8:39 PM · Restricted Project
yrouban created D63058: [InlineCost] Fix bug 42084: return the first negative result.
Jun 9 2019, 7:22 AM · Restricted Project

Jun 5 2019

yrouban reopened D50435: [Inliner] Attribute callsites with inline remarks.

Hi @yrouban,
Since you did some work in this area, can you look at this bug report please?
https://bugs.llvm.org/show_bug.cgi?id=42084

Interesting. I will try but next week.

Jun 5 2019, 4:52 AM

Jun 4 2019

yrouban committed rGa3e16719c46a: Resubmit "[CorrelatedValuePropagation] Fix prof branch_weights metadata… (authored by yrouban).
Resubmit "[CorrelatedValuePropagation] Fix prof branch_weights metadata…
Jun 4 2019, 10:48 PM
yrouban added a reverting change for rG5b32f60ec31c: Revert "[CorrelatedValuePropagation] Fix prof branch_weights metadata handling…: rGa3e16719c46a: Resubmit "[CorrelatedValuePropagation] Fix prof branch_weights metadata….
Jun 4 2019, 10:48 PM
yrouban committed rL362583: Resubmit "[CorrelatedValuePropagation] Fix prof branch_weights metadata….
Resubmit "[CorrelatedValuePropagation] Fix prof branch_weights metadata…
Jun 4 2019, 10:47 PM
yrouban closed D62126: [CorrelatedValuePropagation] Fix prof branch_weights metadata handling for SwitchInst.
Jun 4 2019, 10:47 PM · Restricted Project
yrouban committed rG4f9e68148bd0: Make SwitchInstProfUpdateWrapper safer (authored by yrouban).
Make SwitchInstProfUpdateWrapper safer
Jun 4 2019, 2:04 AM
yrouban committed rL362473: Make SwitchInstProfUpdateWrapper safer.
Make SwitchInstProfUpdateWrapper safer
Jun 4 2019, 2:04 AM
yrouban closed D62656: Make SwitchInstProfUpdateWrapper safer.
Jun 4 2019, 2:04 AM · Restricted Project

Jun 2 2019

yrouban updated the diff for D62656: Make SwitchInstProfUpdateWrapper safer.

fixed typos

Jun 2 2019, 10:03 PM · Restricted Project

May 31 2019

yrouban updated the diff for D62656: Make SwitchInstProfUpdateWrapper safer.

added option switch-inst-prof-update-wrapper-strict to assert if prof data is inconsistent. It is off by default.
Probably it makes sense to enable prof branch_weights validation (patch D61179) in the same way.

May 31 2019, 2:09 AM · Restricted Project
yrouban planned changes to D62656: Make SwitchInstProfUpdateWrapper safer.

I suggest the following path:

  1. add an option to enforce internal error on inconsistency; by default the inconsistency is ignored.

Ok. This option will probably simplify catching such bugs.

May 31 2019, 12:06 AM · Restricted Project

May 30 2019

yrouban updated the diff for D62656: Make SwitchInstProfUpdateWrapper safer.

Formatted and fixed one typo.

May 30 2019, 9:06 PM · Restricted Project
yrouban added inline comments to D62656: Make SwitchInstProfUpdateWrapper safer.
May 30 2019, 9:06 PM · Restricted Project
yrouban added a comment to D62656: Make SwitchInstProfUpdateWrapper safer.

What I meant is that we should never see inconsistent state and instead of setting invalid state, we assert there.

Yes. But in LLVM there are many places to fix. So we have to fix all of them at once and set the assertion here. The other option is to fix them one by one and tolerate such inconsistencies.
For example, SimplifyCFG is safe: it checks that the prof data is ok and only then makes its prof changes.

May 30 2019, 8:26 PM · Restricted Project
yrouban added inline comments to D62656: Make SwitchInstProfUpdateWrapper safer.
May 30 2019, 11:08 AM · Restricted Project
yrouban requested review of D62126: [CorrelatedValuePropagation] Fix prof branch_weights metadata handling for SwitchInst.

Providing an obviously incorrect branch_weights for one of the added test cases is enough to cause an assertion failure:

I have just submitted a fix. Please see D62656. Once it is landed this patch can be landed unchanged.
I decided to not include the crash test case as it would be caught by verification proposed in D61179.

May 30 2019, 6:08 AM · Restricted Project
yrouban added a parent revision for D62126: [CorrelatedValuePropagation] Fix prof branch_weights metadata handling for SwitchInst: D62656: Make SwitchInstProfUpdateWrapper safer.
May 30 2019, 6:02 AM · Restricted Project
yrouban added a child revision for D62656: Make SwitchInstProfUpdateWrapper safer: D62126: [CorrelatedValuePropagation] Fix prof branch_weights metadata handling for SwitchInst.
May 30 2019, 6:02 AM · Restricted Project
yrouban created D62656: Make SwitchInstProfUpdateWrapper safer.
May 30 2019, 6:02 AM · Restricted Project

May 29 2019

yrouban planned changes to D62126: [CorrelatedValuePropagation] Fix prof branch_weights metadata handling for SwitchInst.

Thank you very much for the revert, the analysis and the test.
I'm going make the wrapper class safe by introducing invalid sticky state.

May 29 2019, 4:37 AM · Restricted Project

May 28 2019

yrouban committed rG53f2f3286572: [CorrelatedValuePropagation] Fix prof branch_weights metadata handling for… (authored by yrouban).
[CorrelatedValuePropagation] Fix prof branch_weights metadata handling for…
May 28 2019, 4:33 AM
yrouban committed rL361808: [CorrelatedValuePropagation] Fix prof branch_weights metadata handling for….
[CorrelatedValuePropagation] Fix prof branch_weights metadata handling for…
May 28 2019, 4:32 AM
yrouban closed D62126: [CorrelatedValuePropagation] Fix prof branch_weights metadata handling for SwitchInst.
May 28 2019, 4:32 AM · Restricted Project

May 27 2019

yrouban added a comment to D62186: [SimplifyCFG] Fix prof branch_weights MD while removing unreachable switch cases.

@davidxl, @eraman, @reames please review.

May 27 2019, 9:02 PM · Restricted Project
yrouban added a comment to D62123: [NFC] SimplifyCFG prof branch_weighs handling is simplified.

@davidxl, @eraman, @reames please review.

May 27 2019, 9:02 PM · Restricted Project
yrouban abandoned D60606: [SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for SwitchInst.

@asbirlea, @fedor.sergeev, @mkazantsev, @chandlerc could you please review the patch or suggest somebody who can take a look?

May 27 2019, 9:02 PM · Restricted Project
yrouban reclaimed D60606: [SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for SwitchInst.
May 27 2019, 9:02 PM · Restricted Project
yrouban added a comment to D62126: [CorrelatedValuePropagation] Fix prof branch_weights metadata handling for SwitchInst.

I considered this way and found it error prone. The wrapper stays alive after ConstantFoldTerminator() and developer may accidentally reuse it but the stored weights might be unsync with the underlying SwitchInst's weights changed by ConstantFoldTerminator().

May 27 2019, 8:55 PM · Restricted Project
yrouban updated the diff for D62126: [CorrelatedValuePropagation] Fix prof branch_weights metadata handling for SwitchInst.
  • renamed SwitchInstProfBranchWeightsWrapper to SwitchInstProfUpdateWrapper
  • explicitly narrowed scope of the SwitchInstProfUpdateWrapper object so it does not overlap with ConstantFoldTerminator()
  • added a test case where switch turns into conditional branch
May 27 2019, 7:36 AM · Restricted Project
yrouban added inline comments to D62126: [CorrelatedValuePropagation] Fix prof branch_weights metadata handling for SwitchInst.
May 27 2019, 7:16 AM · Restricted Project

May 23 2019

yrouban committed rGc652b3455ec5: [NFC] SwitchInst: Introduce wrapper for prof branch_weights handling (authored by yrouban).
[NFC] SwitchInst: Introduce wrapper for prof branch_weights handling
May 23 2019, 9:33 PM
yrouban committed rL361596: [NFC] SwitchInst: Introduce wrapper for prof branch_weights handling.
[NFC] SwitchInst: Introduce wrapper for prof branch_weights handling
May 23 2019, 9:33 PM
yrouban closed D62122: [NFC] Introduce SwitchInst wrapper for prof branch_weights handling.
May 23 2019, 9:33 PM · Restricted Project

May 22 2019

yrouban updated the diff for D62122: [NFC] Introduce SwitchInst wrapper for prof branch_weights handling.

Addressed comments:

  • renamed to SwitchInstProfUpdateWrapper
  • added method descriptions
  • added one assertion
May 22 2019, 8:11 AM · Restricted Project
yrouban added inline comments to D62122: [NFC] Introduce SwitchInst wrapper for prof branch_weights handling.
May 22 2019, 8:10 AM · Restricted Project

May 21 2019

yrouban added a child revision for D62122: [NFC] Introduce SwitchInst wrapper for prof branch_weights handling: D62186: [SimplifyCFG] Fix prof branch_weights MD while removing unreachable switch cases.
May 21 2019, 4:01 AM · Restricted Project
yrouban added a parent revision for D62186: [SimplifyCFG] Fix prof branch_weights MD while removing unreachable switch cases: D62122: [NFC] Introduce SwitchInst wrapper for prof branch_weights handling.
May 21 2019, 4:01 AM · Restricted Project
yrouban created D62186: [SimplifyCFG] Fix prof branch_weights MD while removing unreachable switch cases.
May 21 2019, 4:01 AM · Restricted Project
yrouban added inline comments to D62123: [NFC] SimplifyCFG prof branch_weighs handling is simplified.
May 21 2019, 12:03 AM · Restricted Project
yrouban updated the diff for D62123: [NFC] SimplifyCFG prof branch_weighs handling is simplified.

Done early return in eliminateDeadSwitchCases as suggested.

May 21 2019, 12:03 AM · Restricted Project

May 20 2019

yrouban updated the summary of D61179: Verifier: check prof branch_weights.
May 20 2019, 8:24 PM · Restricted Project
yrouban abandoned D60604: [IR] Improve SwitchInst API to support prof branch_weights.

See 62122 and its children.

May 20 2019, 8:23 PM · Restricted Project
yrouban abandoned D60554: Fix number of args of prof branch_weights MD for SwitchInst.

See 62122 and its children.

May 20 2019, 8:22 PM · Restricted Project
yrouban retitled D61179: Verifier: check prof branch_weights from [WIP] Verifier: check prof branch_weights to Verifier: check prof branch_weights.
May 20 2019, 8:19 PM · Restricted Project
yrouban added a child revision for D60606: [SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for SwitchInst: D61179: Verifier: check prof branch_weights.
May 20 2019, 5:23 AM · Restricted Project
yrouban added a parent revision for D61179: Verifier: check prof branch_weights: D60606: [SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for SwitchInst.
May 20 2019, 5:23 AM · Restricted Project
yrouban edited parent revisions for D60606: [SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for SwitchInst, added: 1; removed: 1.
May 20 2019, 5:23 AM · Restricted Project
yrouban added a child revision for D62122: [NFC] Introduce SwitchInst wrapper for prof branch_weights handling: D60606: [SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for SwitchInst.
May 20 2019, 5:23 AM · Restricted Project
yrouban removed a child revision for D60604: [IR] Improve SwitchInst API to support prof branch_weights: D60606: [SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for SwitchInst.
May 20 2019, 5:23 AM · Restricted Project
yrouban updated the diff for D60606: [SimpleLoopUnswitch] Implement handling of prof branch_weights metadata for SwitchInst.
  • made use of SwitchInstProfBranchWeightsWrapper introduced in D62122.
  • created new profmd tests instead of changing the existing tests
May 20 2019, 5:20 AM · Restricted Project
yrouban added a parent revision for D61179: Verifier: check prof branch_weights: D62126: [CorrelatedValuePropagation] Fix prof branch_weights metadata handling for SwitchInst.
May 20 2019, 1:38 AM · Restricted Project
yrouban added a child revision for D62126: [CorrelatedValuePropagation] Fix prof branch_weights metadata handling for SwitchInst: D61179: Verifier: check prof branch_weights.
May 20 2019, 1:38 AM · Restricted Project