Page MenuHomePhabricator

[PassManager] Run PassInstrumentation after analysis invalidation
ClosedPublic

Authored by aeubanks on Tue, Mar 14, 2:50 PM.

Details

Summary

This allows instrumentation to inspect cached analyses to verify them.

The CGSCC PassInstrumentation previously ran runAfterPass() on the original SCC, but really it should be running on UpdatedC when relevant since that's the relevant SCC after the pass.

Diff Detail

Event Timeline

aeubanks created this revision.Tue, Mar 14, 2:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 14, 2:50 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
aeubanks requested review of this revision.Tue, Mar 14, 2:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 14, 2:50 PM
aeubanks added inline comments.Tue, Mar 14, 3:01 PM
llvm/test/Other/scc-deleted-printer.ll
7

the instrumentation stores the name from before the pass ran

nikic accepted this revision.Wed, Mar 15, 1:39 AM

LGTM

This revision is now accepted and ready to land.Wed, Mar 15, 1:39 AM