Page MenuHomePhabricator
Differential D146096

[PassManager] Run PassInstrumentation after analysis invalidation
ClosedPublic
Actions

Authored by aeubanks on Tue, Mar 14, 2:50 PM.

Details

Reviewers
asbirlea
yrouban
nikic
Commits
rGbfc6590e66be: [PassManager] Run PassInstrumentation after analysis invalidation
Summary

This allows instrumentation to inspect cached analyses to verify them.

The CGSCC PassInstrumentation previously ran runAfterPass() on the original SCC, but really it should be running on UpdatedC when relevant since that's the relevant SCC after the pass.

Diff Detail

Event Timeline

aeubanks created this revision.Tue, Mar 14, 2:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 14, 2:50 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
aeubanks requested review of this revision.Tue, Mar 14, 2:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 14, 2:50 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aeubanks updated this revision to Diff 505277.Tue, Mar 14, 2:57 PM

update

aeubanks updated this revision to Diff 505280.Tue, Mar 14, 2:59 PM

update

aeubanks added inline comments.Tue, Mar 14, 3:01 PM
llvm/test/Other/scc-deleted-printer.ll
7

the instrumentation stores the name from before the pass ran

aeubanks added reviewers: asbirlea, yrouban, nikic.Tue, Mar 14, 3:01 PM
Herald added a subscriber: StephenFan. · View Herald TranscriptTue, Mar 14, 3:01 PM
Harbormaster completed remote builds in B219487: Diff 505280.Tue, Mar 14, 4:21 PM
nikic accepted this revision.Wed, Mar 15, 1:39 AM

LGTM

This revision is now accepted and ready to land.Wed, Mar 15, 1:39 AM
Closed by commit rGbfc6590e66be: [PassManager] Run PassInstrumentation after analysis invalidation (authored by aeubanks). · Explain WhyWed, Mar 15, 8:36 AM
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rGbfc6590e66be: [PassManager] Run PassInstrumentation after analysis invalidation.
aeubanks mentioned this in D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved.Wed, Mar 15, 9:28 AM

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
IR/
8 lines
lib/
Analysis/
45 lines
CodeGen/
2 lines
IR/
3 lines
Passes/
4 lines
test/
Other/
2 lines

Diff 505504

View Options

llvm/include/llvm/IR/PassManager.h

Loading...
View Options

llvm/lib/Analysis/CGSCCPassManager.cpp

Loading...
View Options

llvm/lib/CodeGen/MachinePassManager.cpp

Loading...
View Options

llvm/lib/IR/PassManager.cpp

Loading...
View Options

llvm/lib/Passes/StandardInstrumentations.cpp

Loading...
View Options

llvm/test/Other/scc-deleted-printer.ll

Loading...