This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Make -X default for baremetal riscv
ClosedPublic

Authored by abrachet on Mar 9 2023, 1:01 PM.

Diff Detail

Event Timeline

abrachet created this revision.Mar 9 2023, 1:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2023, 1:01 PM
abrachet requested review of this revision.Mar 9 2023, 1:01 PM
phosek accepted this revision.Mar 9 2023, 10:14 PM

LGTM

clang/lib/Driver/ToolChains/BareMetal.cpp
341–346

Can you move it above -o so it's consistent with other drivers?

This revision is now accepted and ready to land.Mar 9 2023, 10:14 PM
kito-cheng added inline comments.Mar 9 2023, 10:35 PM
clang/lib/Driver/ToolChains/BareMetal.cpp
341–346

I think we should do that for RV32 as well?

This revision was landed with ongoing or failed builds.Mar 13 2023, 10:18 PM
This revision was automatically updated to reflect the committed changes.
abrachet marked 2 inline comments as done.
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 10:18 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Both comments addressed in commit