This is an archive of the discontinued LLVM Phabricator instance.

[Xtensa] Add support of the Xtensa function calls
Needs RevisionPublic

Authored by andreisfr on Mar 9 2023, 12:18 AM.

Diff Detail

Event Timeline

andreisfr created this revision.Mar 9 2023, 12:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2023, 12:18 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
andreisfr requested review of this revision.Mar 9 2023, 12:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2023, 12:18 AM
andreisfr updated this revision to Diff 508583.Mar 27 2023, 5:03 AM

Minor code formatting

JKRhb added a subscriber: JKRhb.Mar 30 2023, 12:57 PM
arsenm requested changes to this revision.Aug 18 2023, 4:28 AM

Needs tests

llvm/lib/Target/Xtensa/XtensaFrameLowering.cpp
51

getSubtarget<XTensaSubtarget.().getInstrInfo

llvm/lib/Target/Xtensa/XtensaISelLowering.cpp
334

Why can't this be a regular SmallVector?

370

don't need .getNode (here and other places)

394

StringRef?

433–434

Can use initializer list

472

Register / MCRegister instead of unsigned

llvm/lib/Target/Xtensa/XtensaInstrInfo.cpp
138

isInt<11>?

140

isInt<16>?

146

isInt<32>?

llvm/lib/Target/Xtensa/XtensaRegisterInfo.cpp
85

MCRegister

88

Initialize with ternary operator?

This revision now requires changes to proceed.Aug 18 2023, 4:28 AM