This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Enable subregister liveness by default
ClosedPublic

Authored by BeMg on Mar 7 2023, 10:29 PM.

Details

Summary

This commit enable the subregister liveness by default in RISC-V.

It was previously disabled in https://reviews.llvm.org/D129646 after a previous attempt to enabled it https://reviews.llvm.org/D128016.

We believe that https://reviews.llvm.org/D129735 fixes the issue that caused it to be disabled.

Diff Detail

Event Timeline

BeMg created this revision.Mar 7 2023, 10:29 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2023, 10:29 PM
BeMg requested review of this revision.Mar 7 2023, 10:29 PM
BeMg retitled this revision from [RISCV] Enable subreg liveness by default to [RISCV] Enable subregister liveness by default.Mar 7 2023, 10:43 PM
BeMg edited the summary of this revision. (Show Details)
craig.topper edited the summary of this revision. (Show Details)Mar 7 2023, 10:51 PM
craig.topper accepted this revision.Mar 8 2023, 8:32 PM

LGTM. Forgot to click Accept earlier.

This revision is now accepted and ready to land.Mar 8 2023, 8:32 PM
kito-cheng accepted this revision.Mar 8 2023, 10:01 PM

Although Craig already give LGTM, so it's already ready to go, but I would like to give my blessing here, finally we could re-enable this, thanks you!

This revision was automatically updated to reflect the committed changes.