Funnel fetching and building LLVM instructions into GettingStarted.
Modernize the build steps a little.
Remove comments saying CMAKE_BUILD_TYPE defaults to Debug as that's not true anymore (must explicitly pass it).
Paths
| Differential D145413
[docs] Update README and GettingStarted ClosedPublic Authored by aeubanks on Mar 6 2023, 11:48 AM.
Details Summary Funnel fetching and building LLVM instructions into GettingStarted. Modernize the build steps a little. Remove comments saying CMAKE_BUILD_TYPE defaults to Debug as that's not true anymore (must explicitly pass it).
Diff Detail
Event TimelineComment Actions LGTM. Deduplicating README.md makes sense and removes one place to change when we update instructions.
This revision is now accepted and ready to land.Mar 6 2023, 1:07 PM
Comment Actions address comments Comment Actions Best to wait for a second opinion.
Comment Actions LGTM as-is, but I did have some comments you can feel free to take or leave.
aeubanks marked an inline comment as done. Comment Actionslink to cmake generator docs
This revision was landed with ongoing or failed builds.Mar 8 2023, 12:56 PM Closed by commit rG65548ff34901: [docs] Update README and GettingStarted (authored by aeubanks). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 503477 README.md
llvm/docs/CMake.rst
llvm/docs/GettingStarted.rst
|
Check out