Page MenuHomePhabricator
Differential D145177

[DAGCombiner] Add fold for `~x + x` -> `-1`
ClosedPublic
Actions

Authored by goldstein.w.n on Thu, Mar 2, 12:30 PM.

Details

Reviewers
RKSimon
pengfei
Commits
rGc1ecd0a3f49a: [DAGCombiner] Add fold for `~x + x` -> `-1`
Summary

This is generally done by the InstCombine, but can be emitted as an
intermediate step and is cheap to handle.

Diff Detail

Event Timeline

goldstein.w.n created this revision.Thu, Mar 2, 12:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Mar 2, 12:30 PM
Herald added subscribers: ecnelises, pengfei, hiraditya. · View Herald Transcript
goldstein.w.n requested review of this revision.Thu, Mar 2, 12:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Mar 2, 12:30 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added reviewers: RKSimon, pengfei.Thu, Mar 2, 12:31 PM
goldstein.w.n added a parent revision: D145143: [DAGCombiner] Add fold for `~x & x` -> `0`.
Harbormaster completed remote builds in B217032: Diff 501950.Thu, Mar 2, 1:33 PM
RKSimon accepted this revision.Thu, Mar 2, 2:13 PM
RKSimon mentioned this in D145143: [DAGCombiner] Add fold for `~x & x` -> `0`.

LGTM

This revision is now accepted and ready to land.Thu, Mar 2, 2:13 PM
goldstein.w.n updated this revision to Diff 502062.Thu, Mar 2, 11:41 PM

Use VT

Harbormaster completed remote builds in B217119: Diff 502062.Fri, Mar 3, 1:36 AM
Closed by commit rGc1ecd0a3f49a: [DAGCombiner] Add fold for `~x + x` -> `-1` (authored by goldstein.w.n). · Explain WhyMon, Mar 6, 6:31 PM
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rGc1ecd0a3f49a: [DAGCombiner] Add fold for `~x + x` -> `-1`.

Revision Contents
Changeset List

PathSize
llvm/
lib/
CodeGen/
SelectionDAG/
4 lines
test/
CodeGen/
X86/
24 lines

Diff 502895

View Options

llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Loading...
View Options

llvm/test/CodeGen/X86/combine-add.ll

Loading...