Page MenuHomePhabricator
Differential D144763

[X86] Add masked predicate execution variants for instructions in X86FixupInstTuning
ClosedPublic
Actions

Authored by goldstein.w.n on Feb 24 2023, 3:11 PM.

Details

Reviewers
RKSimon
pengfei
Commits
rG8ac8c579e214: [X86] Add masked predicate execution variants for instructions in…
Summary

Masked variants of UNPCKLPD, UNPCKHPD, and PERMILPS were missing and
be transformed with the same logic as their non-masked counterparts.

Diff Detail

Event Timeline

goldstein.w.n created this revision.Feb 24 2023, 3:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2023, 3:11 PM
Herald added subscribers: pengfei, hiraditya. · View Herald Transcript
goldstein.w.n requested review of this revision.Feb 24 2023, 3:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2023, 3:11 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a parent revision: D144762: [X86] Add more tests for tuning codegen for unpck{l|h}pd shuffle patterns; NFC.Feb 24 2023, 3:12 PM
goldstein.w.n added reviewers: RKSimon, pengfei.
goldstein.w.n mentioned this in D143787: [X86] Add new pass `X86FixupInstTuning` for fixing up machine-instruction selection..
goldstein.w.n updated this revision to Diff 500381.Feb 24 2023, 11:33 PM

Rebase

Harbormaster completed remote builds in B215900: Diff 500381.Feb 24 2023, 11:34 PM
goldstein.w.n edited parent revisions, added: D143860: [X86] Add additional operations that masked instructions can combine with; removed: D144762: [X86] Add more tests for tuning codegen for unpck{l|h}pd shuffle patterns; NFC.Feb 24 2023, 11:34 PM
goldstein.w.n updated this revision to Diff 500482.Sat, Feb 25, 5:02 PM

Rebase

Harbormaster completed remote builds in B215984: Diff 500482.Sat, Feb 25, 7:23 PM
goldstein.w.n added a parent revision: D144570: [X86] Add support for using Sched/Codesize information to `X86FixupInstTuning` Pass..Sun, Feb 26, 10:41 AM
goldstein.w.n removed a parent revision: D143860: [X86] Add additional operations that masked instructions can combine with.
goldstein.w.n updated this revision to Diff 500617.Sun, Feb 26, 12:34 PM

Rebase

Harbormaster completed remote builds in B216101: Diff 500617.Sun, Feb 26, 1:44 PM
goldstein.w.n updated this revision to Diff 500629.Sun, Feb 26, 2:53 PM

Rebase

Harbormaster completed remote builds in B216111: Diff 500629.Sun, Feb 26, 3:53 PM
goldstein.w.n updated this revision to Diff 500965.Mon, Feb 27, 4:19 PM

Rebase (after D144832, no dep on D143786)

Harbormaster completed remote builds in B216355: Diff 500965.Mon, Feb 27, 4:20 PM
goldstein.w.n updated this revision to Diff 502720.Mon, Mar 6, 10:44 AM

Rebase

Harbormaster completed remote builds in B217638: Diff 502720.Mon, Mar 6, 2:57 PM
goldstein.w.n updated this revision to Diff 503183.Tue, Mar 7, 4:25 PM

Rebase

Harbormaster completed remote builds in B217966: Diff 503183.Tue, Mar 7, 4:57 PM
goldstein.w.n updated this revision to Diff 503210.Tue, Mar 7, 7:05 PM

Rebase

Matt added a subscriber: Matt.Tue, Mar 7, 7:08 PM
Harbormaster completed remote builds in B217986: Diff 503210.Tue, Mar 7, 7:38 PM
RKSimon accepted this revision.Wed, Mar 8, 6:56 AM

LGTM

This revision is now accepted and ready to land.Wed, Mar 8, 6:56 AM
This revision was landed with ongoing or failed builds.Wed, Mar 8, 9:58 AM
Closed by commit rG8ac8c579e214: [X86] Add masked predicate execution variants for instructions in… (authored by goldstein.w.n). · Explain Why
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rG8ac8c579e214: [X86] Add masked predicate execution variants for instructions in….

Revision Contents
Changeset List

Diff 503423

View Options

llvm/lib/Target/X86/X86FixupInstTuning.cpp

Loading...
View Options

llvm/test/CodeGen/X86/avx512-intrinsics-fast-isel.ll

Loading...
View Options

llvm/test/CodeGen/X86/avx512-intrinsics-upgrade.ll

Loading...
View Options

llvm/test/CodeGen/X86/avx512-shuffles/in_lane_permute.ll

Loading...
View Options

llvm/test/CodeGen/X86/avx512vl-intrinsics-upgrade.ll

Loading...
View Options

llvm/test/CodeGen/X86/tuning-shuffle-permilps-avx512.ll

Loading...
View Options

llvm/test/CodeGen/X86/tuning-shuffle-unpckpd-avx512.ll

Loading...
View Options

llvm/test/CodeGen/X86/vector-shuffle-combining-avx512f.ll

Loading...