This is an archive of the discontinued LLVM Phabricator instance.

[PS4/PS5] Specify no <complex.h> or <threads.h>
ClosedPublic

Authored by probinson on Feb 22 2023, 11:59 AM.

Details

Summary

We've never provided these headers so set the preprocessor
toggles to reflect that.

Diff Detail

Event Timeline

probinson created this revision.Feb 22 2023, 11:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 22 2023, 11:59 AM
probinson requested review of this revision.Feb 22 2023, 11:59 AM

Just to double-check, no to threads but yes to atomics? (Checking whether you also need __STDC_NO_ATOMICS__ or not.)

Should this have a release note?

That's correct, I do see <stdatomic.h> in our SDK.

I don't see a need for a release note; we're not actually removing anything that we used to support.

aaron.ballman accepted this revision.Feb 23 2023, 5:34 AM

LGTM, thanks for double-checking on the atomics question!

This revision is now accepted and ready to land.Feb 23 2023, 5:34 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2023, 7:09 AM