This is an archive of the discontinued LLVM Phabricator instance.

Differential D144531

[RISCV] Replaced !subst chain with !foldl
ClosedPublic

Authored by nitinjohnraj on Feb 21 2023, 6:43 PM.

Details

Reviewers
craig.topper
kito-cheng
arcbbb
frasercrmck
rogfer01
reames
MaskRay
Commits
rGbbaa5685b2c3: [RISCV] Replaced !subst chain with !foldl

Diff Detail

Event Timeline

nitinjohnraj created this revision.Feb 21 2023, 6:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 6:43 PM
Herald added subscribers: luke, VincentWu, vkmr and 28 others. · View Herald Transcript
nitinjohnraj requested review of this revision.Feb 21 2023, 6:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 6:43 PM
Herald added subscribers: llvm-commits, • pcwang-thead, eopXD, MaskRay. · View Herald Transcript
nitinjohnraj added a reviewer: craig.topper.Feb 21 2023, 6:44 PM
craig.topper added reviewers: kito-cheng, arcbbb, frasercrmck, rogfer01, reames.Feb 21 2023, 7:11 PM
craig.topper retitled this revision from [RISCV] Replaced \!subst chain with \!foldl to [RISCV] Replaced !subst chain with !foldl.
craig.topper added inline comments.Feb 21 2023, 7:17 PM
llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
51–74

For everyone else, I discussed this with Nitin internally. The list here is in reverse order because the original list was applied from the inside out. So "Pseudo" was substituted first. The order almost doesn't matter except that "_B16" must be replaced before "_B1" since "_B1" is a prefix of "_B16"

Harbormaster completed remote builds in B215145: Diff 499347.Feb 21 2023, 7:54 PM
craig.topper accepted this revision.Feb 22 2023, 8:49 AM

LGTM

This revision is now accepted and ready to land.Feb 22 2023, 8:49 AM
MaskRay accepted this revision.Feb 22 2023, 10:06 AM

Add a NFC?

The !foldl use is correct: https://llvm.org/docs/TableGen/ProgRef.html#:~:text=foldl(

Closed by commit rGbbaa5685b2c3: [RISCV] Replaced !subst chain with !foldl (authored by nitinjohnraj, committed by craig.topper). · Explain WhyFeb 22 2023, 12:28 PM
This revision was automatically updated to reflect the committed changes.
craig.topper added a commit: rGbbaa5685b2c3: [RISCV] Replaced !subst chain with !foldl.

Revision Contents

PathSize
llvm/
lib/
Target/
RISCV/
45 lines

Diff 499623

llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
defvar TAIL_AGNOSTIC = 1; defvar TAIL_AGNOSTIC = 1;
defvar TA_MA = 3; defvar TA_MA = 3;
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Utilities. // Utilities.
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
class PseudoToVInst<string PseudoInst> { class PseudoToVInst<string PseudoInst> {
string VInst = !subst("_M8", "", defvar AffixSubsts = [["Pseudo", ""],
!subst("_M4", "", ["F64", "F"],
!subst("_M2", "", ["F32", "F"],
!subst("_M1", "", ["F16", "F"],
!subst("_MF2", "", ["_TU", ""],
!subst("_MF4", "", ["_TIED", ""],
!subst("_MF8", "", ["_MASK", ""],
!subst("_B1", "", ["_B64", ""],
!subst("_B2", "", ["_B32", ""],
!subst("_B4", "", ["_B16", ""],
!subst("_B8", "", ["_B8", ""],
!subst("_B16", "", ["_B4", ""],
!subst("_B32", "", ["_B2", ""],
!subst("_B64", "", ["_B1", ""],
!subst("_MASK", "", ["_MF8", ""],
!subst("_TIED", "", ["_MF4", ""],
!subst("_TU", "", ["_MF2", ""],
!subst("F16", "F", ["_M1", ""],
!subst("F32", "F", ["_M2", ""],
!subst("F64", "F", ["_M4", ""],
!subst("Pseudo", "", PseudoInst))))))))))))))))))))); ["_M8", ""]
];
string VInst = !foldl(PseudoInst, AffixSubsts, Acc, AffixSubst,
!subst(AffixSubst[0], AffixSubst[1], Acc));
craig.topperUnsubmitted
Not Done
ReplyInline Actions

For everyone else, I discussed this with Nitin internally. The list here is in reverse order because the original list was applied from the inside out. So "Pseudo" was substituted first. The order almost doesn't matter except that "_B16" must be replaced before "_B1" since "_B1" is a prefix of "_B16"

craig.topper: For everyone else, I discussed this with Nitin internally. The list here is in reverse order…
} }
// This class describes information associated to the LMUL. // This class describes information associated to the LMUL.
class LMULInfo<int lmul, int oct, VReg regclass, VReg wregclass, class LMULInfo<int lmul, int oct, VReg regclass, VReg wregclass,
VReg f2regclass, VReg f4regclass, VReg f8regclass, string mx> { VReg f2regclass, VReg f4regclass, VReg f8regclass, string mx> {
bits<3> value = lmul; // This is encoded as the vlmul field of vtype. bits<3> value = lmul; // This is encoded as the vlmul field of vtype.
VReg vrclass = regclass; VReg vrclass = regclass;
VReg wvrclass = wregclass; VReg wvrclass = wregclass;
▲ Show 20 Lines • Show All 6,347 Lines • Show Last 20 Lines