Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D144041

[clang-tidy] add primitive types for hungarian identifier-naming (unsigned char and void)
ClosedPublic
Actions

Authored by amurzeau on Feb 14 2023, 1:25 PM.

Details

Reviewers
njames93
alexfh
kazu
dougpuob
aaron.ballman
carlosgalvezp
Commits
rG37e6a4f9496c: [clang-tidy] add primitive types for hungarian identifier-naming (unsigned char…
Summary

Add unsigned char and void types to recognized PrimitiveTypes.
Fixes: #60670

Depends on D144037

Diff Detail

Event Timeline

amurzeau created this revision.Feb 14 2023, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2023, 1:25 PM
Herald added subscribers: carlosgalvezp, xazax.hun. · View Herald Transcript
amurzeau requested review of this revision.Feb 14 2023, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2023, 1:25 PM
Herald added subscribers: cfe-commits, aheejin. · View Herald Transcript
Harbormaster completed remote builds in B213726: Diff 497423.Feb 14 2023, 2:10 PM
Eugene.Zelenko added reviewers: aaron.ballman, carlosgalvezp.Feb 15 2023, 7:19 AM
carlosgalvezp accepted this revision.Feb 15 2023, 7:34 AM

LGTM!

This revision is now accepted and ready to land.Feb 15 2023, 7:34 AM
amurzeau added a comment.Feb 20 2023, 11:00 AM

I do not have commit access to the repo, can someone commit this patch for me ? (after D144037)

Closed by commit rG37e6a4f9496c: [clang-tidy] add primitive types for hungarian identifier-naming (unsigned char… (authored by amurzeau, committed by PiotrZSL). · Explain WhyFeb 20 2023, 11:19 AM
This revision was automatically updated to reflect the committed changes.
PiotrZSL added a commit: rG37e6a4f9496c: [clang-tidy] add primitive types for hungarian identifier-naming (unsigned char….

Revision Contents
Changeset List

PathSize
clang-tools-extra/
clang-tidy/
readability/
6 lines
test/
clang-tidy/
checkers/
readability/
Inputs/
identifier-naming/
hungarian-notation2/
4 lines
14 lines
4 lines

Diff 497423

View Options

clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp

Loading...
View Options

clang-tools-extra/test/clang-tidy/checkers/readability/Inputs/identifier-naming/hungarian-notation2/.clang-tidy

Loading...
View Options

clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-hungarian-notation-cfgfile.cpp

Loading...
View Options

clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-hungarian-notation.cpp

Loading...