[clang-tidy] add primitive types for hungarian identifier-naming (unsigned char and void)

[amurzeau]

Summary

Add unsigned char and void types to recognized PrimitiveTypes.
Fixes: #60670

Depends on D144037

[carlosgalvezp]

LGTM!

[amurzeau]

I do not have commit access to the repo, can someone commit this patch for me ? (after D144037)

clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp

#define HUNGARIAN_NOTATION_PRIMITIVE_TYPES(m) \
      m(signed) \
      m(unsigned-long-long-int) \
      m(unsigned-long-long) \
      m(unsigned-long-int) \
      m(unsigned-long) \
      m(unsigned-short-int) \
      m(unsigned-short) \
      m(unsigned-int) \
+     m(unsigned-char) \
      m(unsigned) \
      m(long-long-int) \
      m(long-double) \
      m(long-long) \
      m(long-int) \
      m(long) \
      m(ptrdiff_t) \
+     m(void) \
 
 static StringRef const HungarainNotationPrimitiveTypes[] = {
 #define STRINGIZE(v) #v,
   HUNGARIAN_NOTATION_PRIMITIVE_TYPES(STRINGIZE)
 #undef STRINGIZE
 };
 
 #define HUNGARIAN_NOTATION_USER_DEFINED_TYPES(m) \
static constexpr std::pair<StringRef, StringRef> PrimitiveTypes[] = {
         {"signed",                  "s"   },
         {"unsigned long long int",  "ulli"},
         {"unsigned long long",      "ull" },
         {"unsigned long int",       "uli" },
         {"unsigned long",           "ul"  },
         {"unsigned short int",      "usi" },
         {"unsigned short",          "us"  },
         {"unsigned int",            "ui"  },
+        {"unsigned char",           "uc"  },
         {"unsigned",                "u"   },
         {"long long int",           "lli" },
         {"long double",             "ld"  },
         {"long long",               "ll"  },
         {"long int",                "li"  },
         {"long",                    "l"   },
-        {"ptrdiff_t",               "p"   }};
+        {"ptrdiff_t",               "p"   },
+        {"void",                    ""    }};
   // clang-format on
   for (const auto &PT : PrimitiveTypes)
     HNOption.PrimitiveType.try_emplace(PT.first, PT.second);
 
   // clang-format off
   static constexpr std::pair<StringRef, StringRef> UserDefinedTypes[] = {
       // Windows data types
       {"BOOL",                    "b"   },

clang-tools-extra/test/clang-tidy/checkers/readability/Inputs/identifier-naming/hungarian-notation2/.clang-tidy

CheckOptions:
   - key:    readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-long
     value:  ul
   - key:    readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-short-int
     value:  usi
   - key:    readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-short
     value:  us
   - key:    readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-int
     value:  ui
+  - key:    readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-char
+    value:  uc
   - key:    readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned
     value:  u
   - key:    readability-identifier-naming.HungarianNotation.PrimitiveType.long-long-int
     value:  lli
   - key:    readability-identifier-naming.HungarianNotation.PrimitiveType.long-double
     value:  ld
   - key:    readability-identifier-naming.HungarianNotation.PrimitiveType.long-long
     value:  ll
   - key:    readability-identifier-naming.HungarianNotation.PrimitiveType.long-int
     value:  li
   - key:    readability-identifier-naming.HungarianNotation.PrimitiveType.long
     value:  l
   - key:    readability-identifier-naming.HungarianNotation.PrimitiveType.ptrdiff_t
     value:  p
+  - key:    readability-identifier-naming.HungarianNotation.PrimitiveType.void
+    value:  v
   - key:    readability-identifier-naming.HungarianNotation.UserDefinedType.BOOL
     value:  b
   - key:    readability-identifier-naming.HungarianNotation.UserDefinedType.BOOLEAN
     value:  b
   - key:    readability-identifier-naming.HungarianNotation.UserDefinedType.BYTE
     value:  by
   - key:    readability-identifier-naming.HungarianNotation.UserDefinedType.CHAR
     value:  c

clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-hungarian-notation-cfgfile.cpp

 // Pointer
 //===----------------------------------------------------------------------===//
 int *DataIntPtr[1] = {0};
 // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: invalid case style for global variable 'DataIntPtr' [readability-identifier-naming]
 // CHECK-FIXES: {{^}}int *paryDataIntPtr[1] = {0};
 
 void *BufferPtr1;
 // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: invalid case style for global pointer 'BufferPtr1' [readability-identifier-naming]
-// CHECK-FIXES: {{^}}void *pBufferPtr1;
+// CHECK-FIXES: {{^}}void *pvBufferPtr1;
 
 void **BufferPtr2;
 // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: invalid case style for global pointer 'BufferPtr2' [readability-identifier-naming]
-// CHECK-FIXES: {{^}}void **ppBufferPtr2;
+// CHECK-FIXES: {{^}}void **ppvBufferPtr2;
 
 void **pBufferPtr3;
 // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: invalid case style for global pointer 'pBufferPtr3' [readability-identifier-naming]
-// CHECK-FIXES: {{^}}void **ppBufferPtr3;
+// CHECK-FIXES: {{^}}void **ppvBufferPtr3;
 
 int *pBufferPtr4;
 // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: invalid case style for global pointer 'pBufferPtr4' [readability-identifier-naming]
 // CHECK-FIXES: {{^}}int *piBufferPtr4;
 
 typedef void (*FUNC_PTR_HELLO)();
 FUNC_PTR_HELLO Hello = NULL;
 // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: invalid case style for global pointer 'Hello' [readability-identifier-naming]
 // CHECK-FIXES: {{^}}FUNC_PTR_HELLO fnHello = NULL;
 
 void *ValueVoidPtr = NULL;
 // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: invalid case style for global pointer 'ValueVoidPtr' [readability-identifier-naming]
-// CHECK-FIXES: {{^}}void *pValueVoidPtr = NULL;
+// CHECK-FIXES: {{^}}void *pvValueVoidPtr = NULL;
 
 ptrdiff_t PtrDiff = NULL;
 // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: invalid case style for global variable 'PtrDiff' [readability-identifier-naming]
 // CHECK-FIXES: {{^}}ptrdiff_t pPtrDiff = NULL;
 
 int8_t *ValueI8Ptr;
 // CHECK-MESSAGES: :[[@LINE-1]]:9: warning: invalid case style for global pointer 'ValueI8Ptr' [readability-identifier-naming]
 // CHECK-FIXES: {{^}}int8_t *pi8ValueI8Ptr;
 
 uint8_t *ValueU8Ptr;
 // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: invalid case style for global pointer 'ValueU8Ptr' [readability-identifier-naming]
 // CHECK-FIXES: {{^}}uint8_t *pu8ValueU8Ptr;
 
 void MyFunc2(void* Val){}
 // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: invalid case style for pointer parameter 'Val' [readability-identifier-naming]
-// CHECK-FIXES: {{^}}void MyFunc2(void* pVal){}
+// CHECK-FIXES: {{^}}void MyFunc2(void* pvVal){}
 
 
 //===----------------------------------------------------------------------===//
 // Reference
 //===----------------------------------------------------------------------===//
 int iValueIndex = 1;
 int &RefValueIndex = iValueIndex;
 // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: invalid case style for global variable 'RefValueIndex' [readability-identifier-naming]

 unsigned short ValueUnsignedShort = 0;
 // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: invalid case style for global variable 'ValueUnsignedShort' [readability-identifier-naming]
 // CHECK-FIXES: {{^}}unsigned short usValueUnsignedShort = 0;
 
 unsigned int ValueUnsignedInt = 0;
 // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: invalid case style for global variable 'ValueUnsignedInt' [readability-identifier-naming]
 // CHECK-FIXES: {{^}}unsigned int uiValueUnsignedInt = 0;
 
+unsigned char ValueUnsignedChar = 0;
+// CHECK-MESSAGES: :[[@LINE-1]]:15: warning: invalid case style for global variable 'ValueUnsignedChar' [readability-identifier-naming]
+// CHECK-FIXES: {{^}}unsigned char ucValueUnsignedChar = 0;
+
 long int ValueLongInt = 0;
 // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: invalid case style for global variable 'ValueLongInt' [readability-identifier-naming]
 // CHECK-FIXES: {{^}}long int liValueLongInt = 0;
 
 
 //===----------------------------------------------------------------------===//
 // Specifier, Qualifier, Other keywords
 //===----------------------------------------------------------------------===//

clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming-hungarian-notation.cpp

 unsigned short ValueUnsignedShort = 0;
 // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: invalid case style for global variable 'ValueUnsignedShort' [readability-identifier-naming]
 // CHECK-FIXES: {{^}}unsigned short usValueUnsignedShort = 0;
 
 unsigned int ValueUnsignedInt = 0;
 // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: invalid case style for global variable 'ValueUnsignedInt' [readability-identifier-naming]
 // CHECK-FIXES: {{^}}unsigned int uiValueUnsignedInt = 0;
 
+unsigned char ValueUnsignedChar = 0;
+// CHECK-MESSAGES: :[[@LINE-1]]:15: warning: invalid case style for global variable 'ValueUnsignedChar' [readability-identifier-naming]
+// CHECK-FIXES: {{^}}unsigned char ucValueUnsignedChar = 0;
+
 long int ValueLongInt = 0;
 // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: invalid case style for global variable 'ValueLongInt' [readability-identifier-naming]
 // CHECK-FIXES: {{^}}long int liValueLongInt = 0;
 
 
 //===----------------------------------------------------------------------===//
 // Specifier, Qualifier, Other keywords
 //===----------------------------------------------------------------------===//