Page MenuHomePhabricator
Differential D144036

[clang-tidy] Add bugprone-enum-to-bool-conversion check
Needs ReviewPublic
Actions

Authored by PiotrZSL on Feb 14 2023, 11:51 AM.

Details

Reviewers
njames93
aaron.ballman
carlosgalvezp
LegalizeAdulthood
Summary

Detect implicit and explicit conversions of enum to bool,
when enum doesn't have a enumerator with value equal to 0.
In theory such conversion should always return TRUE.

Diff Detail

Event Timeline

PiotrZSL created this revision.Feb 14 2023, 11:51 AM
Herald added a reviewer: njames93. · View Herald TranscriptFeb 14 2023, 11:51 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: carlosgalvezp, xazax.hun. · View Herald Transcript
PiotrZSL updated this revision to Diff 497408.Feb 14 2023, 11:54 AM

Removed "Offers fixes" from list.rst

Harbormaster completed remote builds in B213716: Diff 497408.Feb 14 2023, 12:59 PM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.Feb 15 2023, 7:28 AM
Eugene.Zelenko added inline comments.
clang-tools-extra/clang-tidy/bugprone/EnumToBoolConversionCheck.h
29

Should language be checked for C++?

clang-tools-extra/docs/clang-tidy/checks/bugprone/enum-to-bool-conversion.rst
7

Please synchronize first statement with statement in Release Notes. Please use double back-ticks for language constructs.

50

Please use single back-ticks for option values. Default value is usually placed after option description.

Eugene.Zelenko added reviewers: aaron.ballman, carlosgalvezp.Feb 15 2023, 7:28 AM
PiotrZSL updated this revision to Diff 497692.Feb 15 2023, 8:32 AM

Correct copyrights and commit author

PiotrZSL published this revision for review.Feb 15 2023, 8:33 AM

Ready for review

Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2023, 8:33 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B213909: Diff 497692.Feb 15 2023, 9:28 AM
PiotrZSL updated this revision to Diff 497727.Feb 15 2023, 10:14 AM
PiotrZSL marked 3 inline comments as done.

Corrected issues mentioned in review

PiotrZSL added a comment.Feb 15 2023, 10:15 AM

Fixed

Harbormaster completed remote builds in B213936: Diff 497727.Feb 15 2023, 10:49 AM
PiotrZSL planned changes to this revision.Sun, Mar 5, 1:20 PM

Documentation to be updated, option need to be changed to list

PiotrZSL updated this revision to Diff 502752.Mon, Mar 6, 12:14 PM

Ping, Rebase, Changed Option from Regexp to List, Improved documentation, Removed usage of deprecated API

Harbormaster completed remote builds in B217664: Diff 502752.Mon, Mar 6, 3:39 PM
PiotrZSL added a reviewer: LegalizeAdulthood.Tue, Mar 14, 12:32 PM

Revision Contents
Changeset List

PathSize
clang-tools-extra/
clang-tidy/
bugprone/
3 lines
1 line
36 lines
76 lines
docs/
6 lines
clang-tidy/
checks/
bugprone/
58 lines
1 line
test/
clang-tidy/
checkers/
bugprone/
32 lines
130 lines

Diff 502752

View Options

clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

Loading...
View Options

clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt

Loading...
View Options

clang-tools-extra/clang-tidy/bugprone/EnumToBoolConversionCheck.h

Loading...
View Options

clang-tools-extra/clang-tidy/bugprone/EnumToBoolConversionCheck.cpp

Loading...
View Options

clang-tools-extra/docs/ReleaseNotes.rst

Loading...
View Options

clang-tools-extra/docs/clang-tidy/checks/bugprone/enum-to-bool-conversion.rst

Loading...
View Options

clang-tools-extra/docs/clang-tidy/checks/list.rst

Loading...
View Options

clang-tools-extra/test/clang-tidy/checkers/bugprone/enum-to-bool-conversion-cpp11.cpp

Loading...
View Options

clang-tools-extra/test/clang-tidy/checkers/bugprone/enum-to-bool-conversion.cpp

Loading...