This is an archive of the discontinued LLVM Phabricator instance.

[openmp] Fix building with MSVC for ARM64
AbandonedPublic

Authored by mstorsjo on Feb 14 2023, 1:55 AM.

Details

Summary

This fixes a typo from 7a795c42ad7f003cd454bf8dbab714714425664c
(https://reviews.llvm.org/D139139). Apparently some codepaths in
that commit weren't actually ever test compiled, since they
can't have worked due to misbalanced parentheses.

Building with Clang (both mingw mode and clang-cl) didn't use
these codepaths, so building in that mode did work.

Diff Detail

Event Timeline

mstorsjo created this revision.Feb 14 2023, 1:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2023, 1:55 AM
mstorsjo requested review of this revision.Feb 14 2023, 1:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2023, 1:55 AM
Herald added a subscriber: sstefan1. · View Herald Transcript
This revision is now accepted and ready to land.Feb 14 2023, 5:51 AM
mstorsjo abandoned this revision.Feb 14 2023, 1:20 PM

Actually, apparently this was already fixed yesterday, in D143940.