Page MenuHomePhabricator

natgla (Natalia Glagoleva)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 7 2021, 12:26 PM (95 w, 20 h)

Recent Activity

Nov 28 2022

natgla added inline comments to D137748: [openmp] [test] Fix data structure mismatches for tests that define kmp_depend_info.
Nov 28 2022, 1:05 PM · Restricted Project, Restricted Project
natgla added inline comments to D137748: [openmp] [test] Fix data structure mismatches for tests that define kmp_depend_info.
Nov 28 2022, 9:53 AM · Restricted Project, Restricted Project
natgla accepted D138738: [openmp] [test] XFAIL many-microtask-args.c on ARM.
Nov 28 2022, 9:44 AM · Restricted Project, Restricted Project
natgla accepted D138818: [openmp] [test] Use stdint.h instead of manual code defining kmp_int*. NFC..
Nov 28 2022, 9:40 AM · Restricted Project, Restricted Project
natgla added inline comments to D137748: [openmp] [test] Fix data structure mismatches for tests that define kmp_depend_info.
Nov 28 2022, 9:30 AM · Restricted Project, Restricted Project
natgla added inline comments to D138738: [openmp] [test] XFAIL many-microtask-args.c on ARM.
Nov 28 2022, 9:17 AM · Restricted Project, Restricted Project
natgla added inline comments to D138738: [openmp] [test] XFAIL many-microtask-args.c on ARM.
Nov 28 2022, 9:12 AM · Restricted Project, Restricted Project

Nov 15 2022

natgla added a comment to D137828: RFC: [openmp] Don't assume a specific layout for alloca() in Windows arm64 __kmp_invoke_microtask.

@mstorsjo, sorry, didn't ask you earlier: what is your environment? Our combination: everything is on Windows; we are using MSVC compiler to compile OpenMP code (for x64, x86, or arm64), and using libomp140 for runtime. LLVM libomp runtime is compiled by MSVC (for x64, x86, arm64) with additional definition 'OPENMP_MSVC_NAME_SCHEME' for cmake. We also have LLVM_ENABLE_PDB=ON for cmake for release, AFAIK it's different from usual.

Nov 15 2022, 10:12 AM · Restricted Project, Restricted Project
natgla added inline comments to D137828: RFC: [openmp] Don't assume a specific layout for alloca() in Windows arm64 __kmp_invoke_microtask.
Nov 15 2022, 9:51 AM · Restricted Project, Restricted Project

Nov 11 2022

natgla added inline comments to D137828: RFC: [openmp] Don't assume a specific layout for alloca() in Windows arm64 __kmp_invoke_microtask.
Nov 11 2022, 9:11 AM · Restricted Project, Restricted Project

Nov 10 2022

natgla accepted D137776: [openmp] [test] Set the right calling convention for the Windows thread start function.
Nov 10 2022, 10:07 PM · Restricted Project, Restricted Project
natgla accepted D137746: [openmp] [test] Use omp_testsuite.h instead of directly including pthread.h.
Nov 10 2022, 10:00 PM · Restricted Project, Restricted Project
natgla accepted D137745: [openmp] [test] Fix building the affinity/format/fields_values.c testcase on Windows.
Nov 10 2022, 9:51 PM · Restricted Project, Restricted Project
natgla accepted D137743: [openmp] Fix building in debug mode with mingw.
Nov 10 2022, 9:50 PM · Restricted Project, Restricted Project

Nov 7 2022

natgla added a comment to D137168: [OpenMP][mingw] Fix build for aarch64 target.

I've finally managed to somehow cobble things together so I can run the lit tests for this configuration: it mostly seems to work, but there are a couple failures that I probably should look into (although I don't know if they're related to what's being changed here or whether it's a later issue.

Anyway, with x86_64 clang-cl/msvc mode, there's 4 legitimate test failures among the tests; with x86_64 mingw there's those 4 plus yet another one failing. With aarch64 mingw there's 9 more failing tests (but still 180 tests passing).

We never tested this configuration. I'd suggest to look at the additional failures, and if they are related to atomics, to investigate them (otherwise consider them to be a different issue). If you can share all logs, I'd be curious to look at the results too (it won't save you any time though)

Nov 7 2022, 7:16 AM · Restricted Project, Restricted Project

Nov 2 2022

natgla accepted D137168: [OpenMP][mingw] Fix build for aarch64 target.
Nov 2 2022, 2:53 PM · Restricted Project, Restricted Project
natgla added a comment to D137168: [OpenMP][mingw] Fix build for aarch64 target.

FWIW I tested this patch for a mingw/aarch64 environment, and at least a very small testcase does seem to run as expected.

Nov 2 2022, 2:51 PM · Restricted Project, Restricted Project

Nov 1 2022

natgla added inline comments to D137168: [OpenMP][mingw] Fix build for aarch64 target.
Nov 1 2022, 2:28 PM · Restricted Project, Restricted Project
natgla added inline comments to D137168: [OpenMP][mingw] Fix build for aarch64 target.
Nov 1 2022, 2:18 PM · Restricted Project, Restricted Project
natgla added inline comments to D137168: [OpenMP][mingw] Fix build for aarch64 target.
Nov 1 2022, 1:59 PM · Restricted Project, Restricted Project
natgla added inline comments to D137168: [OpenMP][mingw] Fix build for aarch64 target.
Nov 1 2022, 1:36 PM · Restricted Project, Restricted Project

Apr 28 2021

natgla added a comment to D101173: [OpenMP] Changes to enable MSVC ARM64 build of libomp.

@jdoerfert : yes, it's a great idea, I can join next Wednesday. From the agenda I didn't know you'd like to discuss this today. Hopefully Chris will be able to come too, but I'll let him tell for himself

Apr 28 2021, 3:33 PM · Restricted Project