This is an archive of the discontinued LLVM Phabricator instance.

Differential D143357

[RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia
ClosedPublic

Authored by mcgrathr on Feb 5 2023, 3:21 PM.

Details

Reviewers
phosek
paulkirth
leonardchan
Commits
rGf08d86fc7f44: [RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia
Summary

The ShadowCallStack is the preferred and default ABI for Fuchsia.

Diff Detail

Event Timeline

mcgrathr created this revision.Feb 5 2023, 3:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2023, 3:21 PM
Herald added subscribers: VincentWu, abrachet, vkmr and 12 others. · View Herald Transcript
mcgrathr requested review of this revision.Feb 5 2023, 3:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2023, 3:21 PM
Herald added subscribers: cfe-commits, • pcwang-thead, eopXD, MaskRay. · View Herald Transcript
mcgrathr added a parent revision: D143355: [RISCV] Default to -ffixed-x18 for Fuchsia.Feb 5 2023, 3:23 PM
phosek accepted this revision.Feb 5 2023, 4:03 PM

LGTM

clang/lib/Driver/ToolChains/Fuchsia.cpp
475–476

Can you remove this TODO?

This revision is now accepted and ready to land.Feb 5 2023, 4:03 PM
Harbormaster completed remote builds in B211968: Diff 494959.Feb 5 2023, 4:13 PM
mcgrathr updated this revision to Diff 494973.Feb 5 2023, 6:40 PM
mcgrathr marked an inline comment as done.

remove TODO

This revision was landed with ongoing or failed builds.Feb 5 2023, 6:59 PM
Closed by commit rGf08d86fc7f44: [RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia (authored by mcgrathr). · Explain Why
This revision was automatically updated to reflect the committed changes.
mcgrathr added a commit: rGf08d86fc7f44: [RISCV] Default to -fsanitize=shadow-call-stack for Fuchsia.
Harbormaster completed remote builds in B211981: Diff 494973.Feb 5 2023, 7:14 PM

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
2 lines
test/
Driver/
1 line

Diff 494979

clang/lib/Driver/ToolChains/Fuchsia.cpp

Show First 20 Lines • Show All 460 Lines • ▼ Show 20 LinesSanitizerMask Fuchsia::getSupportedSanitizers() const {
Res |= SanitizerKind::Thread; Res |= SanitizerKind::Thread;
return Res; return Res;
} }
SanitizerMask Fuchsia::getDefaultSanitizers() const { SanitizerMask Fuchsia::getDefaultSanitizers() const {
SanitizerMask Res; SanitizerMask Res;
switch (getTriple().getArch()) { switch (getTriple().getArch()) {
case llvm::Triple::aarch64: case llvm::Triple::aarch64:
case llvm::Triple::riscv64:
Res |= SanitizerKind::ShadowCallStack; Res |= SanitizerKind::ShadowCallStack;
break; break;
case llvm::Triple::x86_64: case llvm::Triple::x86_64:
Res |= SanitizerKind::SafeStack; Res |= SanitizerKind::SafeStack;
break; break;
default: default:
// TODO: Enable SafeStack on RISC-V once tested.
break; break;
phosekUnsubmitted
Done
ReplyInline Actions
default:
- // TODO: Enable SafeStack on RISC-V once tested.
break;

Can you remove this TODO?

phosek: Can you remove this `TODO`?
} }
return Res; return Res;
} }

clang/test/Driver/fuchsia.c

Show All 25 Lines
// CHECK-X86_64: "-triple" "x86_64-unknown-fuchsia" // CHECK-X86_64: "-triple" "x86_64-unknown-fuchsia"
// CHECK-AARCH64: "-triple" "aarch64-unknown-fuchsia" // CHECK-AARCH64: "-triple" "aarch64-unknown-fuchsia"
// CHECK-RISCV64: "-triple" "riscv64-unknown-fuchsia" // CHECK-RISCV64: "-triple" "riscv64-unknown-fuchsia"
// CHECK: "-funwind-tables=2" // CHECK: "-funwind-tables=2"
// CHECK: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]" // CHECK: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]"
// CHECK: "-isysroot" "[[SYSROOT:[^"]+]]" // CHECK: "-isysroot" "[[SYSROOT:[^"]+]]"
// CHECK: "-internal-externc-isystem" "[[SYSROOT]]{{/|\\\\}}include" // CHECK: "-internal-externc-isystem" "[[SYSROOT]]{{/|\\\\}}include"
// CHECK-AARCH64: "-fsanitize=shadow-call-stack" // CHECK-AARCH64: "-fsanitize=shadow-call-stack"
// CHECK-RISCV64: "-fsanitize=shadow-call-stack"
// CHECK-X86_64: "-fsanitize=safe-stack" // CHECK-X86_64: "-fsanitize=safe-stack"
// CHECK: "-stack-protector" "2" // CHECK: "-stack-protector" "2"
// CHECK-AARCH64: "-target-feature" "+outline-atomics" // CHECK-AARCH64: "-target-feature" "+outline-atomics"
// CHECK-NOT: "-fcommon" // CHECK-NOT: "-fcommon"
// CHECK: {{.*}}ld.lld{{.*}}" "-z" "max-page-size=4096" "-z" "now" "-z" "rodynamic" "-z" "separate-loadable-segments" "-z" "rel" "--pack-dyn-relocs=relr" // CHECK: {{.*}}ld.lld{{.*}}" "-z" "max-page-size=4096" "-z" "now" "-z" "rodynamic" "-z" "separate-loadable-segments" "-z" "rel" "--pack-dyn-relocs=relr"
// CHECK: "--sysroot=[[SYSROOT]]" // CHECK: "--sysroot=[[SYSROOT]]"
// CHECK: "-pie" // CHECK: "-pie"
// CHECK: "--build-id" // CHECK: "--build-id"
▲ Show 20 Lines • Show All 252 Lines • Show Last 20 Lines