[AMDGPU] Use tablegen to list uniform intrinsics
ClosedPublic
Actions

Authored by yassingh on Jan 31 2023, 1:28 AM.

Details

Reviewers

arsenm
sameerds

Group Reviewers

Restricted Project

Commits

rG422d379de287: [AMDGPU] Use tablegen to list uniform intrinsics

Summary

Right now we do opcode wise matching to identify uniform/non-divergent
AMDGPU intrinsics. It is duplicated at 2 places once at IR level uniformity analysis
and at MIR level. Moving them to single tablegen table for consistency and adding
and API rapper to access them.

Diff Detail

Unit TestsFailed
View All

	Time	Test
	50 ms	x64 debian > MLIR.Dialect/Bufferization/Transforms::one-shot-module-bufferize-force-copy-before-write.mlir Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/mlir-opt /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/Bufferization/Transforms/one-shot-module-bufferize-force-copy-before-write.mlir -one-shot-bufferize="bufferize-function-boundaries=1 no-analysis-func-filter=contains_to_memref_op" -drop-equivalent-buffer-results --split-input-file \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Dialect/Bufferization/Transforms/one-shot-module-bufferize-force-copy-before-write.mlir

Event Timeline

yassingh created this revision.Jan 31 2023, 1:28 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 1:28 AM

Herald added subscribers: kosarev, foad, kerbowa and 2 others. · View Herald Transcript

yassingh requested review of this revision.Jan 31 2023, 1:28 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 1:28 AM

Herald added subscribers: llvm-commits, wdng. · View Herald Transcript

Harbormaster completed remote builds in B210931: Diff 493517.Jan 31 2023, 2:07 AM

yassingh retitled this revision from Make always uniform intrinsics table driven to [AMDGPU] Use tablegen to list uniform intrinsics .Jan 31 2023, 2:07 AM

yassingh edited the summary of this revision. (Show Details)

Herald added subscribers: tpr, dstuttard, yaxunl, kzhuravl. · View Herald TranscriptJan 31 2023, 2:07 AM

arsenm accepted this revision.Jan 31 2023, 3:03 AM

This revision is now accepted and ready to land.Jan 31 2023, 3:03 AM

This revision was landed with ongoing or failed builds.Jan 31 2023, 4:15 AM

Closed by commit rG422d379de287: [AMDGPU] Use tablegen to list uniform intrinsics (authored by yassingh). · Explain Why

This revision was automatically updated to reflect the committed changes.

yassingh added a commit: rG422d379de287: [AMDGPU] Use tablegen to list uniform intrinsics.