[libc++] Enforce formatting for already formatted and new files and ignore the formatting of tests

[philnik]

Summary

It is quite confusing to newcomers that the formatting check gets mostly ignored. To fix that, enforce the formatting for new file and already formatted files, but ignore it for any files that aren't formatted already. We ignore the tests for now, since almost no test is formatted currently, and they are changed almost never.

[Mordante]

From a personal perspective I'm very unhappy with this patch, I really would like to use clang-format in most (all) of our code. From I libc++ developer perspective I agree we need to do this. I think more people need to have a look at it, therefore I will leave the final approval to others.

libcxx/utils/generate_ignore_format.sh

3

This file needs a shebang and I would like comment what it does.

[huixie90]

In D142180#4069287, @Mordante wrote:

From a personal perspective I'm very unhappy with this patch, I really would like to use clang-format in most (all) of our code. From I libc++ developer perspective I agree we need to do this. I think more people need to have a look at it, therefore I will leave the final approval to others.

I think we all agree that we want clang-format for all of our code. The problem now is that it is not the case at the moment. And the format CI is always failing and everyone ignores it. I think this patch at least is a step forward to enforce the formatting. However, this is still very challenging as people have different versions of clang-format. I wonder if we could

[ldionne]

Let's do this. We've been living in this transitional state for long enough.

libcxx/utils/ci/run-buildbot

193

It would be nice if check-generated-output failed when we format a file but we forget to update ignore_format.txt. This can be done by reusing the libcxx/utils/generate_ignore_format.sh script you already have.

[philnik]

Address comments

[ldionne]

LGTM, but let's also update the documentation at https://libcxx.llvm.org/Contributing.html to mention that new files need to be run through clang-format.

libcxx/utils/ci/run-buildbot

218

[ldionne]

We are waiting for the Docker image to be updated to clang-format 16 before we ship this.

[Mordante]

In D142180#4099958, @ldionne wrote:

We are waiting for the Docker image to be updated to clang-format 16 before we ship this.

There is already a review ;-) D143007

[philnik]

Rebased

[philnik]

Sort ignore list to avoid differences between systems

[philnik]

sort doesn't sort consistently between distros, so I guess we have to just apply the patch from the CI.

[philnik]

Try to fix CI

[Mordante]

In D142180#4125811, @philnik wrote:

sort doesn't sort consistently between distros, so I guess we have to just apply the patch from the CI.

I think that can be fixed by using a hard-coded locale. See D144126 (I actually noticed it while working on that patch.)

libcxx/utils/ci/buildkite-pipeline.yml

env:
         GIT_CLANG_FORMAT: "/usr/bin/git-clang-format-${LLVM_STABLE_VERSION}"
     agents:
       queue: "libcxx-builders"
       os: "linux"
     retry:
       automatic:
         - exit_status: -1  # Agent was lost
           limit: 2
-    soft_fail:
-        - exit_status: 1
     timeout_in_minutes: 120
 
   - label: "Generated output"
     command: "libcxx/utils/ci/run-buildbot check-generated-output"
     artifact_paths:
       - "**/generated_output.patch"
       - "**/generated_output.status"
     agents:

libcxx/utils/ci/run-buildbot

check-format)
     # We need to set --extensions so that clang-format checks extensionless files.
     mkdir -p ${BUILD_DIR}
     if [ -z "${GIT_CLANG_FORMAT}" ]; then
        GIT_CLANG_FORMAT=git-clang-format
     fi
     ${GIT_CLANG_FORMAT} \
         --diff \
         --extensions ',h,hh,hpp,hxx,c,cc,cxx,cpp' HEAD~1 \
-        -- \
-            libcxx/{benchmarks,include,src,test} \
-            libcxxabi/{fuzz,include,src,test} \
+        -- $(find libcxx/{benchmarks,include,src}/ -type f | grep -vf libcxx/utils/data/ignore_format.txt) \
         | tee ${BUILD_DIR}/clang-format.patch
     # Check if the diff is empty, fail otherwise.
     ! grep -q '^--- a' ${BUILD_DIR}/clang-format.patch
 ;;
 check-generated-output)
     # `! foo` doesn't work properly with `set -e`, use `! foo || false` instead.
     # https://stackoverflow.com/questions/57681955/set-e-does-not-respect-logical-not
     clean
     generate-cmake
 
     # Reject patches that forgot to re-run the generator scripts.
     echo "+++ Making sure the generator scripts were run"
     ${NINJA} -vC "${BUILD_DIR}" libcxx-generate-files
     git diff | tee ${BUILD_DIR}/generated_output.patch
     git ls-files -o --exclude-standard | tee ${BUILD_DIR}/generated_output.status
     ! grep -q '^--- a' ${BUILD_DIR}/generated_output.patch || false
     if [ -s ${BUILD_DIR}/generated_output.status ]; then
         echo "It looks like not all the generator scripts were run,"
         echo "did you forget to build the libcxx-generate-files target?"
         echo "Did you add all new files it generated?"
         false
     fi
 
+    ${MONOREPO_ROOT}/libcxx/utils/generate_ignore_format.sh
+    git diff | tee ${BUILD_DIR}/generated_output.patch
+    git ls-files -o --exclude-standard | tee ${BUILD_DIR}/generated_output.status
+    ! grep -q '^--- a' ${BUILD_DIR}/generated_output.patch || false
+    if [ -s ${BUILD_DIR}/generated_output.status ]; then
+        echo "It looks like the list of not formatted files has changed."
+        echo "If a file is now formatted, remove the file name from "
+        echo "libcxx/utils/data/ignore_format.txt. Otherwise you have to fix the"
+        echo "formatting of some of the changed files."
+        false
+    fi
+
     # Reject patches that introduce non-ASCII characters or hard tabs.
     # Depends on LC_COLLATE set at the top of this script.
     ! grep -rn '[^ -~]' libcxx/include libcxx/src libcxx/test libcxx/benchmarks \
            --exclude '*.dat' \
            --exclude 'escaped_output.*.pass.cpp' \
            --exclude 'format_tests.h' \
            --exclude 'format.functions.tests.h' \
            --exclude 'formatter.*.pass.cpp' \

libcxx/utils/data/ignore_format.txt

+libcxx/benchmarks/formatter_float.bench.cpp
+libcxx/benchmarks/function.bench.cpp
+libcxx/benchmarks/format_to.bench.cpp
+libcxx/benchmarks/filesystem.bench.cpp
+libcxx/benchmarks/string.bench.cpp
+libcxx/benchmarks/unordered_set_operations.bench.cpp
+libcxx/benchmarks/vector_operations.bench.cpp
+libcxx/benchmarks/GenerateInput.h
+libcxx/benchmarks/ordered_set.bench.cpp
+libcxx/benchmarks/deque.bench.cpp
+libcxx/benchmarks/random.bench.cpp
+libcxx/benchmarks/map.bench.cpp
+libcxx/benchmarks/VariantBenchmarks.h
+libcxx/benchmarks/lit.cfg.py
+libcxx/benchmarks/format_to_n.bench.cpp
+libcxx/benchmarks/ContainerBenchmarks.h
+libcxx/benchmarks/lit.site.cfg.py.in
+libcxx/benchmarks/stringstream.bench.cpp
+libcxx/benchmarks/CMakeLists.txt
+libcxx/benchmarks/formatter_int.bench.cpp
+libcxx/benchmarks/allocation.bench.cpp
+libcxx/benchmarks/CartesianBenchmarks.h
+libcxx/benchmarks/Utilities.h
+libcxx/benchmarks/algorithms/ranges_make_heap_then_sort_heap.bench.cpp
+libcxx/benchmarks/algorithms/ranges_pop_heap.bench.cpp
+libcxx/benchmarks/algorithms/lower_bound.bench.cpp
+libcxx/benchmarks/algorithms/ranges_stable_sort.bench.cpp
+libcxx/benchmarks/algorithms/sort.bench.cpp
+libcxx/benchmarks/algorithms/push_heap.bench.cpp
+libcxx/benchmarks/algorithms/ranges_sort_heap.bench.cpp
+libcxx/benchmarks/algorithms/make_heap.bench.cpp
+libcxx/benchmarks/algorithms/make_heap_then_sort_heap.bench.cpp
+libcxx/benchmarks/algorithms/ranges_make_heap.bench.cpp
+libcxx/benchmarks/algorithms/ranges_push_heap.bench.cpp
+libcxx/benchmarks/algorithms/pop_heap.bench.cpp
+libcxx/benchmarks/algorithms/common.h
+libcxx/benchmarks/algorithms/stable_sort.bench.cpp
+libcxx/benchmarks/algorithms/sort_heap.bench.cpp
+libcxx/benchmarks/algorithms/ranges_sort.bench.cpp
+libcxx/benchmarks/algorithms.partition_point.bench.cpp
+libcxx/include/__string/extern_template_lists.h
+libcxx/include/__string/char_traits.h
+libcxx/include/format
+libcxx/include/__config_site.in
+libcxx/include/float.h
+libcxx/include/__numeric/iota.h
+libcxx/include/__numeric/adjacent_difference.h
+libcxx/include/__numeric/transform_reduce.h
+libcxx/include/__numeric/accumulate.h
+libcxx/include/__numeric/transform_inclusive_scan.h
+libcxx/include/__numeric/midpoint.h
+libcxx/include/__numeric/inner_product.h
+libcxx/include/__numeric/transform_exclusive_scan.h
+libcxx/include/__numeric/reduce.h
+libcxx/include/__numeric/inclusive_scan.h
+libcxx/include/__numeric/exclusive_scan.h
+libcxx/include/__numeric/gcd_lcm.h
+libcxx/include/__numeric/partial_sum.h
+libcxx/include/__coroutine/trivial_awaitables.h
+libcxx/include/__coroutine/noop_coroutine_handle.h
+libcxx/include/__coroutine/coroutine_traits.h
+libcxx/include/__coroutine/coroutine_handle.h
+libcxx/include/semaphore
+libcxx/include/future
+libcxx/include/optional
+libcxx/include/__bsd_locale_fallbacks.h
+libcxx/include/__random/negative_binomial_distribution.h
+libcxx/include/__random/exponential_distribution.h
+libcxx/include/__random/log2.h
+libcxx/include/__random/is_seed_sequence.h
+libcxx/include/__random/binomial_distribution.h
+libcxx/include/__random/weibull_distribution.h
+libcxx/include/__random/linear_congruential_engine.h
+libcxx/include/__random/discrete_distribution.h
+libcxx/include/__random/ranlux.h
+libcxx/include/__random/piecewise_constant_distribution.h
+libcxx/include/__random/piecewise_linear_distribution.h
+libcxx/include/__random/extreme_value_distribution.h
+libcxx/include/__random/uniform_real_distribution.h
+libcxx/include/__random/geometric_distribution.h
+libcxx/include/__random/mersenne_twister_engine.h
+libcxx/include/__random/random_device.h
+libcxx/include/__random/uniform_random_bit_generator.h
+libcxx/include/__random/clamp_to_integral.h
+libcxx/include/__random/normal_distribution.h
+libcxx/include/__random/seed_seq.h
+libcxx/include/__random/gamma_distribution.h
+libcxx/include/__random/generate_canonical.h
+libcxx/include/__random/poisson_distribution.h
+libcxx/include/__random/fisher_f_distribution.h
+libcxx/include/__random/chi_squared_distribution.h
+libcxx/include/__random/student_t_distribution.h
+libcxx/include/__random/subtract_with_carry_engine.h
+libcxx/include/__random/bernoulli_distribution.h
+libcxx/include/__random/uniform_int_distribution.h
+libcxx/include/__random/independent_bits_engine.h
+libcxx/include/__random/shuffle_order_engine.h
+libcxx/include/__random/discard_block_engine.h
+libcxx/include/__random/cauchy_distribution.h
+libcxx/include/__random/is_valid.h
+libcxx/include/__random/lognormal_distribution.h
+libcxx/include/__type_traits/is_base_of.h
+libcxx/include/__type_traits/is_nothrow_move_constructible.h
+libcxx/include/__type_traits/remove_const.h
+libcxx/include/__type_traits/is_copy_assignable.h
+libcxx/include/__type_traits/add_volatile.h
+libcxx/include/__type_traits/is_empty.h
+libcxx/include/__type_traits/is_const.h
+libcxx/include/__type_traits/is_bounded_array.h
+libcxx/include/__type_traits/is_polymorphic.h
+libcxx/include/__type_traits/is_unbounded_array.h
+libcxx/include/__type_traits/is_final.h
+libcxx/include/__type_traits/is_reference_wrapper.h
+libcxx/include/__type_traits/is_swappable.h
+libcxx/include/__type_traits/is_trivially_default_constructible.h
+libcxx/include/__type_traits/has_virtual_destructor.h
+libcxx/include/__type_traits/is_default_constructible.h
+libcxx/include/__type_traits/is_pod.h
+libcxx/include/__type_traits/is_destructible.h
+libcxx/include/__type_traits/type_identity.h
+libcxx/include/__type_traits/remove_reference.h
+libcxx/include/__type_traits/can_extract_key.h
+libcxx/include/__type_traits/aligned_storage.h
+libcxx/include/__type_traits/nat.h
+libcxx/include/__type_traits/is_copy_constructible.h
+libcxx/include/__type_traits/is_trivially_copyable.h
+libcxx/include/__type_traits/is_move_assignable.h
+libcxx/include/__type_traits/is_unsigned_integer.h
+libcxx/include/__type_traits/common_reference.h
+libcxx/include/__type_traits/is_nothrow_constructible.h
+libcxx/include/__type_traits/aligned_union.h
+libcxx/include/__type_traits/remove_pointer.h
+libcxx/include/__type_traits/is_floating_point.h
+libcxx/include/__type_traits/add_lvalue_reference.h
+libcxx/include/__type_traits/is_nothrow_default_constructible.h
+libcxx/include/__type_traits/is_standard_layout.h
+libcxx/include/__type_traits/is_unsigned.h
+libcxx/include/__type_traits/make_const_lvalue_ref.h
+libcxx/include/__type_traits/is_trivially_constructible.h
+libcxx/include/__type_traits/is_signed_integer.h
+libcxx/include/__type_traits/remove_all_extents.h
+libcxx/include/__type_traits/result_of.h
+libcxx/include/__type_traits/is_constructible.h
+libcxx/include/__type_traits/is_nothrow_convertible.h
+libcxx/include/__type_traits/is_trivial.h
+libcxx/include/__type_traits/lazy.h
+libcxx/include/__type_traits/is_integral.h
+libcxx/include/__type_traits/is_member_pointer.h
+libcxx/include/__type_traits/decay.h
+libcxx/include/__type_traits/is_always_bitcastable.h
+libcxx/include/__type_traits/add_cv.h
+libcxx/include/__type_traits/is_arithmetic.h
+libcxx/include/__type_traits/make_32_64_or_128_bit.h
+libcxx/include/__type_traits/is_constant_evaluated.h
+libcxx/include/__type_traits/rank.h
+libcxx/include/__type_traits/type_list.h
+libcxx/include/__type_traits/is_member_function_pointer.h
+libcxx/include/__type_traits/is_nothrow_copy_constructible.h
+libcxx/include/__type_traits/is_aggregate.h
+libcxx/include/__type_traits/is_union.h
+libcxx/include/__type_traits/is_allocator.h
+libcxx/include/__type_traits/is_convertible.h
+libcxx/include/__type_traits/alignment_of.h
+libcxx/include/__type_traits/promote.h
+libcxx/include/__type_traits/is_pointer.h
+libcxx/include/__type_traits/is_null_pointer.h
+libcxx/include/__type_traits/is_class.h
+libcxx/include/__type_traits/is_move_constructible.h
+libcxx/include/__type_traits/remove_cvref.h
+libcxx/include/__type_traits/is_object.h
+libcxx/include/__type_traits/is_void.h
+libcxx/include/__type_traits/is_volatile.h
+libcxx/include/__type_traits/is_nothrow_destructible.h
+libcxx/include/__type_traits/apply_cv.h
+libcxx/include/__type_traits/is_abstract.h
+libcxx/include/__type_traits/remove_volatile.h
+libcxx/include/__type_traits/is_primary_template.h
+libcxx/include/__type_traits/is_fundamental.h
+libcxx/include/__type_traits/is_reference.h
+libcxx/include/__type_traits/remove_extent.h
+libcxx/include/__type_traits/common_type.h
+libcxx/include/__type_traits/underlying_type.h
+libcxx/include/__type_traits/remove_cv.h
+libcxx/include/__type_traits/enable_if.h
+libcxx/include/__type_traits/is_valid_expansion.h
+libcxx/include/__type_traits/copy_cv.h
+libcxx/include/__type_traits/strip_signature.h
+libcxx/include/__type_traits/is_enum.h
+libcxx/include/__type_traits/make_signed.h
+libcxx/include/__type_traits/is_trivially_destructible.h
+libcxx/include/__type_traits/is_nothrow_assignable.h
+libcxx/include/__type_traits/extent.h
+libcxx/include/__type_traits/is_compound.h
+libcxx/include/__type_traits/is_assignable.h
+libcxx/include/__type_traits/integral_constant.h
+libcxx/include/__type_traits/is_array.h
+libcxx/include/__type_traits/noexcept_move_assign_container.h
+libcxx/include/__type_traits/is_nothrow_move_assignable.h
+libcxx/include/__type_traits/is_core_convertible.h
+libcxx/include/__type_traits/is_member_object_pointer.h
+libcxx/include/__type_traits/is_nothrow_copy_assignable.h
+libcxx/include/__type_traits/make_unsigned.h
+libcxx/include/__type_traits/copy_cvref.h
+libcxx/include/__type_traits/is_implicitly_default_constructible.h
+libcxx/include/__type_traits/is_scoped_enum.h
+libcxx/include/__type_traits/void_t.h
+libcxx/include/__type_traits/negation.h
+libcxx/include/__type_traits/is_trivially_copy_constructible.h
+libcxx/include/__type_traits/is_trivially_copy_assignable.h
+libcxx/include/__type_traits/is_callable.h
+libcxx/include/__type_traits/maybe_const.h
+libcxx/include/__type_traits/is_signed.h
+libcxx/include/__type_traits/is_trivially_assignable.h
+libcxx/include/__type_traits/add_const.h
+libcxx/include/__type_traits/is_same.h
+libcxx/include/__type_traits/is_scalar.h
+libcxx/include/__type_traits/is_literal_type.h
+libcxx/include/__type_traits/add_pointer.h
+libcxx/include/__type_traits/has_unique_object_representation.h
+libcxx/include/vector
+libcxx/include/stack
+libcxx/include/limits
+libcxx/include/set
+libcxx/include/tuple
+libcxx/include/codecvt
+libcxx/include/array
+libcxx/include/stdatomic.h
+libcxx/include/__std_stream
+libcxx/include/string
+libcxx/include/scoped_allocator
+libcxx/include/streambuf
+libcxx/include/bitset
+libcxx/include/__config
+libcxx/include/ratio
+libcxx/include/execution
+libcxx/include/experimental/utility
+libcxx/include/experimental/set
+libcxx/include/experimental/string
+libcxx/include/experimental/__config
+libcxx/include/experimental/memory_resource
+libcxx/include/experimental/simd
+libcxx/include/experimental/unordered_set
+libcxx/include/experimental/regex
+libcxx/include/experimental/algorithm
+libcxx/include/experimental/map
+libcxx/include/experimental/type_traits
+libcxx/include/experimental/iterator
+libcxx/include/experimental/unordered_map
+libcxx/include/experimental/propagate_const
+libcxx/include/experimental/functional
+libcxx/include/experimental/__memory
+libcxx/include/string.h
+libcxx/include/__availability
+libcxx/include/__ios/fpos.h
+libcxx/include/__bit/countr.h
+libcxx/include/__bit/endian.h
+libcxx/include/__bit/bit_cast.h
+libcxx/include/__bit/byteswap.h
+libcxx/include/__bit/rotate.h
+libcxx/include/__bit/countl.h
+libcxx/include/__bit/popcount.h
+libcxx/include/__bit/bit_ceil.h
+libcxx/include/cstddef
+libcxx/include/cuchar
+libcxx/include/sstream
+libcxx/include/__threading_support
+libcxx/include/__bsd_locale_defaults.h
+libcxx/include/__concepts/copyable.h
+libcxx/include/__concepts/boolean_testable.h
+libcxx/include/__concepts/convertible_to.h
+libcxx/include/__concepts/semiregular.h
+libcxx/include/__concepts/different_from.h
+libcxx/include/__concepts/destructible.h
+libcxx/include/__concepts/totally_ordered.h
+libcxx/include/__concepts/relation.h
+libcxx/include/__concepts/same_as.h
+libcxx/include/__concepts/regular.h
+libcxx/include/__concepts/class_or_enum.h
+libcxx/include/__concepts/equality_comparable.h
+libcxx/include/__concepts/arithmetic.h
+libcxx/include/__concepts/assignable.h
+libcxx/include/__concepts/derived_from.h
+libcxx/include/__concepts/movable.h
+libcxx/include/__concepts/swappable.h
+libcxx/include/__concepts/common_with.h
+libcxx/include/__concepts/predicate.h
+libcxx/include/__concepts/constructible.h
+libcxx/include/__concepts/common_reference_with.h
+libcxx/include/__concepts/invocable.h
+libcxx/include/__utility/cmp.h
+libcxx/include/__utility/priority_tag.h
+libcxx/include/__utility/piecewise_construct.h
+libcxx/include/__utility/rel_ops.h
+libcxx/include/__utility/exchange.h
+libcxx/include/__utility/integer_sequence.h
+libcxx/include/__utility/convert_to_integral.h
+libcxx/include/__utility/pair.h
+libcxx/include/__utility/to_underlying.h
+libcxx/include/__utility/as_const.h
+libcxx/include/__utility/unreachable.h
+libcxx/include/__utility/in_place.h
+libcxx/include/filesystem
+libcxx/include/math.h
+libcxx/include/iosfwd
+libcxx/include/numbers
+libcxx/include/fenv.h
+libcxx/include/unordered_set
+libcxx/include/__debug_utils/randomize_range.h
+libcxx/include/locale
+libcxx/include/initializer_list
+libcxx/include/uchar.h
+libcxx/include/__split_buffer
+libcxx/include/__verbose_abort
+libcxx/include/strstream
+libcxx/include/stdint.h
+libcxx/include/errno.h
+libcxx/include/charconv
+libcxx/include/__compare/compare_strong_order_fallback.h
+libcxx/include/__compare/three_way_comparable.h
+libcxx/include/__compare/weak_order.h
+libcxx/include/__compare/compare_partial_order_fallback.h
+libcxx/include/__compare/compare_three_way.h
+libcxx/include/__compare/compare_weak_order_fallback.h
+libcxx/include/__compare/strong_order.h
+libcxx/include/__compare/common_comparison_category.h
+libcxx/include/__compare/compare_three_way_result.h
+libcxx/include/__compare/partial_order.h
+libcxx/include/__compare/ordering.h
+libcxx/include/__compare/synth_three_way.h
+libcxx/include/ranges
+libcxx/include/chrono
+libcxx/include/regex
+libcxx/include/shared_mutex
+libcxx/include/ctype.h
+libcxx/include/cctype
+libcxx/include/typeinfo
+libcxx/include/iomanip
+libcxx/include/ext/__hash
+libcxx/include/ext/hash_map
+libcxx/include/ext/hash_set
+libcxx/include/expected
+libcxx/include/wchar.h
+libcxx/include/__errc
+libcxx/include/complex
+libcxx/include/__functional/bind.h
+libcxx/include/__functional/ranges_operations.h
+libcxx/include/__functional/binder1st.h
+libcxx/include/__functional/unary_function.h
+libcxx/include/__functional/compose.h
+libcxx/include/__functional/is_transparent.h
+libcxx/include/__functional/bind_back.h
+libcxx/include/__functional/operations.h
+libcxx/include/__functional/boyer_moore_searcher.h
+libcxx/include/__functional/default_searcher.h
+libcxx/include/__functional/not_fn.h
+libcxx/include/__functional/binder2nd.h
+libcxx/include/__functional/pointer_to_unary_function.h
+libcxx/include/__functional/reference_wrapper.h
+libcxx/include/__functional/binary_function.h
+libcxx/include/__functional/function.h
+libcxx/include/__functional/bind_front.h
+libcxx/include/__functional/weak_result_type.h
+libcxx/include/__functional/invoke.h
+libcxx/include/__functional/mem_fun_ref.h
+libcxx/include/__functional/identity.h
+libcxx/include/__functional/hash.h
+libcxx/include/__functional/unary_negate.h
+libcxx/include/__functional/mem_fn.h
+libcxx/include/__functional/pointer_to_binary_function.h
+libcxx/include/__functional/unwrap_ref.h
+libcxx/include/__functional/perfect_forward.h
+libcxx/include/__functional/binary_negate.h
+libcxx/include/__variant/monostate.h
+libcxx/include/__assert
+libcxx/include/stdexcept
+libcxx/include/map
+libcxx/include/__support/newlib/xlocale.h
+libcxx/include/__support/win32/locale_win32.h
+libcxx/include/__support/solaris/xlocale.h
+libcxx/include/__support/xlocale/__nop_locale_mgmt.h
+libcxx/include/__support/ibm/gettod_zos.h
+libcxx/include/__support/ibm/nanosleep.h
+libcxx/include/__support/ibm/locale_mgmt_zos.h
+libcxx/include/__support/ibm/xlocale.h
+libcxx/include/__support/fuchsia/xlocale.h
+libcxx/include/__support/android/locale_bionic.h
+libcxx/include/latch
+libcxx/include/condition_variable
+libcxx/include/__bit_reference
+libcxx/include/__mutex_base
+libcxx/include/exception
+libcxx/include/span
+libcxx/include/__hash_table
+libcxx/include/__filesystem/directory_entry.h
+libcxx/include/__filesystem/operations.h
+libcxx/include/__filesystem/recursive_directory_iterator.h
+libcxx/include/__filesystem/u8path.h
+libcxx/include/__filesystem/file_type.h
+libcxx/include/__filesystem/perms.h
+libcxx/include/__filesystem/path_iterator.h
+libcxx/include/__filesystem/directory_options.h
+libcxx/include/__filesystem/directory_iterator.h
+libcxx/include/__filesystem/perm_options.h
+libcxx/include/__filesystem/file_status.h
+libcxx/include/__filesystem/filesystem_error.h
+libcxx/include/__filesystem/path.h
+libcxx/include/__filesystem/copy_options.h
+libcxx/include/typeindex
+libcxx/include/ostream
+libcxx/include/queue
+libcxx/include/module.modulemap.in
+libcxx/include/stdlib.h
+libcxx/include/setjmp.h
+libcxx/include/__algorithm/ranges_move_backward.h
+libcxx/include/__algorithm/ranges_min.h
+libcxx/include/__algorithm/ranges_set_union.h
+libcxx/include/__algorithm/for_each_n.h
+libcxx/include/__algorithm/ranges_set_intersection.h
+libcxx/include/__algorithm/next_permutation.h
+libcxx/include/__algorithm/ranges_set_difference.h
+libcxx/include/__algorithm/ranges_max.h
+libcxx/include/__algorithm/ranges_rotate.h
+libcxx/include/__algorithm/search.h
+libcxx/include/__algorithm/ranges_partition_point.h
+libcxx/include/__algorithm/ranges_rotate_copy.h
+libcxx/include/__algorithm/copy_move_common.h
+libcxx/include/__algorithm/remove.h
+libcxx/include/__algorithm/sample.h
+libcxx/include/__algorithm/shift_left.h
+libcxx/include/__algorithm/push_heap.h
+libcxx/include/__algorithm/ranges_all_of.h
+libcxx/include/__algorithm/is_heap_until.h
+libcxx/include/__algorithm/pop_heap.h
+libcxx/include/__algorithm/ranges_is_permutation.h
+libcxx/include/__algorithm/move_backward.h
+libcxx/include/__algorithm/ranges_mismatch.h
+libcxx/include/__algorithm/ranges_remove_copy.h
+libcxx/include/__algorithm/prev_permutation.h
+libcxx/include/__algorithm/ranges_inplace_merge.h
+libcxx/include/__algorithm/ranges_none_of.h
+libcxx/include/__algorithm/unwrap_range.h
+libcxx/include/__algorithm/equal_range.h
+libcxx/include/__algorithm/ranges_any_of.h
+libcxx/include/__algorithm/for_each.h
+libcxx/include/__algorithm/in_out_out_result.h
+libcxx/include/__algorithm/ranges_is_sorted.h
+libcxx/include/__algorithm/in_in_out_result.h
+libcxx/include/__algorithm/ranges_copy_n.h
+libcxx/include/__algorithm/max_element.h
+libcxx/include/__algorithm/sort_heap.h
+libcxx/include/__algorithm/ranges_minmax_element.h
+libcxx/include/__algorithm/partial_sort_copy.h
+libcxx/include/__algorithm/generate.h
+libcxx/include/__algorithm/ranges_partition_copy.h
+libcxx/include/__algorithm/unwrap_iter.h
+libcxx/include/__algorithm/rotate_copy.h
+libcxx/include/__algorithm/is_partitioned.h
+libcxx/include/__algorithm/ranges_copy_if.h
+libcxx/include/__algorithm/sort.h
+libcxx/include/__algorithm/ranges_fill_n.h
+libcxx/include/__algorithm/make_projected.h
+libcxx/include/__algorithm/ranges_sample.h
+libcxx/include/__algorithm/ranges_partial_sort.h
+libcxx/include/__algorithm/stable_sort.h
+libcxx/include/__algorithm/ranges_remove_copy_if.h
+libcxx/include/__algorithm/ranges_replace.h
+libcxx/include/__algorithm/ranges_lower_bound.h
+libcxx/include/__algorithm/lower_bound.h
+libcxx/include/__algorithm/ranges_set_symmetric_difference.h
+libcxx/include/__algorithm/ranges_generate.h
+libcxx/include/__algorithm/ranges_is_heap_until.h
+libcxx/include/__algorithm/ranges_nth_element.h
+libcxx/include/__algorithm/ranges_lexicographical_compare.h
+libcxx/include/__algorithm/ranges_adjacent_find.h
+libcxx/include/__algorithm/ranges_push_heap.h
+libcxx/include/__algorithm/mismatch.h
+libcxx/include/__algorithm/partition_point.h
+libcxx/include/__algorithm/remove_copy.h
+libcxx/include/__algorithm/ranges_fill.h
+libcxx/include/__algorithm/replace_if.h
+libcxx/include/__algorithm/ranges_partition.h
+libcxx/include/__algorithm/find_end.h
+libcxx/include/__algorithm/ranges_find_end.h
+libcxx/include/__algorithm/rotate.h
+libcxx/include/__algorithm/search_n.h
+libcxx/include/__algorithm/ranges_make_heap.h
+libcxx/include/__algorithm/ranges_includes.h
+libcxx/include/__algorithm/shift_right.h
+libcxx/include/__algorithm/ranges_unique_copy.h
+libcxx/include/__algorithm/ranges_find_if.h
+libcxx/include/__algorithm/ranges_stable_sort.h
+libcxx/include/__algorithm/in_found_result.h
+libcxx/include/__algorithm/comp_ref_type.h
+libcxx/include/__algorithm/ranges_for_each.h
+libcxx/include/__algorithm/reverse_copy.h
+libcxx/include/__algorithm/equal.h
+libcxx/include/__algorithm/copy.h
+libcxx/include/__algorithm/ranges_min_element.h
+libcxx/include/__algorithm/comp.h
+libcxx/include/__algorithm/is_heap.h
+libcxx/include/__algorithm/ranges_remove.h
+libcxx/include/__algorithm/inplace_merge.h
+libcxx/include/__algorithm/ranges_remove_if.h
+libcxx/include/__algorithm/is_permutation.h
+libcxx/include/__algorithm/upper_bound.h
+libcxx/include/__algorithm/replace_copy.h
+libcxx/include/__algorithm/ranges_find_if_not.h
+libcxx/include/__algorithm/binary_search.h
+libcxx/include/__algorithm/ranges_transform.h
+libcxx/include/__algorithm/lexicographical_compare.h
+libcxx/include/__algorithm/ranges_find.h
+libcxx/include/__algorithm/ranges_reverse.h
+libcxx/include/__algorithm/ranges_shuffle.h
+libcxx/include/__algorithm/partition_copy.h
+libcxx/include/__algorithm/replace.h
+libcxx/include/__algorithm/ranges_reverse_copy.h
+libcxx/include/__algorithm/partial_sort.h
+libcxx/include/__algorithm/ranges_search_n.h
+libcxx/include/__algorithm/min_max_result.h
+libcxx/include/__algorithm/fill.h
+libcxx/include/__algorithm/ranges_unique.h
+libcxx/include/__algorithm/ranges_binary_search.h
+libcxx/include/__algorithm/min_element.h
+libcxx/include/__algorithm/ranges_copy_backward.h
+libcxx/include/__algorithm/set_difference.h
+libcxx/include/__algorithm/ranges_upper_bound.h
+libcxx/include/__algorithm/ranges_is_heap.h
+libcxx/include/__algorithm/iterator_operations.h
+libcxx/include/__algorithm/in_fun_result.h
+libcxx/include/__algorithm/clamp.h
+libcxx/include/__algorithm/copy_n.h
+libcxx/include/__algorithm/ranges_minmax.h
+libcxx/include/__algorithm/ranges_replace_if.h
+libcxx/include/__algorithm/ranges_pop_heap.h
+libcxx/include/__algorithm/find_first_of.h
+libcxx/include/__algorithm/minmax.h
+libcxx/include/__algorithm/remove_if.h
+libcxx/include/__algorithm/ranges_search.h
+libcxx/include/__algorithm/min.h
+libcxx/include/__algorithm/includes.h
+libcxx/include/__algorithm/ranges_is_partitioned.h
+libcxx/include/__algorithm/ranges_stable_partition.h
+libcxx/include/__algorithm/ranges_merge.h
+libcxx/include/__algorithm/ranges_sort_heap.h
+libcxx/include/__algorithm/sift_down.h
+libcxx/include/__algorithm/ranges_generate_n.h
+libcxx/include/__algorithm/ranges_max_element.h
+libcxx/include/__algorithm/swap_ranges.h
+libcxx/include/__algorithm/ranges_is_sorted_until.h
+libcxx/include/__algorithm/ranges_swap_ranges.h
+libcxx/include/__algorithm/ranges_equal_range.h
+libcxx/include/__algorithm/replace_copy_if.h
+libcxx/include/__algorithm/move.h
+libcxx/include/__algorithm/copy_backward.h
+libcxx/include/__algorithm/half_positive.h
+libcxx/include/__algorithm/copy_if.h
+libcxx/include/__algorithm/partition.h
+libcxx/include/__algorithm/ranges_find_first_of.h
+libcxx/include/__algorithm/shuffle.h
+libcxx/include/__algorithm/merge.h
+libcxx/include/__algorithm/stable_partition.h
+libcxx/include/__algorithm/ranges_replace_copy.h
+libcxx/include/__algorithm/nth_element.h
+libcxx/include/__algorithm/ranges_for_each_n.h
+libcxx/include/__algorithm/ranges_replace_copy_if.h
+libcxx/include/__algorithm/in_out_result.h
+libcxx/include/__algorithm/ranges_clamp.h
+libcxx/include/__algorithm/ranges_count.h
+libcxx/include/__algorithm/ranges_count_if.h
+libcxx/include/__algorithm/ranges_prev_permutation.h
+libcxx/include/__algorithm/ranges_copy.h
+libcxx/include/__algorithm/reverse.h
+libcxx/include/__algorithm/minmax_element.h
+libcxx/include/__algorithm/ranges_equal.h
+libcxx/include/__algorithm/is_sorted.h
+libcxx/include/__algorithm/iter_swap.h
+libcxx/include/__algorithm/max.h
+libcxx/include/__algorithm/fill_n.h
+libcxx/include/__algorithm/generate_n.h
+libcxx/include/__algorithm/ranges_partial_sort_copy.h
+libcxx/include/__algorithm/is_sorted_until.h
+libcxx/include/__algorithm/make_heap.h
+libcxx/include/__algorithm/remove_copy_if.h
+libcxx/include/__algorithm/ranges_move.h
+libcxx/include/__algorithm/ranges_sort.h
+libcxx/include/__algorithm/transform.h
+libcxx/include/__algorithm/in_in_result.h
+libcxx/include/__algorithm/uniform_random_bit_generator_adaptor.h
+libcxx/include/wctype.h
+libcxx/include/stdio.h
+libcxx/include/thread
+libcxx/include/__mbstate_t.h
+libcxx/include/forward_list
+libcxx/include/__locale
+libcxx/include/locale.h
+libcxx/include/ios
+libcxx/include/unordered_map
+libcxx/include/any
+libcxx/include/variant
+libcxx/include/CMakeLists.txt
+libcxx/include/__node_handle
+libcxx/include/new
+libcxx/include/mutex
+libcxx/include/cmath
+libcxx/include/__format/format_context.h
+libcxx/include/__format/format_string.h
+libcxx/include/__format/formatter_floating_point.h
+libcxx/include/__format/formatter_char.h
+libcxx/include/__format/formatter_integral.h
+libcxx/include/__format/formatter_bool.h
+libcxx/include/__format/buffer.h
+libcxx/include/__format/format_functions.h
+libcxx/include/__format/formatter_integer.h
+libcxx/include/__format/format_arg.h
+libcxx/include/__format/format_parse_context.h
+libcxx/include/__format/unicode.h
+libcxx/include/__format/concepts.h
+libcxx/include/__format/format_arg_store.h
+libcxx/include/__format/format_error.h
+libcxx/include/__format/formatter_pointer.h
+libcxx/include/__format/formatter.h
+libcxx/include/__format/escaped_output_table.h
+libcxx/include/__format/format_args.h
+libcxx/include/__format/parser_std_format_spec.h
+libcxx/include/__format/formatter_output.h
+libcxx/include/__format/formatter_string.h
+libcxx/include/__format/extended_grapheme_cluster_table.h
+libcxx/include/__tuple_dir/sfinae_helpers.h
+libcxx/include/__tuple_dir/make_tuple_types.h
+libcxx/include/__tuple_dir/tuple_element.h
+libcxx/include/__tuple_dir/tuple_types.h
+libcxx/include/__tuple_dir/tuple_size.h
+libcxx/include/__tuple_dir/tuple_like_ext.h
+libcxx/include/__tuple_dir/apply_cv.h
+libcxx/include/__tuple_dir/tuple_indices.h
+libcxx/include/fstream
+libcxx/include/__tree
+libcxx/include/__chrono/month_weekday.h
+libcxx/include/__chrono/system_clock.h
+libcxx/include/__chrono/convert_to_timespec.h
+libcxx/include/__chrono/literals.h
+libcxx/include/__chrono/duration.h
+libcxx/include/__chrono/monthday.h
+libcxx/include/__chrono/hh_mm_ss.h
+libcxx/include/__chrono/calendar.h
+libcxx/include/__chrono/high_resolution_clock.h
+libcxx/include/__chrono/time_point.h
+libcxx/include/__chrono/month.h
+libcxx/include/__chrono/day.h
+libcxx/include/__chrono/steady_clock.h
+libcxx/include/__chrono/file_clock.h
+libcxx/include/__chrono/year_month_day.h
+libcxx/include/__chrono/weekday.h
+libcxx/include/__chrono/year.h
+libcxx/include/__chrono/formatter.h
+libcxx/include/__chrono/year_month_weekday.h
+libcxx/include/__chrono/year_month.h
+libcxx/include/string_view
+libcxx/include/__thread/poll_with_backoff.h
+libcxx/include/__thread/timed_backoff_policy.h
+libcxx/include/__memory/allocation_guard.h
+libcxx/include/__memory/allocate_at_least.h
+libcxx/include/__memory/raw_storage_iterator.h
+libcxx/include/__memory/ranges_uninitialized_algorithms.h
+libcxx/include/__memory/assume_aligned.h
+libcxx/include/__memory/compressed_pair.h
+libcxx/include/__memory/ranges_construct_at.h
+libcxx/include/__memory/temp_value.h
+libcxx/include/__memory/addressof.h
+libcxx/include/__memory/pointer_traits.h
+libcxx/include/__memory/unique_ptr.h
+libcxx/include/__memory/temporary_buffer.h
+libcxx/include/__memory/builtin_new_allocator.h
+libcxx/include/__memory/uses_allocator.h
+libcxx/include/__memory/destruct_n.h
+libcxx/include/__memory/aligned_alloc.h
+libcxx/include/__memory/auto_ptr.h
+libcxx/include/__memory/shared_ptr.h
+libcxx/include/__memory/allocator_destructor.h
+libcxx/include/__memory/allocator_arg_t.h
+libcxx/include/__memory/concepts.h
+libcxx/include/__memory/allocator_traits.h
+libcxx/include/__memory/construct_at.h
+libcxx/include/__memory/uninitialized_algorithms.h
+libcxx/include/__memory/allocator.h
+libcxx/include/stddef.h
+libcxx/include/barrier
+libcxx/include/inttypes.h
+libcxx/include/__fwd/span.h
+libcxx/include/__fwd/subrange.h
+libcxx/include/__fwd/get.h
+libcxx/include/__fwd/string_view.h
+libcxx/include/__iterator/mergeable.h
+libcxx/include/__iterator/next.h
+libcxx/include/__iterator/front_insert_iterator.h
+libcxx/include/__iterator/incrementable_traits.h
+libcxx/include/__iterator/empty.h
+libcxx/include/__iterator/iter_move.h
+libcxx/include/__iterator/common_iterator.h
+libcxx/include/__iterator/wrap_iter.h
+libcxx/include/__iterator/projected.h
+libcxx/include/__iterator/indirectly_comparable.h
+libcxx/include/__iterator/ostream_iterator.h
+libcxx/include/__iterator/unreachable_sentinel.h
+libcxx/include/__iterator/data.h
+libcxx/include/__iterator/move_sentinel.h
+libcxx/include/__iterator/iterator_traits.h
+libcxx/include/__iterator/prev.h
+libcxx/include/__iterator/istream_iterator.h
+libcxx/include/__iterator/erase_if_container.h
+libcxx/include/__iterator/default_sentinel.h
+libcxx/include/__iterator/ostreambuf_iterator.h
+libcxx/include/__iterator/insert_iterator.h
+libcxx/include/__iterator/concepts.h
+libcxx/include/__iterator/size.h
+libcxx/include/__iterator/distance.h
+libcxx/include/__iterator/iterator.h
+libcxx/include/__iterator/sortable.h
+libcxx/include/__iterator/move_iterator.h
+libcxx/include/__iterator/reverse_access.h
+libcxx/include/__iterator/istreambuf_iterator.h
+libcxx/include/__iterator/advance.h
+libcxx/include/__iterator/reverse_iterator.h
+libcxx/include/__iterator/access.h
+libcxx/include/__iterator/counted_iterator.h
+libcxx/include/__iterator/iter_swap.h
+libcxx/include/__iterator/permutable.h
+libcxx/include/__iterator/readable_traits.h
+libcxx/include/__iterator/back_insert_iterator.h
+libcxx/include/system_error
+libcxx/include/libcxx.imp
+libcxx/include/__charconv/from_chars_result.h
+libcxx/include/__charconv/chars_format.h
+libcxx/include/__charconv/to_chars_result.h
+libcxx/include/__charconv/to_chars_base_10.h
+libcxx/include/__charconv/tables.h
+libcxx/include/list
+libcxx/include/limits.h
+libcxx/include/stdbool.h
+libcxx/include/deque
+libcxx/include/__expected/expected.h
+libcxx/include/__expected/unexpected.h
+libcxx/include/__debug
+libcxx/include/atomic
+libcxx/include/memory
+libcxx/include/istream
+libcxx/include/numeric
+libcxx/include/valarray
+libcxx/include/__ranges/empty.h
+libcxx/include/__ranges/enable_view.h
+libcxx/include/__ranges/counted.h
+libcxx/include/__ranges/owning_view.h
+libcxx/include/__ranges/zip_view.h
+libcxx/include/__ranges/transform_view.h
+libcxx/include/__ranges/common_view.h
+libcxx/include/__ranges/rbegin.h
+libcxx/include/__ranges/filter_view.h
+libcxx/include/__ranges/all.h
+libcxx/include/__ranges/take_view.h
+libcxx/include/__ranges/single_view.h
+libcxx/include/__ranges/rend.h
+libcxx/include/__ranges/range_adaptor.h
+libcxx/include/__ranges/data.h
+libcxx/include/__ranges/non_propagating_cache.h
+libcxx/include/__ranges/lazy_split_view.h
+libcxx/include/__ranges/iota_view.h
+libcxx/include/__ranges/drop_view.h
+libcxx/include/__ranges/join_view.h
+libcxx/include/__ranges/concepts.h
+libcxx/include/__ranges/size.h
+libcxx/include/__ranges/reverse_view.h
+libcxx/include/__ranges/copyable_box.h
+libcxx/include/__ranges/subrange.h
+libcxx/include/__ranges/views.h
+libcxx/include/__ranges/access.h
+libcxx/include/__ranges/empty_view.h
+libcxx/include/__ranges/ref_view.h
+libcxx/include/__ranges/view_interface.h
+libcxx/src/new.cpp
+libcxx/src/exception.cpp
+libcxx/src/functional.cpp
+libcxx/src/verbose_abort.cpp
+libcxx/src/experimental/memory_resource.cpp
+libcxx/src/mutex.cpp
+libcxx/src/random_shuffle.cpp
+libcxx/src/memory_resource.cpp
+libcxx/src/memory.cpp
+libcxx/src/vector.cpp
+libcxx/src/future.cpp
+libcxx/src/mutex_destructor.cpp
+libcxx/src/optional.cpp
+libcxx/src/filesystem/operations.cpp
+libcxx/src/filesystem/int128_builtins.cpp
+libcxx/src/filesystem/filesystem_common.h
+libcxx/src/filesystem/posix_compat.h
+libcxx/src/filesystem/directory_iterator.cpp
+libcxx/src/bind.cpp
+libcxx/src/hash.cpp
+libcxx/src/condition_variable_destructor.cpp
+libcxx/src/include/atomic_support.h
+libcxx/src/include/refstring.h
+libcxx/src/include/config_elast.h
+libcxx/src/include/ryu/ryu.h
+libcxx/src/include/apple_availability.h
+libcxx/src/include/sso_allocator.h
+libcxx/src/shared_mutex.cpp
+libcxx/src/strstream.cpp
+libcxx/src/charconv.cpp
+libcxx/src/valarray.cpp
+libcxx/src/support/win32/thread_win32.cpp
+libcxx/src/support/win32/locale_win32.cpp
+libcxx/src/support/win32/support.cpp
+libcxx/src/support/solaris/xlocale.cpp
+libcxx/src/support/solaris/mbsnrtowcs.inc
+libcxx/src/support/solaris/wcsnrtombs.inc
+libcxx/src/support/runtime/exception_pointer_cxxabi.ipp
+libcxx/src/support/runtime/stdexcept_vcruntime.ipp
+libcxx/src/support/runtime/stdexcept_default.ipp
+libcxx/src/support/runtime/exception_pointer_msvc.ipp
+libcxx/src/support/runtime/exception_fallback.ipp
+libcxx/src/support/runtime/exception_libcxxabi.ipp
+libcxx/src/support/runtime/exception_pointer_unimplemented.ipp
+libcxx/src/support/runtime/exception_libcxxrt.ipp
+libcxx/src/support/runtime/exception_glibcxx.ipp
+libcxx/src/support/runtime/exception_pointer_glibcxx.ipp
+libcxx/src/support/runtime/new_handler_fallback.ipp
+libcxx/src/support/runtime/exception_msvc.ipp
+libcxx/src/support/ibm/mbsnrtowcs.cpp
+libcxx/src/support/ibm/wcsnrtombs.cpp
+libcxx/src/support/ibm/xlocale_zos.cpp
+libcxx/src/atomic.cpp
+libcxx/src/system_error.cpp
+libcxx/src/string.cpp
+libcxx/src/typeinfo.cpp
+libcxx/src/condition_variable.cpp
+libcxx/src/stdexcept.cpp
+libcxx/src/debug.cpp
+libcxx/src/ios.cpp
+libcxx/src/chrono.cpp
+libcxx/src/CMakeLists.txt
+libcxx/src/barrier.cpp
+libcxx/src/any.cpp
+libcxx/src/iostream.cpp
+libcxx/src/thread.cpp
+libcxx/src/locale.cpp
+libcxx/src/random.cpp
+libcxx/src/legacy_debug_handler.cpp
+libcxx/src/variant.cpp
+libcxx/src/regex.cpp

libcxx/utils/generate_ignore_format.sh

+#!/bin/bash
+
+# Generate a list of headers that aren't formatted yet
+
+rm libcxx/utils/data/ignore_format.txt
+for file in $(find libcxx/{benchmarks,include,src}/ -type f); do
+  clang-format --Werror --dry-run ${file} >& /dev/null
+  if [ $? != 0 ]; then
+    echo ${file} >> libcxx/utils/data/ignore_format.txt
+  fi
+done