This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Improve the format ignorelist generation.

Authored by Mordante on Feb 15 2023, 10:53 AM.


Group Reviewers
Restricted Project
rGf7f86451ecd7: [libc++] Improve the format ignorelist generation.

Several improvements

  • Only add files that we actually want to format.
  • Sort according to a fixed locale.

Some drive-by fixes

  • Rename a text file, this avoids a filter exception.
  • Adds a some missing source files extensions.
  • Removes unused extensions hh, hxx, cc, and cxx from clang-format.

Diff Detail

Event Timeline

Mordante created this revision.Feb 15 2023, 10:53 AM
Mordante updated this revision to Diff 497762.Feb 15 2023, 11:41 AM

Remove testing part and minor improvements.

Mordante published this revision for review.Feb 16 2023, 1:15 PM
Mordante added a reviewer: philnik.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 16 2023, 1:15 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.Feb 16 2023, 1:26 PM

LGTM % comment. Thanks for improving the script.


AFAIK we don't have most of these file endings. IMO we shouldn't list them here (and remove them from check-format).

This revision is now accepted and ready to land.Feb 16 2023, 1:26 PM
Mordante marked an inline comment as done.Feb 17 2023, 8:49 AM

Thanks for the review.


*.c is unused, but I'm want to keep it.
*.hh, *.hxx, *.cc, and *.cxx are unused and these I'll remove.

Mordante edited the summary of this revision. (Show Details)Feb 17 2023, 8:51 AM
philnik added inline comments.Feb 17 2023, 9:01 AM

Sounds good.

This revision was landed with ongoing or failed builds.Feb 17 2023, 9:02 AM
This revision was automatically updated to reflect the committed changes.
Mordante marked an inline comment as done.