Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People huixie90

huixie90 (Hui)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2022, 6:10 AM (89 w, 4 d)

Recent Activity
View All

Thu, Sep 21

huixie90 updated the diff for D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.

address feedback

Thu, Sep 21, 2:58 PM · Restricted Project, Restricted Project

Tue, Sep 19

huixie90 accepted D132509: [libc++] Use _Lazy in tuple constructors.

Thanks LGTM!

Tue, Sep 19, 1:43 PM · Restricted Project, Restricted Project

Sun, Sep 17

huixie90 updated the diff for D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.

ci

Sun, Sep 17, 11:36 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.

guard stop_token headers with no thread macro

Sun, Sep 17, 7:27 AM · Restricted Project, Restricted Project

Sat, Sep 16

huixie90 updated the diff for D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.

CI

Sat, Sep 16, 3:15 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.

CI

Sat, Sep 16, 1:06 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.

CI

Sat, Sep 16, 1:01 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.

CI

Sat, Sep 16, 12:42 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.

FTM

Sat, Sep 16, 12:32 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.

rebase

Sat, Sep 16, 12:11 PM · Restricted Project, Restricted Project
huixie90 closed D151559: [libc++] implement std::`jthread`.

https://github.com/llvm/llvm-project/commit/695138ca8405779c2b7756cc31d887aa54f56bb8

Sat, Sep 16, 11:57 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

CI

Sat, Sep 16, 10:00 AM · Restricted Project, Restricted Project
huixie90 added inline comments to D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.
Sat, Sep 16, 2:41 AM · Restricted Project, Restricted Project

Fri, Sep 15

huixie90 updated the diff for D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.

CI

Fri, Sep 15, 12:21 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

addressed feedback

Fri, Sep 15, 11:58 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.

address feedback rebase

Fri, Sep 15, 4:19 AM · Restricted Project, Restricted Project
huixie90 commandeered D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.
Fri, Sep 15, 1:24 AM · Restricted Project, Restricted Project

Thu, Sep 14

huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

filter platforms

Thu, Sep 14, 11:32 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

formatting

Thu, Sep 14, 1:04 PM · Restricted Project, Restricted Project

Wed, Sep 13

huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

update module map and all tests guard against experimental stop_token macro

Wed, Sep 13, 1:21 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

transitive includes

Wed, Sep 13, 11:33 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

transitive includes

Wed, Sep 13, 6:34 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

formatting

Wed, Sep 13, 5:00 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

put jthread in experimental

Wed, Sep 13, 4:35 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

rebase

Wed, Sep 13, 3:51 AM · Restricted Project, Restricted Project
huixie90 commandeered D151559: [libc++] implement std::`jthread`.
Wed, Sep 13, 2:20 AM · Restricted Project, Restricted Project

Jul 7 2023

huixie90 updated the summary of D154702: [libc++] [DO NOT MERGE] benchmark stop_token and use std::mutex in the implementation of stop_token.
Jul 7 2023, 4:12 AM · Restricted Project, Restricted Project
huixie90 requested review of D154702: [libc++] [DO NOT MERGE] benchmark stop_token and use std::mutex in the implementation of stop_token.
Jul 7 2023, 4:05 AM · Restricted Project, Restricted Project
huixie90 requested review of D154700: [libc++] Make `stop_token` experimental.
Jul 7 2023, 4:03 AM · Restricted Project, Restricted Project

Jun 30 2023

huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

rebase

Jun 30 2023, 1:39 PM · Restricted Project, Restricted Project
huixie90 added inline comments to D151559: [libc++] implement std::`jthread`.
Jun 30 2023, 12:51 PM · Restricted Project, Restricted Project

Jun 28 2023

huixie90 requested review of D153981: [libc++][In progress] Floating Point Atomic.
Jun 28 2023, 7:48 AM · Restricted Project, Restricted Project

Jun 21 2023

huixie90 updated the diff for D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.

CI

Jun 21 2023, 12:56 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

export jthread

Jun 21 2023, 10:11 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

CI

Jun 21 2023, 10:04 AM · Restricted Project, Restricted Project
huixie90 requested review of D153441: [libc++] Implement `std::condition_variable_any::wait[_for/until]` overloads that take `stop_token`.
Jun 21 2023, 9:40 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

CI

Jun 21 2023, 2:31 AM · Restricted Project, Restricted Project

Jun 19 2023

huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

CI

Jun 19 2023, 11:57 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

ci

Jun 19 2023, 6:57 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

update <thread>

Jun 19 2023, 5:38 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151559: [libc++] implement std::`jthread`.

add tests

Jun 19 2023, 5:33 AM · Restricted Project, Restricted Project

Jun 16 2023

huixie90 updated the diff for D151792: [libc++][NFC] Granularise <thread> header.

rebase + CI

Jun 16 2023, 11:53 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D151792: [libc++][NFC] Granularise <thread> header.

CI

Jun 16 2023, 12:06 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D151792: [libc++][NFC] Granularise <thread> header.

address issues

Jun 16 2023, 9:56 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151792: [libc++][NFC] Granularise <thread> header.

rebase + trigger CI

Jun 16 2023, 9:54 AM · Restricted Project, Restricted Project

Jun 5 2023

huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

rebase

Jun 5 2023, 2:17 AM · Restricted Project, Restricted Project

Jun 2 2023

huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

fix stop_token lit_header_restrictions

Jun 2 2023, 11:54 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151792: [libc++][NFC] Granularise <thread> header.

rebase

Jun 2 2023, 10:05 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

rebase

Jun 2 2023, 9:56 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151792: [libc++][NFC] Granularise <thread> header.

includes

Jun 2 2023, 5:52 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151792: [libc++][NFC] Granularise <thread> header.

try again

Jun 2 2023, 3:24 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151792: [libc++][NFC] Granularise <thread> header.

CI

Jun 2 2023, 2:20 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151792: [libc++][NFC] Granularise <thread> header.

CI

Jun 2 2023, 1:26 AM · Restricted Project, Restricted Project

Jun 1 2023

huixie90 updated the diff for D151792: [libc++][NFC] Granularise <thread> header.

unformatting

Jun 1 2023, 11:56 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

rebase

Jun 1 2023, 11:22 PM · Restricted Project, Restricted Project

May 31 2023

huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

fix apple platform

May 31 2023, 12:52 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D151792: [libc++][NFC] Granularise <thread> header.

missing includes

May 31 2023, 9:47 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

try again

May 31 2023, 8:44 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

try again

May 31 2023, 6:41 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151792: [libc++][NFC] Granularise <thread> header.

CI

May 31 2023, 6:36 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D151792: [libc++][NFC] Granularise <thread> header.

private headers

May 31 2023, 4:03 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

CI

May 31 2023, 3:04 AM · Restricted Project, Restricted Project
huixie90 requested review of D151792: [libc++][NFC] Granularise <thread> header.
May 31 2023, 2:50 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

indentation

May 31 2023, 1:57 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

CI

May 31 2023, 1:51 AM · Restricted Project, Restricted Project

May 24 2023

huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

address comments

May 24 2023, 4:12 AM · Restricted Project, Restricted Project

May 22 2023

huixie90 removed reviewers for D145183: [libc++] Implement `stop_token`: andreadb, jdoerfert, sstefan1, nicolasvasilache, herhut, rriddle, sscalpone, ftynse, aartbik, ThomasRaoux, NoQ, dcaballe, kiranchandramohan.
May 22 2023, 12:47 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

rebase

May 22 2023, 12:46 PM · Restricted Project, Restricted Project
huixie90 removed reviewers for D145183: [libc++] Implement `stop_token`: andreadb, jdoerfert, sstefan1, nicolasvasilache, herhut, rriddle, aartbik, sscalpone, ftynse, clementval, ThomasRaoux, NoQ, dcaballe, kiranchandramohan.
May 22 2023, 12:46 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.
  • [libc++] Implement stop_token
May 22 2023, 10:39 AM · Restricted Project, Restricted Project

May 21 2023

huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

rebase

May 21 2023, 10:15 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

CI

May 21 2023, 5:39 AM · Restricted Project, Restricted Project

May 20 2023

huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

CI

May 20 2023, 1:13 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

CI

May 20 2023, 12:38 PM · Restricted Project, Restricted Project

May 19 2023

huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

add tests

May 19 2023, 12:34 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

address review comments

May 19 2023, 12:33 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

CI

May 19 2023, 7:36 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

CI

May 19 2023, 2:37 AM · Restricted Project, Restricted Project

May 18 2023

huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

CI

May 18 2023, 1:51 PM · Restricted Project, Restricted Project

May 17 2023

huixie90 added inline comments to D145183: [libc++] Implement `stop_token`.
May 17 2023, 5:28 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

rebase

May 17 2023, 5:25 AM · Restricted Project, Restricted Project

May 13 2023

huixie90 updated the diff for D150205: [libc++] Utilities for implementing stop_token.

CI

May 13 2023, 1:45 AM · Restricted Project, Restricted Project

May 12 2023

huixie90 updated the diff for D150205: [libc++] Utilities for implementing stop_token.

CI

May 12 2023, 12:53 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D150205: [libc++] Utilities for implementing stop_token.

CI

May 12 2023, 12:32 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D150205: [libc++] Utilities for implementing stop_token.

address comments

May 12 2023, 11:19 AM · Restricted Project, Restricted Project
huixie90 published D150205: [libc++] Utilities for implementing stop_token for review.
May 12 2023, 3:23 AM · Restricted Project, Restricted Project

May 9 2023

huixie90 requested review of D150206: [libc++][ranges] Fix `iota_view`'s constructor's incorrect constraint.
May 9 2023, 9:47 AM · Restricted Project, Restricted Project

Apr 10 2023

huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

formatting

Apr 10 2023, 4:23 AM · Restricted Project, Restricted Project

Mar 28 2023

huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

address feedback

Mar 28 2023, 11:53 AM · Restricted Project, Restricted Project

Mar 21 2023

huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

Fix typo as pointed out by Arthur

Mar 21 2023, 6:51 AM · Restricted Project, Restricted Project

Mar 16 2023

huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

next try

Mar 16 2023, 5:05 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

try again

Mar 16 2023, 4:42 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

CI

Mar 16 2023, 3:27 AM · Restricted Project, Restricted Project

Mar 13 2023

huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

CI

Mar 13 2023, 12:31 PM · Restricted Project, Restricted Project
huixie90 added inline comments to D145183: [libc++] Implement `stop_token`.
Mar 13 2023, 12:25 PM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

address comments

Mar 13 2023, 11:02 AM · Restricted Project, Restricted Project
huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

CI

Mar 13 2023, 9:57 AM · Restricted Project, Restricted Project
huixie90 added inline comments to D145183: [libc++] Implement `stop_token`.
Mar 13 2023, 7:19 AM · Restricted Project, Restricted Project

Mar 12 2023

huixie90 updated the diff for D145183: [libc++] Implement `stop_token`.

refactoring:
spliting the lock and the linked list into separate classes

Mar 12 2023, 5:25 PM · Restricted Project, Restricted Project
huixie90 added inline comments to D145183: [libc++] Implement `stop_token`.
Mar 12 2023, 2:25 PM · Restricted Project, Restricted Project