This is an archive of the discontinued LLVM Phabricator instance.

[mlir][NFC] Set `useFoldAPI` to `kEmitRawAttributesFolder` value for some dialects missed previously
ClosedPublic

Authored by zero9178 on Jan 15 2023, 9:39 AM.

Details

Summary

Found these while working on https://reviews.llvm.org/D141604. These were previously not found due to the old implementation only emitting warnings if an Op has a fold.

Changing these values both avoid the deprecation warning and if new folds were added to ops of these dialects, that they are already using the new API.

Diff Detail

Event Timeline

zero9178 created this revision.Jan 15 2023, 9:39 AM
Herald added a project: Restricted Project. · View Herald Transcript
zero9178 requested review of this revision.Jan 15 2023, 9:39 AM
Mogball accepted this revision.Jan 15 2023, 10:33 AM
This revision is now accepted and ready to land.Jan 15 2023, 10:33 AM
jpienaar accepted this revision.Jan 15 2023, 11:08 AM
zero9178 updated this revision to Diff 489389.Jan 15 2023, 11:55 AM

Missed the toy examples

This revision was landed with ongoing or failed builds.Jan 16 2023, 2:48 AM
This revision was automatically updated to reflect the committed changes.