This is an archive of the discontinued LLVM Phabricator instance.

Differential D141624

[fix] Change formatting to use llvm::formatv Summary:
ClosedPublic

Authored by ayermolo on Jan 12 2023, 11:11 AM.

Details

Reviewers
shafik
hoy
zhuhan0
Commits
rG4e7da8000e27: [fix] Change formatting to use llvm::formatv Summary:
Summary

Missed one formating that was reversed.

Diff Detail

Event Timeline

ayermolo created this revision.Jan 12 2023, 11:11 AM
Herald added a reviewer: shafik. · View Herald TranscriptJan 12 2023, 11:11 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: hoy, modimo, wenlei. · View Herald Transcript
ayermolo requested review of this revision.Jan 12 2023, 11:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2023, 11:11 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
ayermolo mentioned this in D139955: [LLDB] Change formatting to use llvm::formatv.Jan 12 2023, 11:12 AM
Harbormaster completed remote builds in B207450: Diff 488723.Jan 12 2023, 11:15 AM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptJan 12 2023, 11:15 AM
hoy accepted this revision.Jan 12 2023, 11:16 AM
This revision is now accepted and ready to land.Jan 12 2023, 11:16 AM
zhuhan0 accepted this revision.Jan 12 2023, 11:16 AM
Closed by commit rG4e7da8000e27: [fix] Change formatting to use llvm::formatv Summary: (authored by ayermolo). · Explain WhyJan 12 2023, 11:18 AM
This revision was automatically updated to reflect the committed changes.
ayermolo added a commit: rG4e7da8000e27: [fix] Change formatting to use llvm::formatv Summary:.

Revision Contents

PathSize
lldb/
source/
Plugins/
SymbolFile/
DWARF/
2 lines

Diff 488725

lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

Show First 20 Lines • Show All 671 Lines • ▼ Show 20 Lines if (!clang_type && (encoding_data_type == Type::eEncodingIsPointerUID ||
if (cu_language == eLanguageTypeObjC || if (cu_language == eLanguageTypeObjC ||
cu_language == eLanguageTypeObjC_plus_plus) { cu_language == eLanguageTypeObjC_plus_plus) {
if (attrs.name) { if (attrs.name) {
if (attrs.name == "id") { if (attrs.name == "id") {
if (log) if (log)
dwarf->GetObjectFile()->GetModule()->LogMessage( dwarf->GetObjectFile()->GetModule()->LogMessage(
log, log,
"SymbolFileDWARF::ParseType (die = {0:16x}) {1} '{2}' " "SymbolFileDWARF::ParseType (die = {0:x16}) {1} '{2}' "
"is Objective-C 'id' built-in type.", "is Objective-C 'id' built-in type.",
die.GetOffset(), die.GetTagAsCString(), die.GetName()); die.GetOffset(), die.GetTagAsCString(), die.GetName());
clang_type = m_ast.GetBasicType(eBasicTypeObjCID); clang_type = m_ast.GetBasicType(eBasicTypeObjCID);
encoding_data_type = Type::eEncodingIsUID; encoding_data_type = Type::eEncodingIsUID;
attrs.type.Clear(); attrs.type.Clear();
resolve_state = Type::ResolveState::Full; resolve_state = Type::ResolveState::Full;
} else if (attrs.name == "Class") { } else if (attrs.name == "Class") {
if (log) if (log)
▲ Show 20 Lines • Show All 2,983 Lines • Show Last 20 Lines