Add missing Ops and update related testing files.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
Hi @hassnaa-arm, it seems there is some missing test coverage for some of the operations, which wasn't that easy to spot because this patch is quite big. It might help to split up this patch into smaller patches so that at least the sign-extend-inreg changes are in a separate patch, since it touches a number of test files.
It might also help to split out some of the others changes:
- selects (since there are code changes to the LowerSELECT)
- fp extends (since there are code changes to the LowerFP_EXTEND)
You could choose to keep this patch for the bitreverse/bswap/vecreduce/splice/cttz (with added tests)
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp | ||
---|---|---|
1718 | There are tests missing for bitreverse. | |
1724 | There are tests missing for CTTZ | |
1777 | There are tests missing in this patch for the vecreduce_* operations. | |
1789 | there are tests missing for vector_splice. | |
llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-int-mulh.ll | ||
19 | I guess this change is caused by the sign-extend-inreg, maybe it's worth pulling that out into a separate patch? |
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp | ||
---|---|---|
1718 | about this comment and other similar comments, do you mean that some test cases are missing ? |
Split out custom-lowering sign-extend-inreg and related testing files to another patch
The affected testing files are related to custom-lowering ISD::VSELECT and ISD::BITREVERSE
There are tests missing for bitreverse.