This is an archive of the discontinued LLVM Phabricator instance.

Differential D140774

[mlir][Arith] Remove redundant defination, NFC.
ClosedPublic

Authored by jacquesguan on Dec 30 2022, 12:42 AM.

Details

Reviewers
kuhar
nicolasvasilache
ftynse
aartbik
bondhugula
rriddle
mehdi_amini
Mogball
ThomasRaoux
Commits
rGe345d4202541: [mlir][Arith] Remove redundant defination, NFC.

Diff Detail

Event Timeline

jacquesguan created this revision.Dec 30 2022, 12:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 30 2022, 12:42 AM
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 17 others. · View Herald Transcript
jacquesguan requested review of this revision.Dec 30 2022, 12:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 30 2022, 12:42 AM
Herald added a subscriber: stephenneuendorffer. · View Herald Transcript
ftynse accepted this revision.Dec 30 2022, 12:57 AM
This revision is now accepted and ready to land.Dec 30 2022, 12:57 AM
Harbormaster completed remote builds in B205204: Diff 485677.Dec 30 2022, 1:03 AM
Closed by commit rGe345d4202541: [mlir][Arith] Remove redundant defination, NFC. (authored by jacquesguan). · Explain WhyDec 30 2022, 1:08 AM
This revision was automatically updated to reflect the committed changes.
jacquesguan added a commit: rGe345d4202541: [mlir][Arith] Remove redundant defination, NFC..

Revision Contents

PathSize
mlir/
lib/
Dialect/
Arith/
IR/
1 line

Diff 485678

mlir/lib/Dialect/Arith/IR/ArithOps.cpp

Show First 20 Lines • Show All 259 Lines • ▼ Show 20 Lines
} }
LogicalResult LogicalResult
arith::AddUIExtendedOp::fold(ArrayRef<Attribute> operands, arith::AddUIExtendedOp::fold(ArrayRef<Attribute> operands,
SmallVectorImpl<OpFoldResult> &results) { SmallVectorImpl<OpFoldResult> &results) {
Type overflowTy = getOverflow().getType(); Type overflowTy = getOverflow().getType();
// addui_extended(x, 0) -> x, false // addui_extended(x, 0) -> x, false
if (matchPattern(getRhs(), m_Zero())) { if (matchPattern(getRhs(), m_Zero())) {
auto overflowZero = APInt::getZero(1);
Builder builder(getContext()); Builder builder(getContext());
auto falseValue = builder.getZeroAttr(overflowTy); auto falseValue = builder.getZeroAttr(overflowTy);
results.push_back(getLhs()); results.push_back(getLhs());
results.push_back(falseValue); results.push_back(falseValue);
return success(); return success();
} }
▲ Show 20 Lines • Show All 2,095 Lines • Show Last 20 Lines