This is an archive of the discontinued LLVM Phabricator instance.

[ODRHash] Hash `ObjCInterfaceDecl` and diagnose discovered mismatches.
ClosedPublic

Authored by vsapsai on Dec 14 2022, 5:16 PM.

Details

Summary

When two modules contain interfaces with the same name, check the
definitions are equivalent and diagnose if they are not.

Diff Detail

Event Timeline

vsapsai created this revision.Dec 14 2022, 5:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2022, 5:16 PM
Herald added a subscriber: ributzka. · View Herald Transcript
vsapsai requested review of this revision.Dec 14 2022, 5:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2022, 5:16 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
ChuanqiXu accepted this revision.Dec 25 2022, 6:35 PM

Although I'm not familiar with ObjC, the code looks good.

This revision is now accepted and ready to land.Dec 25 2022, 6:35 PM
vsapsai updated this revision to Diff 487045.Jan 6 2023, 8:46 PM

Serialize/deserialize ObjCInterfaceTypeLoc::NameEndLoc as it is used in diagnostic about a mismatching superclass.

Thanks for the review!