Page MenuHomePhabricator
Differential D139957

[LLDB] Change OSO to use DieRef
AbandonedPublic
Actions

Authored by ayermolo on Dec 13 2022, 10:38 AM.

Details

Reviewers
clayborg
labath
Summary

Following example of DWO changing it to use DIERef.

Depends on D138618

Diff Detail

Event Timeline

ayermolo created this revision.Dec 13 2022, 10:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2022, 10:38 AM
Herald added subscribers: hoy, modimo, wenlei. · View Herald Transcript
ayermolo requested review of this revision.Dec 13 2022, 10:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2022, 10:38 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
ayermolo added reviewers: clayborg, labath.Dec 13 2022, 10:41 AM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptDec 13 2022, 10:41 AM
Harbormaster completed remote builds in B202900: Diff 482553.Dec 13 2022, 10:42 AM
ayermolo updated this revision to Diff 491009.Jan 20 2023, 5:15 PM

Updated based on Gregs suggestion.

Harbormaster completed remote builds in B209099: Diff 491009.Jan 20 2023, 5:18 PM
labath added inline comments.Jan 23 2023, 6:10 AM
lldb/source/Plugins/SymbolFile/DWARF/DIERef.h
32

Where is this constructor being used?

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
10

unused include?

ayermolo marked an inline comment as done.Jan 26 2023, 2:09 PM
ayermolo added inline comments.
lldb/source/Plugins/SymbolFile/DWARF/DIERef.h
32

In SymbolFileDWARF.cpp
SymbolFileDWARF::GetUID
SymbolFileDWARF::DecodeUID

labath added inline comments.Jan 27 2023, 5:09 AM
lldb/source/Plugins/SymbolFile/DWARF/DIERef.h
32

I'm sorry, I must have clicked the wrong line. My question was about the constructor below this (line 40).

ayermolo marked 2 inline comments as done.Jan 27 2023, 10:29 AM
ayermolo added inline comments.
lldb/source/Plugins/SymbolFile/DWARF/DIERef.h
32

Ah yes, sorry. Removed.

ayermolo updated this revision to Diff 492842.Jan 27 2023, 10:30 AM
ayermolo marked an inline comment as done.

addressed comments

Harbormaster completed remote builds in B210431: Diff 492842.Jan 27 2023, 10:34 AM
ayermolo added a child revision: D142775: [LLDB] Remove GetUID API.Jan 27 2023, 10:37 AM
ayermolo abandoned this revision.Feb 13 2023, 1:11 PM

Revision Contents
Changeset List

PathSize
lldb/
source/
Plugins/
SymbolFile/
DWARF/
39 lines
3 lines
5 lines
2 lines
test/
Shell/
SymbolFile/
DWARF/
x86/
6 lines

Diff 492842

View Options

lldb/source/Plugins/SymbolFile/DWARF/DIERef.h

Loading...
View Options

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

Loading...
View Options

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h

Loading...
View Options

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp

Loading...
View Options

lldb/test/Shell/SymbolFile/DWARF/x86/debug_rnglists-dwo.s

Loading...