This is an archive of the discontinued LLVM Phabricator instance.

Differential D139588

[llvm-driver] Temporarily remove dsymutil
ClosedPublic

Authored by abrachet on Dec 7 2022, 3:10 PM.

Details

Reviewers
phosek
JDevlieghere
Commits
rGeeee51e4bb99: [llvm-driver] Temporarily remove dsymutil
Summary

A recent change made it such that target_link_libraries is always
called and not conditionally. target_link_libraries doesn't
currently work when LLVM_TOOL_LLVM_DRIVER_BUILD=On. This should
be fixed in the future, but for now let's just remove dsymutil
as part of the llvm-driver build.

Diff Detail

Event Timeline

abrachet created this revision.Dec 7 2022, 3:10 PM
Herald added a reviewer: JDevlieghere. · View Herald TranscriptDec 7 2022, 3:10 PM
Herald added a project: Restricted Project. · View Herald Transcript
abrachet requested review of this revision.Dec 7 2022, 3:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2022, 3:10 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
phosek accepted this revision.Dec 7 2022, 10:57 PM

LGTM

This revision is now accepted and ready to land.Dec 7 2022, 10:57 PM
This revision was landed with ongoing or failed builds.Dec 7 2022, 11:19 PM
Closed by commit rGeeee51e4bb99: [llvm-driver] Temporarily remove dsymutil (authored by abrachet). · Explain Why
This revision was automatically updated to reflect the committed changes.
abrachet added a commit: rGeeee51e4bb99: [llvm-driver] Temporarily remove dsymutil.
Harbormaster completed remote builds in B201828: Diff 481079.Dec 8 2022, 12:47 AM
hokein added a subscriber: hokein.Dec 8 2022, 12:57 AM

FYI: with the followup ab3dd9ad532d63248f731d207afecf71b2fa5b29, it broke our bazel build (fixed in 3661458b4cb3b4af2211a7e9889768cace9c710f). If you add it back in the future, would be nice to update the bazel build file as well.

Revision Contents

PathSize
llvm/
tools/
dsymutil/
1 line

Diff 481158

llvm/tools/dsymutil/CMakeLists.txt

Show All 27 Linesadd_llvm_tool(dsymutil
MachOUtils.cpp MachOUtils.cpp
Reproducer.cpp Reproducer.cpp
SymbolMap.cpp SymbolMap.cpp
DEPENDS DEPENDS
intrinsics_gen intrinsics_gen
${tablegen_deps} ${tablegen_deps}
DsymutilTableGen DsymutilTableGen
GENERATE_DRIVER
) )
if(APPLE) if(APPLE)
target_link_libraries(dsymutil PRIVATE "-framework CoreFoundation") target_link_libraries(dsymutil PRIVATE "-framework CoreFoundation")
endif(APPLE) endif(APPLE)
target_link_libraries(dsymutil PRIVATE ${LLVM_ATOMIC_LIB}) target_link_libraries(dsymutil PRIVATE ${LLVM_ATOMIC_LIB})