This is an archive of the discontinued LLVM Phabricator instance.

[Target] Pass object reference into initializers in object constructors
AbandonedPublic

Authored by gAlfonso-bit on Dec 6 2022, 4:51 PM.

Details

Reviewers
MaskRay

Diff Detail

Event Timeline

gAlfonso-bit created this revision.Dec 6 2022, 4:51 PM
gAlfonso-bit requested review of this revision.Dec 6 2022, 4:51 PM
MaskRay requested changes to this revision.Dec 6 2022, 5:26 PM
MaskRay added inline comments.
llvm/lib/InterfaceStub/IFSStub.cpp
32 ↗(On Diff #480695)

IFSStubTriple inherits from IFSStub and appears to have the unneeded constructor.

llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
519 ↗(On Diff #480695)

This initializes the unused fields in the base class.

This revision now requires changes to proceed.Dec 6 2022, 5:26 PM
gAlfonso-bit marked 2 inline comments as done.
This comment was removed by gAlfonso-bit.

Still infeasible to me. Not sure why initialize unused fields

gAlfonso-bit abandoned this revision.Sep 27 2023, 11:21 AM