[lldb] Remove timer from Module::GetNumCompileUnits

[kastiglione]

Summary

GetNumCompileUnits has fast execution, and is high firing. Fast and frequent functions are not good candidates for timers. In a recent profile, GetNumCompileUnits was called >>10k times with an average duration of 1 microsecond.

[JDevlieghere]

LGTM

lldb/source/Core/Module.cpp

 ModuleSP Module::CalculateSymbolContextModule() { return shared_from_this(); }
 
 void Module::DumpSymbolContext(Stream *s) {
   s->Printf(", Module{%p}", static_cast<void *>(this));
 }
 
 size_t Module::GetNumCompileUnits() {
   std::lock_guard<std::recursive_mutex> guard(m_mutex);
-  LLDB_SCOPED_TIMERF("Module::GetNumCompileUnits (module = %p)",
-                     static_cast<void *>(this));
   if (SymbolFile *symbols = GetSymbolFile())
     return symbols->GetNumCompileUnits();
   return 0;
 }
 
 CompUnitSP Module::GetCompileUnitAtIndex(size_t index) {
   std::lock_guard<std::recursive_mutex> guard(m_mutex);
   size_t num_comp_units = GetNumCompileUnits();