Page MenuHomePhabricator

kastiglione (Dave Lee)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2015, 10:30 PM (283 w, 1 d)

Recent Activity

Thu, Jan 7

kastiglione accepted D94284: [lldb] Make DoReadMemory a protected method..
Thu, Jan 7, 8:51 PM · Restricted Project

Dec 8 2020

kastiglione committed rG012fd0b17f30: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC) (authored by kastiglione).
[lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC)
Dec 8 2020, 11:52 PM
kastiglione closed D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC).
Dec 8 2020, 11:51 PM · Restricted Project

Dec 7 2020

kastiglione added a comment to D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC).

Yes I plan to merge this manually (rather than automerge) to ensure it's not disruptive.

Dec 7 2020, 12:47 PM · Restricted Project
kastiglione updated the diff for D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC).

Remove function use of is_variadic_ptr

Dec 7 2020, 11:26 AM · Restricted Project
kastiglione reclaimed D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC).
Dec 7 2020, 11:26 AM · Restricted Project
kastiglione abandoned D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC).

I can't read.

Dec 7 2020, 11:17 AM · Restricted Project
kastiglione requested review of D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC).
Dec 7 2020, 10:40 AM · Restricted Project

Nov 20 2020

kastiglione committed rGdbcc69217a3f: [lldb] Add examples and reword source-map help string (authored by kastiglione).
[lldb] Add examples and reword source-map help string
Nov 20 2020, 10:02 AM
kastiglione closed D91742: [lldb] Add examples and reword source-map help string.
Nov 20 2020, 10:01 AM · Restricted Project
kastiglione updated the diff for D91742: [lldb] Add examples and reword source-map help string.

Minor rewording

Nov 20 2020, 10:00 AM · Restricted Project

Nov 19 2020

kastiglione accepted D91780: [lldb] Fix that the expression commands --top-level flag overwrites --allow-jit false.
Nov 19 2020, 12:46 PM
kastiglione added a comment to D91780: [lldb] Fix that the expression commands --top-level flag overwrites --allow-jit false.

But those functions don't have any error handling, so not a lot we can do about this in the meantime.

Nov 19 2020, 12:45 PM

Nov 18 2020

kastiglione accepted D91669: Don’t break before nested block param when prior param is not a block.

The purpose and the tests LGTM! Hopefully someone will weigh in on the implementation in ContinuationIndenter.cpp.

Nov 18 2020, 2:17 PM · Restricted Project
kastiglione requested review of D91742: [lldb] Add examples and reword source-map help string.
Nov 18 2020, 2:04 PM · Restricted Project

Nov 11 2020

kastiglione committed rG0783ad9e6a2c: [lldb] Switch expect to runCmd in TestRecursiveTypes (NFC) (authored by kastiglione).
[lldb] Switch expect to runCmd in TestRecursiveTypes (NFC)
Nov 11 2020, 4:18 PM
kastiglione closed D91206: [lldb] Switch expect to runCmd in TestRecursiveTypes (NFC).
Nov 11 2020, 4:17 PM · Restricted Project
kastiglione updated the diff for D91206: [lldb] Switch expect to runCmd in TestRecursiveTypes (NFC).

Remove bogus message.

Nov 11 2020, 10:07 AM · Restricted Project
kastiglione added a comment to D91193: [lldb] Fine tune expect() validation.

Thanks for pointing this in the right direction @labath, @teemperor.

Nov 11 2020, 10:05 AM · Restricted Project

Nov 10 2020

kastiglione abandoned D91193: [lldb] Fine tune expect() validation.
Nov 10 2020, 4:42 PM · Restricted Project
kastiglione requested review of D91206: [lldb] Switch expect to runCmd in TestRecursiveTypes (NFC).
Nov 10 2020, 2:00 PM · Restricted Project
kastiglione added a comment to D91193: [lldb] Fine tune expect() validation.

That's much better. I'll change those callers can be changed to runCmd.

Nov 10 2020, 12:53 PM · Restricted Project
kastiglione added a comment to D91193: [lldb] Fine tune expect() validation.

@teemperor maybe? Do you mean validation should go in runCmd? Or do you mean something else?

Nov 10 2020, 12:32 PM · Restricted Project
kastiglione requested review of D91193: [lldb] Fine tune expect() validation.
Nov 10 2020, 11:37 AM · Restricted Project

Nov 6 2020

kastiglione accepted D90857: [lldb] add a missing dependency on intrinsics_gen.
Nov 6 2020, 8:16 AM · Restricted Project

Nov 5 2020

kastiglione added a reviewer for D90857: [lldb] add a missing dependency on intrinsics_gen: michele.scandale.
Nov 5 2020, 4:07 PM · Restricted Project

Oct 26 2020

kastiglione accepted D89439: [cmake] Add LLVM_UBSAN_FLAGS, to allow overriding UBSan flags.

thanks for correcting my misunderstanding

Oct 26 2020, 3:33 PM · Restricted Project
kastiglione added inline comments to D89439: [cmake] Add LLVM_UBSAN_FLAGS, to allow overriding UBSan flags.
Oct 26 2020, 10:52 AM · Restricted Project

Oct 19 2020

kastiglione accepted D89302: [lldb] Also Catch invalid calls to TestPExpectTest's expect().
Oct 19 2020, 9:58 AM · Restricted Project

Oct 17 2020

kastiglione committed rGae4fe1984f0e: [lldb] Enable cmake policy CMP0077 for option() (authored by kastiglione).
[lldb] Enable cmake policy CMP0077 for option()
Oct 17 2020, 12:16 AM
kastiglione closed D89614: [lldb] Enable cmake policy CMP0077 for option().
Oct 17 2020, 12:16 AM · Restricted Project
kastiglione added a reverting change for rG0ff9116b3678: Register TargetCXXABI.def as a textual header: rG5564ee495bdd: Revert "Register TargetCXXABI.def as a textual header".
Oct 17 2020, 12:16 AM
kastiglione committed rG5564ee495bdd: Revert "Register TargetCXXABI.def as a textual header" (authored by kastiglione).
Revert "Register TargetCXXABI.def as a textual header"
Oct 17 2020, 12:15 AM

Oct 16 2020

kastiglione requested review of D89614: [lldb] Enable cmake policy CMP0077 for option().
Oct 16 2020, 11:08 PM · Restricted Project
kastiglione added a comment to D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

Name suggestion: -prepend_rpath or -insert_initial_rpath. By itself, "insert" feels like it should take a position to say where it insert.

Oct 16 2020, 6:10 PM · Restricted Project
kastiglione committed rGf16cecf3752a: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName() (authored by kastiglione).
[lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName()
Oct 16 2020, 2:24 PM
kastiglione closed D89589: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName().
Oct 16 2020, 2:24 PM · Restricted Project
kastiglione requested review of D89589: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName().
Oct 16 2020, 1:09 PM · Restricted Project

Oct 14 2020

kastiglione added a reverting change for rG73c6beb2f705: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex: rG4cb4db11ee13: Revert "[ASTImporter] Fix crash caused by unset AttributeSpellingListIndex".
Oct 14 2020, 5:22 PM
kastiglione committed rG4cb4db11ee13: Revert "[ASTImporter] Fix crash caused by unset AttributeSpellingListIndex" (authored by kastiglione).
Revert "[ASTImporter] Fix crash caused by unset AttributeSpellingListIndex"
Oct 14 2020, 5:22 PM
kastiglione added a reverting change for D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex: rG4cb4db11ee13: Revert "[ASTImporter] Fix crash caused by unset AttributeSpellingListIndex".
Oct 14 2020, 5:22 PM · Restricted Project
kastiglione added a comment to D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex.

Reverted here: 4cb4db11ee1323c5d4bf66d21deb046970f4e516

Oct 14 2020, 5:22 PM · Restricted Project
kastiglione added a comment to D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex.

@martong here's a partial backtrace:

Oct 14 2020, 4:17 PM · Restricted Project
kastiglione added a comment to D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex.

@martong hi, this caused a test regression. In TestImportBuiltinFileID.py, this unreachable assertion is hit:

Oct 14 2020, 4:12 PM · Restricted Project

Oct 13 2020

kastiglione committed rG41f946a6d2a4: [cmake] Limit missing external lit warning to be shown once (authored by kastiglione).
[cmake] Limit missing external lit warning to be shown once
Oct 13 2020, 9:04 PM
kastiglione closed D89356: [cmake] Limit missing external lit warning to be shown once.
Oct 13 2020, 9:03 PM · Restricted Project
kastiglione accepted D89352: [lldb] Unconditionally strip the `.py(c)` extension as we always import Python modules.
Oct 13 2020, 7:26 PM · Restricted Project
kastiglione added inline comments to D89356: [cmake] Limit missing external lit warning to be shown once.
Oct 13 2020, 7:09 PM · Restricted Project
kastiglione updated the diff for D89356: [cmake] Limit missing external lit warning to be shown once.

Use type INTERNAL

Oct 13 2020, 7:09 PM · Restricted Project
kastiglione updated the diff for D89356: [cmake] Limit missing external lit warning to be shown once.

else/if -> elseif

Oct 13 2020, 6:32 PM · Restricted Project
kastiglione updated the summary of D89356: [cmake] Limit missing external lit warning to be shown once.
Oct 13 2020, 6:31 PM · Restricted Project
kastiglione added a reviewer for D89356: [cmake] Limit missing external lit warning to be shown once: teemperor.
Oct 13 2020, 6:31 PM · Restricted Project
kastiglione requested review of D89356: [cmake] Limit missing external lit warning to be shown once.
Oct 13 2020, 6:29 PM · Restricted Project
kastiglione accepted D89343: [cmake] Unconditionally set the force flag when codesigning.

This doesn't require a ld64 version check, and it's a much less invasive cmake change.

Oct 13 2020, 4:40 PM · Restricted Project
kastiglione added inline comments to D89334: [lldb] Support Python imports relative the to the current file being sourced.
Oct 13 2020, 12:24 PM · Restricted Project
kastiglione added a comment to D89334: [lldb] Support Python imports relative the to the current file being sourced.

Would you mind adding a couple tests for imports via a path to a python file, ex command script import command.py, maybe even a test that checks nested directories, ex: command script import path/to/command.py?

Oct 13 2020, 12:22 PM · Restricted Project
kastiglione added a comment to D89295: [lldb] Add $HOME to Python's sys.path.

I don't think it's that unreasonable to do the same for $HOME to be able to use imports relative to the .lldbinit file in both cases.

Oct 13 2020, 8:46 AM
kastiglione added a comment to D89295: [lldb] Add $HOME to Python's sys.path.

(and whether we should make this implicit a relative path vs for example some kind of placeholder 'variable' or something like that).

Oct 13 2020, 8:35 AM
kastiglione added a comment to D89295: [lldb] Add $HOME to Python's sys.path.

For lldbinit files, and any file that gets command source'd, I think it would be useful if they could perform command script import some/path/to/command.py, where some is resolved relative to the dirname of the lldb file. For example, given an lldbinit file at my/project/scripts/project.lldb, it could load a python at my/project/scripts/commands/my.py by running command script import commands/my.py.

Oct 13 2020, 8:27 AM
kastiglione added a comment to D89295: [lldb] Add $HOME to Python's sys.path.

That actually seems to work (if you add .py to the end).

Oct 13 2020, 8:18 AM
kastiglione accepted D89305: [lldb] Replace TestAbortExitCode with a debugserver specific test.

Thanks

Oct 13 2020, 8:16 AM · Restricted Project

Oct 12 2020

kastiglione added a comment to D89295: [lldb] Add $HOME to Python's sys.path.

Could this have undesirable side effects? I wouldn't expect command script import to be searching my home dir. Second question: is there value in requiring the explicit use of ~, for ex: command script import ~/path.

Oct 12 2020, 11:20 PM
kastiglione committed rG08924b54debc: [lldb] Remove unused code in GetVersion (NFC) (authored by kastiglione).
[lldb] Remove unused code in GetVersion (NFC)
Oct 12 2020, 4:31 PM
kastiglione closed D88939: [lldb] Remove unused code in GetVersion (NFC).
Oct 12 2020, 4:31 PM · Restricted Project
kastiglione committed rGa52cc9b4be36: [lldb] Handle alternative output in TestAbortExitCode (authored by kastiglione).
[lldb] Handle alternative output in TestAbortExitCode
Oct 12 2020, 4:30 PM
kastiglione closed D89273: [lldb] Handle alternative output in TestAbortExitCode.
Oct 12 2020, 4:30 PM · Restricted Project
kastiglione added a reviewer for D89273: [lldb] Handle alternative output in TestAbortExitCode: teemperor.
Oct 12 2020, 3:08 PM · Restricted Project
kastiglione requested review of D89273: [lldb] Handle alternative output in TestAbortExitCode.
Oct 12 2020, 2:50 PM · Restricted Project

Oct 7 2020

kastiglione updated the diff for D88939: [lldb] Remove unused code in GetVersion (NFC).

Update commit message

Oct 7 2020, 8:50 AM · Restricted Project
kastiglione added a comment to D88939: [lldb] Remove unused code in GetVersion (NFC).

@teemperor I removed the comment and restored repository handling. It becomes much more of a useless diff :)

Oct 7 2020, 8:44 AM · Restricted Project
kastiglione updated the summary of D88939: [lldb] Remove unused code in GetVersion (NFC).
Oct 7 2020, 8:43 AM · Restricted Project
kastiglione updated the diff for D88939: [lldb] Remove unused code in GetVersion (NFC).

Restore repository handling

Oct 7 2020, 8:43 AM · Restricted Project
kastiglione accepted D88950: [lldb][cmake] Remove custom logic for finding VCS file to fix LLDB's VCSVersion.inc generation.
Oct 7 2020, 7:44 AM · Restricted Project

Oct 6 2020

kastiglione added inline comments to D88939: [lldb] Remove unused code in GetVersion (NFC).
Oct 6 2020, 7:16 PM · Restricted Project
kastiglione updated the diff for D88939: [lldb] Remove unused code in GetVersion (NFC).

switch NULL to ""

Oct 6 2020, 7:12 PM · Restricted Project
kastiglione updated the diff for D88939: [lldb] Remove unused code in GetVersion (NFC).

Unbreak code

Oct 6 2020, 6:59 PM · Restricted Project
kastiglione requested review of D88939: [lldb] Remove unused code in GetVersion (NFC).
Oct 6 2020, 6:25 PM · Restricted Project

Oct 5 2020

kastiglione added a comment to D88840: [dotest] Simplify logic to find the Python path.

About -P, the man page for lldb and the driver's Options.td say it:

Oct 5 2020, 7:13 PM · Restricted Project
kastiglione committed rG010d7a388b14: [lldb/test] Catch invalid calls to expect() (authored by kastiglione).
[lldb/test] Catch invalid calls to expect()
Oct 5 2020, 12:42 PM
kastiglione closed D88792: [lldb/test] Catch invalid calls to expect().
Oct 5 2020, 12:42 PM · Restricted Project
kastiglione updated the diff for D88792: [lldb/test] Catch invalid calls to expect().

"missing a matcher" -> "missing a matcher argument"

Oct 5 2020, 10:09 AM · Restricted Project
kastiglione added inline comments to D88792: [lldb/test] Catch invalid calls to expect().
Oct 5 2020, 10:07 AM · Restricted Project
kastiglione updated the summary of D88792: [lldb/test] Catch invalid calls to expect().
Oct 5 2020, 10:05 AM · Restricted Project
kastiglione added inline comments to D88792: [lldb/test] Catch invalid calls to expect().
Oct 5 2020, 10:05 AM · Restricted Project
kastiglione updated the diff for D88792: [lldb/test] Catch invalid calls to expect().

Resyntax the isinstance asserts; Add expect() tests

Oct 5 2020, 10:04 AM · Restricted Project

Oct 3 2020

kastiglione requested review of D88792: [lldb/test] Catch invalid calls to expect().
Oct 3 2020, 11:03 PM · Restricted Project
kastiglione added inline comments to D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata.
Oct 3 2020, 8:42 AM · Restricted Project

Sep 30 2020

kastiglione added a comment to D88581: [lldb] Symlink the Clang resource directory to the LLDB build directory in standalone builds.

I must have missed something, isn't this embedded the installed path of the clang resource dir? The diff description says "i.e., building just LLDB against an existing LLVM/Clang installation". I agree that embedding a build path is bad, but embedding clang's installed path seems legit.

Sep 30 2020, 12:39 PM · Restricted Project
kastiglione accepted D88581: [lldb] Symlink the Clang resource directory to the LLDB build directory in standalone builds.

Nice fix. Every time I see issues with the relative resource directory heuristic, I think "someone should improve that".

Sep 30 2020, 8:57 AM · Restricted Project

Sep 29 2020

kastiglione committed rG5d19eb542db4: [lldb/docs] Remove manual codesigning documentation (authored by kastiglione).
[lldb/docs] Remove manual codesigning documentation
Sep 29 2020, 12:51 PM
kastiglione closed D88257: [lldb/docs] Remove manual codesigning documentation.
Sep 29 2020, 12:51 PM · Restricted Project

Sep 24 2020

kastiglione added a comment to D88257: [lldb/docs] Remove manual codesigning documentation.

I agree it's nice to have somewhere, but git history should be fine. I should elaborate on motivations, 1. ensure everyone is using the script so that any issues are surfaced, 2. prevent missteps in the manual process, which may also be bit rotting if everyone is using the script.

Sep 24 2020, 1:55 PM · Restricted Project
kastiglione requested review of D88257: [lldb/docs] Remove manual codesigning documentation.
Sep 24 2020, 1:03 PM · Restricted Project
kastiglione added inline comments to D88129: Add "break delete --disabled" to delete all currently disabled breakpoints.
Sep 24 2020, 10:44 AM · Restricted Project
kastiglione committed rGada1e2ffa117: [lldb/examples] Add missing declaration in heap.py (authored by kastiglione).
[lldb/examples] Add missing declaration in heap.py
Sep 24 2020, 8:46 AM
kastiglione closed D88158: [lldb/examples] Add missing declaration in heap.py.
Sep 24 2020, 8:45 AM · Restricted Project

Sep 23 2020

kastiglione added inline comments to D88129: Add "break delete --disabled" to delete all currently disabled breakpoints.
Sep 23 2020, 4:03 PM · Restricted Project
kastiglione added inline comments to D88129: Add "break delete --disabled" to delete all currently disabled breakpoints.
Sep 23 2020, 2:55 PM · Restricted Project
kastiglione accepted D88181: Utility: ignore OS version on non-Darwin targets in `ArchSpec`.

sgtm

Sep 23 2020, 2:38 PM · Restricted Project
kastiglione added inline comments to D88129: Add "break delete --disabled" to delete all currently disabled breakpoints.
Sep 23 2020, 12:16 PM · Restricted Project