- User Since
- Aug 14 2015, 10:30 PM (423 w, 3 d)
Wed, Sep 20
Could we fix that, so the SmallVector formatter is only used for SmallVector objects, not pointers?
Tue, Aug 29
Thanks for doing this!
Aug 23 2023
Aug 21 2023
Aug 15 2023
Aug 3 2023
Aug 1 2023
Jul 20 2023
Jul 19 2023
Redo ValueObjectDynamicValue::UpdateValue changes based on upstream testing
Jul 13 2023
@Michael137 I'll wait a week before merging, in case any issues arise in your usage. These days I haven't been crossing paths with many DenseMap instances, so my beta testing has been zero.
Thanks, I will disable these for now, and see what can be done to address the issues we've seen.
@broadwaylamb hi, have you been using the PointerUnion formatter? We have seen a variety of issues, which don't seem to have easy fixes. If you're not using it, I will disable it. Alternatively, I propose creating a separate file that you and others could choose to import separately from lldbDataFormatters.py.
Jul 12 2023
Add -e to expand DenseMap children
Jul 11 2023
Change bool IsSwift() to LanguageType GetImplementationLanguage()
Refactor for better API layering
Remove the DenseSet logic, which I had wrong
Fix range(N) to list(range(N))
- Add logic to recognize DenseSet, in which case all buckets are printed
- Change the summary to call out when a single tombstone is present in the children
Jul 7 2023
Jul 6 2023
Jul 3 2023
Jun 30 2023
Remove FUNCTION from FormatManager logs
Restore static_cast<void *>() because of -Wformat-pedantic
Include formatter kind ("format", "summary", "synthetic") to FormatManager logs
Jun 29 2023
I just gave __PRETTY_FUNCTION__ a test drive, and it's a bit verbose/noisy: For example:
Jun 28 2023
I wonder if we should hint in all 3 command objects (expr, frame var and DWIM) or if we should limit this to DWIM instead (since DWIM is the one aliased to p and po and I don't think vo or expr -O are often used unintentionally).
This was superseded by D145276.
Jun 27 2023
I will try to reproduce.
Jun 26 2023
Jun 25 2023
Jun 23 2023
Jun 16 2023
Jun 15 2023
Jun 13 2023
Jun 12 2023
Jun 9 2023
Jun 7 2023
Jun 5 2023
+1 to a test
Jun 2 2023
To expand the conversation, I have also opened D152031 which makes the same change to GetChildAtIndex.
correction: there's still an overload of GetChildAtNamePath, which takes a can_create value and passes it through to GetChildMemberWithName. However that function isn't used, and could be deleted. To delete the parameter, that overload of GetChildMemberWithName would need to be deleted too. In general, I'm still in favor of the conservative choice of giving it a default. Deleting it altogether is an easy follow up, if so desired.
Jun 1 2023
That's an option too, which I considered. I went with this as a more
conservative change. If there's agreement to remove it then I can change it.
Change auto to StringRef