Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

kastiglione (Dave Lee)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2015, 10:30 PM (423 w, 3 d)

Recent Activity

Wed, Sep 20

kastiglione added a comment to D157961: [llvm][utils] Fix SmallVector formatter when type is a pointer.

Could we fix that, so the SmallVector formatter is only used for SmallVector objects, not pointers?

Wed, Sep 20, 2:59 PM · Restricted Project, Restricted Project
kastiglione added a comment to D158663: [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC).

Merged in https://github.com/llvm/llvm-project/pull/66949

Wed, Sep 20, 2:24 PM · Restricted Project, Restricted Project

Tue, Aug 29

kastiglione added inline comments to D159142: [lldb] Add support for recognizing swift ast sections in object files.
Tue, Aug 29, 2:57 PM · Restricted Project, Restricted Project
kastiglione added a comment to D159127: [lldb][libc++] Adds chrono data formatters..

Thanks for doing this!

Tue, Aug 29, 1:34 PM · Restricted Project, Restricted Project

Aug 23 2023

kastiglione requested review of D158663: [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC).
Aug 23 2023, 12:57 PM · Restricted Project, Restricted Project

Aug 21 2023

kastiglione accepted D158470: [lldb] Add support for recognizing swift mangled names.
Aug 21 2023, 8:57 PM · Restricted Project, Restricted Project

Aug 15 2023

kastiglione committed rG6c36a70828d9: [clang] Fix f7f3e68419 (NFC) (authored by kastiglione).
[clang] Fix f7f3e68419 (NFC)
Aug 15 2023, 10:36 AM · Restricted Project, Restricted Project
kastiglione committed rGf7f3e6841968: [clang] Fix CCC_OVERRIDE_OPTIONS docstring to say "space separated" (NFC) (authored by kastiglione).
[clang] Fix CCC_OVERRIDE_OPTIONS docstring to say "space separated" (NFC)
Aug 15 2023, 10:33 AM · Restricted Project, Restricted Project
kastiglione accepted D157961: [llvm][utils] Fix SmallVector formatter when type is a pointer.
Aug 15 2023, 10:16 AM · Restricted Project, Restricted Project

Aug 3 2023

kastiglione added inline comments to D157041: [lldb] Protect OptionValue accesses from data races.
Aug 3 2023, 4:25 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D157041: [lldb] Protect OptionValue accesses from data races.
Aug 3 2023, 4:22 PM · Restricted Project, Restricted Project

Aug 1 2023

kastiglione accepted D153489: [lldb] Print hint if object description is requested but not implemented.
Aug 1 2023, 2:32 PM · Restricted Project, Restricted Project

Jul 20 2023

kastiglione committed rGb8580ef717af: [llvm][utils] Use literal type name for non-template data formatters (NFC) (authored by kastiglione).
[llvm][utils] Use literal type name for non-template data formatters (NFC)
Jul 20 2023, 7:34 PM · Restricted Project, Restricted Project
kastiglione committed rGa6ff60ecdd06: [lldb] Delete unused LibcxxOptionalSummaryProvider (NFC) (authored by kastiglione).
[lldb] Delete unused LibcxxOptionalSummaryProvider (NFC)
Jul 20 2023, 7:33 PM · Restricted Project
kastiglione committed rGe19339f5f8c1: [lldb] Identify Swift-implemented ObjC classes (authored by kastiglione).
[lldb] Identify Swift-implemented ObjC classes
Jul 20 2023, 7:32 PM · Restricted Project
kastiglione closed D152837: [lldb] Identify Swift-implemented ObjC classes.
Jul 20 2023, 7:32 PM · Restricted Project, Restricted Project

Jul 19 2023

kastiglione updated the diff for D152837: [lldb] Identify Swift-implemented ObjC classes.

Redo ValueObjectDynamicValue::UpdateValue changes based on upstream testing

Jul 19 2023, 1:27 PM · Restricted Project, Restricted Project
kastiglione committed rG78c9122ac9ad: [llvm][utils] Add DenseMap data formatters (authored by kastiglione).
[llvm][utils] Add DenseMap data formatters
Jul 19 2023, 1:22 PM · Restricted Project, Restricted Project
kastiglione closed D137028: [llvm][utils] Add DenseMap data formatters.
Jul 19 2023, 1:22 PM · Restricted Project, Restricted Project

Jul 13 2023

kastiglione committed rGf0acfaf92418: [llvm][utils] Disable lldb formatters for PointerIntPair and PointerUnion (authored by kastiglione).
[llvm][utils] Disable lldb formatters for PointerIntPair and PointerUnion
Jul 13 2023, 3:52 PM · Restricted Project, Restricted Project
kastiglione closed D155219: [llvm][utils] Disable lldb formatters for PointerIntPair and PointerUnion.
Jul 13 2023, 3:51 PM · Restricted Project, Restricted Project
kastiglione added a comment to D137028: [llvm][utils] Add DenseMap data formatters.

@Michael137 I'll wait a week before merging, in case any issues arise in your usage. These days I haven't been crossing paths with many DenseMap instances, so my beta testing has been zero.

Jul 13 2023, 10:13 AM · Restricted Project, Restricted Project
kastiglione requested review of D155219: [llvm][utils] Disable lldb formatters for PointerIntPair and PointerUnion.
Jul 13 2023, 10:09 AM · Restricted Project, Restricted Project
kastiglione added a comment to D117779: [LLDB] Add formatters for PointerIntPair, PointerUnion.

Thanks, I will disable these for now, and see what can be done to address the issues we've seen.

Jul 13 2023, 9:56 AM · Restricted Project, Restricted Project
Herald added a project to D117779: [LLDB] Add formatters for PointerIntPair, PointerUnion: Restricted Project.

@broadwaylamb hi, have you been using the PointerUnion formatter? We have seen a variety of issues, which don't seem to have easy fixes. If you're not using it, I will disable it. Alternatively, I propose creating a separate file that you and others could choose to import separately from lldbDataFormatters.py.

Jul 13 2023, 7:31 AM · Restricted Project, Restricted Project

Jul 12 2023

kastiglione updated the diff for D137028: [llvm][utils] Add DenseMap data formatters.

Add -e to expand DenseMap children

Jul 12 2023, 10:23 AM · Restricted Project, Restricted Project

Jul 11 2023

kastiglione updated the diff for D152837: [lldb] Identify Swift-implemented ObjC classes.

Change bool IsSwift() to LanguageType GetImplementationLanguage()

Jul 11 2023, 7:19 PM · Restricted Project, Restricted Project
kastiglione added a comment to D152837: [lldb] Identify Swift-implemented ObjC classes.

@bulbazord @augusto2112 hopefully this is a quick review.

Jul 11 2023, 2:51 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D152837: [lldb] Identify Swift-implemented ObjC classes.

Refactor for better API layering

Jul 11 2023, 1:22 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D137028: [llvm][utils] Add DenseMap data formatters.

Remove the DenseSet logic, which I had wrong

Jul 11 2023, 11:15 AM · Restricted Project, Restricted Project
kastiglione updated the diff for D137028: [llvm][utils] Add DenseMap data formatters.

Fix range(N) to list(range(N))

Jul 11 2023, 10:58 AM · Restricted Project, Restricted Project
kastiglione updated the diff for D137028: [llvm][utils] Add DenseMap data formatters.
  • Add logic to recognize DenseSet, in which case all buckets are printed
  • Change the summary to call out when a single tombstone is present in the children
Jul 11 2023, 10:50 AM · Restricted Project, Restricted Project

Jul 7 2023

kastiglione added inline comments to D153489: [lldb] Print hint if object description is requested but not implemented.
Jul 7 2023, 11:01 AM · Restricted Project, Restricted Project

Jul 6 2023

kastiglione added inline comments to D153489: [lldb] Print hint if object description is requested but not implemented.
Jul 6 2023, 3:23 PM · Restricted Project, Restricted Project

Jul 3 2023

kastiglione committed rG6977c1caf43f: [lldb] Remove old commented out code (NFC) (authored by kastiglione).
[lldb] Remove old commented out code (NFC)
Jul 3 2023, 2:41 PM · Restricted Project

Jun 30 2023

kastiglione committed rGb43375bb8195: [lldb] Add log indicating which kind of data formatter (authored by kastiglione).
[lldb] Add log indicating which kind of data formatter
Jun 30 2023, 4:51 PM · Restricted Project
kastiglione closed D154128: [lldb] Add log indicating which kind of data formatter.
Jun 30 2023, 4:51 PM · Restricted Project, Restricted Project
kastiglione committed rG2c37cbef5821: [lldb] Delete RewriteObjCClassReferences (NFC) (authored by kastiglione).
[lldb] Delete RewriteObjCClassReferences (NFC)
Jun 30 2023, 2:39 PM · Restricted Project
kastiglione closed D153802: [lldb] Delete RewriteObjCClassReferences (NFC).
Jun 30 2023, 2:39 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D154128: [lldb] Add log indicating which kind of data formatter.

Remove FUNCTION from FormatManager logs

Jun 30 2023, 11:55 AM · Restricted Project, Restricted Project
kastiglione updated the diff for D154128: [lldb] Add log indicating which kind of data formatter.

Restore static_cast<void *>() because of -Wformat-pedantic

Jun 30 2023, 10:01 AM · Restricted Project, Restricted Project
kastiglione updated the diff for D154128: [lldb] Add log indicating which kind of data formatter.

Include formatter kind ("format", "summary", "synthetic") to FormatManager logs

Jun 30 2023, 9:54 AM · Restricted Project, Restricted Project

Jun 29 2023

kastiglione added a comment to D154128: [lldb] Add log indicating which kind of data formatter.

I just gave __PRETTY_FUNCTION__ a test drive, and it's a bit verbose/noisy: For example:

Jun 29 2023, 12:59 PM · Restricted Project, Restricted Project
kastiglione requested review of D154128: [lldb] Add log indicating which kind of data formatter.
Jun 29 2023, 11:17 AM · Restricted Project, Restricted Project

Jun 28 2023

kastiglione added inline comments to D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch.
Jun 28 2023, 1:14 PM · Restricted Project, Restricted Project
kastiglione accepted D153905: [lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer.
Jun 28 2023, 10:50 AM · Restricted Project, Restricted Project
kastiglione accepted D153840: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate..
Jun 28 2023, 10:39 AM · Restricted Project, Restricted Project
kastiglione accepted D153810: [lldb][NFCI] TypeSystemClang::CreateStructForIdentifier should take a StringRef.
Jun 28 2023, 10:31 AM · Restricted Project, Restricted Project
kastiglione added inline comments to D153489: [lldb] Print hint if object description is requested but not implemented.
Jun 28 2023, 10:30 AM · Restricted Project, Restricted Project
kastiglione added a comment to D153489: [lldb] Print hint if object description is requested but not implemented.

I wonder if we should hint in all 3 command objects (expr, frame var and DWIM) or if we should limit this to DWIM instead (since DWIM is the one aliased to p and po and I don't think vo or expr -O are often used unintentionally).

Jun 28 2023, 10:30 AM · Restricted Project, Restricted Project
kastiglione added inline comments to D153489: [lldb] Print hint if object description is requested but not implemented.
Jun 28 2023, 10:28 AM · Restricted Project, Restricted Project
kastiglione abandoned D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC).

This was superseded by D145276.

Jun 28 2023, 10:15 AM · Restricted Project, Restricted Project

Jun 27 2023

kastiglione committed rG8ce2d90f1e80: [lldb] Fix search & replace mistake in IRForTarget comment (NFC) (authored by kastiglione).
[lldb] Fix search & replace mistake in IRForTarget comment (NFC)
Jun 27 2023, 6:38 PM · Restricted Project
kastiglione committed rG6feb35bac59e: [lldb] Improve log message (NFC) (authored by kastiglione).
[lldb] Improve log message (NFC)
Jun 27 2023, 6:32 PM · Restricted Project
kastiglione added inline comments to D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments.
Jun 27 2023, 3:35 PM · Restricted Project, Restricted Project
kastiglione committed rG86fd957af981: [lldb] Duplicate Target::Launch resuming logic into… (authored by kastiglione).
[lldb] Duplicate Target::Launch resuming logic into…
Jun 27 2023, 3:30 PM · Restricted Project
kastiglione closed D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch.
Jun 27 2023, 3:30 PM · Restricted Project, Restricted Project
kastiglione updated subscribers of D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments.

Thanks to @jingham's help in identifying this issue, I have opened https://reviews.llvm.org/D153922 as a potential fix for the issue on macOS.

Jun 27 2023, 2:29 PM · Restricted Project, Restricted Project
kastiglione requested review of D153922: [lldb] Duplicate Target::Launch resuming logic into CommandObjectPlatformProcessLaunch.
Jun 27 2023, 2:27 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments.
Jun 27 2023, 2:11 PM · Restricted Project, Restricted Project
kastiglione added a comment to D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments.

I will try to reproduce.

Jun 27 2023, 9:46 AM · Restricted Project, Restricted Project

Jun 26 2023

kastiglione requested review of D153802: [lldb] Delete RewriteObjCClassReferences (NFC).
Jun 26 2023, 12:05 PM · Restricted Project, Restricted Project

Jun 25 2023

kastiglione committed rG080fa1ee38d6: [lldb] Use LLDB_LOGF for printf format strings in AppleObjCDeclVendor.cpp (authored by kastiglione).
[lldb] Use LLDB_LOGF for printf format strings in AppleObjCDeclVendor.cpp
Jun 25 2023, 8:27 AM · Restricted Project

Jun 23 2023

kastiglione added a comment to D153648: [lldb] Remove broken shared cache duplicate class handling.

and that the one that won will indeed be in that list but will not be marked as a duplicate.

Jun 23 2023, 1:02 PM · Restricted Project, Restricted Project
kastiglione requested review of D153648: [lldb] Remove broken shared cache duplicate class handling.
Jun 23 2023, 10:47 AM · Restricted Project, Restricted Project

Jun 16 2023

kastiglione committed rGf2a1320c2ff5: [lldb] De-virtualize applicable functions in ValueObject (NFC) (authored by kastiglione).
[lldb] De-virtualize applicable functions in ValueObject (NFC)
Jun 16 2023, 11:13 AM · Restricted Project
kastiglione closed D153088: [lldb] De-virtualize applicable functions in ValueObject (NFC).
Jun 16 2023, 11:12 AM · Restricted Project, Restricted Project

Jun 15 2023

kastiglione requested review of D153088: [lldb] De-virtualize applicable functions in ValueObject (NFC).
Jun 15 2023, 5:43 PM · Restricted Project, Restricted Project

Jun 13 2023

kastiglione committed rGa1a74f7cdea3: [lldb] Default can_create to true in GetChildAtIndex (NFC) (authored by kastiglione).
[lldb] Default can_create to true in GetChildAtIndex (NFC)
Jun 13 2023, 3:51 PM · Restricted Project
kastiglione closed D152031: [lldb] Default can_create to true in GetChildAtIndex (NFC).
Jun 13 2023, 3:51 PM · Restricted Project, Restricted Project
kastiglione committed rG7d4fcd411b3d: [lldb] Default can_create to true in GetChildMemberWithName (NFC) (authored by kastiglione).
[lldb] Default can_create to true in GetChildMemberWithName (NFC)
Jun 13 2023, 11:38 AM · Restricted Project
kastiglione closed D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC).
Jun 13 2023, 11:37 AM · Restricted Project, Restricted Project
kastiglione added inline comments to D152837: [lldb] Identify Swift-implemented ObjC classes.
Jun 13 2023, 11:06 AM · Restricted Project, Restricted Project
kastiglione requested review of D152837: [lldb] Identify Swift-implemented ObjC classes.
Jun 13 2023, 10:38 AM · Restricted Project, Restricted Project

Jun 12 2023

kastiglione added inline comments to D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources.
Jun 12 2023, 5:52 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources.
Jun 12 2023, 5:48 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D152590: Streamline expression parser error messages.
Jun 12 2023, 10:32 AM · Restricted Project, Restricted Project

Jun 9 2023

kastiglione added inline comments to D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources.
Jun 9 2023, 12:45 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources.
Jun 9 2023, 12:43 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources.
Jun 9 2023, 12:42 PM · Restricted Project, Restricted Project

Jun 7 2023

kastiglione accepted D152409: [lldb] Never print children if the max depth has been reached.
Jun 7 2023, 4:55 PM · Restricted Project, Restricted Project
kastiglione accepted D151950: [lldb] Unconditionally increment depth when printing children.

thanks!

Jun 7 2023, 4:53 PM · Restricted Project, Restricted Project

Jun 5 2023

kastiglione added a comment to D151950: [lldb] Unconditionally increment depth when printing children.

+1 to a test

Jun 5 2023, 4:37 PM · Restricted Project, Restricted Project

Jun 2 2023

kastiglione added a comment to D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC).

To expand the conversation, I have also opened D152031 which makes the same change to GetChildAtIndex.

Jun 2 2023, 1:54 PM · Restricted Project, Restricted Project
kastiglione requested review of D152031: [lldb] Default can_create to true in GetChildAtIndex (NFC).
Jun 2 2023, 1:53 PM · Restricted Project, Restricted Project
kastiglione added a comment to D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC).

correction: there's still an overload of GetChildAtNamePath, which takes a can_create value and passes it through to GetChildMemberWithName. However that function isn't used, and could be deleted. To delete the parameter, that overload of GetChildMemberWithName would need to be deleted too. In general, I'm still in favor of the conservative choice of giving it a default. Deleting it altogether is an easy follow up, if so desired.

Jun 2 2023, 1:51 PM · Restricted Project, Restricted Project
kastiglione accepted D152010: [lldb][NFCI] ConstString methods should take StringRefs by value.
Jun 2 2023, 11:29 AM · Restricted Project, Restricted Project
kastiglione added inline comments to D152010: [lldb][NFCI] ConstString methods should take StringRefs by value.
Jun 2 2023, 10:31 AM · Restricted Project, Restricted Project
kastiglione added inline comments to D152010: [lldb][NFCI] ConstString methods should take StringRefs by value.
Jun 2 2023, 10:24 AM · Restricted Project, Restricted Project

Jun 1 2023

kastiglione updated subscribers of D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC).

That's an option too, which I considered. I went with this as a more
conservative change. If there's agreement to remove it then I can change it.

Jun 1 2023, 11:14 PM · Restricted Project, Restricted Project
kastiglione requested review of D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC).
Jun 1 2023, 9:14 PM · Restricted Project, Restricted Project
kastiglione committed rG00e52cc4a8cc: [lldb] Take StringRef names in GetChildAtNamePath (NFC) (authored by kastiglione).
[lldb] Take StringRef names in GetChildAtNamePath (NFC)
Jun 1 2023, 8:42 PM · Restricted Project
kastiglione closed D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC).
Jun 1 2023, 8:42 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC).

Change auto to StringRef

Jun 1 2023, 8:27 PM · Restricted Project, Restricted Project
kastiglione committed rG5dae706259da: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC) (authored by kastiglione).
[lldb] Take StringRef name in GetIndexOfChildWithName (NFC)
Jun 1 2023, 8:24 PM · Restricted Project
kastiglione closed D151811: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC).
Jun 1 2023, 8:24 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D151811: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC).
Jun 1 2023, 8:23 PM · Restricted Project, Restricted Project

May 31 2023

kastiglione committed rG57c122d0ea1d: [lldb] Take StringRef name in GetIndexOfChildMemberWithName (NFC) (authored by kastiglione).
[lldb] Take StringRef name in GetIndexOfChildMemberWithName (NFC)
May 31 2023, 11:03 AM · Restricted Project
kastiglione closed D151810: [lldb] Take StringRef name in GetIndexOfChildMemberWithName (NFC).
May 31 2023, 11:03 AM · Restricted Project, Restricted Project
kastiglione added inline comments to D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC).
May 31 2023, 10:37 AM · Restricted Project, Restricted Project