- User Since
- Aug 14 2015, 10:30 PM (305 w, 3 d)
Is there a utility for exec'ing a command without a shell? Seems this could also be solved by avoiding a shell altogether.
Tue, Jun 15
Wed, Jun 2
thanks for your help. As you suggested, using a #line directive and viewing the IR generated by clang, led to showing how to change the file via DILexicalBlockFile.
Test new logic in coro-async.ll
Tue, Jun 1
There is a second .resume.1, thanks I hadn't noticed that, I'll see if I can use that.
Thu, May 27
following up here, looks like test/Transforms/Coroutines/coro-async.ll is the test that has the right "existing testcase" however it looks like I need to duplicate the whole thing and then tweak it. That test covers the SP->getFile() == DL->getFile() case, and if I change it by "artificially changing a suspend point's !dbg location to use a different file name", then it will instead test cover the inverted case (SP->getFile() != DL->getFile()).
May 20 2021
@thakis thanks for pointing that out. I had tried -Wall using the clang included with the latest version of Xcode, and that does not enable -Wmisleading-indentation. I see from the compiler explorer that recent clang versions do include misleading indentation diagnostics with -Wall. It seems worth keeping in until an Xcode release includes it with -Wall.
May 17 2021
only propagate scope line when files are the same
I've updated this to follow this advice:
Change logic to be based on current scope line, not current filename.
May 15 2021
use "accepted" as the verb
May 14 2021
May 13 2021
May 10 2021
Will keep an eye on buildbots, thanks.
May 7 2021
Didn't mean to self-accept this, so I resigned as reviewer.
Enable for llvm.
@dblaikie I have checked lldb, it builds cleanly. In the downstream swift branch of lldb there were a couple issues.
@Tyker in case you didn't see my previous message, I'm curious if you'd be willing to take a look at the bug. Thanks!
May 5 2021
Apr 29 2021
I changed direction, to ensure the impl pointer is always non-null.
Ensure m_impl_up is always non-null
I should expand this to fix other unchecked dereferences.
Apr 23 2021
Apr 22 2021
I guess wait until the dust on https://reviews.llvm.org/D101037 settles?
Apr 19 2021
I like it, though I'm not sure about the python3 requirement.
Apr 16 2021
other than the clang-tidy note about the capitalization of rpath, lgtm
Apr 6 2021
For reformat commits, what are your thoughts on adding the shas in .git-blame-ignore-revs?
Generally we try pretty hard to be -Werror clean for clang at least (& some folks do so for gcc too)
friendly ping @jingham
- I've updated the summary to include wording from the original diff D98224 which points out that -Werror=return-type is used in libcxx, libcxxabi, and libunwind.
- Warnings have a spectrum of severity, -Wreturn-type is one of the most severe, but turning on -Werror for more mundane warnings would be a deal breaker for some projects. I think it's more reasonable to turn errors on individually, rather than require a codebase to be all or nothing.
- There are already other -Werror=... in this same file, so there is precedent.
Apr 4 2021
Apr 2 2021
Apr 1 2021
s/lldb alias/pdb alias
Indent source block
Mar 31 2021
Mar 29 2021
Mar 22 2021
Mar 19 2021
Mar 16 2021
Mar 15 2021
Mar 12 2021
Mar 10 2021
@xbolva00 yes I plan to do that. I'll quickly check into the gcc situation first, and but may just re-enable it for clang.
Reverted because some versions of gcc can emit -Wreturn-type warnings on functions that have exhaustive switches over enums. A fix is to use llvm_unreachable but that's not currently done everywhere (and also seems like a poor/unnecessary practice).
Jim previously approved this offline.
Mar 9 2021
thanks. I reverted my module change 736afe465f4216f55372a907d7288910f9de6bea
Mar 8 2021
I pushed f1b690598eeca0568e39134f28e0a59c1c1f3598 as a fix or temporary fix.
Mar 7 2021
@Tyker Hi, I noticed a case that isn't caught by -Wmisleading-indentation. In code that uses two space indents, there's a corner case that isn't caught when the preceding if uses curly braces. I've noticed a couple instances of this in lldb.