Page MenuHomePhabricator

kastiglione (Dave Lee)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2015, 10:30 PM (213 w, 5 d)

Recent Activity

Jul 9 2019

kastiglione committed rG90148db02a5b: [Docs] Replace SVN revisions with lldb versions (authored by kastiglione).
[Docs] Replace SVN revisions with lldb versions
Jul 9 2019, 2:25 PM
kastiglione committed rL365559: [Docs] Replace SVN revisions with lldb versions.
[Docs] Replace SVN revisions with lldb versions
Jul 9 2019, 2:25 PM
kastiglione closed D61778: [Docs] Replace SVN revisions with lldb versions.
Jul 9 2019, 2:25 PM · Restricted Project, Restricted Project

May 9 2019

kastiglione updated the summary of D61778: [Docs] Replace SVN revisions with lldb versions.
May 9 2019, 11:54 PM · Restricted Project, Restricted Project
kastiglione created D61778: [Docs] Replace SVN revisions with lldb versions.
May 9 2019, 11:54 PM · Restricted Project, Restricted Project

Apr 4 2019

kastiglione added a comment to D60252: [dwarfdump] Make -arch accept alternative spellings.

Sounds good @aprantl

Apr 4 2019, 8:57 AM · Restricted Project
kastiglione abandoned D60252: [dwarfdump] Make -arch accept alternative spellings.
Apr 4 2019, 8:55 AM · Restricted Project

Apr 3 2019

kastiglione updated the diff for D60252: [dwarfdump] Make -arch accept alternative spellings.

Remove unintended changes.

Apr 3 2019, 11:34 PM · Restricted Project
kastiglione created D60252: [dwarfdump] Make -arch accept alternative spellings.
Apr 3 2019, 11:31 PM · Restricted Project

Mar 10 2019

kastiglione committed rG0affb5822f12: Quiet command regex instructions during batch execution (authored by kastiglione).
Quiet command regex instructions during batch execution
Mar 10 2019, 4:17 PM
kastiglione added a comment to D48752: Quiet command regex instructions during batch execution.

Thanks for reviewing @clayborg.

Mar 10 2019, 4:17 PM · Restricted Project
kastiglione committed rL355793: Quiet command regex instructions during batch execution.
Quiet command regex instructions during batch execution
Mar 10 2019, 4:17 PM
kastiglione committed rLLDB355793: Quiet command regex instructions during batch execution.
Quiet command regex instructions during batch execution
Mar 10 2019, 4:17 PM
kastiglione closed D48752: Quiet command regex instructions during batch execution.
Mar 10 2019, 4:17 PM · Restricted Project
kastiglione added a comment to D59101: [SBAPI] Log from record macro.

I'm getting build failures that appear to be caused by this patch. I'm compiling on macOS with Xcode 10.1. The failures are uses of LLDB_RECORD_DUMMY(), passing a callback function pointer as one of the args. This results in errors like:

Mar 10 2019, 3:25 PM · Restricted Project

Feb 27 2019

kastiglione added a comment to D48752: Quiet command regex instructions during batch execution.

@clayborg this has been updated the approach you suggested, adding an interactive parameter.

Feb 27 2019, 11:10 AM · Restricted Project

Feb 16 2019

kastiglione updated the diff for D48752: Quiet command regex instructions during batch execution.

Add interactive parameter

Feb 16 2019, 12:18 AM · Restricted Project

Feb 15 2019

kastiglione added a comment to D48798: llvm-nm: Observe -no-llvm-bc for archive members.

Thanks @compnerd!

Feb 15 2019, 11:00 PM · Restricted Project
kastiglione committed rG5fc9edf6bb59: llvm-nm: Observe -no-llvm-bc for archive members (authored by kastiglione).
llvm-nm: Observe -no-llvm-bc for archive members
Feb 15 2019, 11:00 PM
kastiglione committed rL354196: llvm-nm: Observe -no-llvm-bc for archive members.
llvm-nm: Observe -no-llvm-bc for archive members
Feb 15 2019, 10:59 PM
kastiglione closed D48798: llvm-nm: Observe -no-llvm-bc for archive members.
Feb 15 2019, 10:59 PM · Restricted Project

Jan 18 2019

kastiglione added a comment to D48798: llvm-nm: Observe -no-llvm-bc for archive members.

@pcc I have this fix related to -no-llvm-bc (D4371). I'm looking for a reviewer: could you review, or could you suggest someone? Thanks.

Jan 18 2019, 2:22 PM · Restricted Project

Nov 27 2018

kastiglione added a comment to D48798: llvm-nm: Observe -no-llvm-bc for archive members.

@compnerd would you be willing to accept?

Nov 27 2018, 8:22 PM · Restricted Project
kastiglione updated the summary of D48798: llvm-nm: Observe -no-llvm-bc for archive members.
Nov 27 2018, 7:11 PM · Restricted Project
kastiglione added a comment to D48752: Quiet command regex instructions during batch execution.

@jingham If you're still willing to review this change to command regex, it is updated per our previous discussion, thanks.

Nov 27 2018, 7:04 PM · Restricted Project

Nov 4 2018

kastiglione added a comment to D49776: Update framework-header-fix to force system sed.

@keith I screwed up and committed without amending the commit message to attribute you as the author :(

Nov 4 2018, 8:02 AM
kastiglione committed rLLDB346099: Update framework-header-fix to force system sed.
Update framework-header-fix to force system sed
Nov 4 2018, 8:00 AM
kastiglione committed rL346099: Update framework-header-fix to force system sed.
Update framework-header-fix to force system sed
Nov 4 2018, 7:59 AM
kastiglione closed D49776: Update framework-header-fix to force system sed.
Nov 4 2018, 7:59 AM

Nov 3 2018

kastiglione added a comment to D48752: Quiet command regex instructions during batch execution.

There are other commands that print instructions in the same way that command regex does, should they be updated in this change too?

Nov 3 2018, 12:59 AM · Restricted Project
kastiglione updated the diff for D48752: Quiet command regex instructions during batch execution.

Added IOHandlerActivatedInteractively

Nov 3 2018, 12:42 AM · Restricted Project
kastiglione added a comment to D48798: llvm-nm: Observe -no-llvm-bc for archive members.

@smeenai or @compnerd – much late follow up, but either of you willing to accept?

Nov 3 2018, 12:00 AM · Restricted Project

Aug 2 2018

kastiglione updated the diff for D48798: llvm-nm: Observe -no-llvm-bc for archive members.

Fix accidentally changed llvm-nm test invocation

Aug 2 2018, 6:09 PM · Restricted Project
kastiglione updated the diff for D48798: llvm-nm: Observe -no-llvm-bc for archive members.

Update lit setup

Aug 2 2018, 6:07 PM · Restricted Project
kastiglione committed rL338792: objdump: Better handling of Mach-O universal binaries.
objdump: Better handling of Mach-O universal binaries
Aug 2 2018, 5:07 PM
kastiglione closed D48702: objdump: Better handling of Mach-O universal binaries.
Aug 2 2018, 5:07 PM

Jul 26 2018

kastiglione accepted D49776: Update framework-header-fix to force system sed.

LGTM

Jul 26 2018, 7:25 AM

Jul 20 2018

kastiglione added inline comments to D48702: objdump: Better handling of Mach-O universal binaries.
Jul 20 2018, 3:39 PM

Jul 18 2018

kastiglione added inline comments to D48798: llvm-nm: Observe -no-llvm-bc for archive members.
Jul 18 2018, 4:35 PM · Restricted Project

Jul 5 2018

kastiglione updated the diff for D48702: objdump: Better handling of Mach-O universal binaries.

Oops, fix last diff update

Jul 5 2018, 10:24 PM
kastiglione updated the diff for D48702: objdump: Better handling of Mach-O universal binaries.

Make if/else bracing consistent

Jul 5 2018, 10:21 PM
kastiglione committed rL336411: Reapply: "objdump: Support newer ObjC image info flags".
Reapply: "objdump: Support newer ObjC image info flags"
Jul 5 2018, 10:16 PM
kastiglione committed rL336402: Revert "objdump: Support newer ObjC image info flags".
Revert "objdump: Support newer ObjC image info flags"
Jul 5 2018, 5:18 PM
kastiglione added a comment to rL336399: objdump: Support newer ObjC image info flags.

reverting, test is failing on some buildbots

Jul 5 2018, 5:17 PM
kastiglione committed rL336399: objdump: Support newer ObjC image info flags.
objdump: Support newer ObjC image info flags
Jul 5 2018, 4:37 PM
kastiglione closed D48568: objdump: Support newer ObjC image info flags.
Jul 5 2018, 4:37 PM

Jul 4 2018

kastiglione committed rL336287: Fix and simplify lldb.command decorator.
Fix and simplify lldb.command decorator
Jul 4 2018, 9:16 AM
kastiglione closed D48658: Fix and simplify lldb.command decorator.
Jul 4 2018, 9:16 AM

Jul 2 2018

kastiglione committed rL336126: nm: Add -no-weak flag for hiding weak symbols.
nm: Add -no-weak flag for hiding weak symbols
Jul 2 2018, 10:29 AM
kastiglione closed D48751: nm: Add -no-weak flag for hiding weak symbols.
Jul 2 2018, 10:29 AM

Jul 1 2018

kastiglione updated the summary of D48658: Fix and simplify lldb.command decorator.
Jul 1 2018, 12:00 PM
kastiglione updated the diff for D48658: Fix and simplify lldb.command decorator.

Add tests and make command_name optional

Jul 1 2018, 11:58 AM

Jun 30 2018

kastiglione added a comment to D48751: nm: Add -no-weak flag for hiding weak symbols.

Can you also document -no-weak in docs/CommandGuide/llvm-nm.rst?

Jun 30 2018, 11:04 PM
kastiglione updated the diff for D48798: llvm-nm: Observe -no-llvm-bc for archive members.

Use %t instead of %T

Jun 30 2018, 10:51 PM · Restricted Project
kastiglione updated the diff for D48798: llvm-nm: Observe -no-llvm-bc for archive members.

Fixup test

Jun 30 2018, 3:55 PM · Restricted Project
kastiglione added inline comments to D48798: llvm-nm: Observe -no-llvm-bc for archive members.
Jun 30 2018, 12:30 AM · Restricted Project
kastiglione updated the diff for D48798: llvm-nm: Observe -no-llvm-bc for archive members.

Remove hardcoded bitcode from test

Jun 30 2018, 12:26 AM · Restricted Project

Jun 29 2018

kastiglione added a reviewer for D48798: llvm-nm: Observe -no-llvm-bc for archive members: pcc.
Jun 29 2018, 11:26 PM · Restricted Project
kastiglione created D48798: llvm-nm: Observe -no-llvm-bc for archive members.
Jun 29 2018, 11:22 PM · Restricted Project
kastiglione updated the diff for D48568: objdump: Support newer ObjC image info flags.

test without binaries

Jun 29 2018, 8:30 PM
kastiglione accepted D48751: nm: Add -no-weak flag for hiding weak symbols.

Accepting with the following reasoning: This is consistent with the existing filtering by other symbol kinds, and is opt-in/non-breaking.

Jun 29 2018, 4:37 PM
kastiglione added inline comments to D48751: nm: Add -no-weak flag for hiding weak symbols.
Jun 29 2018, 12:03 PM
kastiglione added a comment to D48752: Quiet command regex instructions during batch execution.

if the IOHandlerDelegate could say whether it wants to be notified for IOHandlerActivated when non-interactive (like have a "ShouldNotifyWhenNonInteractive" method), and then the IOHandler could dispatch it or not based on the response to that method

Jun 29 2018, 11:55 AM · Restricted Project
kastiglione planned changes to D48658: Fix and simplify lldb.command decorator.
Jun 29 2018, 11:50 AM
kastiglione planned changes to D48568: objdump: Support newer ObjC image info flags.

For tests, instead of yaml2obj, I'll generate object files via llvm-mc.

Jun 29 2018, 11:50 AM

Jun 28 2018

kastiglione created D48752: Quiet command regex instructions during batch execution.
Jun 28 2018, 4:38 PM · Restricted Project

Jun 27 2018

kastiglione created D48702: objdump: Better handling of Mach-O universal binaries.
Jun 27 2018, 9:14 PM
kastiglione added a comment to D48658: Fix and simplify lldb.command decorator.

@clayborg I'll dig into how python-extensions.swig gets tested, and add something accordingly.

Jun 27 2018, 4:27 PM
kastiglione updated subscribers of D48658: Fix and simplify lldb.command decorator.
Jun 27 2018, 10:51 AM
kastiglione updated subscribers of D48658: Fix and simplify lldb.command decorator.

Thanks @granata.enrico, sorry for the disruption, I noticed previous comments after I had submitted this.

Jun 27 2018, 10:01 AM
kastiglione updated the diff for D48658: Fix and simplify lldb.command decorator.

Update a comment

Jun 27 2018, 9:56 AM
kastiglione created D48658: Fix and simplify lldb.command decorator.
Jun 27 2018, 9:53 AM
kastiglione abandoned D48656: Fix and simplify lldb.command decorator.
Jun 27 2018, 9:53 AM
kastiglione updated the diff for D48656: Fix and simplify lldb.command decorator.

update

Jun 27 2018, 9:53 AM
kastiglione abandoned D48656: Fix and simplify lldb.command decorator.
Jun 27 2018, 9:40 AM
kastiglione created D48656: Fix and simplify lldb.command decorator.
Jun 27 2018, 9:40 AM

Jun 26 2018

kastiglione committed rL335709: Fix a single typo in SBSymbolContext.
Fix a single typo in SBSymbolContext
Jun 26 2018, 11:51 PM
kastiglione closed D48620: Fix a single typo in SBSymbolContext.
Jun 26 2018, 11:51 PM
kastiglione created D48620: Fix a single typo in SBSymbolContext.
Jun 26 2018, 11:14 PM
kastiglione added a comment to D48568: objdump: Support newer ObjC image info flags.

@compnerd The mach-o flavor of yaml2obj doesn't support section contents. In light of that, what do you think?

Jun 26 2018, 8:56 AM

Jun 25 2018

kastiglione added a comment to D48568: objdump: Support newer ObjC image info flags.

Yep for sure. I will update the tests.

Jun 25 2018, 2:22 PM
kastiglione created D48568: objdump: Support newer ObjC image info flags.
Jun 25 2018, 2:11 PM

Jun 13 2018

kastiglione abandoned D34321: Fix overstrict validation of Mach-O rebase opcode.
Jun 13 2018, 9:46 PM
kastiglione abandoned D34909: Driver: consume -nostdinc++ along with -nostdinc.
Jun 13 2018, 9:46 PM

Nov 17 2017

kastiglione committed rL318529: Fix skipping of flags in getClangStripDependencyFileAdjuster.
Fix skipping of flags in getClangStripDependencyFileAdjuster
Nov 17 2017, 8:28 AM
kastiglione closed D40024: Fix skipping of flags in getClangStripDependencyFileAdjuster by committing rL318529: Fix skipping of flags in getClangStripDependencyFileAdjuster.
Nov 17 2017, 8:28 AM

Nov 16 2017

kastiglione committed rL318433: Add ELF dynamic symbol support to yaml2obj/obj2yaml.
Add ELF dynamic symbol support to yaml2obj/obj2yaml
Nov 16 2017, 10:11 AM
kastiglione closed D39582: Add ELF dynamic symbol support to yaml2obj/obj2yaml by committing rL318433: Add ELF dynamic symbol support to yaml2obj/obj2yaml.
Nov 16 2017, 10:11 AM
kastiglione committed rL318428: Allow empty mappings for optional YAML input.
Allow empty mappings for optional YAML input
Nov 16 2017, 9:47 AM
kastiglione closed D39908: Allow empty mappings for optional YAML input by committing rL318428: Allow empty mappings for optional YAML input.
Nov 16 2017, 9:47 AM

Nov 15 2017

kastiglione updated the diff for D39908: Allow empty mappings for optional YAML input.

inline if condition

Nov 15 2017, 11:42 PM
kastiglione updated the diff for D40024: Fix skipping of flags in getClangStripDependencyFileAdjuster.

Add tests

Nov 15 2017, 11:19 PM

Nov 14 2017

kastiglione updated the summary of D39908: Allow empty mappings for optional YAML input.
Nov 14 2017, 3:43 PM
kastiglione added reviewers for D39908: Allow empty mappings for optional YAML input: mehdi_amini, pcc.
Nov 14 2017, 2:21 PM
kastiglione added a reviewer for D40024: Fix skipping of flags in getClangStripDependencyFileAdjuster: alexshap.
Nov 14 2017, 10:12 AM
kastiglione added a reviewer for D39908: Allow empty mappings for optional YAML input: kledzik.
Nov 14 2017, 8:58 AM
kastiglione committed rL318152: Make isDefinition matcher support ObjCMethodDecl.
Make isDefinition matcher support ObjCMethodDecl
Nov 14 2017, 6:19 AM
kastiglione closed D39948: Make isDefinition matcher support ObjCMethodDecl by committing rL318152: Make isDefinition matcher support ObjCMethodDecl.
Nov 14 2017, 6:19 AM
kastiglione updated the diff for D39948: Make isDefinition matcher support ObjCMethodDecl.

Regenerate AST Matcher docs

Nov 14 2017, 6:15 AM
kastiglione updated the diff for D39948: Make isDefinition matcher support ObjCMethodDecl.

Update isDefinition comment docs to reflect addition of ObjCMethodDecl

Nov 14 2017, 6:13 AM