Page MenuHomePhabricator

kastiglione (Dave Lee)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2015, 10:30 PM (305 w, 3 d)

Recent Activity

Today

kastiglione added a comment to D104653: [lldb] Explicitly prefer a vanilla shell (zsh, bash, sh) over the user's default shell when running `xcrun`.

Is there a utility for exec'ing a command without a shell? Seems this could also be solved by avoiding a shell altogether.

Mon, Jun 21, 2:35 PM · Restricted Project
kastiglione accepted D104377: [lldb] Don't try to set -Wno-deprecated-declarations.

thanks!

Mon, Jun 21, 2:02 PM · Restricted Project

Tue, Jun 15

kastiglione accepted D100662: [lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect template parameters.
Tue, Jun 15, 10:04 AM · Restricted Project

Wed, Jun 2

kastiglione added a comment to D102412: [coro] Preserve scope line for compiler generated functions.

thanks for your help. As you suggested, using a #line directive and viewing the IR generated by clang, led to showing how to change the file via DILexicalBlockFile.

Wed, Jun 2, 3:58 PM · Restricted Project
kastiglione committed rG60ce8babf77e: [coro] Preserve scope line for compiler generated functions (authored by kastiglione).
[coro] Preserve scope line for compiler generated functions
Wed, Jun 2, 3:57 PM
kastiglione closed D102412: [coro] Preserve scope line for compiler generated functions.
Wed, Jun 2, 3:57 PM · Restricted Project
kastiglione updated the diff for D102412: [coro] Preserve scope line for compiler generated functions.

Test new logic in coro-async.ll

Wed, Jun 2, 2:07 PM · Restricted Project

Tue, Jun 1

kastiglione added a comment to D102412: [coro] Preserve scope line for compiler generated functions.

There is a second .resume.1, thanks I hadn't noticed that, I'll see if I can use that.

Tue, Jun 1, 10:21 AM · Restricted Project

Thu, May 27

kastiglione added a comment to D102412: [coro] Preserve scope line for compiler generated functions.

following up here, looks like test/Transforms/Coroutines/coro-async.ll is the test that has the right "existing testcase" however it looks like I need to duplicate the whole thing and then tweak it. That test covers the SP->getFile() == DL->getFile() case, and if I change it by "artificially changing a suspend point's !dbg location to use a different file name", then it will instead test cover the inverted case (SP->getFile() != DL->getFile()).

Thu, May 27, 3:18 PM · Restricted Project

May 20 2021

kastiglione added a comment to D102092: [lldb] Enable -Wmisleading-indentation.

@thakis thanks for pointing that out. I had tried -Wall using the clang included with the latest version of Xcode, and that does not enable -Wmisleading-indentation. I see from the compiler explorer that recent clang versions do include misleading indentation diagnostics with -Wall. It seems worth keeping in until an Xcode release includes it with -Wall.

May 20 2021, 11:38 AM · Restricted Project, Restricted Project

May 17 2021

kastiglione updated the diff for D102412: [coro] Preserve scope line for compiler generated functions.

only propagate scope line when files are the same

May 17 2021, 5:56 PM · Restricted Project
kastiglione added inline comments to D102412: [coro] Preserve scope line for compiler generated functions.
May 17 2021, 5:48 PM · Restricted Project
kastiglione added inline comments to D102412: [coro] Preserve scope line for compiler generated functions.
May 17 2021, 12:59 PM · Restricted Project
kastiglione added a comment to D102412: [coro] Preserve scope line for compiler generated functions.

I've updated this to follow this advice:

May 17 2021, 12:58 PM · Restricted Project
kastiglione updated the diff for D102412: [coro] Preserve scope line for compiler generated functions.

Change logic to be based on current scope line, not current filename.

May 17 2021, 12:55 PM · Restricted Project
kastiglione committed rG02286d96dbb3: [lldb] Document ctrl-f for completing show-autosuggestion (authored by kastiglione).
[lldb] Document ctrl-f for completing show-autosuggestion
May 17 2021, 12:52 PM
kastiglione closed D102544: [lldb] Document ctrl-f for completing show-autosuggestion.
May 17 2021, 12:52 PM · Restricted Project

May 15 2021

kastiglione updated the diff for D102544: [lldb] Document ctrl-f for completing show-autosuggestion.

use "accepted" as the verb

May 15 2021, 8:57 AM · Restricted Project

May 14 2021

kastiglione requested review of D102544: [lldb] Document ctrl-f for completing show-autosuggestion.
May 14 2021, 6:14 PM · Restricted Project

May 13 2021

kastiglione requested review of D102412: [coro] Preserve scope line for compiler generated functions.
May 13 2021, 9:15 AM · Restricted Project

May 10 2021

kastiglione added a comment to D102092: [lldb] Enable -Wmisleading-indentation.

Will keep an eye on buildbots, thanks.

May 10 2021, 9:57 AM · Restricted Project, Restricted Project
kastiglione committed rGf44c6f20f5e9: [cmake] Enable -Wmisleading-indentation (authored by kastiglione).
[cmake] Enable -Wmisleading-indentation
May 10 2021, 9:56 AM
kastiglione closed D102092: [lldb] Enable -Wmisleading-indentation.
May 10 2021, 9:56 AM · Restricted Project, Restricted Project

May 7 2021

kastiglione added a comment to D102092: [lldb] Enable -Wmisleading-indentation.

Didn't mean to self-accept this, so I resigned as reviewer.

May 7 2021, 3:43 PM · Restricted Project, Restricted Project
kastiglione resigned from D102092: [lldb] Enable -Wmisleading-indentation.
May 7 2021, 3:43 PM · Restricted Project, Restricted Project
kastiglione accepted D102092: [lldb] Enable -Wmisleading-indentation.
May 7 2021, 3:42 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D102092: [lldb] Enable -Wmisleading-indentation.

Enable for llvm.

May 7 2021, 3:42 PM · Restricted Project, Restricted Project
kastiglione added a comment to D102092: [lldb] Enable -Wmisleading-indentation.

@dblaikie I have checked lldb, it builds cleanly. In the downstream swift branch of lldb there were a couple issues.

May 7 2021, 3:05 PM · Restricted Project, Restricted Project
kastiglione requested review of D102092: [lldb] Enable -Wmisleading-indentation.
May 7 2021, 2:22 PM · Restricted Project, Restricted Project
kastiglione added a comment to D70638: [Diagnostic] add a warning which warns about misleading indentation.

@Tyker in case you didn't see my previous message, I'm curious if you'd be willing to take a look at the bug. Thanks!

May 7 2021, 11:14 AM · Restricted Project

May 5 2021

kastiglione committed rGc5cf4b8f11cd: [lldb] Handle missing SBStructuredData copy assignment cases (authored by kastiglione).
[lldb] Handle missing SBStructuredData copy assignment cases
May 5 2021, 3:12 PM
kastiglione closed D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null.
May 5 2021, 3:12 PM · Restricted Project
kastiglione updated the diff for D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null.

Add unittest

May 5 2021, 3:09 PM · Restricted Project

Apr 29 2021

kastiglione added inline comments to D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null.
Apr 29 2021, 5:25 PM · Restricted Project
kastiglione added a comment to D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null.

I changed direction, to ensure the impl pointer is always non-null.

Apr 29 2021, 5:25 PM · Restricted Project
kastiglione retitled D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null from [lldb] Handle missing SBStructuredData copy assignment cases to [lldb] Ensure SBStructuredData::m_impl_up is always non-null.
Apr 29 2021, 5:24 PM · Restricted Project
kastiglione updated the diff for D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null.

Ensure m_impl_up is always non-null

Apr 29 2021, 5:22 PM · Restricted Project
kastiglione added a comment to D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null.

I should expand this to fix other unchecked dereferences.

Apr 29 2021, 4:44 PM · Restricted Project
kastiglione requested review of D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null.
Apr 29 2021, 4:06 PM · Restricted Project
kastiglione added inline comments to D101537: [lldb] Make the NSSet formatter faster and less prone to infinite recursion.
Apr 29 2021, 9:44 AM · Restricted Project

Apr 23 2021

kastiglione added a comment to D99825: [cmake] Enable -Werror=return-type for clang.

@aaron.ballman's point that maybe this should be -Werror by default in clang sounds plausible - because not all projects will be using -Werror, etc. If that helps some users who work on LLVM itself but don't want to turn on -Werror (not sure why - the buildbots will do it and so things will break/you'll have to fix stuff if you're not building with -Werror using a fairly recent clang) that's OK.

Apr 23 2021, 4:19 PM · Restricted Project
kastiglione committed rG638d84b60b7e: [cmake] Configure policy CMP0116 (authored by kastiglione).
[cmake] Configure policy CMP0116
Apr 23 2021, 8:58 AM
kastiglione closed D101083: [cmake] Configure policy CMP0116.
Apr 23 2021, 8:57 AM · Restricted Project

Apr 22 2021

kastiglione added a comment to D100692: clang-tidy: discover binaries in build dir.

I guess wait until the dust on https://reviews.llvm.org/D101037 settles?

Apr 22 2021, 10:15 AM · Restricted Project
kastiglione requested review of D101083: [cmake] Configure policy CMP0116.
Apr 22 2021, 10:13 AM · Restricted Project

Apr 19 2021

kastiglione added a comment to D100692: clang-tidy: discover binaries in build dir.

I like it, though I'm not sure about the python3 requirement.

Apr 19 2021, 9:00 AM · Restricted Project

Apr 16 2021

kastiglione accepted D100681: llvm-objdump: add --rpaths to macho support.

other than the clang-tidy note about the capitalization of rpath, lgtm

Apr 16 2021, 4:36 PM · Restricted Project

Apr 6 2021

kastiglione added a comment to rGdc8d63de5d5e: [lldb] Format Plugins/Language/ObjC/Cocoa.cpp (NFC).

For reformat commits, what are your thoughts on adding the shas in .git-blame-ignore-revs?

Apr 6 2021, 3:38 PM
kastiglione added a comment to D99825: [cmake] Enable -Werror=return-type for clang.

Generally we try pretty hard to be -Werror clean for clang at least (& some folks do so for gcc too)

Apr 6 2021, 2:42 PM · Restricted Project
kastiglione added a comment to D96715: [lldb] Decouple IsMasterPlan and OkayToDiscard (NFC).

friendly ping @jingham

Apr 6 2021, 11:30 AM · Restricted Project
kastiglione added a comment to D99825: [cmake] Enable -Werror=return-type for clang.
  1. I've updated the summary to include wording from the original diff D98224 which points out that -Werror=return-type is used in libcxx, libcxxabi, and libunwind.
  2. Warnings have a spectrum of severity, -Wreturn-type is one of the most severe, but turning on -Werror for more mundane warnings would be a deal breaker for some projects. I think it's more reasonable to turn errors on individually, rather than require a codebase to be all or nothing.
  3. There are already other -Werror=... in this same file, so there is precedent.
Apr 6 2021, 11:00 AM · Restricted Project
kastiglione updated the summary of D99825: [cmake] Enable -Werror=return-type for clang.
Apr 6 2021, 10:55 AM · Restricted Project

Apr 4 2021

kastiglione committed rGd1a1798e51a3: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC) (authored by kastiglione).
[lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC)
Apr 4 2021, 8:05 PM
kastiglione closed D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC).
Apr 4 2021, 8:05 PM · Restricted Project
kastiglione committed rG10ed479d7303: [lldb] Import ObjectiveC module instead of Foundation in test (authored by kastiglione).
[lldb] Import ObjectiveC module instead of Foundation in test
Apr 4 2021, 8:05 PM
kastiglione closed D99859: [lldb] Import ObjectiveC module instead of Foundation in test (NFC).
Apr 4 2021, 8:04 PM · Restricted Project
kastiglione added inline comments to D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC).
Apr 4 2021, 4:09 PM · Restricted Project
kastiglione updated the diff for D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC).

fix lldb/test/API/commands/frame/recognizer/main.m

Apr 4 2021, 4:08 PM · Restricted Project
kastiglione requested review of D99867: [lldb] Replace unneeded use of Foundation with ObjectiveC in tests (NFC).
Apr 4 2021, 2:58 PM · Restricted Project
kastiglione retitled D99859: [lldb] Import ObjectiveC module instead of Foundation in test (NFC) from [lldb] Import ObjectiveC module instead of Foundation in test to [lldb] Import ObjectiveC module instead of Foundation in test (NFC).
Apr 4 2021, 2:51 PM · Restricted Project
kastiglione requested review of D99859: [lldb] Import ObjectiveC module instead of Foundation in test (NFC).
Apr 4 2021, 8:31 AM · Restricted Project

Apr 2 2021

kastiglione requested review of D99825: [cmake] Enable -Werror=return-type for clang.
Apr 2 2021, 5:58 PM · Restricted Project

Apr 1 2021

kastiglione committed rG0c653d4c3d14: [lldb] Update test.rst with a paragraph about pdb (authored by kastiglione).
[lldb] Update test.rst with a paragraph about pdb
Apr 1 2021, 9:53 AM
kastiglione closed D99744: [lldb] Update test.rst with a paragraph about pdb.
Apr 1 2021, 9:53 AM · Restricted Project
kastiglione updated the diff for D99744: [lldb] Update test.rst with a paragraph about pdb.

s/lldb alias/pdb alias

Apr 1 2021, 9:47 AM · Restricted Project
kastiglione added inline comments to D99744: [lldb] Update test.rst with a paragraph about pdb.
Apr 1 2021, 9:43 AM · Restricted Project
kastiglione updated the diff for D99744: [lldb] Update test.rst with a paragraph about pdb.

Indent source block

Apr 1 2021, 9:43 AM · Restricted Project
kastiglione requested review of D99744: [lldb] Update test.rst with a paragraph about pdb.
Apr 1 2021, 9:31 AM · Restricted Project

Mar 31 2021

kastiglione added inline comments to D99693: Update the linkage name of coro-split functions where applicable.
Mar 31 2021, 5:07 PM · Restricted Project

Mar 29 2021

kastiglione committed rG50a6aa6c0f6d: [llvm][utils] Fix handling of llvm::None (authored by kastiglione).
[llvm][utils] Fix handling of llvm::None
Mar 29 2021, 5:44 PM

Mar 22 2021

kastiglione accepted D99077: [ASTImporter] Fix import of ObjCPropertyDecl that share the same name.

nice fix!

Mar 22 2021, 8:08 AM · Restricted Project

Mar 19 2021

kastiglione accepted D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY.

🚢

Mar 19 2021, 2:53 PM · Restricted Project
kastiglione added inline comments to D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY.
Mar 19 2021, 1:17 PM · Restricted Project

Mar 16 2021

kastiglione added inline comments to D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC).
Mar 16 2021, 11:22 AM · Restricted Project

Mar 15 2021

kastiglione added inline comments to D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC).
Mar 15 2021, 3:03 PM · Restricted Project
kastiglione retitled D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC) from [lldb] Refactor to support non-pointer instance variables (NFC) to [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC).
Mar 15 2021, 1:07 PM · Restricted Project
kastiglione updated the summary of D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC).
Mar 15 2021, 12:57 PM · Restricted Project
kastiglione requested review of D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC).
Mar 15 2021, 12:51 PM · Restricted Project

Mar 12 2021

kastiglione committed rGf3b07f9c5d97: [lldb] Remove unused StackFrame::TrackGlobalVariable (authored by kastiglione).
[lldb] Remove unused StackFrame::TrackGlobalVariable
Mar 12 2021, 8:51 AM

Mar 10 2021

kastiglione added a comment to D98224: [cmake] Enable -Werror=return-type.

@xbolva00 yes I plan to do that. I'll quickly check into the gcc situation first, and but may just re-enable it for clang.

Mar 10 2021, 3:11 PM · Restricted Project
kastiglione added a comment to D98224: [cmake] Enable -Werror=return-type.

Reverted because some versions of gcc can emit -Wreturn-type warnings on functions that have exhaustive switches over enums. A fix is to use llvm_unreachable but that's not currently done everywhere (and also seems like a poor/unnecessary practice).

Mar 10 2021, 2:50 PM · Restricted Project
kastiglione added a reverting change for rGce94a161651d: [cmake] Enable -Werror=return-type: rG683e89722aa0: Revert "[cmake] Enable -Werror=return-type".
Mar 10 2021, 2:47 PM
kastiglione committed rG683e89722aa0: Revert "[cmake] Enable -Werror=return-type" (authored by kastiglione).
Revert "[cmake] Enable -Werror=return-type"
Mar 10 2021, 2:47 PM
kastiglione added a reverting change for D98224: [cmake] Enable -Werror=return-type: rG683e89722aa0: Revert "[cmake] Enable -Werror=return-type".
Mar 10 2021, 2:47 PM · Restricted Project
kastiglione committed rGdaf36998694f: [lldb] Ignore linkage diagnostic for LLDBSwigPythonBreakpointCallbackFunction… (authored by kastiglione).
[lldb] Ignore linkage diagnostic for LLDBSwigPythonBreakpointCallbackFunction…
Mar 10 2021, 2:16 PM
kastiglione closed D98368: [lldb] Ignore linkage diagnostic for LLDBSwigPythonBreakpointCallbackFunction (NFC).
Mar 10 2021, 2:16 PM · Restricted Project
kastiglione requested review of D98368: [lldb] Ignore linkage diagnostic for LLDBSwigPythonBreakpointCallbackFunction (NFC).
Mar 10 2021, 12:51 PM · Restricted Project
kastiglione committed rG354d10530d26: [lldb] Fix PushPlan to set subplan to private (authored by kastiglione).
[lldb] Fix PushPlan to set subplan to private
Mar 10 2021, 11:06 AM
kastiglione closed D96916: [lldb] Fix PushPlan to set subplan to private.
Mar 10 2021, 11:06 AM · Restricted Project
kastiglione added a comment to D96916: [lldb] Fix PushPlan to set subplan to private.

Jim previously approved this offline.

Mar 10 2021, 11:04 AM · Restricted Project

Mar 9 2021

kastiglione committed rGce94a161651d: [cmake] Enable -Werror=return-type (authored by kastiglione).
[cmake] Enable -Werror=return-type
Mar 9 2021, 1:51 PM
kastiglione closed D98224: [cmake] Enable -Werror=return-type.
Mar 9 2021, 1:51 PM · Restricted Project
kastiglione added a comment to rGa2a55def354d: Move llvm/Analysis/ObjCARCUtil.h to IR to fix layering..

thanks. I reverted my module change 736afe465f4216f55372a907d7288910f9de6bea

Mar 9 2021, 9:37 AM
kastiglione added a reverting change for rGf1b690598eec: [build][modules] Fix ObjCARCUtil.h modularization: rG736afe465f42: Revert "[build][modules] Fix ObjCARCUtil.h modularization".
Mar 9 2021, 9:37 AM
kastiglione committed rG736afe465f42: Revert "[build][modules] Fix ObjCARCUtil.h modularization" (authored by kastiglione).
Revert "[build][modules] Fix ObjCARCUtil.h modularization"
Mar 9 2021, 9:37 AM

Mar 8 2021

kastiglione committed rG1200f85818d1: [lldb] Remove duplicated ThreadPlanStepOverBreakpoint comment (authored by kastiglione).
[lldb] Remove duplicated ThreadPlanStepOverBreakpoint comment
Mar 8 2021, 10:35 PM
kastiglione requested review of D98224: [cmake] Enable -Werror=return-type.
Mar 8 2021, 5:06 PM · Restricted Project
kastiglione added a comment to rGa2a55def354d: Move llvm/Analysis/ObjCARCUtil.h to IR to fix layering..

I pushed f1b690598eeca0568e39134f28e0a59c1c1f3598 as a fix or temporary fix.

Mar 8 2021, 3:52 PM
kastiglione committed rGf1b690598eec: [build][modules] Fix ObjCARCUtil.h modularization (authored by kastiglione).
[build][modules] Fix ObjCARCUtil.h modularization
Mar 8 2021, 3:52 PM

Mar 7 2021

kastiglione added a comment to D70638: [Diagnostic] add a warning which warns about misleading indentation.

@Tyker Hi, I noticed a case that isn't caught by -Wmisleading-indentation. In code that uses two space indents, there's a corner case that isn't caught when the preceding if uses curly braces. I've noticed a couple instances of this in lldb.

Mar 7 2021, 12:00 PM · Restricted Project