Sounds good @aprantl

Remove unintended changes.

Thanks for reviewing @clayborg.

I'm getting build failures that appear to be caused by this patch. I'm compiling on macOS with Xcode 10.1. The failures are uses of LLDB_RECORD_DUMMY(), passing a callback function pointer as one of the args. This results in errors like:

@clayborg this has been updated the approach you suggested, adding an interactive parameter.

Add interactive parameter

Thanks @compnerd!

@pcc I have this fix related to -no-llvm-bc (D4371). I'm looking for a reviewer: could you review, or could you suggest someone? Thanks.

@compnerd would you be willing to accept?

@jingham If you're still willing to review this change to command regex, it is updated per our previous discussion, thanks.

@keith I screwed up and committed without amending the commit message to attribute you as the author :(

There are other commands that print instructions in the same way that command regex does, should they be updated in this change too?

Added IOHandlerActivatedInteractively

@smeenai or @compnerd – much late follow up, but either of you willing to accept?

Fix accidentally changed llvm-nm test invocation

Update lit setup

LGTM

Oops, fix last diff update

Make if/else bracing consistent

reverting, test is failing on some buildbots

Add tests and make command_name optional

Can you also document -no-weak in docs/CommandGuide/llvm-nm.rst?

Use %t instead of %T

Fixup test

Remove hardcoded bitcode from test

test without binaries

Accepting with the following reasoning: This is consistent with the existing filtering by other symbol kinds, and is opt-in/non-breaking.

if the IOHandlerDelegate could say whether it wants to be notified for IOHandlerActivated when non-interactive (like have a "ShouldNotifyWhenNonInteractive" method), and then the IOHandler could dispatch it or not based on the response to that method

For tests, instead of yaml2obj, I'll generate object files via llvm-mc.

@clayborg I'll dig into how python-extensions.swig gets tested, and add something accordingly.

Thanks @granata.enrico, sorry for the disruption, I noticed previous comments after I had submitted this.

Update a comment

update

@compnerd The mach-o flavor of yaml2obj doesn't support section contents. In light of that, what do you think?

Yep for sure. I will update the tests.

inline if condition

Add tests

Regenerate AST Matcher docs

Update isDefinition comment docs to reflect addition of ObjCMethodDecl