Page MenuHomePhabricator

kastiglione (Dave Lee)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2015, 10:30 PM (358 w, 6 d)

Recent Activity

Tue, Jun 21

kastiglione accepted D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command.

thanks Jim

Tue, Jun 21, 4:30 PM · Restricted Project, Restricted Project

Fri, Jun 17

kastiglione committed rG4cc8f2a017c7: [lldb][tests] Automatically call compute_mydir (NFC) (authored by kastiglione).
[lldb][tests] Automatically call compute_mydir (NFC)
Fri, Jun 17, 2:35 PM · Restricted Project
kastiglione closed D128077: [lldb][tests] Automatically call compute_mydir (NFC).
Fri, Jun 17, 2:35 PM · Restricted Project, Restricted Project
kastiglione requested review of D128077: [lldb][tests] Automatically call compute_mydir (NFC).
Fri, Jun 17, 11:12 AM · Restricted Project, Restricted Project

Thu, Jun 16

kastiglione accepted D127937: [lldb] Add RotatingLogHandler.

lgtm

Thu, Jun 16, 2:26 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D127937: [lldb] Add RotatingLogHandler.
Thu, Jun 16, 11:08 AM · Restricted Project, Restricted Project

Wed, Jun 15

kastiglione committed rGe9349ef9e6d8: Fix `script -lpython` to handle control flow in one-line commands. (authored by kastiglione).
Fix `script -lpython` to handle control flow in one-line commands.
Wed, Jun 15, 10:23 PM · Restricted Project
kastiglione closed D127586: [lldb][Interpreter] Add newline terminal to one-line script calls.
Wed, Jun 15, 10:23 PM · Restricted Project, Restricted Project
kastiglione committed rGe30c493894c4: [lldb] Support non-pointer implicit this/self in… (authored by kastiglione).
[lldb] Support non-pointer implicit this/self in…
Wed, Jun 15, 10:05 PM · Restricted Project
kastiglione closed D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath.
Wed, Jun 15, 10:05 PM · Restricted Project, Restricted Project
kastiglione accepted D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter.

Before this, I didn't realize that quit/exit worked without being a function call. I think it's unfortunate we have to preserve that, but oh well.

Wed, Jun 15, 2:40 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter.
Wed, Jun 15, 1:25 PM · Restricted Project, Restricted Project

Mon, Jun 13

kastiglione added a comment to D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath.

This is good, but it also illustrates how the strings "->" and ".'" should actually come from the typesystem and not be hardcoded. We're just lucky that all languages have a "." operator.

More elegant would be to just add an API to TypeSystem to get the operator to access ivars.

Mon, Jun 13, 4:52 PM · Restricted Project, Restricted Project

Sun, Jun 12

kastiglione updated the diff for D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath.

check valid compiler type

Sun, Jun 12, 4:39 PM · Restricted Project, Restricted Project
kastiglione updated the summary of D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath.
Sun, Jun 12, 12:14 PM · Restricted Project, Restricted Project
kastiglione updated the summary of D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath.
Sun, Jun 12, 12:12 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath.

use explicit type instead of auto

Sun, Jun 12, 12:10 PM · Restricted Project, Restricted Project
kastiglione requested review of D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath.
Sun, Jun 12, 12:08 PM · Restricted Project, Restricted Project

Sat, Jun 11

kastiglione updated the summary of D127586: [lldb][Interpreter] Add newline terminal to one-line script calls.
Sat, Jun 11, 9:07 PM · Restricted Project, Restricted Project
kastiglione requested review of D127586: [lldb][Interpreter] Add newline terminal to one-line script calls.
Sat, Jun 11, 8:58 PM · Restricted Project, Restricted Project
kastiglione committed rGc7a56af3072c: [lldb][bindings] Implement __repr__ instead of __str__ (authored by kastiglione).
[lldb][bindings] Implement __repr__ instead of __str__
Sat, Jun 11, 10:20 AM · Restricted Project
kastiglione closed D127458: [lldb][bindings] Implement __repr__ instead of __str__.
Sat, Jun 11, 10:20 AM · Restricted Project, Restricted Project

Fri, Jun 10

kastiglione updated the diff for D127458: [lldb][bindings] Implement __repr__ instead of __str__.

update TestConvenienceVariables.test

Fri, Jun 10, 11:07 AM · Restricted Project, Restricted Project
kastiglione updated the diff for D127458: [lldb][bindings] Implement __repr__ instead of __str__.

add test/API/sanity/TestReprStrEquality.py

Fri, Jun 10, 10:49 AM · Restricted Project, Restricted Project
kastiglione added a comment to D127458: [lldb][bindings] Implement __repr__ instead of __str__.

Note also that the tests use str() in many places, so we can be sure this hasn't regressed that. I will add a test for repr.

Fri, Jun 10, 9:48 AM · Restricted Project, Restricted Project
kastiglione accepted D127038: Add some documentation for the "breakpoint name" feature.

thank you again

Fri, Jun 10, 9:46 AM · Restricted Project, Restricted Project
kastiglione updated the summary of D127458: [lldb][bindings] Implement __repr__ instead of __str__.
Fri, Jun 10, 9:14 AM · Restricted Project, Restricted Project
kastiglione updated the summary of D127458: [lldb][bindings] Implement __repr__ instead of __str__.
Fri, Jun 10, 9:11 AM · Restricted Project, Restricted Project
kastiglione added a comment to D127458: [lldb][bindings] Implement __repr__ instead of __str__.

@mib I tried but failed to answer that in the original commit description. I have reworded it to be more clear. Here's the relevant paragraph:

Fri, Jun 10, 9:11 AM · Restricted Project, Restricted Project
kastiglione updated the summary of D127458: [lldb][bindings] Implement __repr__ instead of __str__.
Fri, Jun 10, 9:10 AM · Restricted Project, Restricted Project

Thu, Jun 9

kastiglione requested review of D127458: [lldb][bindings] Implement __repr__ instead of __str__.
Thu, Jun 9, 4:53 PM · Restricted Project, Restricted Project
kastiglione committed rG47c4c6a7469f: [lldb] Use assertState in more tests (NFC) (authored by kastiglione).
[lldb] Use assertState in more tests (NFC)
Thu, Jun 9, 4:18 PM · Restricted Project
kastiglione added a comment to D127378: [lldb] Use assertState in more tests (NFC).

@JDevlieghere assertEquals is the deprecated name, assertEqual is the

Thu, Jun 9, 4:18 PM · Restricted Project, Restricted Project
kastiglione closed D127378: [lldb] Use assertState in more tests (NFC).
Thu, Jun 9, 4:18 PM · Restricted Project, Restricted Project

Wed, Jun 8

kastiglione updated the summary of D127378: [lldb] Use assertState in more tests (NFC).
Wed, Jun 8, 10:26 PM · Restricted Project, Restricted Project
kastiglione added a comment to D127355: [lldb] Add assertState function.

nice, I've wanted this too.

Wed, Jun 8, 10:24 PM · Restricted Project, Restricted Project
kastiglione requested review of D127378: [lldb] Use assertState in more tests (NFC).
Wed, Jun 8, 10:24 PM · Restricted Project, Restricted Project
kastiglione accepted D127258: [lldb] Parse the dotest output to determine the most appropriate result code.
Wed, Jun 8, 8:36 AM · Restricted Project, Restricted Project

Tue, Jun 7

kastiglione added a comment to D127258: [lldb] Parse the dotest output to determine the most appropriate result code.

instead of reducing and picking returning a single result, can we return the raw counts and then report the totals of the counts?

Tue, Jun 7, 6:45 PM · Restricted Project, Restricted Project
kastiglione added a comment to D127258: [lldb] Parse the dotest output to determine the most appropriate result code.

That means that if you have a test that has 3 passes and 4 skips, it will be reported as unsupported (while currently it's considered a pass).

Tue, Jun 7, 6:39 PM · Restricted Project, Restricted Project
kastiglione accepted D127258: [lldb] Parse the dotest output to determine the most appropriate result code.
Tue, Jun 7, 3:55 PM · Restricted Project, Restricted Project

Fri, Jun 3

kastiglione added inline comments to D127016: [lldb] Prevent crash due to reading memory from page zero..
Fri, Jun 3, 4:11 PM · Restricted Project, Restricted Project

Wed, Jun 1

kastiglione added inline comments to D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command.
Wed, Jun 1, 11:14 AM · Restricted Project, Restricted Project

Jun 1 2022

kastiglione added a comment to D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command.

I noticed that the example python command and this feature don't support specifying breakpoint locations. Should it?

Jun 1 2022, 9:51 AM · Restricted Project, Restricted Project
kastiglione added a comment to D126789: Stop regex commands from double entry into the history.

thank you for fixing!

Jun 1 2022, 9:44 AM · Restricted Project, Restricted Project
kastiglione accepted D121667: [llvm-cov] Assume repeat architectures for universal binaries.

+1 – it doesn't make sense to have to repeat the same -arch flag and value N times for N binaries.

Jun 1 2022, 9:43 AM · Restricted Project, Restricted Project

May 31 2022

kastiglione accepted D126730: Fix a bug where `break com add -s py -o "some_python" BKPT_NAME` only added the command to the first breakpoint.

thanks!

May 31 2022, 4:08 PM · Restricted Project, Restricted Project

May 24 2022

kastiglione added a comment to D125148: Add an example command that runs to one of a set of breakpoints.

The patch gets a little hard to read with all the no-longer in the right places comments

May 24 2022, 4:47 PM · Restricted Project, Restricted Project

May 23 2022

kastiglione committed rG760298adc264: [lldb] Specify aguments of `image list` (authored by kastiglione).
[lldb] Specify aguments of `image list`
May 23 2022, 11:01 AM · Restricted Project
kastiglione closed D125154: [lldb] Specify aguments of `image list`.
May 23 2022, 11:01 AM · Restricted Project, Restricted Project
kastiglione updated the summary of D125154: [lldb] Specify aguments of `image list`.
May 23 2022, 10:59 AM · Restricted Project, Restricted Project
kastiglione committed rG0da230ff4439: [lldb] Improve formatting of dlopen error messages (NFC) (authored by kastiglione).
[lldb] Improve formatting of dlopen error messages (NFC)
May 23 2022, 10:58 AM · Restricted Project
kastiglione closed D126078: [lldb] Improve formatting of dlopen error messages (NFC).
May 23 2022, 10:58 AM · Restricted Project, Restricted Project

May 20 2022

kastiglione requested review of D126078: [lldb] Improve formatting of dlopen error messages (NFC).
May 20 2022, 10:22 AM · Restricted Project, Restricted Project

May 10 2022

kastiglione added a comment to D125154: [lldb] Specify aguments of `image list`.

@DavidSpickett I might do some follow up work, if so I will add coverage then.

May 10 2022, 1:22 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D125154: [lldb] Specify aguments of `image list`.

add to TestHelp.py

May 10 2022, 1:20 PM · Restricted Project, Restricted Project

May 6 2022

kastiglione requested review of D125154: [lldb] Specify aguments of `image list`.
May 6 2022, 7:08 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D125148: Add an example command that runs to one of a set of breakpoints.
May 6 2022, 7:01 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D125148: Add an example command that runs to one of a set of breakpoints.
May 6 2022, 6:59 PM · Restricted Project, Restricted Project
kastiglione added inline comments to D125148: Add an example command that runs to one of a set of breakpoints.
May 6 2022, 6:04 PM · Restricted Project, Restricted Project

May 5 2022

kastiglione accepted D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0.

thanks for fixing these, especially the lr technique!

May 5 2022, 5:29 PM · Restricted Project, Restricted Project

May 3 2022

kastiglione committed rG2f9fc576be20: [lldb] Add setting for max depth of value object printing (NFC) (authored by kastiglione).
[lldb] Add setting for max depth of value object printing (NFC)
May 3 2022, 10:40 AM · Restricted Project
kastiglione closed D123954: [lldb] Add setting for max depth of value object printing (NFC).
May 3 2022, 10:39 AM · Restricted Project, Restricted Project
kastiglione updated the diff for D123954: [lldb] Add setting for max depth of value object printing (NFC).

Fixed/improved docstring

May 3 2022, 10:21 AM · Restricted Project, Restricted Project
kastiglione updated the diff for D123954: [lldb] Add setting for max depth of value object printing (NFC).

Addresses Adrian's feedback.

May 3 2022, 10:17 AM · Restricted Project, Restricted Project
kastiglione added inline comments to D123954: [lldb] Add setting for max depth of value object printing (NFC).
May 3 2022, 8:59 AM · Restricted Project, Restricted Project

Apr 28 2022

kastiglione added a reviewer for D123954: [lldb] Add setting for max depth of value object printing (NFC): DavidSpickett.
Apr 28 2022, 1:43 PM · Restricted Project, Restricted Project
kastiglione updated the diff for D123954: [lldb] Add setting for max depth of value object printing (NFC).

Fixed: comment formatting; bool logic bug

Apr 28 2022, 10:05 AM · Restricted Project, Restricted Project
kastiglione added inline comments to D123954: [lldb] Add setting for max depth of value object printing (NFC).
Apr 28 2022, 9:49 AM · Restricted Project, Restricted Project

Apr 27 2022

kastiglione added inline comments to D123954: [lldb] Add setting for max depth of value object printing (NFC).
Apr 27 2022, 4:56 PM · Restricted Project, Restricted Project

Apr 26 2022

kastiglione updated the diff for D123954: [lldb] Add setting for max depth of value object printing (NFC).

Updated for code review.

Apr 26 2022, 4:38 PM · Restricted Project, Restricted Project

Apr 22 2022

kastiglione added inline comments to D123954: [lldb] Add setting for max depth of value object printing (NFC).
Apr 22 2022, 11:37 AM · Restricted Project, Restricted Project

Apr 21 2022

kastiglione added a comment to D123954: [lldb] Add setting for max depth of value object printing (NFC).

thanks for the review @DavidSpickett

Apr 21 2022, 10:40 AM · Restricted Project, Restricted Project

Apr 20 2022

kastiglione updated the summary of D123954: [lldb] Add setting for max depth of value object printing (NFC).
Apr 20 2022, 4:27 PM · Restricted Project, Restricted Project

Apr 18 2022

kastiglione requested review of D123954: [lldb] Add setting for max depth of value object printing (NFC).
Apr 18 2022, 12:03 PM · Restricted Project, Restricted Project

Apr 14 2022

kastiglione accepted D123698: [lldb] Port Process::PrintWarning* to use the new diagnostic events.
Apr 14 2022, 10:04 AM · Restricted Project, Restricted Project

Apr 9 2022

kastiglione accepted D121665: [llvm-dis] Improve missing file error message.
Apr 9 2022, 2:54 PM · Restricted Project, Restricted Project
kastiglione accepted D122361: [docs][tools] Remove old llvm-bcanalyzer options.
Apr 9 2022, 2:52 PM · Restricted Project, Restricted Project

Apr 5 2022

kastiglione added a comment to D122924: [lld] Add version info to generic driver output.

I don't agree that an #include and a function call "add complexity". By that reasoning, writing any code is adding complexity, and then the question is not whether code is complex (because it all would be), and only whether reviewers choose to evoke a "code complexity" argument. The llvm project has lots of complexity, and I don't believe this is an example of it.

Apr 5 2022, 6:32 PM · Restricted Project, Restricted Project
kastiglione added a comment to D122924: [lld] Add version info to generic driver output.

@MaskRay sorry for butting in, but what am I missing here? The hardline and opaque rejection don't reconcile with such a minor change. To me, there is no complexity whatsoever to this change. You mention consistency, but don't say with what (which doesn't allow people to make their own judgement). I also don't see how feature orthogonality relates. Rejections happen, but I think it's rejections ought to be clear to readers, and in this instance I found it confusing.

Apr 5 2022, 5:46 PM · Restricted Project, Restricted Project

Mar 24 2022

kastiglione added a comment to D122041: [llvm][utils] Fix llvm::Optional summary provider.

There's some CMake trickery

Mar 24 2022, 10:04 AM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2022

kastiglione added inline comments to D122347: Expose GetAddressingBits() in the Process API.
Mar 23 2022, 3:08 PM · Restricted Project, Restricted Project

Mar 21 2022

kastiglione committed rG826bdf51ff31: [lldb] Fix llvm::Optional summary provider (authored by kastiglione).
[lldb] Fix llvm::Optional summary provider
Mar 21 2022, 10:03 AM · Restricted Project
kastiglione closed D122041: [llvm][utils] Fix llvm::Optional summary provider.
Mar 21 2022, 10:03 AM · Restricted Project, Restricted Project, Restricted Project

Mar 18 2022

kastiglione requested review of D122041: [llvm][utils] Fix llvm::Optional summary provider.
Mar 18 2022, 2:29 PM · Restricted Project, Restricted Project, Restricted Project

Mar 12 2022

kastiglione accepted D100692: clang-tidy: discover binaries in build dir.
Mar 12 2022, 12:11 PM · Restricted Project, Restricted Project

Mar 11 2022

kastiglione committed rG94bda3aaa121: [lldb] Removed scoped timer from ReadMemoryFromFileCache (authored by kastiglione).
[lldb] Removed scoped timer from ReadMemoryFromFileCache
Mar 11 2022, 12:47 PM · Restricted Project
kastiglione closed D121226: [lldb] Removed scoped timer from ReadMemoryFromFileCache.
Mar 11 2022, 12:46 PM · Restricted Project, Restricted Project
kastiglione reopened D121226: [lldb] Removed scoped timer from ReadMemoryFromFileCache.

Ignore previous comment, wrong diff.

Mar 11 2022, 12:44 PM · Restricted Project, Restricted Project
kastiglione closed D121480: [lldb] Move Module::FindTypes scoped timer to SymbolFileDWARFDebugMap.

Merged in rG3ca91adef8e885d89658a540860d3cee8746b1d9

Mar 11 2022, 12:44 PM · Restricted Project, Restricted Project
kastiglione closed D121226: [lldb] Removed scoped timer from ReadMemoryFromFileCache.
Mar 11 2022, 12:43 PM · Restricted Project, Restricted Project
kastiglione committed rG3ca91adef8e8: [lldb] Move FindTypes scoped timer to SymbolFileDWARFDebugMap (authored by kastiglione).
[lldb] Move FindTypes scoped timer to SymbolFileDWARFDebugMap
Mar 11 2022, 12:40 PM · Restricted Project
kastiglione added inline comments to D121481: Applying clang-tidy modernize-use-default-member-init over LLDB.
Mar 11 2022, 11:30 AM · Restricted Project, Restricted Project
kastiglione requested review of D121480: [lldb] Move Module::FindTypes scoped timer to SymbolFileDWARFDebugMap.
Mar 11 2022, 11:23 AM · Restricted Project, Restricted Project

Mar 10 2022

kastiglione committed rG14e4d2e5643e: [lldb] Remove unused include in ScriptedProcessInterface.h (authored by kastiglione).
[lldb] Remove unused include in ScriptedProcessInterface.h
Mar 10 2022, 2:56 PM · Restricted Project
kastiglione committed rG47f652d69517: [lldb] Call ThreadPlan::DiscardPlan from Thread::DiscardPlan (authored by kastiglione).
[lldb] Call ThreadPlan::DiscardPlan from Thread::DiscardPlan
Mar 10 2022, 1:58 PM · Restricted Project
kastiglione closed D96655: [lldb] Call ThreadPlan::DiscardPlan from Thread::DiscardPlan.
Mar 10 2022, 1:58 PM · Restricted Project, Restricted Project
kastiglione committed rGe3dfa30501c5: [lldb] Remove extra space in step logging message (authored by kastiglione).
[lldb] Remove extra space in step logging message
Mar 10 2022, 12:03 PM · Restricted Project

Mar 9 2022

kastiglione committed rG02def06e6036: [lldb] Fix step-avoid-regexp logging (authored by kastiglione).
[lldb] Fix step-avoid-regexp logging
Mar 9 2022, 8:35 AM · Restricted Project
kastiglione closed D119298: [lldb] Fix step-avoid-regexp logging.
Mar 9 2022, 8:35 AM · Restricted Project, Restricted Project