Page MenuHomePhabricator

augusto2112 (Augusto Noronha)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 8 2019, 10:01 AM (97 w, 4 d)

Recent Activity

Tue, Jun 1

augusto2112 accepted D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit.

LGTM

Tue, Jun 1, 9:09 AM · Restricted Project

May 17 2021

augusto2112 accepted D102595: [lldb][NFC] Use StringRef in TypeSystem API (TypeSystem, CompilerType, TypeSystemClang).

LGTM!

May 17 2021, 6:14 AM · Restricted Project
augusto2112 added inline comments to D102595: [lldb][NFC] Use StringRef in TypeSystem API (TypeSystem, CompilerType, TypeSystemClang).
May 17 2021, 6:08 AM · Restricted Project

May 11 2021

augusto2112 committed rGec28e43e0154: Add null-pointer checks when accessing a TypeSystem's SymbolFile (authored by augusto2112).
Add null-pointer checks when accessing a TypeSystem's SymbolFile
May 11 2021, 9:20 AM
augusto2112 closed D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile.
May 11 2021, 9:20 AM · Restricted Project
augusto2112 committed rG6c82b8a378a6: Change Target::ReadMemory to ensure the amount of memory read from the file… (authored by augusto2112).
Change Target::ReadMemory to ensure the amount of memory read from the file…
May 11 2021, 9:09 AM
augusto2112 closed D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..
May 11 2021, 9:09 AM · Restricted Project
augusto2112 updated the diff for D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile.

Update test

May 11 2021, 5:22 AM · Restricted Project

May 10 2021

augusto2112 added a comment to D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile.

@teemperor let me know if this test is OK, or if there's a better way to test this :)

May 10 2021, 12:36 PM · Restricted Project
augusto2112 updated the diff for D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile.

Add GetExeModuleWhenMissingSymbolFile tesst.

May 10 2021, 12:35 PM · Restricted Project

Apr 30 2021

augusto2112 accepted D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null.

LGTM!

Apr 30 2021, 8:45 AM · Restricted Project

Apr 29 2021

augusto2112 added inline comments to D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..
Apr 29 2021, 9:43 AM · Restricted Project
augusto2112 updated the diff for D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..

Rely on unique_ptr's bool operator, instead of checking the underlying pointer.

Apr 29 2021, 9:43 AM · Restricted Project
augusto2112 added inline comments to D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..
Apr 29 2021, 8:42 AM · Restricted Project
augusto2112 updated the diff for D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..

Change buffer unique pointer from void to uint8_t, eliminating the need to call malloc/free.

Apr 29 2021, 8:41 AM · Restricted Project
augusto2112 requested review of D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile.
Apr 29 2021, 8:13 AM · Restricted Project

Apr 28 2021

augusto2112 added inline comments to D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..
Apr 28 2021, 11:40 AM · Restricted Project

Apr 27 2021

augusto2112 requested review of D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..
Apr 27 2021, 12:31 PM · Restricted Project

Apr 20 2021

augusto2112 requested review of D100850: Fix reading from file cache using address instead of resolved address for getting a section.
Apr 20 2021, 6:31 AM · Restricted Project

Apr 15 2021

augusto2112 added a comment to D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions.

Hey @jasonmolenda thanks for the input, and nice empirical experiment! Do you think simply adding a setting that sleeps by a constant amount would be enough to model this problem?

Apr 15 2021, 6:11 AM · Restricted Project
augusto2112 updated the diff for D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

Updates all calls to ReadMemory to keep the current behavior.

Apr 15 2021, 5:56 AM · Restricted Project

Apr 14 2021

augusto2112 added a comment to D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

@jasonmolenda I've updated all the function calls to prefer the file cache (except the one you pointed out), but I'm a little worried about this, since I changed a lot of function calls. Maybe I could update the function signature to force_live_memory (and default it to false), but keep all the current calls having the same behavior (by negating whatever was passed previously as prefer_file_cache). What do you think?

Apr 14 2021, 2:16 PM · Restricted Project
augusto2112 updated the diff for D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

Changed the approach from a target setting to updating Target::ReadMemory to prefer the file cache (if section is read-only)

Apr 14 2021, 2:12 PM · Restricted Project
augusto2112 added a comment to D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions.

This patch introduces a new setting on ProcessGDBRemote to allow artificially slowing down the communication betwenn lldb and the server. The new setting sleeps PacketDelayMultiplier nanoseconds per byte read or written in GDBRemoteCommunication.

Apr 14 2021, 12:09 PM · Restricted Project
augusto2112 requested review of D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions.
Apr 14 2021, 11:56 AM · Restricted Project

Apr 13 2021

augusto2112 added a comment to D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

@jasonmolenda actually, most of them are passing prefer_file_cache = false, unfortunately. But they might be doing this because there's they weren't sure if the memory was writable, so this was the safer option. I want to change all the ones we deem safe to force_live_memory = false, which is why I ask which files you think this change would be safe.

Apr 13 2021, 11:16 AM · Restricted Project
augusto2112 added a comment to D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

Thanks for the input @jasonmolenda. FWIW I also think it's worth implementing this correctly.

Apr 13 2021, 11:09 AM · Restricted Project

Apr 12 2021

augusto2112 requested review of D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.
Apr 12 2021, 12:55 PM · Restricted Project

Mar 9 2021

augusto2112 added a comment to D96176: Implement jAttachWait.

I'm not sure this new functionality is really worth the new packet (or two), but if it solves a use case you care about, then I suppose that's fine.

Mar 9 2021, 10:39 AM · Restricted Project
augusto2112 updated the diff for D96176: Implement jAttachWait.

Address comments

Mar 9 2021, 10:32 AM · Restricted Project
augusto2112 added a comment to D95230: Save and restore previous terminal after setting the terminal for checking if terminal supports colors..

We'll still need to be careful about using this functionality on the lldb side though. This fix will only help if there is proper synchronization between using this function and libedit initialization

Mar 9 2021, 8:09 AM · Restricted Project

Feb 7 2021

augusto2112 added a comment to D96176: Implement jAttachWait.

One alternative could be to just tack on some extra data to the existing vAttach family packets (vAttachWait;foo;interval:47;duration=74).

Feb 7 2021, 4:26 AM · Restricted Project

Feb 5 2021

augusto2112 added a comment to D96176: Implement jAttachWait.

As discussed in the vAttachWait patch (https://reviews.llvm.org/D93895), I've implemented a jAttachWait packet with supports two additional parameters (polling interval and polling duration) when attaching to a process by name and waiting for it to appear.

Feb 5 2021, 1:43 PM · Restricted Project
augusto2112 requested review of D96176: Implement jAttachWait.
Feb 5 2021, 1:24 PM · Restricted Project

Feb 1 2021

augusto2112 added reviewers for D95230: Save and restore previous terminal after setting the terminal for checking if terminal supports colors.: haampie, phosek.
Feb 1 2021, 11:23 AM · Restricted Project

Jan 22 2021

augusto2112 added a comment to D95230: Save and restore previous terminal after setting the terminal for checking if terminal supports colors..

This is the second (and better) solution that addresses this issue. Previous discussions can be found here.

Jan 22 2021, 6:36 AM · Restricted Project
augusto2112 requested review of D95230: Save and restore previous terminal after setting the terminal for checking if terminal supports colors..
Jan 22 2021, 6:35 AM · Restricted Project
augusto2112 added a comment to D94672: Implement vAttachOrWait.

@labath sorry for the repeated messages. I believe this is ready to be merged, right?

Jan 22 2021, 5:23 AM · Restricted Project
augusto2112 added a comment to D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux.

@labath, you were absolutely correct! It was simply a matter of saving and restoring the terminal struct on the terminalHasColors function in the Process.inc file (I really should've tried that before). I'm currently recompiling and will re-run the tests locally, and will push the changes after that. I do worry this could potentially impact macOS though (I don't know if these low-level terminal functions work differently between differently OSes), so how do we ensure this doesn't break anything there?

Jan 22 2021, 5:09 AM · Restricted Project

Jan 21 2021

augusto2112 added a comment to D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux.

This issue was found on the Swift REPL. However, I tested @teemperor's C REPL patch (https://reviews.llvm.org/D87281) and the same problem shows up.

Jan 21 2021, 1:10 PM · Restricted Project
augusto2112 requested review of D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux.
Jan 21 2021, 1:07 PM · Restricted Project

Jan 20 2021

augusto2112 added a comment to D94672: Implement vAttachOrWait.

@labath, @clayborg since both of you approved of it, I think this patch is ready to be merged, right? Could one of you do it? I don't have commit access.

Jan 20 2021, 2:50 AM · Restricted Project

Jan 14 2021

augusto2112 added inline comments to D94672: Implement vAttachOrWait.
Jan 14 2021, 2:28 PM · Restricted Project
augusto2112 updated the diff for D94672: Implement vAttachOrWait.

Addresses comments, includes tests.

Jan 14 2021, 2:25 PM · Restricted Project
augusto2112 added inline comments to D94672: Implement vAttachOrWait.
Jan 14 2021, 6:07 AM · Restricted Project
augusto2112 added inline comments to D94672: Implement vAttachOrWait.
Jan 14 2021, 4:44 AM · Restricted Project
augusto2112 requested review of D94672: Implement vAttachOrWait.
Jan 14 2021, 4:36 AM · Restricted Project

Jan 12 2021

augusto2112 added a comment to D93895: Implement vAttachWait in lldb-server.

@clayborg @labath if possible, could one of you merge this please?

Jan 12 2021, 4:31 PM · Restricted Project

Jan 10 2021

augusto2112 added a comment to D93895: Implement vAttachWait in lldb-server.

Looks good, modulo the inline comment.

Jan 10 2021, 1:08 PM · Restricted Project

Jan 6 2021

augusto2112 updated the diff for D93895: Implement vAttachWait in lldb-server.

Changes test to launch a process before and after we ask for the attach. Minor code fixes as well.

Jan 6 2021, 7:30 AM · Restricted Project
augusto2112 updated the diff for D93895: Implement vAttachWait in lldb-server.

Back to implementation of vAttachWait

Jan 6 2021, 6:12 AM · Restricted Project
augusto2112 added a comment to D93895: Implement vAttachWait in lldb-server.

I don't think it's a good idea to stuff all of this into a single patch. Can we go back to the version which just implements the basic vAttachWait packet (we can bikeshed on what the default interval should be)? I believe new commands/options/packets should be done in separate patches...

Jan 6 2021, 5:56 AM · Restricted Project
augusto2112 added a comment to D93895: Implement vAttachWait in lldb-server.

Ok, that makes sense!

Jan 6 2021, 3:01 AM · Restricted Project

Jan 5 2021

augusto2112 added a comment to D93895: Implement vAttachWait in lldb-server.

I think I get your point. If we pass the extra options in the packet, the validation on older lldb-server versions will reject the message.

Jan 5 2021, 2:29 PM · Restricted Project
augusto2112 added a comment to D93895: Implement vAttachWait in lldb-server.

Here lies the problem that I mentioned above. I would like to avoid having to launch lldb-server with any arguments so that we continue to work with older lldb-servers.

Jan 5 2021, 2:18 PM · Restricted Project
augusto2112 added a comment to D93895: Implement vAttachWait in lldb-server.

So it might be nice to add support for vAttachOrWait, along with the query packet, in this patch if you have the time?

Jan 5 2021, 12:23 PM · Restricted Project
augusto2112 added a comment to D93895: Implement vAttachWait in lldb-server.

Question: why does lldb queries if vAttachOrWait is supported, but not vAttachWait? Does it make sense to keep this query? Or should I remove it?

Jan 5 2021, 9:35 AM · Restricted Project
augusto2112 added a comment to D93895: Implement vAttachWait in lldb-server.

@clayborg I've added support for the 'waitfor-interval' and 'waitfor-duration' flags. Yesterday I thought they existed in macOS, but now I'm not so sure, as I couldn't find them on "Options.td". They were added in 2009, so maybe they did exist but were dropped later. Or I just didn't look at the right place.

Jan 5 2021, 9:29 AM · Restricted Project
augusto2112 updated the diff for D93895: Implement vAttachWait in lldb-server.

Adds support to 'vAttachOrWait', as well as the 'waitfor-interval' and 'waitfor-duration' flags.

Jan 5 2021, 9:15 AM · Restricted Project

Jan 4 2021

augusto2112 added inline comments to D93895: Implement vAttachWait in lldb-server.
Jan 4 2021, 3:39 PM · Restricted Project

Jan 2 2021

augusto2112 updated the diff for D93895: Implement vAttachWait in lldb-server.

Fix issues pointed out in comments left in previous patch, and clean the code a bit

Jan 2 2021, 1:34 PM · Restricted Project

Jan 1 2021

augusto2112 added a comment to D93895: Implement vAttachWait in lldb-server.

Hi @labath. Ok, I believe the test is passing now. Thank you for all the help today!

Jan 1 2021, 1:33 PM · Restricted Project
augusto2112 updated the diff for D93895: Implement vAttachWait in lldb-server.

Re-include deleted files.

Jan 1 2021, 1:30 PM · Restricted Project
augusto2112 updated the diff for D93895: Implement vAttachWait in lldb-server.

Update test.

Jan 1 2021, 1:26 PM · Restricted Project
augusto2112 added a comment to D93895: Implement vAttachWait in lldb-server.

Hi @labath. I see! I changed it to lldbgdbserverutils.gdbremote_hex_encode_string. Looking at the logs, I found that the checksum I inserted was wrong, so I've corrected that as well (is there a way I can calculate the checksum on the test, instead of hard-coding it in the string?). Despite these changes, I still get the same error (ConnectionResetError: [Errno 104] Connection reset by peer on line 46).

Jan 1 2021, 3:36 AM · Restricted Project

Dec 29 2020

augusto2112 updated the diff for D93895: Implement vAttachWait in lldb-server.

Fix formatting issues

Dec 29 2020, 3:31 AM · Restricted Project
augusto2112 added a comment to D93895: Implement vAttachWait in lldb-server.

Hi guys.

Dec 29 2020, 3:20 AM · Restricted Project
augusto2112 updated the summary of D93895: Implement vAttachWait in lldb-server.
Dec 29 2020, 3:13 AM · Restricted Project
augusto2112 requested review of D93895: Implement vAttachWait in lldb-server.
Dec 29 2020, 3:10 AM · Restricted Project