Page MenuHomePhabricator

augusto2112 (Augusto Noronha)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 8 2019, 10:01 AM (150 w, 6 d)

Recent Activity

May 24 2022

augusto2112 accepted D126217: [lldb] Improve TestAppleSimulatorOSType.py error message.
May 24 2022, 5:10 PM · Unknown Object (Project), Restricted Project

Apr 15 2022

augusto2112 added a comment to D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type.

Hi @zequanwu, your patch's new test seems to be failing on CI (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/). Could you fix it or revert the changes? Thanks!

Apr 15 2022, 2:16 AM · Restricted Project, Unknown Object (Project)

Mar 23 2022

augusto2112 committed rG44a609cd594f: [dsymutil] Update vector of section starts with size of current section (authored by augusto2112).
[dsymutil] Update vector of section starts with size of current section
Mar 23 2022, 6:16 AM · Restricted Project
augusto2112 closed D122239: [dsymutil] Update vector of section starts with size of current section.
Mar 23 2022, 6:16 AM · Restricted Project, Restricted Project
augusto2112 updated the diff for D122239: [dsymutil] Update vector of section starts with size of current section.

Clang format

Mar 23 2022, 5:42 AM · Restricted Project, Restricted Project
augusto2112 updated the diff for D122239: [dsymutil] Update vector of section starts with size of current section.

Clang format

Mar 23 2022, 5:41 AM · Restricted Project, Restricted Project
augusto2112 added a comment to D122239: [dsymutil] Update vector of section starts with size of current section.

That looks plausible. Does this affect any of the tests?

Mar 23 2022, 5:36 AM · Restricted Project, Restricted Project

Mar 22 2022

augusto2112 requested review of D122239: [dsymutil] Update vector of section starts with size of current section.
Mar 22 2022, 10:20 AM · Restricted Project, Restricted Project

Mar 17 2022

augusto2112 committed rG9b3af5e7b702: [dsymutil] Apply relocations present in Swift reflection sections (authored by augusto2112).
[dsymutil] Apply relocations present in Swift reflection sections
Mar 17 2022, 10:24 AM · Restricted Project
augusto2112 closed D120574: [dsymutil] Apply relocations present in Swift reflection sections.
Mar 17 2022, 10:23 AM · Restricted Project, Restricted Project

Mar 11 2022

augusto2112 added a comment to D120574: [dsymutil] Apply relocations present in Swift reflection sections.

I noticed that there is no test for this change. Can you please add one?

Mar 11 2022, 12:10 PM · Restricted Project, Restricted Project
augusto2112 updated the diff for D120574: [dsymutil] Apply relocations present in Swift reflection sections.

Updated reflection-dump test, moved isMachOPairedReloc to MachO.h, changed SectionToOffsetInDwarf from a map to a vector.

Mar 11 2022, 12:09 PM · Restricted Project, Restricted Project

Feb 25 2022

augusto2112 added inline comments to D120578: [lldb] Implement ObjectFile::GetCStrFromSection.
Feb 25 2022, 11:41 AM · Unknown Object (Project)
augusto2112 requested review of D120578: [lldb] Implement ObjectFile::GetCStrFromSection.
Feb 25 2022, 11:07 AM · Unknown Object (Project)
augusto2112 requested review of D120574: [dsymutil] Apply relocations present in Swift reflection sections.
Feb 25 2022, 10:36 AM · Restricted Project, Restricted Project

Jan 28 2022

augusto2112 requested changes to D118494: [lldb] Observe SG_READ_ONLY flag in MachO binaries.
Jan 28 2022, 12:38 PM · Restricted Project, Unknown Object (Project)
augusto2112 committed rGb414954a5f1c: [lldb] Make ReadCStringFromMemory default to read from the file-cache. (authored by augusto2112).
[lldb] Make ReadCStringFromMemory default to read from the file-cache.
Jan 28 2022, 8:09 AM
augusto2112 closed D118265: [lldb] Make ReadCStringFromMemory default to read from the file-cache..
Jan 28 2022, 8:09 AM · Unknown Object (Project)

Jan 26 2022

augusto2112 requested review of D118265: [lldb] Make ReadCStringFromMemory default to read from the file-cache..
Jan 26 2022, 9:28 AM · Unknown Object (Project)

Jan 5 2022

augusto2112 accepted D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos.

I liked the small cleanups in the code as well!

Jan 5 2022, 12:03 PM · Unknown Object (Project)

Dec 14 2021

augusto2112 abandoned D115723: [lldb] Fix ABIMacOSX_arm64::PrepareTrivialCall logging.

Looks like this was already fixed.

Dec 14 2021, 5:29 AM · Unknown Object (Project)
augusto2112 requested review of D115723: [lldb] Fix ABIMacOSX_arm64::PrepareTrivialCall logging.
Dec 14 2021, 5:25 AM · Unknown Object (Project)

Sep 23 2021

augusto2112 committed rGfbaf36721783: [lldb] Show fix-it applied even if expression didn't evaluate succesfully (authored by augusto2112).
[lldb] Show fix-it applied even if expression didn't evaluate succesfully
Sep 23 2021, 12:46 PM
augusto2112 closed D109908: [lldb] Show fix-it applied even if expression didn't evaluate succesfully.
Sep 23 2021, 12:46 PM · Unknown Object (Project)

Sep 22 2021

augusto2112 added a comment to D109908: [lldb] Show fix-it applied even if expression didn't evaluate succesfully.

Could you add a test for that? The usual test fixit in Clang is ./-> mixup, e.g.

(lldb) expr struct Foo { int i; }; Foo *f; f.i ; unknown_identifier_for_fatal_error
(int) $0 = 0
  Fix-it applied, fixed expression was: 
    struct Foo { int i; }; Foo *f; f->i ; unknown_identifier_for_fatal_error
...
Sep 22 2021, 1:09 PM · Unknown Object (Project)
augusto2112 updated the diff for D109908: [lldb] Show fix-it applied even if expression didn't evaluate succesfully.

Add test

Sep 22 2021, 1:04 PM · Unknown Object (Project)

Sep 16 2021

augusto2112 added a reverting change for rG47dd1f642846: [lldb] Skip TestAppleSimulatorOSType if json parsing fails: rG8fb86011026c: Revert "[lldb] Skip TestAppleSimulatorOSType if json parsing fails".
Sep 16 2021, 1:51 PM
augusto2112 committed rG8fb86011026c: Revert "[lldb] Skip TestAppleSimulatorOSType if json parsing fails" (authored by augusto2112).
Revert "[lldb] Skip TestAppleSimulatorOSType if json parsing fails"
Sep 16 2021, 1:50 PM
augusto2112 added a reverting change for D109336: [lldb] Skip TestAppleSimulatorOSType if json parsing fails: rG8fb86011026c: Revert "[lldb] Skip TestAppleSimulatorOSType if json parsing fails".
Sep 16 2021, 1:50 PM · Unknown Object (Project)
augusto2112 committed rG47dd1f642846: [lldb] Skip TestAppleSimulatorOSType if json parsing fails (authored by augusto2112).
[lldb] Skip TestAppleSimulatorOSType if json parsing fails
Sep 16 2021, 12:39 PM
augusto2112 closed D109336: [lldb] Skip TestAppleSimulatorOSType if json parsing fails.
Sep 16 2021, 12:39 PM · Unknown Object (Project)
augusto2112 requested review of D109908: [lldb] Show fix-it applied even if expression didn't evaluate succesfully.
Sep 16 2021, 12:29 PM · Unknown Object (Project)

Sep 6 2021

augusto2112 requested review of D109336: [lldb] Skip TestAppleSimulatorOSType if json parsing fails.
Sep 6 2021, 1:07 PM · Unknown Object (Project)

Aug 31 2021

augusto2112 added a comment to D109004: [lldb] Catch all exceptions when checking if simulator exists.

My initial thought was that xcodebuild is throwing some other error (maybe, for some reason, it times out, which is a subprocess.TimeoutExpired exception), which is why my solution was to catch any exception thrown by subprocess.check_output.

Aug 31 2021, 1:16 PM · Unknown Object (Project)
augusto2112 added a comment to D100263: [lldb] [gdb-remote client] Remove breakpoints in forked processes.

Hi. It looks like the fork-follow-parent-softbp test is failing on CI.

Aug 31 2021, 11:54 AM · Unknown Object (Project)
augusto2112 added a comment to D109004: [lldb] Catch all exceptions when checking if simulator exists.

The error that happens in xcodebuild is:

Aug 31 2021, 10:20 AM · Unknown Object (Project)
augusto2112 requested review of D109004: [lldb] Catch all exceptions when checking if simulator exists.
Aug 31 2021, 10:00 AM · Unknown Object (Project)
augusto2112 accepted D108983: [lldb] Don't save empty expressions in the multiline editor history.

LGTM!

Aug 31 2021, 9:09 AM · Unknown Object (Project)

Jul 29 2021

augusto2112 closed D106584: [lldb] Assert file cache and live memory are equal on debug builds.

Commit 77e9d10f0fbfe04a14e6ce61753376dd78e0c2f0

Jul 29 2021, 6:37 AM · Unknown Object (Project)
augusto2112 committed rG77e9d10f0fbf: [lldb] Assert filecache and live memory match on debug under a setting (authored by augusto2112).
[lldb] Assert filecache and live memory match on debug under a setting
Jul 29 2021, 6:31 AM
augusto2112 updated the diff for D106584: [lldb] Assert file cache and live memory are equal on debug builds.

Add test to test/Shell/lit-lldb-init.in

Jul 29 2021, 5:47 AM · Unknown Object (Project)

Jul 28 2021

augusto2112 updated the diff for D106584: [lldb] Assert file cache and live memory are equal on debug builds.

Run file-cache verification on tests, change raw buffer to unique pointer

Jul 28 2021, 1:42 PM · Unknown Object (Project)
augusto2112 updated the diff for D106584: [lldb] Assert file cache and live memory are equal on debug builds.

Add setting to enable assert

Jul 28 2021, 10:01 AM · Unknown Object (Project)

Jul 27 2021

augusto2112 retitled D106584: [lldb] Assert file cache and live memory are equal on debug builds from [lldb] Improve checking of file cache read eligibility for mach-O to [lldb] Assert file cache and live memory are equal on debug builds.
Jul 27 2021, 5:29 AM · Unknown Object (Project)
augusto2112 updated the diff for D106584: [lldb] Assert file cache and live memory are equal on debug builds.

Keep only filecache and live memory equality assertion

Jul 27 2021, 5:28 AM · Unknown Object (Project)
augusto2112 added a comment to D106584: [lldb] Assert file cache and live memory are equal on debug builds.

Hey Augusto, thanks for tackling this, I'm just now slowly paging things in.

Is this a correct statement of the problem: LLDB is failing to disable its file cache optimization when reading writable segments (say, __DATA) from a MachO sourced from the shared cache?

If that's right, then I wonder whether you considered "simply" doing a bounds check on the address? The shared region should be mapped at a fixed virtual range in the debuggee process, and we can determine that range using dyld APIs.

Jul 27 2021, 5:27 AM · Unknown Object (Project)

Jul 23 2021

augusto2112 added a comment to D106584: [lldb] Assert file cache and live memory are equal on debug builds.

Hi Jason,

Jul 23 2021, 8:05 AM · Unknown Object (Project)

Jul 22 2021

augusto2112 requested review of D106584: [lldb] Assert file cache and live memory are equal on debug builds.
Jul 22 2021, 12:33 PM · Unknown Object (Project)

Jun 1 2021

augusto2112 accepted D103439: [lldb] Print the backtrace for all threads if the test breakpoint can't be hit.

LGTM

Jun 1 2021, 9:09 AM · Unknown Object (Project)

May 17 2021

augusto2112 accepted D102595: [lldb][NFC] Use StringRef in TypeSystem API (TypeSystem, CompilerType, TypeSystemClang).

LGTM!

May 17 2021, 6:14 AM · Unknown Object (Project)
augusto2112 added inline comments to D102595: [lldb][NFC] Use StringRef in TypeSystem API (TypeSystem, CompilerType, TypeSystemClang).
May 17 2021, 6:08 AM · Unknown Object (Project)

May 11 2021

augusto2112 committed rGec28e43e0154: Add null-pointer checks when accessing a TypeSystem's SymbolFile (authored by augusto2112).
Add null-pointer checks when accessing a TypeSystem's SymbolFile
May 11 2021, 9:20 AM
augusto2112 closed D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile.
May 11 2021, 9:20 AM · Unknown Object (Project)
augusto2112 committed rG6c82b8a378a6: Change Target::ReadMemory to ensure the amount of memory read from the file… (authored by augusto2112).
Change Target::ReadMemory to ensure the amount of memory read from the file…
May 11 2021, 9:09 AM
augusto2112 closed D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..
May 11 2021, 9:09 AM · Unknown Object (Project)
augusto2112 updated the diff for D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile.

Update test

May 11 2021, 5:22 AM · Unknown Object (Project)

May 10 2021

augusto2112 added a comment to D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile.

@teemperor let me know if this test is OK, or if there's a better way to test this :)

May 10 2021, 12:36 PM · Unknown Object (Project)
augusto2112 updated the diff for D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile.

Add GetExeModuleWhenMissingSymbolFile tesst.

May 10 2021, 12:35 PM · Unknown Object (Project)

Apr 30 2021

augusto2112 accepted D101585: [lldb] Ensure SBStructuredData::m_impl_up is always non-null.

LGTM!

Apr 30 2021, 8:45 AM · Unknown Object (Project)

Apr 29 2021

augusto2112 added inline comments to D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..
Apr 29 2021, 9:43 AM · Unknown Object (Project)
augusto2112 updated the diff for D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..

Rely on unique_ptr's bool operator, instead of checking the underlying pointer.

Apr 29 2021, 9:43 AM · Unknown Object (Project)
augusto2112 added inline comments to D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..
Apr 29 2021, 8:42 AM · Unknown Object (Project)
augusto2112 updated the diff for D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..

Change buffer unique pointer from void to uint8_t, eliminating the need to call malloc/free.

Apr 29 2021, 8:41 AM · Unknown Object (Project)
augusto2112 requested review of D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile.
Apr 29 2021, 8:13 AM · Unknown Object (Project)

Apr 28 2021

augusto2112 added inline comments to D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..
Apr 28 2021, 11:40 AM · Unknown Object (Project)

Apr 27 2021

augusto2112 requested review of D101390: Change Target::ReadMemory to ensure the amount of memory read from the file-cache is the amount requested..
Apr 27 2021, 12:31 PM · Unknown Object (Project)

Apr 20 2021

augusto2112 requested review of D100850: Fix reading from file cache using address instead of resolved address for getting a section.
Apr 20 2021, 6:31 AM · Unknown Object (Project)

Apr 15 2021

augusto2112 added a comment to D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions.

Hey @jasonmolenda thanks for the input, and nice empirical experiment! Do you think simply adding a setting that sleeps by a constant amount would be enough to model this problem?

Apr 15 2021, 6:11 AM · Unknown Object (Project)
augusto2112 updated the diff for D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

Updates all calls to ReadMemory to keep the current behavior.

Apr 15 2021, 5:56 AM · Unknown Object (Project)

Apr 14 2021

augusto2112 added a comment to D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

@jasonmolenda I've updated all the function calls to prefer the file cache (except the one you pointed out), but I'm a little worried about this, since I changed a lot of function calls. Maybe I could update the function signature to force_live_memory (and default it to false), but keep all the current calls having the same behavior (by negating whatever was passed previously as prefer_file_cache). What do you think?

Apr 14 2021, 2:16 PM · Unknown Object (Project)
augusto2112 updated the diff for D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

Changed the approach from a target setting to updating Target::ReadMemory to prefer the file cache (if section is read-only)

Apr 14 2021, 2:12 PM · Unknown Object (Project)
augusto2112 added a comment to D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions.

This patch introduces a new setting on ProcessGDBRemote to allow artificially slowing down the communication betwenn lldb and the server. The new setting sleeps PacketDelayMultiplier nanoseconds per byte read or written in GDBRemoteCommunication.

Apr 14 2021, 12:09 PM · Unknown Object (Project)
augusto2112 requested review of D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions.
Apr 14 2021, 11:56 AM · Unknown Object (Project)

Apr 13 2021

augusto2112 added a comment to D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

@jasonmolenda actually, most of them are passing prefer_file_cache = false, unfortunately. But they might be doing this because there's they weren't sure if the memory was writable, so this was the safer option. I want to change all the ones we deem safe to force_live_memory = false, which is why I ask which files you think this change would be safe.

Apr 13 2021, 11:16 AM · Unknown Object (Project)
augusto2112 added a comment to D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

Thanks for the input @jasonmolenda. FWIW I also think it's worth implementing this correctly.

Apr 13 2021, 11:09 AM · Unknown Object (Project)

Apr 12 2021

augusto2112 requested review of D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.
Apr 12 2021, 12:55 PM · Unknown Object (Project)

Mar 9 2021

augusto2112 added a comment to D96176: Implement jAttachWait.

I'm not sure this new functionality is really worth the new packet (or two), but if it solves a use case you care about, then I suppose that's fine.

Mar 9 2021, 10:39 AM · Unknown Object (Project)
augusto2112 updated the diff for D96176: Implement jAttachWait.

Address comments

Mar 9 2021, 10:32 AM · Unknown Object (Project)
augusto2112 added a comment to D95230: Save and restore previous terminal after setting the terminal for checking if terminal supports colors..

We'll still need to be careful about using this functionality on the lldb side though. This fix will only help if there is proper synchronization between using this function and libedit initialization

Mar 9 2021, 8:09 AM · Restricted Project

Feb 7 2021

augusto2112 added a comment to D96176: Implement jAttachWait.

One alternative could be to just tack on some extra data to the existing vAttach family packets (vAttachWait;foo;interval:47;duration=74).

Feb 7 2021, 4:26 AM · Unknown Object (Project)

Feb 5 2021

augusto2112 added a comment to D96176: Implement jAttachWait.

As discussed in the vAttachWait patch (https://reviews.llvm.org/D93895), I've implemented a jAttachWait packet with supports two additional parameters (polling interval and polling duration) when attaching to a process by name and waiting for it to appear.

Feb 5 2021, 1:43 PM · Unknown Object (Project)
augusto2112 requested review of D96176: Implement jAttachWait.
Feb 5 2021, 1:24 PM · Unknown Object (Project)

Feb 1 2021

augusto2112 added reviewers for D95230: Save and restore previous terminal after setting the terminal for checking if terminal supports colors.: haampie, phosek.
Feb 1 2021, 11:23 AM · Restricted Project

Jan 22 2021

augusto2112 added a comment to D95230: Save and restore previous terminal after setting the terminal for checking if terminal supports colors..

This is the second (and better) solution that addresses this issue. Previous discussions can be found here.

Jan 22 2021, 6:36 AM · Restricted Project
augusto2112 requested review of D95230: Save and restore previous terminal after setting the terminal for checking if terminal supports colors..
Jan 22 2021, 6:35 AM · Restricted Project
augusto2112 added a comment to D94672: Implement vAttachOrWait.

@labath sorry for the repeated messages. I believe this is ready to be merged, right?

Jan 22 2021, 5:23 AM · Unknown Object (Project)
augusto2112 added a comment to D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux.

@labath, you were absolutely correct! It was simply a matter of saving and restoring the terminal struct on the terminalHasColors function in the Process.inc file (I really should've tried that before). I'm currently recompiling and will re-run the tests locally, and will push the changes after that. I do worry this could potentially impact macOS though (I don't know if these low-level terminal functions work differently between differently OSes), so how do we ensure this doesn't break anything there?

Jan 22 2021, 5:09 AM · Unknown Object (Project)

Jan 21 2021

augusto2112 added a comment to D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux.

This issue was found on the Swift REPL. However, I tested @teemperor's C REPL patch (https://reviews.llvm.org/D87281) and the same problem shows up.

Jan 21 2021, 1:10 PM · Unknown Object (Project)
augusto2112 requested review of D95165: Implement workaround for issue that shows between libedit and low-level terminal routines on Linux.
Jan 21 2021, 1:07 PM · Unknown Object (Project)

Jan 20 2021

augusto2112 added a comment to D94672: Implement vAttachOrWait.

@labath, @clayborg since both of you approved of it, I think this patch is ready to be merged, right? Could one of you do it? I don't have commit access.

Jan 20 2021, 2:50 AM · Unknown Object (Project)

Jan 14 2021

augusto2112 added inline comments to D94672: Implement vAttachOrWait.
Jan 14 2021, 2:28 PM · Unknown Object (Project)
augusto2112 updated the diff for D94672: Implement vAttachOrWait.

Addresses comments, includes tests.

Jan 14 2021, 2:25 PM · Unknown Object (Project)
augusto2112 added inline comments to D94672: Implement vAttachOrWait.
Jan 14 2021, 6:07 AM · Unknown Object (Project)
augusto2112 added inline comments to D94672: Implement vAttachOrWait.
Jan 14 2021, 4:44 AM · Unknown Object (Project)
augusto2112 requested review of D94672: Implement vAttachOrWait.
Jan 14 2021, 4:36 AM · Unknown Object (Project)

Jan 12 2021

augusto2112 added a comment to D93895: Implement vAttachWait in lldb-server.

@clayborg @labath if possible, could one of you merge this please?

Jan 12 2021, 4:31 PM · Unknown Object (Project)

Jan 10 2021

augusto2112 added a comment to D93895: Implement vAttachWait in lldb-server.

Looks good, modulo the inline comment.

Jan 10 2021, 1:08 PM · Unknown Object (Project)

Jan 6 2021

augusto2112 updated the diff for D93895: Implement vAttachWait in lldb-server.

Changes test to launch a process before and after we ask for the attach. Minor code fixes as well.

Jan 6 2021, 7:30 AM · Unknown Object (Project)
augusto2112 updated the diff for D93895: Implement vAttachWait in lldb-server.

Back to implementation of vAttachWait

Jan 6 2021, 6:12 AM · Unknown Object (Project)
augusto2112 added a comment to D93895: Implement vAttachWait in lldb-server.

I don't think it's a good idea to stuff all of this into a single patch. Can we go back to the version which just implements the basic vAttachWait packet (we can bikeshed on what the default interval should be)? I believe new commands/options/packets should be done in separate patches...

Jan 6 2021, 5:56 AM · Restricted Project