This is an archive of the discontinued LLVM Phabricator instance.

[llvm-debuginfo-analyzer] Remove '--print=sizes' in test case.
AbandonedPublic

Authored by CarlosAlbertoEnciso on Nov 2 2022, 4:11 AM.

Details

Summary

The use of '--print=sizes' produces an invalid output
on the following platforms/systems:

clang-armv7-vfpv3-2stage
https://lab.llvm.org/buildbot/#/builders/182/builds/4232

clang-armv7-global-isel
https://lab.llvm.org/buildbot/#/builders/186/builds/9519

clang-armv7-2stage
https://lab.llvm.org/buildbot/#/builders/187/builds/9483

The same problem reported building 32-bit multilib on amd64.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 4:11 AM
CarlosAlbertoEnciso requested review of this revision.Nov 2 2022, 4:11 AM
mgorny added a comment.Nov 2 2022, 8:27 AM

I suppose this makes sense as a stop-gap measure but the option should be fixed to work on all platforms.

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/06-dwarf-full-logical-view.test
8–15

Buildbot logs expire after some time, so I don't think there's a value in linking them.

mgorny requested changes to this revision.Nov 4 2022, 1:25 AM

D137400 is the proper fix.

This revision now requires changes to proceed.Nov 4 2022, 1:25 AM

I suppose this makes sense as a stop-gap measure but the option should be fixed to work on all platforms.

You are correct. That option must work on all platforms.

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/06-dwarf-full-logical-view.test
8–15

That is a good point. May keep only the buildbot link:

; clang-armv7-vfpv3-2stage
; https://lab.llvm.org/buildbot/#/builders/182
;
; clang-armv7-global-isel
; https://lab.llvm.org/buildbot/#/builders/186
;
; clang-armv7-2stage
; https://lab.llvm.org/buildbot/#/builders/187

D137400 is the proper fix.

I am sorry missing your patch.