Page MenuHomePhabricator

CarlosAlbertoEnciso (Carlos Alberto Enciso)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2017, 4:02 AM (200 w, 6 d)

Recent Activity

Mon, Jun 14

CarlosAlbertoEnciso committed rGd0a5d8611935: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects. (authored by CarlosAlbertoEnciso).
[Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects.
Mon, Jun 14, 10:54 PM
CarlosAlbertoEnciso closed D103089: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects..
Mon, Jun 14, 10:54 PM · Restricted Project, debug-info
CarlosAlbertoEnciso added a reverting change for rGb4d40e19def8: [NFC] This is a test commit to check commit access.: rG5e92cbddb901: Revert "[NFC] This is a test commit to check commit access.".
Mon, Jun 14, 10:26 PM
CarlosAlbertoEnciso committed rG5e92cbddb901: Revert "[NFC] This is a test commit to check commit access." (authored by CarlosAlbertoEnciso).
Revert "[NFC] This is a test commit to check commit access."
Mon, Jun 14, 10:26 PM
CarlosAlbertoEnciso committed rGb4d40e19def8: [NFC] This is a test commit to check commit access. (authored by CarlosAlbertoEnciso).
[NFC] This is a test commit to check commit access.
Mon, Jun 14, 10:21 PM

Sun, Jun 13

CarlosAlbertoEnciso added a comment to D103089: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects..

@amccarth: Thanks very much for your review.

Sun, Jun 13, 9:49 PM · Restricted Project, debug-info

Fri, Jun 11

CarlosAlbertoEnciso added inline comments to D103089: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects..
Fri, Jun 11, 10:55 AM · Restricted Project, debug-info
CarlosAlbertoEnciso updated the diff for D103089: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects..

Address comments from @amccarth:

Fri, Jun 11, 10:54 AM · Restricted Project, debug-info

Mon, Jun 7

CarlosAlbertoEnciso added a comment to D103089: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects..

I'm fine focusing on this part to get the bug fixed. We can consider looking at accepting upper and lower case letters in the future.

Mon, Jun 7, 6:47 AM · Restricted Project, debug-info

Thu, May 27

CarlosAlbertoEnciso added a comment to D103089: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects..

I'm be happy to always generate uppercase hex digits when formatting a GUID to registry format, but maybe we should also consider accepting upper or lowercase when reading a formatted GUID.

Thu, May 27, 11:23 PM · Restricted Project, debug-info

Wed, May 26

CarlosAlbertoEnciso updated the diff for D103089: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects..

Correct patch to include binary files used for the test.

Wed, May 26, 4:10 AM · Restricted Project, debug-info

Tue, May 25

CarlosAlbertoEnciso added a comment to D103089: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects..

This sounds like an appropriate place to apply Postel's Law: Be conservative in what you do, be liberal in what you accept from others. I'm be happy to always generate uppercase hex digits when formatting a GUID to registry format, but maybe we should also consider accepting upper or lowercase when reading a formatted GUID.

Some clarifications:

  • GUIDs are numbers not strings. Microsoft claims they are essentially UUIDs (per RFC 4122).
  • The cited document is actually specific to the string representation of GUIDs as required by Windows Installer. In fact, the braces indicate that it's the registry format. Windows installer--and other tools that use formatted GUIDs as registry keys--do string comparisons rather than converting the string representation to a numeric GUID that can be compared directly.
  • The bit about using uppercase for the hex digits in the string representation does not apply everywhere, not even in the Microsoft world. Microsoft's GUIDGEN tool formats GUIDs in various ways with respect to the case of the hex digits. And in RFC 4122 says string representations of UUIDs should use lowercase.
Tue, May 25, 1:48 PM · Restricted Project, debug-info
CarlosAlbertoEnciso abandoned D103114: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects..
Tue, May 25, 1:42 PM · Restricted Project
CarlosAlbertoEnciso requested review of D103114: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects..
Tue, May 25, 1:35 PM · Restricted Project
CarlosAlbertoEnciso added reviewers for D103089: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects.: rnk, aorlov, zturner.
Tue, May 25, 8:48 AM · Restricted Project, debug-info
CarlosAlbertoEnciso requested review of D103089: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects..
Tue, May 25, 8:24 AM · Restricted Project, debug-info

Mar 9 2021

CarlosAlbertoEnciso added a comment to D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete..

I started looking into some diffs of debug info in libc++ tests, but it's pretty hard to tell what's different - as far as I can see, there are just a bunch of __hash_value_types and __value_types.

This is a job for.... llvm-dva! See the preliminary patch at D88661, although it's getting a bit old and might not apply/build cleanly.

(llvm-dva is undergoing an internal review at the moment, we hope to have a proper reviewable patch series up soon-ish.)

Mar 9 2021, 3:06 AM · Restricted Project
CarlosAlbertoEnciso updated the diff for D88661: llvm-dva - Debug Information Visual Analizer.

Uploaded a patch that builds with the current TOT.

Mar 9 2021, 3:02 AM · Restricted Project, debug-info

Oct 27 2020

CarlosAlbertoEnciso updated the diff for D88661: llvm-dva - Debug Information Visual Analizer.

Uploaded a patch that corrects a merge conflict.

Oct 27 2020, 3:09 AM · Restricted Project, debug-info

Oct 21 2020

CarlosAlbertoEnciso added a comment to D88661: llvm-dva - Debug Information Visual Analizer.

@MaskRay: We have added support for Split DWARF. We would appreciate, if you can try again llvm-dva with the binaries you used in your test cases. Thanks.

Oct 21 2020, 7:30 AM · Restricted Project, debug-info
CarlosAlbertoEnciso updated the diff for D88661: llvm-dva - Debug Information Visual Analizer.

Following suggestions from @echristo in relation with the tool name, it was decided to renamed it as llvm-dva.

Oct 21 2020, 7:14 AM · Restricted Project, debug-info

Oct 8 2020

CarlosAlbertoEnciso updated the diff for D88661: llvm-dva - Debug Information Visual Analizer.

Uploaded an updated patch:

Oct 8 2020, 2:36 AM · Restricted Project, debug-info

Oct 4 2020

CarlosAlbertoEnciso updated the diff for D88661: llvm-dva - Debug Information Visual Analizer.

Uploaded a correct patch that includes:

Oct 4 2020, 11:30 AM · Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D88661: llvm-dva - Debug Information Visual Analizer.
% fllvm-diva --print=scopes /tmp/Debug/bin/clang             

Logical View:
           {File} '/tmp/debug/bin/clang'

             {CompileUnit} 'cc1_main.cpp.dwo'

             {CompileUnit} 'cc1as_main.cpp.dwo'

             {CompileUnit} 'cc1gen_reproducer_main.cpp.dwo'

             {CompileUnit} 'driver.cpp.dwo'

Are 'instructions', 'symbols', and 'types' unavailable?

% fllvm-diva --print=symbols /tmp/Debug/bin/clang

Logical View:
% fllvm-diva --print=types /tmp/Debug/bin/clang                                                                                                               

Logical View:
Oct 4 2020, 11:20 AM · Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D88661: llvm-dva - Debug Information Visual Analizer.

Some documented options appear to be unavailable.

% fllvm-diva --sort=offset /tmp/Debug/bin/clang       
llvm-diva: Unknown command line argument '--sort=offset'.  Try: '/tmp/RelA/bin/llvm-diva --help'
llvm-diva: Did you mean '--report=offset'?
Oct 4 2020, 11:10 AM · Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D88661: llvm-dva - Debug Information Visual Analizer.

For CMake changes, it'd be good to test a -DBUILD_SHARED_LIBS=on configuration. Many unspecified dependency can be caught. It also pushes the author to think whether certain dependencies are needed.

FAILED: lib/libLLVMDebugInfoLogicalView.so.12git
...
ld.lld: error: undefined symbol: llvm::raw_ostream::write(char const*, unsigned long)
ld.lld: error: undefined symbol: llvm::Twine::str[abi:cxx11]() const
Oct 4 2020, 11:02 AM · Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D88661: llvm-dva - Debug Information Visual Analizer.

@MaskRay Thanks very much for your valuable comments.

Oct 4 2020, 9:08 AM · Restricted Project, debug-info

Oct 2 2020

CarlosAlbertoEnciso added a comment to D88661: llvm-dva - Debug Information Visual Analizer.

(If you use arc diff to upload a patch (https://llvm.org/docs/GettingStarted.html#sending-patches), reviewers can use arc patch D88661 to apply the patch locally.
This patch does not have a/ b/ prefixes (git format-patch or git diff) and does not apply cleanly)

Oct 2 2020, 2:24 AM · Restricted Project, debug-info
CarlosAlbertoEnciso updated the diff for D88661: llvm-dva - Debug Information Visual Analizer.

This patch includes the a/ b/ prefixes.

Oct 2 2020, 2:23 AM · Restricted Project, debug-info

Oct 1 2020

CarlosAlbertoEnciso updated the summary of D88661: llvm-dva - Debug Information Visual Analizer.
Oct 1 2020, 8:39 AM · Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D88661: llvm-dva - Debug Information Visual Analizer.
Oct 1 2020, 8:37 AM · Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D88661: llvm-dva - Debug Information Visual Analizer.
Oct 1 2020, 8:24 AM · Restricted Project, debug-info
CarlosAlbertoEnciso requested review of D88661: llvm-dva - Debug Information Visual Analizer.
Oct 1 2020, 8:07 AM · Restricted Project, debug-info

Apr 23 2020

CarlosAlbertoEnciso added a comment to D78265: [AArch64ConditionOptimizer] Fix missed optimization due to debug insts [10/10].
In D78265#1999445, @vsk wrote:

Sorry about the breakage, I've renamed the variable in 210616bd38d589020b45f8cbbf9f9ef1296f2729.

Apr 23 2020, 11:52 AM · Restricted Project
CarlosAlbertoEnciso added a comment to D78265: [AArch64ConditionOptimizer] Fix missed optimization due to debug insts [10/10].

Looks like it's a scope error in gcc <= 5.5.
https://gcc.godbolt.org/z/ECqRJJ

The minimum required version to build LLVM GCC 5.1.
https://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library

Apr 23 2020, 8:38 AM · Restricted Project
CarlosAlbertoEnciso added a comment to D78265: [AArch64ConditionOptimizer] Fix missed optimization due to debug insts [10/10].

I cannot build llvm locally using ninja clean && ninja check-all with this patch due to the following error:

AArch64ConditionOptimizer.cpp: In member function 'llvm::MachineInstr* {anonymous}::AArch64ConditionOptimizer::findSuitableCompare(llvm::MachineBasicBlock*) ... no matching function call to 'prev(llvm::MachineInstr&)'

Using the following cmake command in llvm-project/build

cmake -G Ninja -DLLVM_ENABLE_PROJECTS="clang;lld" -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_ASSERTIONS=On -DLLVM_TARGETS_TO_BUILD="ARM;X86;AArch64" -DLLVM_ENABLE_SOLVER_Z3=Off -DPARALLEL_LINK_JOBS=2 -DLLVM_USE_LINKER=gold ../llvm

It looks as though harbourmaster is failing as well.
Based on commit hash 3a53806 on master

Apr 23 2020, 8:04 AM · Restricted Project

Apr 4 2020

CarlosAlbertoEnciso added a comment to D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang.

I pushed Andrew's fix (thanks!) (with minor formatting tweaks) in dbb0d8ecb3a024bd6817ebd8ad8c5c199a51d933 . Let me know if you still see issues.

Apr 4 2020, 5:47 AM · Restricted Project, Restricted Project

Apr 3 2020

CarlosAlbertoEnciso added a comment to D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang.

Thanks!

Apr 3 2020, 1:34 AM · Restricted Project, Restricted Project

Feb 11 2019

CarlosAlbertoEnciso committed rGe848d426a7dd: [DWARF] LLVM ERROR: Broken function found, while removing Debug Intrinsics. (authored by CarlosAlbertoEnciso).
[DWARF] LLVM ERROR: Broken function found, while removing Debug Intrinsics.
Feb 11 2019, 2:19 AM
CarlosAlbertoEnciso added a comment to D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.

@aprantl, as per your feedback I have moved the test case to the correct location.

Feb 11 2019, 2:19 AM · Restricted Project, debug-info

Feb 8 2019

CarlosAlbertoEnciso added a comment to D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.

Sorry for not noticing this before, but we noticed now that the test case is placed under test/CodeGen/X86/, although it is a simplifycfg test. Should it ideally be placed under test/Transforms/SimplifyCFG/?

Feb 8 2019, 7:19 AM · Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.

Thanks @aprantl, @uabelho for your valuable review.

Feb 8 2019, 3:16 AM · Restricted Project, debug-info
CarlosAlbertoEnciso committed rG08dc50f2fb82: [DWARF] LLVM ERROR: Broken function found, while removing Debug Intrinsics. (authored by CarlosAlbertoEnciso).
[DWARF] LLVM ERROR: Broken function found, while removing Debug Intrinsics.
Feb 8 2019, 2:57 AM

Feb 7 2019

CarlosAlbertoEnciso added inline comments to D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.
Feb 7 2019, 5:47 AM · Restricted Project, debug-info
CarlosAlbertoEnciso updated the diff for D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.

Updated patch to address comments from @aprantl .

Feb 7 2019, 5:37 AM · Restricted Project, debug-info

Jan 31 2019

CarlosAlbertoEnciso updated the diff for D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.

Updated patch to remove the negative CHECK. Thanks for your feedback.

Jan 31 2019, 5:18 AM · Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.
Jan 31 2019, 5:15 AM · Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.
Jan 31 2019, 2:27 AM · Restricted Project, debug-info
CarlosAlbertoEnciso updated the diff for D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.

Thanks very much for your invaluable feedback and reviews.

Jan 31 2019, 2:26 AM · Restricted Project, debug-info

Jan 30 2019

CarlosAlbertoEnciso created D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.
Jan 30 2019, 3:37 AM · Restricted Project, debug-info

Jan 15 2019

CarlosAlbertoEnciso added inline comments to D56265: [DebugInfo] MCP: collect and update DBG_VALUEs encountered in local block.
Jan 15 2019, 6:21 AM · Restricted Project

Jan 10 2019

CarlosAlbertoEnciso added inline comments to D56265: [DebugInfo] MCP: collect and update DBG_VALUEs encountered in local block.
Jan 10 2019, 6:55 AM · Restricted Project
CarlosAlbertoEnciso added inline comments to D56265: [DebugInfo] MCP: collect and update DBG_VALUEs encountered in local block.
Jan 10 2019, 6:53 AM · Restricted Project

Nov 13 2018

CarlosAlbertoEnciso added a comment to rL346726: [BuildingAJIT] Update chapter 2 to use the ORCv2 APIs..

Your change seems to cause build failures. The following is the error message:

Nov 13 2018, 7:23 AM

Nov 8 2018

CarlosAlbertoEnciso updated the diff for D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

@vsk: I have updated the patch to remove the test case pr39187-gline-tables-only.ll, as per your suggestion.

Nov 8 2018, 2:30 AM · debug-info

Nov 7 2018

CarlosAlbertoEnciso added inline comments to D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Nov 7 2018, 8:24 AM · debug-info
CarlosAlbertoEnciso updated the diff for D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Thanks for your comments.

Nov 7 2018, 8:22 AM · debug-info

Nov 6 2018

CarlosAlbertoEnciso added inline comments to D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Nov 6 2018, 12:57 AM · debug-info

Nov 5 2018

CarlosAlbertoEnciso added inline comments to D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Nov 5 2018, 11:51 PM · debug-info
CarlosAlbertoEnciso added inline comments to D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Nov 5 2018, 6:56 AM · debug-info
CarlosAlbertoEnciso added inline comments to D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Nov 5 2018, 4:23 AM · debug-info

Oct 30 2018

CarlosAlbertoEnciso added inline comments to D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Oct 30 2018, 5:51 AM · debug-info
CarlosAlbertoEnciso updated the diff for D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Thanks for your comments. I have updated the patch to address them.

Oct 30 2018, 5:51 AM · debug-info

Oct 29 2018

CarlosAlbertoEnciso added a comment to D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Ping.

Oct 29 2018, 5:45 AM · debug-info

Oct 25 2018

CarlosAlbertoEnciso added a comment to D52932: [MCSched] Bind PFM Counters to the CPUs instead of the SchedModel..

@courbet: Your commit seems to cause build issues:

Oct 25 2018, 3:49 AM
CarlosAlbertoEnciso added a comment to D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

@aprantl, @vsk: Thanks very much for your valuable comments and suggestions.

Oct 25 2018, 2:59 AM · debug-info
CarlosAlbertoEnciso added a comment to D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
In D53287#1274290, @vsk wrote:

LGTM, thanks. I'm sorry for the delay in reviewing this.

Oct 25 2018, 2:57 AM · debug-info

Oct 24 2018

CarlosAlbertoEnciso added a comment to D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

@vsk: Do you have any additional comments? It is OK for you if I commit the patch?

Oct 24 2018, 7:26 AM · debug-info

Oct 18 2018

CarlosAlbertoEnciso created D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Oct 18 2018, 3:35 AM · debug-info

Oct 16 2018

CarlosAlbertoEnciso added inline comments to D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Oct 16 2018, 7:09 AM · debug-info
CarlosAlbertoEnciso updated the diff for D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Address issues raised by @aprantl.

Oct 16 2018, 7:08 AM · debug-info

Oct 15 2018

CarlosAlbertoEnciso abandoned D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

This revision caused builbot failures.

Oct 15 2018, 7:16 AM · debug-info
CarlosAlbertoEnciso created D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Oct 15 2018, 7:13 AM · debug-info

Oct 11 2018

CarlosAlbertoEnciso reopened D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

The patch caused some assertions. For more details see PR39243.

Oct 11 2018, 11:52 AM · debug-info

Oct 10 2018

CarlosAlbertoEnciso added a comment to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

@mstorsjo, The change has been reverted. Thanks for creating the bugzilla.

Oct 10 2018, 5:16 AM · debug-info
CarlosAlbertoEnciso added a comment to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

This broke compilation for me, compiling some source files now fail due to triggered assertions, see PR39243 for details. I guess I'll revert this in a while unless there's someone to fix it soon.

Oct 10 2018, 5:05 AM · debug-info
CarlosAlbertoEnciso added a comment to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Thanks very much to all the reviewers for your valuable comments and suggestions.

Oct 10 2018, 12:56 AM · debug-info

Oct 9 2018

CarlosAlbertoEnciso updated the diff for D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Address issues raised by the reviewers.

Oct 9 2018, 3:39 AM · debug-info

Oct 8 2018

CarlosAlbertoEnciso updated the diff for D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Address issues raised by the reviewers.

Oct 8 2018, 7:27 AM · debug-info
CarlosAlbertoEnciso added inline comments to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Oct 8 2018, 7:18 AM · debug-info

Oct 5 2018

CarlosAlbertoEnciso updated the diff for D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Address issues raised by the reviewers.

Oct 5 2018, 5:16 AM · debug-info
CarlosAlbertoEnciso added inline comments to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Oct 5 2018, 5:11 AM · debug-info

Oct 4 2018

CarlosAlbertoEnciso created D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Oct 4 2018, 7:09 AM · debug-info

Oct 1 2018

CarlosAlbertoEnciso added a comment to D52614: [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal..

Thanks very much to all the reviewers for your valuable comments and suggestions.

Oct 1 2018, 1:17 AM · debug-info

Sep 28 2018

CarlosAlbertoEnciso updated the diff for D52614: [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal..

Address issues raised by the reviewers.

Sep 28 2018, 8:34 AM · debug-info
CarlosAlbertoEnciso retitled D52614: [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal. from [DebugInfo][Dexter] Divide-before-return displays wrong value in debugger to [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal..
Sep 28 2018, 8:30 AM · debug-info
CarlosAlbertoEnciso added inline comments to D52614: [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal..
Sep 28 2018, 8:28 AM · debug-info
CarlosAlbertoEnciso added a comment to D52614: [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal..

It would be good to change the title to reflect what is done in MCP (at least before submitting this).

Sep 28 2018, 3:45 AM · debug-info

Sep 27 2018

CarlosAlbertoEnciso created D52614: [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal..
Sep 27 2018, 8:01 AM · debug-info

Sep 19 2018

CarlosAlbertoEnciso added a comment to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

Thanks very much to all the reviewers for your valuable comments and suggestions.

Sep 19 2018, 1:12 AM · debug-info

Sep 18 2018

CarlosAlbertoEnciso added inline comments to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.
Sep 18 2018, 7:02 AM · debug-info
CarlosAlbertoEnciso updated the diff for D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

The general preference seems to land this patch as-is.

Sep 18 2018, 1:31 AM · debug-info
CarlosAlbertoEnciso added inline comments to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.
Sep 18 2018, 1:24 AM · debug-info

Sep 17 2018

CarlosAlbertoEnciso added a comment to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

@aprantl and @probinson,

Sep 17 2018, 12:11 PM · debug-info
CarlosAlbertoEnciso updated the diff for D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

Address issues raised by the reviewers.

Sep 17 2018, 7:24 AM · debug-info
CarlosAlbertoEnciso added a comment to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

Having read the real testcase now, I understand why you are dropping the debug info now. I would like to point out that we could do better. If we extended llvm.dbg.value to take more than one LLVM SSA Value, then we could produce a DIExpression that selects either %add or %sub depending on the value of %cmp. Let me know if you are interested in implementing this, it should be relatively straight forward to do and would come in useful in all sorts of other situations, too.

Sep 17 2018, 7:17 AM · debug-info

Sep 14 2018

CarlosAlbertoEnciso updated the diff for D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

Address issues raised by the reviewers.

Sep 14 2018, 7:37 AM · debug-info
CarlosAlbertoEnciso added inline comments to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.
Sep 14 2018, 7:23 AM · debug-info
CarlosAlbertoEnciso updated the diff for D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

Address issues raised by the reviewers.

Sep 14 2018, 7:12 AM · debug-info

Sep 13 2018

CarlosAlbertoEnciso added a comment to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

It still isn't clear to me why you need to drop the debug info in the first place (instead of e.g., making it point to the select, or leave it on its operands) but I hope that that will become obvious once I see the actual testcase.

Sep 13 2018, 11:59 AM · debug-info