User Details
- User Since
- Aug 14 2017, 4:02 AM (292 w, 4 d)
Fri, Mar 17
Wed, Mar 15
https://reviews.llvm.org/D144857 added the README for the tool.
@Orlando Thanks very much for your review.
Mon, Feb 27
These are the next 2 patches:
Feb 16 2023
To all reviewers,
Updated patch to reflect changes from 08a-memory-management.
@Orlando Do you have any additional comments on the updated patch?
Update the patch to reflect a change based on @dblaikie feedback.
Feb 15 2023
@dblaikie: Thanks for your valuable feedback.
Address feedback from @dblaikie.
Feb 13 2023
@jmorse Thanks for your review.
Feb 12 2023
Feb 10 2023
Feb 9 2023
@dblaikie Do you have any additional questions or concerns that I have not answered it? Thanks.
Feb 3 2023
Feb 2 2023
Jan 31 2023
Jan 23 2023
Address the feedback from @Orlando:
Jan 20 2023
LGTM
May be add some explanatory notes for the change to 'private'.
Jan 19 2023
This patch uses the new SpecificBumpPtrAllocator functionality to manage the creation of logical elements.
I have explored several options for how to model the pointer ownership, and I think SpecificBumpPtrAllocator is probably the best, my reasoning is below.
Address @dblaikie concerns on the use of a bucket with smart pointers.
Jan 12 2023
@dblaikie: I am sorry for my delay in addressing your feedback/concerns. I just came last week from a long annual leave (from Nov 19th).
Nov 17 2022
To all reviewers,
To all reviewers,
Nov 16 2022
Updated patch addressing @dblaikie review.
Owner | What | Tracked |
LVReaderHander | LVReader | TheReaders |
LVReader | Logical Elements | AllocatedObjects |
LVReader | LVLineAssembler | DiscoveredLines |
The main logical unit is the LVReader, which is the main access point from the user point of view. Its functions are:
- Load the binary file
- Parse the debug information
- Create the logical view which is a tree composed of logical elements (LVScopes, LVSymbols, LVTypes and LVLines, etc.). Depending on the command line options, additional information is added to the those logical elements.
- Print the logical view.
- Select logical elements using user criterias.
- Compare two `logical views'.
Nov 15 2022
Nov 14 2022
@dblaikie A new patch has been uploaded that addresses the memory management issues: https://reviews.llvm.org/D137933 (10 Smart pointers).
Nov 4 2022
@mgorny Can you update and close https://github.com/llvm/llvm-project/issues/58758 after your fix is landed. Thanks.
@mgorny submitted a correct patch.
https://reviews.llvm.org/D137400
LGTM.
Nov 3 2022
Nov 2 2022
Updated patch that includes:
The test case tools/llvm-debuginfo-analyzer/DWARF/06-dwarf-full-logical-view.test was disabled due to unexpected output:
Nov 1 2022
Thanks very much for your review.
Still the same questing as before: Can this code avoid using directly new/delete and rely on unique_ptrs?
The test case tools/llvm-debuginfo-analyzer/DWARF/pr-incorrect-logical-instructions.test was disabled due to memory leak detected by the sanitizers.
Oct 31 2022
After installing gcc-i686-linux-gnu and using
CC='/usr/bin/i686-linux-gnu-gcc -m32' CXX='/usr/bin/i686-linux-gnu-g++ -m32' cmake ../llvm -GNinja -DBUILD_SHARED_LIBS=OFF -DCMAKE_BUILD_TYPE=MinSizeRel -DLLVM_TARGETS_TO_BUILD=X86 -DCLANG_ENABLE_ARCMT=OFF -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_CCACHE_BUILD=ON -DLLVM_ENABLE_PROJECTS="llvm" -DLLVM_BUILD_TESTS=OFF -DLLVM_HOST_TRIPLE=i686-pc-linux-gnu
I can reproduce the problem with
Very much appreciated your input and I fully understand your concerns about code reviews and large/complex patches.