Page MenuHomePhabricator

CarlosAlbertoEnciso (Carlos Alberto Enciso)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2017, 4:02 AM (292 w, 4 d)

Recent Activity

Fri, Mar 17

CarlosAlbertoEnciso committed rGca3f7a5c06f9: [Docs] Fix typo in LoopTerminology. (authored by CarlosAlbertoEnciso).
[Docs] Fix typo in LoopTerminology.
Fri, Mar 17, 6:43 AM · Restricted Project, Restricted Project

Wed, Mar 15

CarlosAlbertoEnciso added a comment to D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.

https://reviews.llvm.org/D144857 added the README for the tool.

Wed, Mar 15, 10:50 PM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso closed D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.
Wed, Mar 15, 10:25 PM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D144857: [llvm-debuginfo-analyzer] README.

@Orlando Thanks very much for your review.

Wed, Mar 15, 6:40 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso committed rG82238fc7765b: [llvm-debuginfo-analyzer] README (authored by CarlosAlbertoEnciso).
[llvm-debuginfo-analyzer] README
Wed, Mar 15, 6:35 AM · Restricted Project, Restricted Project
CarlosAlbertoEnciso closed D144857: [llvm-debuginfo-analyzer] README.
Wed, Mar 15, 6:34 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added inline comments to D144857: [llvm-debuginfo-analyzer] README.
Wed, Mar 15, 6:14 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso updated the diff for D144857: [llvm-debuginfo-analyzer] README.
Wed, Mar 15, 2:49 AM · Restricted Project, debug-info, Restricted Project

Mon, Feb 27

CarlosAlbertoEnciso added inline comments to D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.
Mon, Feb 27, 2:19 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D144857: [llvm-debuginfo-analyzer] README.

These are the next 2 patches:

Mon, Feb 27, 2:06 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso requested review of D144857: [llvm-debuginfo-analyzer] README.
Mon, Feb 27, 1:51 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso committed rGe7950fceb1e7: [llvm-debuginfo-analyzer] (09/09) - CodeView Reader (authored by CarlosAlbertoEnciso).
[llvm-debuginfo-analyzer] (09/09) - CodeView Reader
Mon, Feb 27, 1:25 AM · Restricted Project, Restricted Project
CarlosAlbertoEnciso closed D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader.
Mon, Feb 27, 1:25 AM · Restricted Project, Restricted Project, debug-info

Feb 16 2023

CarlosAlbertoEnciso added a comment to D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader.

To all reviewers,

Feb 16 2023, 6:30 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the diff for D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader.

Updated patch to reflect changes from 08a-memory-management.

Feb 16 2023, 6:29 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.

@dblaikie, @Orlando Thanks very much for your valuable feedback.

Feb 16 2023, 2:35 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso committed rG7fbcc24409ef: [llvm-debuginfo-analyzer] (08a/09) - Memory Management (authored by CarlosAlbertoEnciso).
[llvm-debuginfo-analyzer] (08a/09) - Memory Management
Feb 16 2023, 2:32 AM · Restricted Project, Restricted Project
CarlosAlbertoEnciso closed D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.
Feb 16 2023, 2:32 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.
Feb 16 2023, 1:31 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.

@Orlando Do you have any additional comments on the updated patch?

Feb 16 2023, 12:22 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.
Feb 16 2023, 12:21 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the diff for D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.

Update the patch to reflect a change based on @dblaikie feedback.

Feb 16 2023, 12:21 AM · Restricted Project, Restricted Project, debug-info

Feb 15 2023

CarlosAlbertoEnciso added a comment to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.

@dblaikie: Thanks for your valuable feedback.

Feb 15 2023, 5:39 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the diff for D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.

Address feedback from @dblaikie.

Feb 15 2023, 5:38 AM · Restricted Project, Restricted Project, debug-info

Feb 13 2023

CarlosAlbertoEnciso added a comment to D143716: [llvm-debuginfo-analyzer] LLVM 16.0.0-rc1 Failing test on osx-64..

@jmorse Thanks for your review.

Feb 13 2023, 12:01 AM · Restricted Project, Restricted Project, debug-info

Feb 12 2023

CarlosAlbertoEnciso added a comment to D143716: [llvm-debuginfo-analyzer] LLVM 16.0.0-rc1 Failing test on osx-64..

Tested this patch in https://github.com/conda-forge/llvmdev-feedstock/pull/198, can confirm it works. Thanks a lot!

Feb 12 2023, 9:52 PM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso committed rG92716a42a6aa: [llvm-debuginfo-analyzer] LLVM 16.0.0-rc1 Failing test on osx-64. (authored by CarlosAlbertoEnciso).
[llvm-debuginfo-analyzer] LLVM 16.0.0-rc1 Failing test on osx-64.
Feb 12 2023, 9:48 PM · Restricted Project, Restricted Project
CarlosAlbertoEnciso closed D143716: [llvm-debuginfo-analyzer] LLVM 16.0.0-rc1 Failing test on osx-64..
Feb 12 2023, 9:48 PM · Restricted Project, Restricted Project, debug-info

Feb 10 2023

CarlosAlbertoEnciso added inline comments to D143716: [llvm-debuginfo-analyzer] LLVM 16.0.0-rc1 Failing test on osx-64..
Feb 10 2023, 4:30 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated subscribers of D143716: [llvm-debuginfo-analyzer] LLVM 16.0.0-rc1 Failing test on osx-64..
Feb 10 2023, 2:11 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso requested review of D143716: [llvm-debuginfo-analyzer] LLVM 16.0.0-rc1 Failing test on osx-64..
Feb 10 2023, 2:10 AM · Restricted Project, Restricted Project, debug-info

Feb 9 2023

CarlosAlbertoEnciso added a comment to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.

@dblaikie Do you have any additional questions or concerns that I have not answered it? Thanks.

Feb 9 2023, 4:16 AM · Restricted Project, Restricted Project, debug-info

Feb 3 2023

CarlosAlbertoEnciso added inline comments to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.
Feb 3 2023, 2:56 AM · Restricted Project, Restricted Project, debug-info

Feb 2 2023

CarlosAlbertoEnciso added a comment to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.

That's all of my concerns addressed now, so this LGTM. Thanks @CarlosAlbertoEnciso for your detailed responses.

I won't hit accept though in case @dblaikie has further comments on this new approach.

Feb 2 2023, 2:45 AM · Restricted Project, Restricted Project, debug-info

Jan 31 2023

CarlosAlbertoEnciso added inline comments to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.
Jan 31 2023, 5:20 AM · Restricted Project, Restricted Project, debug-info

Jan 23 2023

CarlosAlbertoEnciso updated the diff for D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.

Address the feedback from @Orlando:

Jan 23 2023, 5:30 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.
Jan 23 2023, 5:27 AM · Restricted Project, Restricted Project, debug-info

Jan 20 2023

CarlosAlbertoEnciso accepted D141854: [Assignment Tracking] Fix invalidated iterator usage.

LGTM

Jan 20 2023, 5:56 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso accepted D142027: [Assignment Tracking][NFC] Replace LLVM command line option with a new module flag.

May be add some explanatory notes for the change to 'private'.

Jan 20 2023, 5:42 AM · Restricted Project, Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added inline comments to D142027: [Assignment Tracking][NFC] Replace LLVM command line option with a new module flag.
Jan 20 2023, 5:39 AM · Restricted Project, Restricted Project, debug-info, Restricted Project

Jan 19 2023

CarlosAlbertoEnciso updated the diff for D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader.

This patch uses the new SpecificBumpPtrAllocator functionality to manage the creation of logical elements.

Jan 19 2023, 6:02 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader.
Jan 19 2023, 6:01 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.

I have explored several options for how to model the pointer ownership, and I think SpecificBumpPtrAllocator is probably the best, my reasoning is below.

Jan 19 2023, 4:31 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the diff for D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.

Address @dblaikie concerns on the use of a bucket with smart pointers.

Jan 19 2023, 4:23 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.
Jan 19 2023, 4:18 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso retitled D137933: [llvm-debuginfo-analyzer] 08a - Memory Management from [llvm-debuginfo-analyzer] 10 - Smart Pointers to [llvm-debuginfo-analyzer] 08a - Memory Management.
Jan 19 2023, 4:13 AM · Restricted Project, Restricted Project, debug-info

Jan 12 2023

CarlosAlbertoEnciso added a comment to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.

@dblaikie: I am sorry for my delay in addressing your feedback/concerns. I just came last week from a long annual leave (from Nov 19th).

Jan 12 2023, 12:48 AM · Restricted Project, Restricted Project, debug-info

Nov 17 2022

CarlosAlbertoEnciso added a comment to D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader.

To all reviewers,

Nov 17 2022, 10:04 PM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader.

To all reviewers,

Nov 17 2022, 10:02 PM · Restricted Project, Restricted Project, debug-info

Nov 16 2022

CarlosAlbertoEnciso added a comment to D138092: [llvm-debuginfo-analyzer] Return by reference instead of value - Warning analysis data..

Sounds good (this sort of cleanup is fine for post-commit review, FWIW)

Nov 16 2022, 10:34 PM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso committed rGd896ea75c591: [llvm-debuginfo-analyzer] Return by reference instead of value. (authored by CarlosAlbertoEnciso).
[llvm-debuginfo-analyzer] Return by reference instead of value.
Nov 16 2022, 10:33 PM · Restricted Project, Restricted Project
CarlosAlbertoEnciso closed D138092: [llvm-debuginfo-analyzer] Return by reference instead of value - Warning analysis data..
Nov 16 2022, 10:32 PM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso updated the diff for D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.

Updated patch addressing @dblaikie review.

Nov 16 2022, 5:45 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.
Nov 16 2022, 5:43 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.
OwnerWhatTracked
LVReaderHanderLVReaderTheReaders
LVReaderLogical ElementsAllocatedObjects
LVReaderLVLineAssemblerDiscoveredLines
Nov 16 2022, 5:22 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.

The main logical unit is the LVReader, which is the main access point from the user point of view. Its functions are:

  • Load the binary file
  • Parse the debug information
  • Create the logical view which is a tree composed of logical elements (LVScopes, LVSymbols, LVTypes and LVLines, etc.). Depending on the command line options, additional information is added to the those logical elements.
  • Print the logical view.
  • Select logical elements using user criterias.
  • Compare two `logical views'.
Nov 16 2022, 4:30 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.
Nov 16 2022, 2:45 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.
Nov 16 2022, 12:35 AM · Restricted Project, Restricted Project, debug-info

Nov 15 2022

CarlosAlbertoEnciso added inline comments to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.
Nov 15 2022, 10:15 PM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso requested review of D138092: [llvm-debuginfo-analyzer] Return by reference instead of value - Warning analysis data..
Nov 15 2022, 10:12 PM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added a comment to D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.

(some suggestions here might be too noisy to do all in this review - maybe a matter of splitting things up - the discussion about new data structures/changes in ownership might be one of those worth breaking down into smaller steps, not sure)

Perhaps some general discussion about the ownership/lifetime model of everything here would be useful to add to the patch description to get a general lay of the land?

Nov 15 2022, 6:58 AM · Restricted Project, Restricted Project, debug-info

Nov 14 2022

CarlosAlbertoEnciso added inline comments to D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.
Nov 14 2022, 4:17 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D125778: [llvm-debuginfo-analyzer] 03 - Logical elements.

@dblaikie A new patch has been uploaded that addresses the memory management issues: https://reviews.llvm.org/D137933 (10 Smart pointers).

Nov 14 2022, 4:13 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader.
Nov 14 2022, 4:03 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.
Nov 14 2022, 4:03 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D125782: [llvm-debuginfo-analyzer] 07 - Compare elements.
Nov 14 2022, 4:02 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D125781: [llvm-debuginfo-analyzer] 06 - Warning and internal options.
Nov 14 2022, 4:02 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D125780: [llvm-debuginfo-analyzer] 05 - Select elements.
Nov 14 2022, 4:02 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D125779: [llvm-debuginfo-analyzer] 04 - Locations and ranges.
Nov 14 2022, 4:01 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D125778: [llvm-debuginfo-analyzer] 03 - Logical elements.
Nov 14 2022, 4:01 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D125777: [llvm-debuginfo-analyzer] 02 - Driver and documentation.
Nov 14 2022, 4:01 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso updated the summary of D125776: [llvm-debuginfo-analyzer] 01 - Interval tree.
Nov 14 2022, 4:00 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso updated the summary of D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.
Nov 14 2022, 3:53 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso requested review of D137933: [llvm-debuginfo-analyzer] 08a - Memory Management.
Nov 14 2022, 3:53 AM · Restricted Project, Restricted Project, debug-info

Nov 4 2022

CarlosAlbertoEnciso updated subscribers of D137400: [llvm-debuginfo-analyzer] Fix format string-type mismatch in LVScope.
Nov 4 2022, 4:39 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso added a comment to D137400: [llvm-debuginfo-analyzer] Fix format string-type mismatch in LVScope.

@mgorny Can you update and close https://github.com/llvm/llvm-project/issues/58758 after your fix is landed. Thanks.

Nov 4 2022, 4:19 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso abandoned D137242: [llvm-debuginfo-analyzer] Remove '--print=sizes' in test case..

@mgorny submitted a correct patch.
https://reviews.llvm.org/D137400

Nov 4 2022, 4:14 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso accepted D137400: [llvm-debuginfo-analyzer] Fix format string-type mismatch in LVScope.

LGTM.

Nov 4 2022, 4:11 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso added a comment to D137400: [llvm-debuginfo-analyzer] Fix format string-type mismatch in LVScope.

That said, I've only checked format strings in LVScope.cpp. I suspect other files may suffer from similar problems. If you replace llvm::format() with plain printf(), 32-bit GCC warns about type mismatches.

Nov 4 2022, 4:09 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso added a comment to D137242: [llvm-debuginfo-analyzer] Remove '--print=sizes' in test case..

D137400 is the proper fix.

Nov 4 2022, 3:35 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D137242: [llvm-debuginfo-analyzer] Remove '--print=sizes' in test case..

I suppose this makes sense as a stop-gap measure but the option should be fixed to work on all platforms.

Nov 4 2022, 3:31 AM · Restricted Project, Restricted Project, debug-info

Nov 3 2022

CarlosAlbertoEnciso added inline comments to D125778: [llvm-debuginfo-analyzer] 03 - Logical elements.
Nov 3 2022, 8:37 AM · Restricted Project, Restricted Project, debug-info

Nov 2 2022

CarlosAlbertoEnciso added a comment to D137156: [llvm-debuginfo-analyzer] Fix memory leak reported by sanitizers..

Based on your suggestion, I can create a GitHub issue to include all the information and add that link to each of the entries in the reviews that refer to the memory handling.

I think it would be best to prioritise creating this issue quite soon (in the next few days), as it would be good to have on hand when discussing the current status of any other memory-related issues that arise with the tool.

Nov 2 2022, 7:27 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added inline comments to D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.
Nov 2 2022, 6:19 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the diff for D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader.

Updated patch that includes:

Nov 2 2022, 6:15 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.

The test case tools/llvm-debuginfo-analyzer/DWARF/06-dwarf-full-logical-view.test was disabled due to unexpected output:

Nov 2 2022, 4:19 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a reviewer for D137242: [llvm-debuginfo-analyzer] Remove '--print=sizes' in test case.: mgorny.
Nov 2 2022, 4:12 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso requested review of D137242: [llvm-debuginfo-analyzer] Remove '--print=sizes' in test case..
Nov 2 2022, 4:11 AM · Restricted Project, Restricted Project, debug-info

Nov 1 2022

CarlosAlbertoEnciso committed rG9d56d9a95fcf: [llvm-debuginfo-analyzer] Fix memory leak reported by sanitizers. (authored by CarlosAlbertoEnciso).
[llvm-debuginfo-analyzer] Fix memory leak reported by sanitizers.
Nov 1 2022, 11:08 PM · Restricted Project, Restricted Project
CarlosAlbertoEnciso closed D137156: [llvm-debuginfo-analyzer] Fix memory leak reported by sanitizers..
Nov 1 2022, 11:08 PM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added a comment to D137156: [llvm-debuginfo-analyzer] Fix memory leak reported by sanitizers..

LGTM if this fixes the bug

Thanks very much for your review.

Still the same questing as before: Can this code avoid using directly new/delete and rely on unique_ptrs?

Nov 1 2022, 10:48 PM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added a comment to D137156: [llvm-debuginfo-analyzer] Fix memory leak reported by sanitizers..

Thanks, this looks reasonable to me! 🙂

Were you able to reproduce the failure locally?

Nov 1 2022, 9:55 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso updated the summary of D137156: [llvm-debuginfo-analyzer] Fix memory leak reported by sanitizers..
Nov 1 2022, 6:30 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added a comment to D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.

The test case tools/llvm-debuginfo-analyzer/DWARF/pr-incorrect-logical-instructions.test was disabled due to memory leak detected by the sanitizers.

Nov 1 2022, 6:24 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso requested review of D137156: [llvm-debuginfo-analyzer] Fix memory leak reported by sanitizers..
Nov 1 2022, 6:16 AM · Restricted Project, debug-info, Restricted Project

Oct 31 2022

CarlosAlbertoEnciso added a comment to D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.

After installing gcc-i686-linux-gnu and using

CC='/usr/bin/i686-linux-gnu-gcc -m32' CXX='/usr/bin/i686-linux-gnu-g++ -m32' cmake ../llvm -GNinja -DBUILD_SHARED_LIBS=OFF -DCMAKE_BUILD_TYPE=MinSizeRel -DLLVM_TARGETS_TO_BUILD=X86 -DCLANG_ENABLE_ARCMT=OFF -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_CCACHE_BUILD=ON -DLLVM_ENABLE_PROJECTS="llvm" -DLLVM_BUILD_TESTS=OFF -DLLVM_HOST_TRIPLE=i686-pc-linux-gnu

I can reproduce the problem with

Oct 31 2022, 10:54 PM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.

As you are building on i386, can I have the CMake configuration?

Just to be clear, I'm building 32-bit multilib on amd64.
But I can also reproduce in my working copy that's configured as:

CC=i686-pc-linux-gnu-gcc CXX=i686-pc-linux-gnu-g++ cmake ../llvm -G Ninja -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=MinSizeRel -DLLVM_TARGETS_TO_BUILD=X86 -DCLANG_ENABLE_ARCMT=OFF -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_CCACHE_BUILD=ON -DLLVM_ENABLE_PROJECTS='llvm' -DLLVM_BUILD_TESTS=OFF -DLLVM_HOST_TRIPLE=i686-pc-linux-gnu

where i686-pc-linux-gnu-* wrappers simply call the respective GCC executables with -m32.

Oct 31 2022, 8:27 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.

A bit concerned about two things that happened here (though, apologies as I haven't otherwise been following the review):

Very much appreciated your input and I fully understand your concerns about code reviews and large/complex patches.

Oct 31 2022, 1:49 AM · Restricted Project, Restricted Project, debug-info

Oct 30 2022

CarlosAlbertoEnciso updated subscribers of D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.

This is also broken on i386 (so perhaps on all 32-bit platforms?):

Input was:
           76:        189 (  0.00%) : [0x000000000b][001]              {CompileUnit} 'test.cpp' 
           77:        110 ( -0.00%) : [0x000000002a][002]      2         {Function} extern not_inlined 'foo' -> [0x0000000099]'int' 
           78:         27 (-26815615859885194199148049996411692254958731641184786755447122887443528060147093953603748596333806855380063716372972101707507765623893139892867298012168192.00%) : [0x0000000071][003]                  {Block}
Oct 30 2022, 11:43 PM · Restricted Project, Restricted Project, debug-info

Oct 28 2022

CarlosAlbertoEnciso closed D136593: [llvm-debuginfo-analyzer] (07/09) - Compare elements - Test case (AddressSanitizer: leaked in allocations).

Commit: https://reviews.llvm.org/rGcddea67663655591b3d650d81d6546abbdc50ae5

Oct 28 2022, 6:09 AM · Restricted Project, debug-info, Restricted Project