Page MenuHomePhabricator

CarlosAlbertoEnciso (Carlos Alberto Enciso)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2017, 4:02 AM (255 w, 3 d)

Recent Activity

Today

CarlosAlbertoEnciso added inline comments to D125782: [llvm-dva] 07 - Compare elements.
Thu, Jul 7, 6:18 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D125781: [llvm-dva] 06 - Warning and internal options.
Thu, Jul 7, 3:14 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added a comment to D127938: Update Windows packaging script..

I have created https://reviews.llvm.org/D129263
That patch address only the symbolic link creation issue. (Administrator permissions and/or 7-zip version).

Thu, Jul 7, 1:40 AM · Restricted Project, Restricted Project
CarlosAlbertoEnciso requested review of D129263: Windows packaging script. Check administrator permissions and/or 7-Zip version..
Thu, Jul 7, 1:38 AM · Restricted Project, Restricted Project

Yesterday

CarlosAlbertoEnciso added inline comments to D125779: [llvm-dva] 04 - Locations and ranges.
Wed, Jul 6, 10:17 PM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D125781: [llvm-dva] 06 - Warning and internal options.
Wed, Jul 6, 3:55 AM · Restricted Project, debug-info, Restricted Project

Tue, Jul 5

CarlosAlbertoEnciso added inline comments to D125781: [llvm-dva] 06 - Warning and internal options.
Tue, Jul 5, 6:40 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added inline comments to D125779: [llvm-dva] 04 - Locations and ranges.
Tue, Jul 5, 2:13 AM · Restricted Project, Restricted Project, debug-info

Fri, Jul 1

CarlosAlbertoEnciso added inline comments to D125781: [llvm-dva] 06 - Warning and internal options.
Fri, Jul 1, 5:43 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added inline comments to D125780: [llvm-dva] 05 - Select elements.
Fri, Jul 1, 4:08 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added inline comments to D125779: [llvm-dva] 04 - Locations and ranges.
Fri, Jul 1, 1:28 AM · Restricted Project, Restricted Project, debug-info

Thu, Jun 30

CarlosAlbertoEnciso added inline comments to D125779: [llvm-dva] 04 - Locations and ranges.
Thu, Jun 30, 3:58 AM · Restricted Project, Restricted Project, debug-info

Wed, Jun 29

CarlosAlbertoEnciso added inline comments to D125778: [llvm-dva] 03 - Logical elements.
Wed, Jun 29, 11:48 PM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added inline comments to D125778: [llvm-dva] 03 - Logical elements.
Wed, Jun 29, 1:25 AM · Restricted Project, debug-info, Restricted Project

Tue, Jun 28

CarlosAlbertoEnciso added inline comments to D125778: [llvm-dva] 03 - Logical elements.
Tue, Jun 28, 6:08 AM · Restricted Project, debug-info, Restricted Project

Mon, Jun 27

CarlosAlbertoEnciso added inline comments to D125778: [llvm-dva] 03 - Logical elements.
Mon, Jun 27, 4:10 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added inline comments to D125778: [llvm-dva] 03 - Logical elements.
Mon, Jun 27, 2:21 AM · Restricted Project, debug-info, Restricted Project

Sun, Jun 26

CarlosAlbertoEnciso added inline comments to D127938: Update Windows packaging script..
Sun, Jun 26, 9:58 PM · Restricted Project, Restricted Project

Fri, Jun 24

CarlosAlbertoEnciso added a comment to D125777: [llvm-dva] 02 - Driver and documentation.

@CarlosAlbertoEnciso You are welcome! I'll be glad if my modest efforts help you to land this amazing tool.

Fri, Jun 24, 6:14 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso added inline comments to D125777: [llvm-dva] 02 - Driver and documentation.
Fri, Jun 24, 5:38 AM · debug-info, Restricted Project, Restricted Project

Thu, Jun 23

CarlosAlbertoEnciso added inline comments to D125777: [llvm-dva] 02 - Driver and documentation.
Thu, Jun 23, 3:43 AM · debug-info, Restricted Project, Restricted Project

Tue, Jun 21

CarlosAlbertoEnciso added a comment to D127938: Update Windows packaging script..

What I would suggest is to have the following incremental patches:

Tue, Jun 21, 12:37 AM · Restricted Project, Restricted Project

Mon, Jun 20

CarlosAlbertoEnciso added inline comments to D127938: Update Windows packaging script..
Mon, Jun 20, 4:24 AM · Restricted Project, Restricted Project
CarlosAlbertoEnciso added a comment to D127938: Update Windows packaging script..

Taking a step back, at this point the patch is almost a rewrite of the current script. It's doing a lot of different things, and I'm not sure I agree with all of them. Perhaps we need to discuss a bit more what are the goals of these changes, and whether they can be done as a series of incremental patches rather than a rewrite.

Mon, Jun 20, 3:30 AM · Restricted Project, Restricted Project
CarlosAlbertoEnciso updated the summary of D127938: Update Windows packaging script..
Mon, Jun 20, 1:34 AM · Restricted Project, Restricted Project
CarlosAlbertoEnciso updated the diff for D127938: Update Windows packaging script..

Update patch to address the feedback received.

Mon, Jun 20, 1:33 AM · Restricted Project, Restricted Project

Sun, Jun 19

CarlosAlbertoEnciso added inline comments to D127938: Update Windows packaging script..
Sun, Jun 19, 9:54 PM · Restricted Project, Restricted Project
CarlosAlbertoEnciso added inline comments to D127938: Update Windows packaging script..
Sun, Jun 19, 9:38 PM · Restricted Project, Restricted Project

Fri, Jun 17

CarlosAlbertoEnciso added inline comments to D125777: [llvm-dva] 02 - Driver and documentation.
Fri, Jun 17, 7:12 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso added inline comments to D125777: [llvm-dva] 02 - Driver and documentation.
Fri, Jun 17, 6:50 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso added reviewers for D125784: [llvm-dva] 09 - CodeView Reader: psamolysov, djtodoro.
Fri, Jun 17, 6:40 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a reviewer for D125783: [llvm-dva] 08 - ELF Reader: psamolysov.
Fri, Jun 17, 6:39 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a reviewer for D125782: [llvm-dva] 07 - Compare elements: psamolysov.
Fri, Jun 17, 6:38 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a reviewer for D125781: [llvm-dva] 06 - Warning and internal options: psamolysov.
Fri, Jun 17, 6:37 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added a reviewer for D125780: [llvm-dva] 05 - Select elements: psamolysov.
Fri, Jun 17, 6:36 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added a reviewer for D125779: [llvm-dva] 04 - Locations and ranges: psamolysov.
Fri, Jun 17, 6:36 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a reviewer for D125778: [llvm-dva] 03 - Logical elements: psamolysov.
Fri, Jun 17, 6:35 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added a reviewer for D125777: [llvm-dva] 02 - Driver and documentation: psamolysov.
Fri, Jun 17, 6:34 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso added a reviewer for D125776: [llvm-dva] 01 - Interval tree: psamolysov.
Fri, Jun 17, 6:34 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D125777: [llvm-dva] 02 - Driver and documentation.
Fri, Jun 17, 6:33 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso added inline comments to D125777: [llvm-dva] 02 - Driver and documentation.
Fri, Jun 17, 5:58 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso added a comment to D127863: [clang] Dont print implicit forrange initializer.

@kadircet It seems that your change broke couple of clang tests:

Fri, Jun 17, 5:13 AM · Restricted Project, Restricted Project
CarlosAlbertoEnciso added a comment to D125777: [llvm-dva] 02 - Driver and documentation.

Good job! I believe the tool will be very usable. Thank you very much.

I'm not a subject matter expert in the debug tools and LLVM's debug info area and therefore cannot be an official reviewer but I've read the code and my findings are below. They are just some nits and typos mostly.

Fri, Jun 17, 4:44 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso added a comment to D125777: [llvm-dva] 02 - Driver and documentation.

Implementation for an Interval Tree (light tree data structure to hold intervals).

(in the patch description), I believe there should be a description for the second patch in the series, not the first.

Fri, Jun 17, 4:41 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso updated the summary of D125777: [llvm-dva] 02 - Driver and documentation.
Fri, Jun 17, 4:41 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso added inline comments to D125776: [llvm-dva] 01 - Interval tree.
Fri, Jun 17, 3:42 AM · Restricted Project, Restricted Project, debug-info

Thu, Jun 16

CarlosAlbertoEnciso added inline comments to D127938: Update Windows packaging script..
Thu, Jun 16, 11:15 PM · Restricted Project, Restricted Project
CarlosAlbertoEnciso updated the summary of D127938: Update Windows packaging script..
Thu, Jun 16, 2:47 AM · Restricted Project, Restricted Project

Wed, Jun 15

CarlosAlbertoEnciso edited reviewers for D127938: Update Windows packaging script., added: russell.gallop; removed: rgal.
Wed, Jun 15, 10:51 PM · Restricted Project, Restricted Project
CarlosAlbertoEnciso requested review of D127938: Update Windows packaging script..
Wed, Jun 15, 10:50 PM · Restricted Project, Restricted Project

Mon, Jun 13

CarlosAlbertoEnciso added inline comments to D125776: [llvm-dva] 01 - Interval tree.
Mon, Jun 13, 2:40 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D88661: llvm-dva - Debug Information Visual Analizer.

This is exciting!
I understand where it comes from, but I wanted to at least ask if it would make sense to give the tool a more descriptive and discoverable name than llvm-dva such as llvm-debuginfo-analyzer. I understand there's a tradeoff between having a short command and a descriptive name.

Mon, Jun 13, 1:34 AM · Restricted Project, Restricted Project, debug-info

Jun 2 2022

CarlosAlbertoEnciso added inline comments to D125776: [llvm-dva] 01 - Interval tree.
Jun 2 2022, 5:33 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D88661: llvm-dva - Debug Information Visual Analizer.

This is exciting!
I understand where it comes from, but I wanted to at least ask if it would make sense to give the tool a more descriptive and discoverable name than llvm-dva such as llvm-debuginfo-analyzer. I understand there's a tradeoff between having a short command and a descriptive name.

Jun 2 2022, 5:28 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D126875: llvm-dva - Debug Information Visual Analizer.
Jun 2 2022, 5:05 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso requested review of D126875: llvm-dva - Debug Information Visual Analizer.
Jun 2 2022, 5:00 AM · Restricted Project, Restricted Project, debug-info

Jun 1 2022

CarlosAlbertoEnciso added inline comments to D125776: [llvm-dva] 01 - Interval tree.
Jun 1 2022, 5:20 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D125776: [llvm-dva] 01 - Interval tree.
Jun 1 2022, 2:28 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D125776: [llvm-dva] 01 - Interval tree.
Jun 1 2022, 2:17 AM · Restricted Project, Restricted Project, debug-info

May 30 2022

CarlosAlbertoEnciso added inline comments to D125776: [llvm-dva] 01 - Interval tree.
May 30 2022, 6:18 AM · Restricted Project, Restricted Project, debug-info

May 24 2022

CarlosAlbertoEnciso added inline comments to D125776: [llvm-dva] 01 - Interval tree.
May 24 2022, 6:28 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D125776: [llvm-dva] 01 - Interval tree.
May 24 2022, 4:37 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D125776: [llvm-dva] 01 - Interval tree.
May 24 2022, 3:39 AM · Restricted Project, Restricted Project, debug-info

May 19 2022

CarlosAlbertoEnciso added a comment to D88661: llvm-dva - Debug Information Visual Analizer.

@CarlosAlbertoEnciso That's great news! Thank you for letting me know.

May 19 2022, 2:23 AM · Restricted Project, Restricted Project, debug-info

May 18 2022

CarlosAlbertoEnciso added inline comments to D125784: [llvm-dva] 09 - CodeView Reader.
May 18 2022, 3:23 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D125784: [llvm-dva] 09 - CodeView Reader.
May 18 2022, 1:36 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D125783: [llvm-dva] 08 - ELF Reader.
May 18 2022, 1:35 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D125782: [llvm-dva] 07 - Compare elements.
May 18 2022, 1:35 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D125781: [llvm-dva] 06 - Warning and internal options.
May 18 2022, 1:34 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso updated the summary of D125780: [llvm-dva] 05 - Select elements.
May 18 2022, 1:34 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso updated the summary of D125779: [llvm-dva] 04 - Locations and ranges.
May 18 2022, 1:33 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated the summary of D125778: [llvm-dva] 03 - Logical elements.
May 18 2022, 1:33 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso updated the summary of D125777: [llvm-dva] 02 - Driver and documentation.
May 18 2022, 1:32 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso updated the summary of D125776: [llvm-dva] 01 - Interval tree.
May 18 2022, 1:29 AM · Restricted Project, Restricted Project, debug-info

May 17 2022

CarlosAlbertoEnciso added reviewers for D125784: [llvm-dva] 09 - CodeView Reader: StephenTozer, Orlando.
May 17 2022, 8:12 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added reviewers for D125783: [llvm-dva] 08 - ELF Reader: StephenTozer, Orlando.
May 17 2022, 8:12 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added reviewers for D125782: [llvm-dva] 07 - Compare elements: StephenTozer, Orlando.
May 17 2022, 8:11 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added reviewers for D125781: [llvm-dva] 06 - Warning and internal options: StephenTozer, Orlando.
May 17 2022, 8:11 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added reviewers for D125780: [llvm-dva] 05 - Select elements: StephenTozer, Orlando.
May 17 2022, 8:11 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added reviewers for D125779: [llvm-dva] 04 - Locations and ranges: StephenTozer, Orlando.
May 17 2022, 8:11 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added reviewers for D125778: [llvm-dva] 03 - Logical elements: StephenTozer, Orlando.
May 17 2022, 8:10 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added reviewers for D125777: [llvm-dva] 02 - Driver and documentation: Orlando, StephenTozer.
May 17 2022, 8:10 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso added reviewers for D125776: [llvm-dva] 01 - Interval tree: Orlando, StephenTozer, probinson.
May 17 2022, 8:10 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated subscribers of D125777: [llvm-dva] 02 - Driver and documentation.
May 17 2022, 8:05 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso updated subscribers of D125776: [llvm-dva] 01 - Interval tree.
May 17 2022, 8:04 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated subscribers of D125777: [llvm-dva] 02 - Driver and documentation.
May 17 2022, 8:03 AM · debug-info, Restricted Project, Restricted Project
CarlosAlbertoEnciso updated subscribers of D125778: [llvm-dva] 03 - Logical elements.
May 17 2022, 8:03 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso updated subscribers of D125779: [llvm-dva] 04 - Locations and ranges.
May 17 2022, 8:03 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated subscribers of D125780: [llvm-dva] 05 - Select elements.
May 17 2022, 8:02 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso updated subscribers of D125781: [llvm-dva] 06 - Warning and internal options.
May 17 2022, 8:02 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso updated subscribers of D125782: [llvm-dva] 07 - Compare elements.
May 17 2022, 8:01 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated subscribers of D125783: [llvm-dva] 08 - ELF Reader.
May 17 2022, 8:01 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso updated subscribers of D125784: [llvm-dva] 09 - CodeView Reader.
May 17 2022, 8:01 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added reviewers for D125784: [llvm-dva] 09 - CodeView Reader: echristo, dblaikie, rnk, aganea, probinson.
May 17 2022, 7:59 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso edited reviewers for D125783: [llvm-dva] 08 - ELF Reader, added: echristo, dblaikie, rnk, aganea, probinson; removed: jdoerfert.
May 17 2022, 7:58 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added reviewers for D125782: [llvm-dva] 07 - Compare elements: echristo, dblaikie, rnk, aganea, probinson.
May 17 2022, 7:57 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added reviewers for D125781: [llvm-dva] 06 - Warning and internal options: echristo, dblaikie, rnk, aganea, probinson.
May 17 2022, 7:56 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added reviewers for D125780: [llvm-dva] 05 - Select elements: echristo, dblaikie, rnk, aganea, probinson.
May 17 2022, 7:55 AM · Restricted Project, debug-info, Restricted Project
CarlosAlbertoEnciso added reviewers for D125779: [llvm-dva] 04 - Locations and ranges: echristo, dblaikie, rnk, aganea, probinson.
May 17 2022, 7:54 AM · Restricted Project, Restricted Project, debug-info
CarlosAlbertoEnciso added reviewers for D125778: [llvm-dva] 03 - Logical elements: echristo, dblaikie, rnk, aganea, probinson.
May 17 2022, 7:53 AM · Restricted Project, debug-info, Restricted Project