Page MenuHomePhabricator

CarlosAlbertoEnciso (Carlos Alberto Enciso)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2017, 4:02 AM (88 w, 13 h)

Recent Activity

Feb 11 2019

CarlosAlbertoEnciso committed rGe848d426a7dd: [DWARF] LLVM ERROR: Broken function found, while removing Debug Intrinsics. (authored by CarlosAlbertoEnciso).
[DWARF] LLVM ERROR: Broken function found, while removing Debug Intrinsics.
Feb 11 2019, 2:19 AM
CarlosAlbertoEnciso added a comment to D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.

@aprantl, as per your feedback I have moved the test case to the correct location.

Feb 11 2019, 2:19 AM · Restricted Project, debug-info

Feb 8 2019

CarlosAlbertoEnciso added a comment to D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.

Sorry for not noticing this before, but we noticed now that the test case is placed under test/CodeGen/X86/, although it is a simplifycfg test. Should it ideally be placed under test/Transforms/SimplifyCFG/?

Feb 8 2019, 7:19 AM · Restricted Project, debug-info
CarlosAlbertoEnciso added a comment to D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.

Thanks @aprantl, @uabelho for your valuable review.

Feb 8 2019, 3:16 AM · Restricted Project, debug-info
CarlosAlbertoEnciso committed rG08dc50f2fb82: [DWARF] LLVM ERROR: Broken function found, while removing Debug Intrinsics. (authored by CarlosAlbertoEnciso).
[DWARF] LLVM ERROR: Broken function found, while removing Debug Intrinsics.
Feb 8 2019, 2:57 AM

Feb 7 2019

CarlosAlbertoEnciso added inline comments to D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.
Feb 7 2019, 5:47 AM · Restricted Project, debug-info
CarlosAlbertoEnciso updated the diff for D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.

Updated patch to address comments from @aprantl .

Feb 7 2019, 5:37 AM · Restricted Project, debug-info

Jan 31 2019

CarlosAlbertoEnciso updated the diff for D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.

Updated patch to remove the negative CHECK. Thanks for your feedback.

Jan 31 2019, 5:18 AM · Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.
Jan 31 2019, 5:15 AM · Restricted Project, debug-info
CarlosAlbertoEnciso added inline comments to D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.
Jan 31 2019, 2:27 AM · Restricted Project, debug-info
CarlosAlbertoEnciso updated the diff for D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.

Thanks very much for your invaluable feedback and reviews.

Jan 31 2019, 2:26 AM · Restricted Project, debug-info

Jan 30 2019

CarlosAlbertoEnciso created D57444: [DebugInfo] LLVM ERROR: Broken function found, while removing Debug Intrinsics.
Jan 30 2019, 3:37 AM · Restricted Project, debug-info

Jan 15 2019

CarlosAlbertoEnciso added inline comments to D56265: [DebugInfo] MCP: collect and update DBG_VALUEs encountered in local block.
Jan 15 2019, 6:21 AM

Jan 10 2019

CarlosAlbertoEnciso added inline comments to D56265: [DebugInfo] MCP: collect and update DBG_VALUEs encountered in local block.
Jan 10 2019, 6:55 AM
CarlosAlbertoEnciso added inline comments to D56265: [DebugInfo] MCP: collect and update DBG_VALUEs encountered in local block.
Jan 10 2019, 6:53 AM

Nov 13 2018

CarlosAlbertoEnciso added a comment to rL346726: [BuildingAJIT] Update chapter 2 to use the ORCv2 APIs..

Your change seems to cause build failures. The following is the error message:

Nov 13 2018, 7:23 AM

Nov 8 2018

CarlosAlbertoEnciso updated the diff for D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

@vsk: I have updated the patch to remove the test case pr39187-gline-tables-only.ll, as per your suggestion.

Nov 8 2018, 2:30 AM · debug-info

Nov 7 2018

CarlosAlbertoEnciso added inline comments to D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Nov 7 2018, 8:24 AM · debug-info
CarlosAlbertoEnciso updated the diff for D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Thanks for your comments.

Nov 7 2018, 8:22 AM · debug-info

Nov 6 2018

CarlosAlbertoEnciso added inline comments to D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Nov 6 2018, 12:57 AM · debug-info

Nov 5 2018

CarlosAlbertoEnciso added inline comments to D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Nov 5 2018, 11:51 PM · debug-info
CarlosAlbertoEnciso added inline comments to D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Nov 5 2018, 6:56 AM · debug-info
CarlosAlbertoEnciso added inline comments to D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Nov 5 2018, 4:23 AM · debug-info

Oct 30 2018

CarlosAlbertoEnciso added inline comments to D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Oct 30 2018, 5:51 AM · debug-info
CarlosAlbertoEnciso updated the diff for D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Thanks for your comments. I have updated the patch to address them.

Oct 30 2018, 5:51 AM · debug-info

Oct 29 2018

CarlosAlbertoEnciso added a comment to D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Ping.

Oct 29 2018, 5:45 AM · debug-info

Oct 25 2018

CarlosAlbertoEnciso added a comment to D52932: [MCSched] Bind PFM Counters to the CPUs instead of the SchedModel..

@courbet: Your commit seems to cause build issues:

Oct 25 2018, 3:49 AM
CarlosAlbertoEnciso added a comment to D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

@aprantl, @vsk: Thanks very much for your valuable comments and suggestions.

Oct 25 2018, 2:59 AM · debug-info
CarlosAlbertoEnciso added a comment to D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
In D53287#1274290, @vsk wrote:

LGTM, thanks. I'm sorry for the delay in reviewing this.

Oct 25 2018, 2:57 AM · debug-info

Oct 24 2018

CarlosAlbertoEnciso added a comment to D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

@vsk: Do you have any additional comments? It is OK for you if I commit the patch?

Oct 24 2018, 7:26 AM · debug-info

Oct 18 2018

CarlosAlbertoEnciso created D53390: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Oct 18 2018, 3:35 AM · debug-info

Oct 16 2018

CarlosAlbertoEnciso added inline comments to D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Oct 16 2018, 7:09 AM · debug-info
CarlosAlbertoEnciso updated the diff for D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Address issues raised by @aprantl.

Oct 16 2018, 7:08 AM · debug-info

Oct 15 2018

CarlosAlbertoEnciso abandoned D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

This revision caused builbot failures.

Oct 15 2018, 7:16 AM · debug-info
CarlosAlbertoEnciso created D53287: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Oct 15 2018, 7:13 AM · debug-info

Oct 11 2018

CarlosAlbertoEnciso reopened D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

The patch caused some assertions. For more details see PR39243.

Oct 11 2018, 11:52 AM · debug-info

Oct 10 2018

CarlosAlbertoEnciso added a comment to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

@mstorsjo, The change has been reverted. Thanks for creating the bugzilla.

Oct 10 2018, 5:16 AM · debug-info
CarlosAlbertoEnciso added a comment to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

This broke compilation for me, compiling some source files now fail due to triggered assertions, see PR39243 for details. I guess I'll revert this in a while unless there's someone to fix it soon.

Oct 10 2018, 5:05 AM · debug-info
CarlosAlbertoEnciso added a comment to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Thanks very much to all the reviewers for your valuable comments and suggestions.

Oct 10 2018, 12:56 AM · debug-info

Oct 9 2018

CarlosAlbertoEnciso updated the diff for D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Address issues raised by the reviewers.

Oct 9 2018, 3:39 AM · debug-info

Oct 8 2018

CarlosAlbertoEnciso updated the diff for D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Address issues raised by the reviewers.

Oct 8 2018, 7:27 AM · debug-info
CarlosAlbertoEnciso added inline comments to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Oct 8 2018, 7:18 AM · debug-info

Oct 5 2018

CarlosAlbertoEnciso updated the diff for D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..

Address issues raised by the reviewers.

Oct 5 2018, 5:16 AM · debug-info
CarlosAlbertoEnciso added inline comments to D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Oct 5 2018, 5:11 AM · debug-info

Oct 4 2018

CarlosAlbertoEnciso created D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG..
Oct 4 2018, 7:09 AM · debug-info

Oct 1 2018

CarlosAlbertoEnciso added a comment to D52614: [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal..

Thanks very much to all the reviewers for your valuable comments and suggestions.

Oct 1 2018, 1:17 AM · debug-info

Sep 28 2018

CarlosAlbertoEnciso updated the diff for D52614: [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal..

Address issues raised by the reviewers.

Sep 28 2018, 8:34 AM · debug-info
CarlosAlbertoEnciso retitled D52614: [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal. from [DebugInfo][Dexter] Divide-before-return displays wrong value in debugger to [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal..
Sep 28 2018, 8:30 AM · debug-info
CarlosAlbertoEnciso added inline comments to D52614: [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal..
Sep 28 2018, 8:28 AM · debug-info
CarlosAlbertoEnciso added a comment to D52614: [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal..

It would be good to change the title to reflect what is done in MCP (at least before submitting this).

Sep 28 2018, 3:45 AM · debug-info

Sep 27 2018

CarlosAlbertoEnciso created D52614: [DebugInfo][Dexter] Incorrect DBG_VALUE after MCP dead copy instruction removal..
Sep 27 2018, 8:01 AM · debug-info

Sep 19 2018

CarlosAlbertoEnciso added a comment to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

Thanks very much to all the reviewers for your valuable comments and suggestions.

Sep 19 2018, 1:12 AM · debug-info

Sep 18 2018

CarlosAlbertoEnciso added inline comments to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.
Sep 18 2018, 7:02 AM · debug-info
CarlosAlbertoEnciso updated the diff for D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

The general preference seems to land this patch as-is.

Sep 18 2018, 1:31 AM · debug-info
CarlosAlbertoEnciso added inline comments to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.
Sep 18 2018, 1:24 AM · debug-info

Sep 17 2018

CarlosAlbertoEnciso added a comment to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

@aprantl and @probinson,

Sep 17 2018, 12:11 PM · debug-info
CarlosAlbertoEnciso updated the diff for D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

Address issues raised by the reviewers.

Sep 17 2018, 7:24 AM · debug-info
CarlosAlbertoEnciso added a comment to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

Having read the real testcase now, I understand why you are dropping the debug info now. I would like to point out that we could do better. If we extended llvm.dbg.value to take more than one LLVM SSA Value, then we could produce a DIExpression that selects either %add or %sub depending on the value of %cmp. Let me know if you are interested in implementing this, it should be relatively straight forward to do and would come in useful in all sorts of other situations, too.

Sep 17 2018, 7:17 AM · debug-info

Sep 14 2018

CarlosAlbertoEnciso updated the diff for D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

Address issues raised by the reviewers.

Sep 14 2018, 7:37 AM · debug-info
CarlosAlbertoEnciso added inline comments to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.
Sep 14 2018, 7:23 AM · debug-info
CarlosAlbertoEnciso updated the diff for D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

Address issues raised by the reviewers.

Sep 14 2018, 7:12 AM · debug-info

Sep 13 2018

CarlosAlbertoEnciso added a comment to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

It still isn't clear to me why you need to drop the debug info in the first place (instead of e.g., making it point to the select, or leave it on its operands) but I hope that that will become obvious once I see the actual testcase.

Sep 13 2018, 11:59 AM · debug-info
CarlosAlbertoEnciso added inline comments to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.
Sep 13 2018, 2:40 AM · debug-info

Sep 12 2018

CarlosAlbertoEnciso updated subscribers of D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.
Sep 12 2018, 5:20 AM · debug-info
CarlosAlbertoEnciso created D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.
Sep 12 2018, 4:45 AM · debug-info

Sep 3 2018

CarlosAlbertoEnciso added a comment to D51583: Test commit - Remove a new line..

Maybe remove a comma in the comment? A lot of tools don't like trailing newlines.

Up to you, any NFC change is usually fine for this, though you didn't assign anyone as a reviewer.

Sep 3 2018, 2:37 AM
CarlosAlbertoEnciso created D51583: Test commit - Remove a new line..
Sep 3 2018, 2:17 AM

Aug 30 2018

CarlosAlbertoEnciso committed rL341025: [DWARF] Missing location debug information with -O2..
[DWARF] Missing location debug information with -O2.
Aug 30 2018, 12:19 AM
CarlosAlbertoEnciso closed D50887: [DWARF] Missing location debug information with -O2..
Aug 30 2018, 12:18 AM

Aug 29 2018

CarlosAlbertoEnciso added a comment to D50887: [DWARF] Missing location debug information with -O2..
In D50887#1216171, @vsk wrote:

Thanks, LGTM. If you don't have commit access yet [1], I'd be happy to commit this on your behalf.

[1] https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

Aug 29 2018, 7:05 AM
CarlosAlbertoEnciso added a comment to D50887: [DWARF] Missing location debug information with -O2..

@vsk & @aprantl Thanks your reviews.

Aug 29 2018, 6:59 AM

Aug 28 2018

CarlosAlbertoEnciso updated the diff for D50887: [DWARF] Missing location debug information with -O2..

Update the original patch, as the results from the investigation to replace the algorithm used by 'collectDebugValues', showed some additional complexities.

Aug 28 2018, 1:59 AM
CarlosAlbertoEnciso added a comment to D50887: [DWARF] Missing location debug information with -O2..
In D50887#1212594, @vsk wrote:

@CarlosAlbertoEnciso thanks for investigating this and testing out a new way to collect debug values. Given the complexity of replacing the current algorithm, and that it's not strictly related to fixing MachineCSE, I'd recommend keeping the current algorithm (i.e not using MachineRegisterInfo for now). That will allow us to land a fix in tree soon and hopefully iterate on it.

Aug 28 2018, 1:21 AM
CarlosAlbertoEnciso added a comment to D50887: [DWARF] Missing location debug information with -O2..

Do you have OrderMap readily available or would you need to compute it first?

Aug 28 2018, 1:14 AM

Aug 24 2018

CarlosAlbertoEnciso added a comment to D50887: [DWARF] Missing location debug information with -O2..
In D50887#1207849, @vsk wrote:

This is looking really good. I think it's great that the test exercises more than just MachineCSE in isolation. Just two more minor comments (inline) --

Aug 24 2018, 4:45 AM

Aug 21 2018

CarlosAlbertoEnciso updated the diff for D50887: [DWARF] Missing location debug information with -O2..

Following feedback from the reviewers:

Aug 21 2018, 6:51 AM

Aug 20 2018

CarlosAlbertoEnciso added inline comments to D50887: [DWARF] Missing location debug information with -O2..
Aug 20 2018, 12:28 AM

Aug 17 2018

CarlosAlbertoEnciso created D50887: [DWARF] Missing location debug information with -O2..
Aug 17 2018, 2:23 AM

Jul 26 2018

CarlosAlbertoEnciso added a comment to D46190: For a used declaration, mark any associated usings as referenced..

Is there anything I can add to this patch in order to submit it?
This patch is blocking the review https://reviews.llvm.org/D44826 which is already approved.

Jul 26 2018, 7:17 AM · Restricted Project

Jul 20 2018

CarlosAlbertoEnciso updated the diff for D46190: For a used declaration, mark any associated usings as referenced..

A minor modification to allow the comments for MarkNamespaceAliasReferenced to be picked up by doxygen.

Jul 20 2018, 3:21 AM · Restricted Project
CarlosAlbertoEnciso updated the diff for D46190: For a used declaration, mark any associated usings as referenced..

Used clang-format-diff as indicated by @probinson:

Jul 20 2018, 2:55 AM · Restricted Project

Jul 19 2018

CarlosAlbertoEnciso added a comment to D46190: For a used declaration, mark any associated usings as referenced..

@probinson: I tried clang-format-diff and the main format issues are with the test cases.

Jul 19 2018, 6:41 AM · Restricted Project
CarlosAlbertoEnciso added a comment to D46190: For a used declaration, mark any associated usings as referenced..

A bunch of style comments. Maybe try clang-format-diff.

Jul 19 2018, 4:51 AM · Restricted Project
CarlosAlbertoEnciso added inline comments to D46190: For a used declaration, mark any associated usings as referenced..
Jul 19 2018, 4:49 AM · Restricted Project
CarlosAlbertoEnciso updated the diff for D46190: For a used declaration, mark any associated usings as referenced..

Address review comments from @probinson

Jul 19 2018, 4:48 AM · Restricted Project

Jul 18 2018

CarlosAlbertoEnciso added a comment to D46190: For a used declaration, mark any associated usings as referenced..

@rsmith and @probinson:

Jul 18 2018, 4:11 AM · Restricted Project
CarlosAlbertoEnciso added a comment to D49426: [DEBUG_INFO] fix .loc directives emitted for missing prologues.

Could you provide a small example dump of the invalid line table you're addressing?

I fed the resulting .elf into dwarfdump with -l and got the following output:

Jul 18 2018, 3:10 AM

Jul 11 2018

CarlosAlbertoEnciso added a comment to D46190: For a used declaration, mark any associated usings as referenced..

@rsmith Is there anything I can add to this patch?

Jul 11 2018, 1:47 AM · Restricted Project

Jul 4 2018

CarlosAlbertoEnciso added inline comments to D46190: For a used declaration, mark any associated usings as referenced..
Jul 4 2018, 4:58 AM · Restricted Project
CarlosAlbertoEnciso updated the diff for D46190: For a used declaration, mark any associated usings as referenced..

Update the patch to address the comments from the reviewers.

Jul 4 2018, 4:57 AM · Restricted Project
CarlosAlbertoEnciso retitled D46190: For a used declaration, mark any associated usings as referenced. from For a referenced declaration, mark any associated usings as referenced. to For a used declaration, mark any associated usings as referenced..
Jul 4 2018, 4:54 AM · Restricted Project
CarlosAlbertoEnciso added a comment to D48441: [clangd] Incorporate transitive #includes into code complete proximity scoring..

Hi Carlos, thanks for letting us know! I sent r336249 to fix the windows
test.

Jul 4 2018, 4:12 AM
CarlosAlbertoEnciso added a comment to D46190: For a used declaration, mark any associated usings as referenced..

Style comments.
The two new Sema methods (for namespaces and using references) are C++ specific, so SemaDeclCXX.cpp would seem like a more appropriate home for them.

Jul 4 2018, 2:35 AM · Restricted Project
CarlosAlbertoEnciso added a comment to D46190: For a used declaration, mark any associated usings as referenced..

The right way to handle this is to pass both the ultimately-selected declaration and the declaration found by name lookup into the calls to MarkAnyDeclReferenced and friends. We should mark the selected declaration as Used (when appropriate), and mark the found declaration as Referenced.

We should not be trying to reconstruct which using declarations are in scope after the fact. Only declarations actually found by name lookup and then selected by the context performing the lookup should be marked referenced. (There may be cases where name lookup discards equivalent lookup results that are not redeclarations of one another, though, and to handle such cases properly, you may need to teach name lookup to track a list of found declarations rather than only one.)

Jul 4 2018, 2:34 AM · Restricted Project
CarlosAlbertoEnciso added a comment to D48441: [clangd] Incorporate transitive #includes into code complete proximity scoring..

It seems that your patch is causing an error in the tests for

Jul 4 2018, 12:51 AM

Jun 19 2018

CarlosAlbertoEnciso added a comment to D46190: For a used declaration, mark any associated usings as referenced..

rsmith Thanks very much for your review. I will address them.

Jun 19 2018, 7:23 AM · Restricted Project
CarlosAlbertoEnciso added a comment to D46190: For a used declaration, mark any associated usings as referenced..

@probinson Thanks very much for your review. I will address them.

Jun 19 2018, 7:22 AM · Restricted Project

Jun 14 2018

CarlosAlbertoEnciso added a comment to D46190: For a used declaration, mark any associated usings as referenced..

The review

Jun 14 2018, 3:00 AM · Restricted Project

Jun 12 2018

CarlosAlbertoEnciso added a comment to D43015: clang-format: Introduce BreakInheritanceList option.

It seems that the changes done to ClangFormatStyleOptions.rst @334408 are causing the generation of the documentation to fail, with the following error:

Jun 12 2018, 4:32 AM

Jun 7 2018

CarlosAlbertoEnciso added a comment to D46190: For a used declaration, mark any associated usings as referenced..

The review

Jun 7 2018, 2:42 AM · Restricted Project