Page MenuHomePhabricator

psamolysov (Pavel Samolysov)
User

Projects

User does not belong to any projects.

User Details

User Since
May 20 2019, 4:16 AM (168 w, 1 d)

Recent Activity

Tue, Jul 19

psamolysov added inline comments to D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader.
Tue, Jul 19, 5:00 AM · Restricted Project, Restricted Project, debug-info
psamolysov added inline comments to D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.
Tue, Jul 19, 5:00 AM · Restricted Project, Restricted Project, debug-info

Wed, Jul 13

psamolysov added inline comments to D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.
Wed, Jul 13, 3:46 AM · Restricted Project, Restricted Project, debug-info

Tue, Jul 12

psamolysov updated the diff for D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

Return the PostOrderFunctionAttrsPass pass back on its original place in the pipeline.

Tue, Jul 12, 1:40 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added a comment to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

@aeubanks Hmm, if I correctly get your comment, I should revert this patch to the state before the proposed solution with moving the PostOrderFunctionAttrsPass at the end of the buildInlinerPipeline function regardless of the readonly instead of readnone regression. Personally along with your concern about compilation time, I have a concern about some changing in coroutines compilation, the Clang :: CodeGenCoroutines/coro-elide.cpp test demonstrates them:

Tue, Jul 12, 1:37 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jul 11

psamolysov updated the diff for D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

[Pipelines] Fix the Clang :: CodeGenCoroutines/coro-elide.cpp

Mon, Jul 11, 8:46 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov updated the diff for D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

@aeubanks Thank you for the great explanation.

Mon, Jul 11, 7:15 AM · Restricted Project, Restricted Project, Restricted Project

Jul 7 2022

psamolysov added inline comments to D125781: [llvm-debuginfo-analyzer] 06 - Warning and internal options.
Jul 7 2022, 11:38 PM · Restricted Project, Restricted Project, debug-info

Jul 6 2022

psamolysov added inline comments to D125781: [llvm-debuginfo-analyzer] 06 - Warning and internal options.
Jul 6 2022, 6:20 AM · Restricted Project, Restricted Project, debug-info

Jun 30 2022

psamolysov updated the diff for D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

Fix Clang :: CodeGen/thinlto-distributed-newpm.ll

Jun 30 2022, 11:13 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov updated the diff for D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

Try to remove the DAE from the original point. Also, apply the suggestion from @nikic - make the DAE a part of the normal module optimization pipeline (post module simplification).

Jun 30 2022, 9:06 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added a comment to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

Do we need to retain the run of DeadArgumentEliminationPass in the original position or is a single run at the new position sufficient?

Jun 30 2022, 9:04 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added inline comments to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.
Jun 30 2022, 8:03 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added inline comments to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.
Jun 30 2022, 7:57 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov updated the diff for D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

Actualize the new PM tests.

Jun 30 2022, 5:17 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov planned changes to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

A number of tests failed, I'm going to fix them ASAP.

Jun 30 2022, 4:54 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov updated the diff for D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

Add a PhaseOrdering test to show how the patch affects dead argument elimination after argument promotion.

Jun 30 2022, 3:13 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov updated the summary of D128830: [Pipelines] Introduce DAE after ArgumentPromotion.
Jun 30 2022, 3:12 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added a comment to D128830: [Pipelines] Introduce DAE after ArgumentPromotion.

There should be a PhaseOrdering test that shows that the argument is not removed in the current opimization pipeline.

Jun 30 2022, 3:11 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov committed rG3b7650da725c: [Pipelines] Add a test how DCE works after ArgumentPromotion (authored by psamolysov).
[Pipelines] Add a test how DCE works after ArgumentPromotion
Jun 30 2022, 2:57 AM · Restricted Project, Restricted Project

Jun 29 2022

psamolysov requested review of D128830: [Pipelines] Introduce DAE after ArgumentPromotion.
Jun 29 2022, 8:25 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov added inline comments to D125778: [llvm-debuginfo-analyzer] 03 - Logical elements.
Jun 29 2022, 1:51 AM · debug-info, Restricted Project, Restricted Project
psamolysov added inline comments to D125778: [llvm-debuginfo-analyzer] 03 - Logical elements.
Jun 29 2022, 1:50 AM · debug-info, Restricted Project, Restricted Project
psamolysov committed rG3d9ce9e43d07: [ArgPromotion] Remove all the getters and ReplaceCallSite (NFC) (authored by psamolysov).
[ArgPromotion] Remove all the getters and ReplaceCallSite (NFC)
Jun 29 2022, 12:48 AM · Restricted Project, Restricted Project
psamolysov committed rG8958057fb100: [ArgPromotion] Move isDenselyPacked static member (NFC) (authored by psamolysov).
[ArgPromotion] Move isDenselyPacked static member (NFC)
Jun 29 2022, 12:48 AM · Restricted Project, Restricted Project
psamolysov closed D128727: [ArgPromotion] Remove all the getters and ReplaceCallSite.
Jun 29 2022, 12:48 AM · Restricted Project, Restricted Project
psamolysov closed D128725: [ArgPromotion] Move isDenselyPacked static member (NFC).
Jun 29 2022, 12:48 AM · Restricted Project, Restricted Project

Jun 28 2022

psamolysov added a comment to D128727: [ArgPromotion] Remove all the getters and ReplaceCallSite.

CGSCCPassManager and LazyCallGraph are included in the class' header. About Module I'm not sure, CLion marks this header as unused, I also see no Module in the code.

Jun 28 2022, 9:21 AM · Restricted Project, Restricted Project
psamolysov updated the diff for D128727: [ArgPromotion] Remove all the getters and ReplaceCallSite.

Remove #include of unused headers.

Jun 28 2022, 8:25 AM · Restricted Project, Restricted Project
psamolysov updated the diff for D128727: [ArgPromotion] Remove all the getters and ReplaceCallSite.

Eliminate all the getters as well as the ReplaceCallSite parameter.

Jun 28 2022, 8:17 AM · Restricted Project, Restricted Project
psamolysov added a comment to D128727: [ArgPromotion] Remove all the getters and ReplaceCallSite.

Good catch, thank you. I think the ReplicaCallSite parameter can be removed too because we pass only None for it.

Jun 28 2022, 7:55 AM · Restricted Project, Restricted Project
psamolysov requested review of D128727: [ArgPromotion] Remove all the getters and ReplaceCallSite.
Jun 28 2022, 6:35 AM · Restricted Project, Restricted Project
psamolysov added inline comments to D125778: [llvm-debuginfo-analyzer] 03 - Logical elements.
Jun 28 2022, 6:13 AM · debug-info, Restricted Project, Restricted Project
psamolysov requested review of D128725: [ArgPromotion] Move isDenselyPacked static member (NFC).
Jun 28 2022, 6:08 AM · Restricted Project, Restricted Project
psamolysov committed rG170c4d21bd94: [ArgPromotion] Unify byval promotion with non-byval (authored by psamolysov).
[ArgPromotion] Unify byval promotion with non-byval
Jun 28 2022, 5:23 AM · Restricted Project, Restricted Project
psamolysov closed D125485: [ArgPromotion] Unify byval promotion with non-byval.
Jun 28 2022, 5:23 AM · Restricted Project, Restricted Project

Jun 27 2022

psamolysov added a comment to D125485: [ArgPromotion] Unify byval promotion with non-byval.

@nikic Thank you for accepting. I've got the commit access and able to land patches. I'm going to land the patch in a day or two.

Jun 27 2022, 4:37 AM · Restricted Project, Restricted Project
psamolysov added inline comments to D125485: [ArgPromotion] Unify byval promotion with non-byval.
Jun 27 2022, 4:04 AM · Restricted Project, Restricted Project
psamolysov updated the diff for D125485: [ArgPromotion] Unify byval promotion with non-byval.

Apply the suggestion about doing a LI->setOperand(0, GetAlloca(Ptr)) and not really creating a new instruction and RAUW.

Jun 27 2022, 4:03 AM · Restricted Project, Restricted Project
psamolysov added inline comments to D125778: [llvm-debuginfo-analyzer] 03 - Logical elements.
Jun 27 2022, 3:14 AM · debug-info, Restricted Project, Restricted Project
psamolysov added a comment to D125485: [ArgPromotion] Unify byval promotion with non-byval.

@nikic thank you for landing D128536. The patch has been rebased.

Jun 27 2022, 3:07 AM · Restricted Project, Restricted Project
psamolysov updated the diff for D125485: [ArgPromotion] Unify byval promotion with non-byval.

Rebase the patch on main, remove all the stuff related to the legacy pass manager.

Jun 27 2022, 3:06 AM · Restricted Project, Restricted Project

Jun 25 2022

psamolysov committed rG6e3d4712b90b: [DeadArgElim] Replace insert with emplace (NFC) (authored by psamolysov).
[DeadArgElim] Replace insert with emplace (NFC)
Jun 25 2022, 12:34 AM · Restricted Project, Restricted Project

Jun 24 2022

psamolysov updated the diff for D125485: [ArgPromotion] Unify byval promotion with non-byval.

Fetch AssumptionCache for the new function rather than the old one.

Jun 24 2022, 8:39 AM · Restricted Project, Restricted Project
psamolysov added a comment to D125485: [ArgPromotion] Unify byval promotion with non-byval.

@nikic I believe this is a very good idea just to drop the legacy PM support in ArgPromotion. Thank you for the patch, once your patch has been landed, I'll just leave the single DTGetter.

Jun 24 2022, 8:36 AM · Restricted Project, Restricted Project
psamolysov updated the diff for D125485: [ArgPromotion] Unify byval promotion with non-byval.

Implement the proposed solution with DTGetter to reuse DominatorTrees from the pass manager. This works fine on the new PM but not on the legacy one. As a workaround, a new DominatorTree is created for every new generated function whenever the Argument Promotion Pass is used through the legacy pass manager.

Jun 24 2022, 7:47 AM · Restricted Project, Restricted Project
psamolysov added inline comments to D125485: [ArgPromotion] Unify byval promotion with non-byval.
Jun 24 2022, 7:37 AM · Restricted Project, Restricted Project
psamolysov added inline comments to D125485: [ArgPromotion] Unify byval promotion with non-byval.
Jun 24 2022, 5:29 AM · Restricted Project, Restricted Project
psamolysov updated the diff for D125485: [ArgPromotion] Unify byval promotion with non-byval.

Apply suggestions from the code review.

Jun 24 2022, 5:27 AM · Restricted Project, Restricted Project
psamolysov added inline comments to D125485: [ArgPromotion] Unify byval promotion with non-byval.
Jun 24 2022, 5:24 AM · Restricted Project, Restricted Project
psamolysov updated the diff for D125485: [ArgPromotion] Unify byval promotion with non-byval.

Address almost the all reviewer's comments.

Jun 24 2022, 3:20 AM · Restricted Project, Restricted Project
psamolysov added a comment to D125485: [ArgPromotion] Unify byval promotion with non-byval.

@nikic Thank you very much for the review and comments, I've addressed almost all of them and asked a pair of questions about alignment check for loads in the HandleEndUser lambda. Could you have a look and give your answers?

Jun 24 2022, 3:15 AM · Restricted Project, Restricted Project

Jun 23 2022

psamolysov added inline comments to D125777: [llvm-debuginfo-analyzer] 02 - Driver and documentation.
Jun 23 2022, 4:32 AM · debug-info, Restricted Project, Restricted Project
psamolysov added a comment to D125485: [ArgPromotion] Unify byval promotion with non-byval.

@nikic @aeubanks Colleagues, ping, could you have a look at the changes?

Jun 23 2022, 4:25 AM · Restricted Project, Restricted Project

Jun 21 2022

psamolysov committed rGf44bf3805ab2: [DeadArgElim] Reformat the pass in accordance with the code style (authored by psamolysov).
[DeadArgElim] Reformat the pass in accordance with the code style
Jun 21 2022, 11:28 PM · Restricted Project, Restricted Project
psamolysov added a comment to D128168: [DeadArgElim] Reformat the pass in accordance with the code style.

@MaskRay Thank you for the review. I've landed the patch.

Jun 21 2022, 11:28 PM · Restricted Project, Restricted Project
psamolysov closed D128168: [DeadArgElim] Reformat the pass in accordance with the code style.
Jun 21 2022, 11:28 PM · Restricted Project, Restricted Project

Jun 20 2022

psamolysov requested review of D128168: [DeadArgElim] Reformat the pass in accordance with the code style.
Jun 20 2022, 2:30 AM · Restricted Project, Restricted Project

Jun 17 2022

psamolysov added inline comments to D125777: [llvm-debuginfo-analyzer] 02 - Driver and documentation.
Jun 17 2022, 8:07 AM · debug-info, Restricted Project, Restricted Project
psamolysov accepted D125776: [llvm-debuginfo-analyzer] 01 - Interval tree.

Ongoing changes LGTM but I would like you to wait for another approve too. @CarlosAlbertoEnciso please upload the final revision.

Jun 17 2022, 8:04 AM · Restricted Project, debug-info, Restricted Project
psamolysov added a comment to D125777: [llvm-debuginfo-analyzer] 02 - Driver and documentation.

@CarlosAlbertoEnciso You are welcome! I'll be glad if my modest efforts help you to land this amazing tool.

Jun 17 2022, 4:48 AM · debug-info, Restricted Project, Restricted Project

Jun 14 2022

psamolysov added inline comments to D125776: [llvm-debuginfo-analyzer] 01 - Interval tree.
Jun 14 2022, 2:32 AM · Restricted Project, debug-info, Restricted Project

Jun 10 2022

psamolysov added a comment to D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader.

Good job! Thank you for the patch series and the usable tool!

Jun 10 2022, 12:43 AM · Restricted Project, Restricted Project, debug-info

Jun 8 2022

psamolysov added a comment to D126699: [CMake] Skip linker check if the LLVM_LINKER_SKIP_TEST is set.

Ping. Does this change make sense at all?

Jun 8 2022, 1:49 AM · Restricted Project, Restricted Project

Jun 3 2022

psamolysov added a comment to D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader.

Here are a series of comments to the new patch. The most comments are just nits (replacing map#insert with map#emplace but sometimes a piecewise construct could make sense however; and manually constructing by [const] Map::value_type & references to a map entry in foreach loops with the already defined in the std::map class template reference and const_reference aliases. Also a couple of possible memory leaks and bugs related to handling Map.end() iterator have been found, have a look, please.

Jun 3 2022, 9:08 AM · Restricted Project, Restricted Project, debug-info
psamolysov added reviewers for D125485: [ArgPromotion] Unify byval promotion with non-byval: chandlerc, eli.friedman.

Unfortunately, it looks like @nikic and @aeubanks have no time to review the patch (or maybe I'm getting something wrong and I should have added the nicks via @ in my comments during ping request sending, I'm sorry if you, colleagues, just didn't catch my requests). @chandlerc Could you as a code owner and one of the pass's author have a look at the patch? @jdoerfert @eli.friedman Or you? Thanks a lot in advance.

Jun 3 2022, 5:45 AM · Restricted Project, Restricted Project

Jun 2 2022

psamolysov added inline comments to D125781: [llvm-debuginfo-analyzer] 06 - Warning and internal options.
Jun 2 2022, 9:43 AM · Restricted Project, Restricted Project, debug-info

Jun 1 2022

psamolysov added inline comments to D125776: [llvm-debuginfo-analyzer] 01 - Interval tree.
Jun 1 2022, 6:09 AM · Restricted Project, debug-info, Restricted Project
psamolysov added inline comments to D125776: [llvm-debuginfo-analyzer] 01 - Interval tree.
Jun 1 2022, 5:17 AM · Restricted Project, debug-info, Restricted Project
psamolysov added a comment to D125782: [llvm-debuginfo-analyzer] 07 - Compare elements.

Good job! I have a few most stylistic only comments here. What I would like to discuss with the other reviewers: should an assert be used in every function that accepts an argument by pointer and dereferences the pointer or calls functions on it (so, dereferences it too)? My personal opinion: yes but there can be other opinions too, so I do not insist.

Jun 1 2022, 4:48 AM · Restricted Project, Restricted Project, debug-info

May 31 2022

psamolysov added inline comments to D125781: [llvm-debuginfo-analyzer] 06 - Warning and internal options.
May 31 2022, 11:12 PM · Restricted Project, Restricted Project, debug-info
psamolysov retitled D126699: [CMake] Skip linker check if the LLVM_LINKER_SKIP_TEST is set from [CMake] Skip linker check if the LLVM_LINKER_WORKS is set to [CMake] Skip linker check if the LLVM_LINKER_SKIP_TEST is set.
May 31 2022, 7:14 AM · Restricted Project, Restricted Project
psamolysov updated the diff for D126699: [CMake] Skip linker check if the LLVM_LINKER_SKIP_TEST is set.

Rename LLVM_LINKER_WORKS to LLVM_LINKER_SKIP_TEST.

May 31 2022, 7:13 AM · Restricted Project, Restricted Project
psamolysov added a comment to D126699: [CMake] Skip linker check if the LLVM_LINKER_SKIP_TEST is set.

@thieta A problem occurs when I try to build LLVM with runtime components for RISCV, for example, and in fact, CMake cross-compiles the components in this case. So, If I set -DLLVM_ENABLE_LLD=ON, the following errors are issued due to LLVM's attempt to check the linker:

May 31 2022, 7:05 AM · Restricted Project, Restricted Project
psamolysov added a comment to D126699: [CMake] Skip linker check if the LLVM_LINKER_SKIP_TEST is set.

Colleagues, I propose this change to make the runtime components buildable with a "not-ready yet" lld linker and libraries. One disadvantage I see, when the LLVM_USE_LINKER is not set, the CMake issues warnings about the unused variable LLVM_LINKER_WORKS.

May 31 2022, 6:59 AM · Restricted Project, Restricted Project
psamolysov requested review of D126699: [CMake] Skip linker check if the LLVM_LINKER_SKIP_TEST is set.
May 31 2022, 6:52 AM · Restricted Project, Restricted Project
psamolysov added a comment to D125781: [llvm-debuginfo-analyzer] 06 - Warning and internal options.

Some my comments repeat comments to previous patches, sorry if it looks noisy. Could you check the {A, B} replacement of the std::make_pair(A, B)? If it works, there is a couple of places where std::make_pair is used and they can be replaced with {A, B} too.

May 31 2022, 6:08 AM · Restricted Project, Restricted Project, debug-info
psamolysov added inline comments to D125779: [llvm-debuginfo-analyzer] 04 - Locations and ranges.
May 31 2022, 5:45 AM · Restricted Project, Restricted Project, debug-info

May 30 2022

psamolysov added inline comments to D125776: [llvm-debuginfo-analyzer] 01 - Interval tree.
May 30 2022, 6:40 AM · Restricted Project, debug-info, Restricted Project
psamolysov added a comment to D125780: [llvm-debuginfo-analyzer] 05 - Select elements.

Good job! Here is a series of comments, please have a look if you don't mind.

May 30 2022, 2:43 AM · Restricted Project, Restricted Project, debug-info
psamolysov added a comment to D125485: [ArgPromotion] Unify byval promotion with non-byval.

Ping.

May 30 2022, 1:28 AM · Restricted Project, Restricted Project

May 26 2022

psamolysov committed rGe251fb4cdeb7: [libunwind][CMake] Fix name of LIBUNWIND_SUPPORTS_NODEFAULTLIBS_FLAG (authored by psamolysov).
[libunwind][CMake] Fix name of LIBUNWIND_SUPPORTS_NODEFAULTLIBS_FLAG
May 26 2022, 11:22 PM · Restricted Project
psamolysov closed D126466: [libunwind][CMake] Fix name of LIBUNWIND_SUPPORTS_NODEFAULTLIBS_FLAG.
May 26 2022, 11:21 PM · Restricted Project, Restricted Project, Restricted Project
psamolysov added a comment to D125779: [llvm-debuginfo-analyzer] 04 - Locations and ranges.

Good job! Here is a series of comments, please have a look.

May 26 2022, 8:08 AM · Restricted Project, Restricted Project, debug-info
psamolysov added a comment to D126466: [libunwind][CMake] Fix name of LIBUNWIND_SUPPORTS_NODEFAULTLIBS_FLAG.

@Ericson2314 Thank you for the comment. I'm going to land this small patch in a day if there will be no objections.

May 26 2022, 7:41 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov requested review of D126466: [libunwind][CMake] Fix name of LIBUNWIND_SUPPORTS_NODEFAULTLIBS_FLAG.
May 26 2022, 7:16 AM · Restricted Project, Restricted Project, Restricted Project
psamolysov updated the diff for D125485: [ArgPromotion] Unify byval promotion with non-byval.

Fix a typo in the comment to the not used anymore isDenselyPacked static member function.

May 26 2022, 1:42 AM · Restricted Project, Restricted Project

May 25 2022

psamolysov added inline comments to D125778: [llvm-debuginfo-analyzer] 03 - Logical elements.
May 25 2022, 1:09 AM · debug-info, Restricted Project, Restricted Project
psamolysov added inline comments to D125776: [llvm-debuginfo-analyzer] 01 - Interval tree.
May 25 2022, 12:59 AM · Restricted Project, debug-info, Restricted Project

May 24 2022

psamolysov added a comment to D125778: [llvm-debuginfo-analyzer] 03 - Logical elements.

There a lot of small nit comments and a few questions. These questions are by no means a criticism of your code or design decisions, they are here just to let me understand more about using classes in LLVM Support. Thank you in advance for the answers,

May 24 2022, 6:30 AM · debug-info, Restricted Project, Restricted Project

May 23 2022

psamolysov added inline comments to D125485: [ArgPromotion] Unify byval promotion with non-byval.
May 23 2022, 1:48 AM · Restricted Project, Restricted Project
psamolysov added a comment to D125485: [ArgPromotion] Unify byval promotion with non-byval.

Colleagues the patch is ready for review. Could you have a look again? Thank you.

May 23 2022, 1:47 AM · Restricted Project, Restricted Project

May 19 2022

psamolysov added a comment to D125777: [llvm-debuginfo-analyzer] 02 - Driver and documentation.

Good job! I believe the tool will be very usable. Thank you very much.

May 19 2022, 8:18 AM · debug-info, Restricted Project, Restricted Project
psamolysov updated the diff for D125485: [ArgPromotion] Unify byval promotion with non-byval.

Create a DominatorTree for a new function

May 19 2022, 1:52 AM · Restricted Project, Restricted Project

May 18 2022

psamolysov added a comment to D125485: [ArgPromotion] Unify byval promotion with non-byval.

Unfortunately, a CallGraphSCCPass pass (the legacy ArgPromotion pass is a child of this class) cannot use a function analysis pass, DominatorTreeWrapperPass for example. It is interesting, the compiled with the new version of the ArgumentPromotion pass opt tool crashes by this reason only during a run of the Polly tests (you can see the crash in the pre-merge checks on Windows).

May 18 2022, 8:56 AM · Restricted Project, Restricted Project
psamolysov added a comment to D125777: [llvm-debuginfo-analyzer] 02 - Driver and documentation.

Implementation for an Interval Tree (light tree data structure to hold intervals).

(in the patch description), I believe there should be a description for the second patch in the series, not the first.

May 18 2022, 5:37 AM · debug-info, Restricted Project, Restricted Project
psamolysov updated the diff for D125485: [ArgPromotion] Unify byval promotion with non-byval.

Reformat the code to let the git-clang-format check pass.

May 18 2022, 5:34 AM · Restricted Project, Restricted Project
psamolysov added inline comments to D125776: [llvm-debuginfo-analyzer] 01 - Interval tree.
May 18 2022, 5:22 AM · Restricted Project, debug-info, Restricted Project
psamolysov added inline comments to D125776: [llvm-debuginfo-analyzer] 01 - Interval tree.
May 18 2022, 5:20 AM · Restricted Project, debug-info, Restricted Project
psamolysov added a comment to D125776: [llvm-debuginfo-analyzer] 01 - Interval tree.

I'm not familiar with the discussion of the class design. From the architecture point of view, the class can be divided into a builder that accumulates the intervals and build the tree and an immutable tree class that contains the query methods only. This design can be an overengineering but on the other hand the implemented algorithm (in the find_iterator for example) is not short and it deserves its own class.

May 18 2022, 4:59 AM · Restricted Project, debug-info, Restricted Project