This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SVE] Rename PPR3b register class to PPR_p0to7
AbandonedPublic

Authored by david-arm on Oct 27 2022, 1:57 AM.

Details

Summary

In order to be consistent with the naming scheme introduced
by D136678 for the register class PPR_p8to15, I've also
created this patch to rename PPR3b to PPR_p0to7.

Diff Detail

Unit TestsFailed

Event Timeline

david-arm created this revision.Oct 27 2022, 1:57 AM
david-arm requested review of this revision.Oct 27 2022, 1:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 27 2022, 1:57 AM

I won't go as far as saying I'm against this patch given there is logic behind the change but I will highlight the existing idiom of specifying the bit length to restrict the range of another operand is pretty common. For example, we have ZPR_3b, ZPR_4b and the immediates are defined in this way. My comment on D136678 was more about not needing to duplicate information for something that wasn't purely about restricting the upper bound. However, the change is sensible and more expressive so if you feel strongly enough then fair enough.

Matt added a subscriber: Matt.Oct 29 2022, 8:21 AM
paulwalker-arm accepted this revision.Oct 30 2022, 9:53 AM
This revision is now accepted and ready to land.Oct 30 2022, 9:53 AM
david-arm abandoned this revision.Apr 4 2023, 5:42 AM