[mlir][llvm] Tighten LLVM dialect intrinsic type constraints.

[gysit]

Summary

The revision specifies more precise argument and result type
constraints for many of the llvm intrinsics. Additionally, add
tests to verify intrinsics with invalid arguments/result result
in a verification error.

[ftynse]

mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td

22

I suspect we want AnySignlessInteger here and below, MLIR integers can have signs and we don't want those in the LLVM intrinsics.

mlir/test/Target/LLVMIR/llvmir-invalid.mlir

138

Nit: FileCheck now supports @below instead of @+1 that reads better and works when combining errors and notes.

[gysit]

Address comments:

• use @below instead of @+1
• use AnySignlessInteger for all intrinsics

Rebase (after https://reviews.llvm.org/D136498):

• use qualified(type($ptr)) for arguments of type LLVM_AnyPointer
• adapt expected error messages

[gysit]

@dcaballe I changed the integer type constraints on the vector predicate intrinsics from AnyInteger to AnySignlessInteger as well. I hope this does not conflict with your changes.

[dcaballe]

In D136360#3882263, @gysit wrote:

@dcaballe I changed the integer type constraints on the vector predicate intrinsics from AnyInteger to AnySignlessInteger as well. I hope this does not conflict with your changes.

That should be fine! Thanks for pinging me :)