This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][CodeGen][NFC] Add fixed vector type test cases for llvm.round.*
ClosedPublic

Authored by eopXD on Sep 28 2022, 3:04 AM.

Diff Detail

Event Timeline

eopXD created this revision.Sep 28 2022, 3:04 AM
eopXD requested review of this revision.Sep 28 2022, 3:04 AM
frasercrmck added inline comments.Sep 28 2022, 3:09 AM
llvm/test/CodeGen/RISCV/rvv/fround-sdnode.ll
297

These should probably be in fixed-vectors-round.ll to fit in with our other tests.

eopXD updated this revision to Diff 463484.Sep 28 2022, 3:17 AM

Follow current convention and sort test cases correctly.

eopXD marked an inline comment as done.Sep 28 2022, 3:17 AM
eopXD added inline comments.
llvm/test/CodeGen/RISCV/rvv/fround-sdnode.ll
297

Thank you for pointing this out.

eopXD marked an inline comment as done.EditedSep 28 2022, 3:19 AM

Probably should rename current test cases of xxx-sdnode.ll to xxx.ll too to make file naming more consistent.

reames accepted this revision.Sep 28 2022, 7:26 AM
reames added a subscriber: reames.

LGTM

This revision is now accepted and ready to land.Sep 28 2022, 7:27 AM
This revision was landed with ongoing or failed builds.Sep 28 2022, 9:28 AM
This revision was automatically updated to reflect the committed changes.

What was wrong with the tests in fixed-vectors-fp.ll other than it not covering as many types?

eopXD added a comment.Sep 28 2022, 9:44 AM

What was wrong with the tests in fixed-vectors-fp.ll other than it not covering as many types?

Sorry that I didn't notice test cases where collected under fixed-vectors-fp.ll. Do you recommend to revert this commit?

What was wrong with the tests in fixed-vectors-fp.ll other than it not covering as many types?

Sorry that I didn't notice test cases where collected under fixed-vectors-fp.ll. Do you recommend to revert this commit?

Don't revert it. We should probably remove the redundant round tests from fixed-vectors-fp.ll