Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/CodeGen/RISCV/rvv/fround-sdnode.ll | ||
---|---|---|
295 | These should probably be in fixed-vectors-round.ll to fit in with our other tests. |
llvm/test/CodeGen/RISCV/rvv/fround-sdnode.ll | ||
---|---|---|
295 | Thank you for pointing this out. |
Comment Actions
Probably should rename current test cases of xxx-sdnode.ll to xxx.ll too to make file naming more consistent.
Comment Actions
What was wrong with the tests in fixed-vectors-fp.ll other than it not covering as many types?
Comment Actions
Sorry that I didn't notice test cases where collected under fixed-vectors-fp.ll. Do you recommend to revert this commit?
Comment Actions
Don't revert it. We should probably remove the redundant round tests from fixed-vectors-fp.ll
These should probably be in fixed-vectors-round.ll to fit in with our other tests.