This is an archive of the discontinued LLVM Phabricator instance.

[LegalizeTypes][RISCV] Support f16 in ExpandIntRes_LLROUND_LLRINT.
ClosedPublic

Authored by craig.topper on Sep 23 2022, 7:01 PM.

Details

Summary

Promote f16 to f32 and use the f32 libcall.

I deleted rv64zfh-half-intrinsics-strict.ll because it only existed due to this issue breaking rv32.

Diff Detail

Event Timeline

craig.topper created this revision.Sep 23 2022, 7:01 PM
craig.topper requested review of this revision.Sep 23 2022, 7:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2022, 7:02 PM
craig.topper edited the summary of this revision. (Show Details)Sep 23 2022, 7:03 PM
reames requested changes to this revision.Sep 26 2022, 7:14 AM

LGTM. I'm basically trusting this is valid by the float semantics, and am only reviewing the code change.

This revision now requires changes to proceed.Sep 26 2022, 7:14 AM

@reames I assume you chose Needs Revision in error?

This revision was not accepted when it landed; it landed in state Needs Revision.Sep 26 2022, 11:17 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

@reames I assume you chose Needs Revision in error?

Yep.

llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp