This is an archive of the discontinued LLVM Phabricator instance.

Move TargetTransformInfo::maxLegalDivRemBitWidth -> TargetLowering::maxSupportedDivRemBitWidth
ClosedPublic

Authored by mgehre-amd on Sep 12 2022, 6:30 AM.

Details

Summary

Also remove new-pass-manager version of ExpandLargeDivRem because there is no way
yet to access TargetLowering in the new pass manager.

Diff Detail

Event Timeline

mgehre-amd created this revision.Sep 12 2022, 6:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2022, 6:30 AM
mgehre-amd requested review of this revision.Sep 12 2022, 6:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2022, 6:30 AM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm added inline comments.Sep 12 2022, 6:45 AM
llvm/include/llvm/CodeGen/TargetLowering.h
4595

Could just add another unsigned field similar to MaxAtomicSizeInBitsSupported rather than the hassle of a virtual

Use a field instead of virtual functions

mgehre-amd marked an inline comment as done.Sep 12 2022, 8:43 AM
arsenm accepted this revision.Sep 12 2022, 9:02 AM
This revision is now accepted and ready to land.Sep 12 2022, 9:02 AM
This revision was landed with ongoing or failed builds.Sep 12 2022, 9:06 AM
This revision was automatically updated to reflect the committed changes.

Seems tests are failing when x86 is not configured.
See clang-aarch64-quick.

Seems tests are failing when x86 is not configured.
See clang-aarch64-quick.

Thanks, I'll check.

llvm/include/llvm/Analysis/TargetTransformInfoImpl.h