Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D133402

[mlir][Math] Fix RoundEven constant folder.
ClosedPublic
Actions

Authored by jacquesguan on Sep 7 2022, 1:05 AM.

Details

Reviewers
sscalpone
Mogball
nicolasvasilache
ftynse
aartbik
bondhugula
rriddle
mehdi_amini
ThomasRaoux
Meinersbur
Commits
rG238e08d64326: [mlir][Math] Fix RoundEven constant folder.
Summary

Use roundToIntegral instead roundeven of libm to avoid window build failed.

Diff Detail

Event Timeline

jacquesguan created this revision.Sep 7 2022, 1:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 7 2022, 1:05 AM
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 18 others. · View Herald Transcript
jacquesguan requested review of this revision.Sep 7 2022, 1:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 7 2022, 1:05 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B185361: Diff 458372.Sep 7 2022, 1:31 AM
jacquesguan added reviewers: nicolasvasilache, ftynse, aartbik, bondhugula, rriddle, mehdi_amini, ThomasRaoux.Sep 7 2022, 1:58 AM
jacquesguan added a reviewer: Meinersbur.Sep 7 2022, 2:05 AM
jacquesguan mentioned this in D133344: [mlir][Math] Add constant folder for RoundEvenOp..
mehdi_amini accepted this revision.Sep 7 2022, 4:47 AM
This revision is now accepted and ready to land.Sep 7 2022, 4:47 AM
Closed by commit rG238e08d64326: [mlir][Math] Fix RoundEven constant folder. (authored by jacquesguan, committed by mehdi_amini). · Explain WhySep 7 2022, 5:46 AM
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rG238e08d64326: [mlir][Math] Fix RoundEven constant folder..

Revision Contents
Changeset List

PathSize
mlir/
lib/
Dialect/
Math/
IR/
16 lines

Diff 458433

View Options

mlir/lib/Dialect/Math/IR/MathOps.cpp

Loading...