This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][CodeGen] add assertion to RISCVTargetStreamer getTargetStreamer()
ClosedPublic

Authored by michaelmaitland on Aug 29 2022, 9:24 AM.

Details

Summary

X86 and ARM AsmParsers have this same assertion. This assertion provides better reporting when the RISCVTargetStreamer is null and helps to prevent null pointer access.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2022, 9:24 AM
michaelmaitland requested review of this revision.Aug 29 2022, 9:24 AM
bkramer accepted this revision.Aug 30 2022, 4:11 AM

Makes sense, thanks!

This revision is now accepted and ready to land.Aug 30 2022, 4:11 AM

I do not have commit access. Can someone please commit for me? Thanks.