[clang-tidy] Fix modernize-use-emplace to support alias cases

[corona10]

Summary

Fix modernize-use-emplace to support alias cases

[corona10]

I am new to this project. I know that I need to write a test also likewise: https://github.com/llvm/llvm-project/blob/b8655f7ff286b9ebcd97cdd24b9c8eb5b89b9651/clang-tools-extra/test/clang-tidy/checkers/modernize/use-emplace.cpp#L872-L884
Please let me know how to generate CHECK-MESSAGES and CHECK-FIXES comments to this.

[corona10]

Add unittest

[njames93]

Can you mention this change in the Release Notes (clang-tools-extra/docs/ReleaseNotes.rst).

clang-tools-extra/test/clang-tidy/checkers/modernize/use-emplace.cpp

1059 ↗

(On Diff #455544)

Can you please add a test like this, where emplace is called with a temporary object when the container type is an alias.

[corona10]

• Update modernize-use-emplace to support emplacy cases for alias types.
• Add new test
• Update release note.

[corona10]

clang-tools-extra/test/clang-tidy/checkers/modernize/use-emplace.cpp

1059 ↗

(On Diff #455544)

Done!

[corona10]

Rebase

[njames93]

LGTM, just with a small nit.

[corona10]

In D132640#3753744, @njames93 wrote:

LGTM, just with a small nit.

@njames93

Thank you but I can not find your comment about nit.
Would you like to check the comment one more time?

[njames93]

clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp

137

Sorry about that, not sure what happened.
Anyway same goes for below, use a cxxRecordDecl matcher instead of namedDecl.

[corona10]

Address code review.

[corona10]

Thanks! I updated the change.

[corona10]

• clang-format

[corona10]

@njames93 Can we land this patch before it occurs conflicting with other changes?

[njames93]

In D132640#3757277, @corona10 wrote:

@njames93 Can we land this patch before it occurs conflicting with other changes?

Yes, sorry do you have commit access. If you don't what is your GitHub name and email that I should use when committing.

[corona10]

In D132640#3757395, @njames93 wrote:

In D132640#3757277, @corona10 wrote:

@njames93 Can we land this patch before it occurs conflicting with other changes?

Yes, sorry do you have commit access. If you don't what is your GitHub name and email that I should use when committing.

Thanks, I don't have a commit bit :)

Github name: corona10
email: [e-mail]

Thank you!

clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp

: ClangTidyCheck(Name, Context), IgnoreImplicitConstructors(Options.get(
           Options.get("EmplacyFunctions", DefaultEmplacyFunctions))) {}
 
 void UseEmplaceCheck::registerMatchers(MatchFinder *Finder) {
   // FIXME: Bunch of functionality that could be easily added:
   // + add handling of `insert` for stl associative container, but be careful
   // because this requires special treatment (it could cause performance
   // regression)
   // + match for emplace calls that should be replaced with insertion
-  auto CallPushBack = cxxMemberCallExpr(
-      hasDeclaration(functionDecl(hasName("push_back"))),
-      on(hasType(cxxRecordDecl(hasAnyName(ContainersWithPushBack)))));
-
-  auto CallPush = cxxMemberCallExpr(
-      hasDeclaration(functionDecl(hasName("push"))),
-      on(hasType(cxxRecordDecl(hasAnyName(ContainersWithPush)))));
-
-  auto CallPushFront = cxxMemberCallExpr(
-      hasDeclaration(functionDecl(hasName("push_front"))),
-      on(hasType(cxxRecordDecl(hasAnyName(ContainersWithPushFront)))));
+  auto CallPushBack =
+      cxxMemberCallExpr(hasDeclaration(functionDecl(hasName("push_back"))),
+                        on(hasType(hasCanonicalType(hasDeclaration(
+                            namedDecl(hasAnyName(ContainersWithPushBack)))))));
+
+  auto CallPush =
+      cxxMemberCallExpr(hasDeclaration(functionDecl(hasName("push"))),
+                        on(hasType(hasCanonicalType(hasDeclaration(
+                            namedDecl(hasAnyName(ContainersWithPush)))))));
+
+  auto CallPushFront =
+      cxxMemberCallExpr(hasDeclaration(functionDecl(hasName("push_front"))),
+                        on(hasType(hasCanonicalType(hasDeclaration(
+                            namedDecl(hasAnyName(ContainersWithPushFront)))))));
 
   auto CallEmplacy = cxxMemberCallExpr(
       hasDeclaration(
           functionDecl(hasAnyNameIgnoringTemplates(EmplacyFunctions))),
       on(hasType(cxxRecordDecl(has(typedefNameDecl(
           hasName("value_type"), hasType(type(hasUnqualifiedDesugaredType(
                                      recordType().bind("value_type"))))))))));