Fix modernize-use-emplace to support alias cases
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
I am new to this project. I know that I need to write a test also likewise: https://github.com/llvm/llvm-project/blob/b8655f7ff286b9ebcd97cdd24b9c8eb5b89b9651/clang-tools-extra/test/clang-tidy/checkers/modernize/use-emplace.cpp#L872-L884
Please let me know how to generate CHECK-MESSAGES and CHECK-FIXES comments to this.
Can you mention this change in the Release Notes (clang-tools-extra/docs/ReleaseNotes.rst).
clang-tools-extra/test/clang-tidy/checkers/modernize/use-emplace.cpp | ||
---|---|---|
1059 ↗ | (On Diff #455544) | Can you please add a test like this, where emplace is called with a temporary object when the container type is an alias. |
- Update modernize-use-emplace to support emplacy cases for alias types.
- Add new test
- Update release note.
clang-tools-extra/test/clang-tidy/checkers/modernize/use-emplace.cpp | ||
---|---|---|
1059 ↗ | (On Diff #455544) | Done! |
Thank you but I can not find your comment about nit.
Would you like to check the comment one more time?
clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp | ||
---|---|---|
140 | Sorry about that, not sure what happened. |
Yes, sorry do you have commit access. If you don't what is your GitHub name and email that I should use when committing.
Thanks, I don't have a commit bit :)
Github name: corona10
email: donghee.na92@gmail.com
Thank you!
Sorry about that, not sure what happened.
Anyway same goes for below, use a cxxRecordDecl matcher instead of namedDecl.